127823 2014-01-28 18:36:54 -0800 [iOS] REGRESSION (r162663): Webpages have strange artifacts or corruption around tile boundaries 2014-01-28 19:01:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes dbates ddkilzer simon.fraser thorton oldest_to_newest 973250 0 aestes 2014-01-28 18:36:54 -0800 [iOS] REGRESSION (r162663): Webpages have strange artifacts or corruption around tile boundaries 973251 1 aestes 2014-01-28 18:37:08 -0800 <rdar://problem/15920823> 973253 2 222541 aestes 2014-01-28 18:39:21 -0800 Created attachment 222541 [iOS] REGRESSION (r162663): Webpages have strange artifacts or corruption around tile boundaries 973254 3 222541 dbates 2014-01-28 18:41:06 -0800 Comment on attachment 222541 [iOS] REGRESSION (r162663): Webpages have strange artifacts or corruption around tile boundaries OK. Feel free to get a rendering expert to provide a more thorough review. 973256 4 222541 dbates 2014-01-28 18:55:55 -0800 Comment on attachment 222541 [iOS] REGRESSION (r162663): Webpages have strange artifacts or corruption around tile boundaries View in context: https://bugs.webkit.org/attachment.cgi?id=222541&action=review > Source/WebCore/platform/ScrollView.cpp:385 > + IntSize scrollSize = m_contentsSize - visibleContentRect(LegacyIOSDocumentViewRect).size(); Notice that LegacyIOSDocumentViewRect is only defined when building for iOS. Instead we should use LegacyIOSDocumentVisibleRect, which is defined to be LegacyIOSDocumentViewRect and ContentsVisibleRect on iOS and non-iOS ports, respectively. 973257 5 aestes 2014-01-28 19:01:32 -0800 Committed r162994: <http://trac.webkit.org/changeset/162994> 222541 2014-01-28 18:39:21 -0800 2014-01-28 18:55:55 -0800 [iOS] REGRESSION (r162663): Webpages have strange artifacts or corruption around tile boundaries bug-127823-20140128183921.patch text/plain 2871 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyOTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTY5NjhhMDkxMGEyMDIx YWIwZjAyMTMyZjYyZTY2ZWY1ZTU3MTA2MC4uNzU2Zjc0M2ZlZDZlMDMyYTcxZWU4MmQ0OTM0YWM1 YTFlYzQ5NDMwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAxLTI4ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBSRUdSRVNTSU9OIChy MTYyNjYzKTogV2VicGFnZXMgaGF2ZSBzdHJhbmdlIGFydGlmYWN0cyBvciBjb3JydXB0aW9uIGFy b3VuZCB0aWxlIGJvdW5kYXJpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyNzgyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorICAgICAgICAKKyAgICAgICAgT3JpZ2luYWwgcGF0Y2ggYnkgU2ltb24gRnJhc2VyLgorCisg ICAgICAgICogcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHA6IFNwZWNpZnkgTGVnYWN5SU9TRG9jdW1l bnRWaWV3UmVjdCB3aGVuIGNhbGxpbmcgdmlzaWJsZUNvbnRlbnRSZWN0KCkuCisKIDIwMTQtMDEt MjggIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0NTUyBT aGFwZXNdIEFkanVzdCBpbnNldCBzaXppbmcgc3ludGF4IHRvIHRoZSBsYXRlc3Qgc3BlY2lmaWNh dGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcAppbmRleCA3ZDY5MmNhM2Rk YzI5YmJiZmM1ZDgxMjM5ZjVlNjk1NzZjZjcyMjYxLi5iNDY3Njc0M2Q3YjUwOWViYjIyMjZhMzdi M2JkMWE0ZTdiN2FmYmQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3Jv bGxWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcApA QCAtMzgyLDcgKzM4Miw3IEBAIGludCBTY3JvbGxWaWV3OjpzY3JvbGxTaXplKFNjcm9sbGJhck9y aWVudGF0aW9uIG9yaWVudGF0aW9uKSBjb25zdAogewogICAgIC8vIElmIG5vIHNjcm9sbGJhcnMg YXJlIHByZXNlbnQsIGl0IGRvZXMgbm90IGluZGljYXRlIGNvbnRlbnQgaXMgbm90IGJlIHNjcm9s bGFibGUuCiAgICAgaWYgKCFtX2hvcml6b250YWxTY3JvbGxiYXIgJiYgIW1fdmVydGljYWxTY3Jv bGxiYXIgJiYgIXByb2hpYml0c1Njcm9sbGluZygpKSB7Ci0gICAgICAgIEludFNpemUgc2Nyb2xs U2l6ZSA9IG1fY29udGVudHNTaXplIC0gdmlzaWJsZUNvbnRlbnRSZWN0KCkuc2l6ZSgpOworICAg ICAgICBJbnRTaXplIHNjcm9sbFNpemUgPSBtX2NvbnRlbnRzU2l6ZSAtIHZpc2libGVDb250ZW50 UmVjdChMZWdhY3lJT1NEb2N1bWVudFZpZXdSZWN0KS5zaXplKCk7CiAgICAgICAgIHNjcm9sbFNp emUuY2xhbXBOZWdhdGl2ZVRvWmVybygpOwogICAgICAgICByZXR1cm4gb3JpZW50YXRpb24gPT0g SG9yaXpvbnRhbFNjcm9sbGJhciA/IHNjcm9sbFNpemUud2lkdGgoKSA6IHNjcm9sbFNpemUuaGVp Z2h0KCk7CiAgICAgfQpAQCAtMTAyNSw3ICsxMDI1LDcgQEAgdm9pZCBTY3JvbGxWaWV3OjpyZXBh aW50Q29udGVudFJlY3RhbmdsZShjb25zdCBJbnRSZWN0JiByZWN0LCBib29sIG5vdykKIHsKICAg ICBJbnRSZWN0IHBhaW50UmVjdCA9IHJlY3Q7CiAgICAgaWYgKGNsaXBzUmVwYWludHMoKSAmJiAh cGFpbnRzRW50aXJlQ29udGVudHMoKSkKLSAgICAgICAgcGFpbnRSZWN0LmludGVyc2VjdCh2aXNp YmxlQ29udGVudFJlY3QoKSk7CisgICAgICAgIHBhaW50UmVjdC5pbnRlcnNlY3QodmlzaWJsZUNv bnRlbnRSZWN0KExlZ2FjeUlPU0RvY3VtZW50Vmlld1JlY3QpKTsKICAgICBpZiAocGFpbnRSZWN0 LmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuOwogCkBAIC0xMTQyLDcgKzExNDIsNyBAQCB2b2lk IFNjcm9sbFZpZXc6OnBhaW50KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgSW50UmVj dCYgcmVjdCkKIAogICAgIEludFJlY3QgZG9jdW1lbnREaXJ0eVJlY3QgPSByZWN0OwogICAgIGlm ICghcGFpbnRzRW50aXJlQ29udGVudHMoKSkgewotICAgICAgICBJbnRSZWN0IHZpc2libGVBcmVh V2l0aG91dFNjcm9sbGJhcnMobG9jYXRpb24oKSwgdmlzaWJsZUNvbnRlbnRSZWN0KCkuc2l6ZSgp KTsKKyAgICAgICAgSW50UmVjdCB2aXNpYmxlQXJlYVdpdGhvdXRTY3JvbGxiYXJzKGxvY2F0aW9u KCksIHZpc2libGVDb250ZW50UmVjdChMZWdhY3lJT1NEb2N1bWVudFZpZXdSZWN0KS5zaXplKCkp OwogICAgICAgICBkb2N1bWVudERpcnR5UmVjdC5pbnRlcnNlY3QodmlzaWJsZUFyZWFXaXRob3V0 U2Nyb2xsYmFycyk7CiAgICAgfQogCkBAIC0xMTU2LDcgKzExNTYsNyBAQCB2b2lkIFNjcm9sbFZp ZXc6OnBhaW50KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgSW50UmVjdCYgcmVjdCkK ICAgICAgICAgICAgIGNvbnRleHQtPnRyYW5zbGF0ZSgtc2Nyb2xsWCgpLCAtc2Nyb2xsWSgpKTsK ICAgICAgICAgICAgIGRvY3VtZW50RGlydHlSZWN0Lm1vdmVCeShzY3JvbGxQb3NpdGlvbigpKTsK IAotICAgICAgICAgICAgY29udGV4dC0+Y2xpcCh2aXNpYmxlQ29udGVudFJlY3QoKSk7CisgICAg ICAgICAgICBjb250ZXh0LT5jbGlwKHZpc2libGVDb250ZW50UmVjdChMZWdhY3lJT1NEb2N1bWVu dFZpZXdSZWN0KSk7CiAgICAgICAgIH0KIAogICAgICAgICBwYWludENvbnRlbnRzKGNvbnRleHQs IGRvY3VtZW50RGlydHlSZWN0KTsK