127819 2014-01-28 17:39:04 -0800 [iOS] round the scrollview content size to natural numbers 2014-08-19 22:34:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 benjamin benjamin oldest_to_newest 973236 0 benjamin 2014-01-28 17:39:04 -0800 [iOS] round the scrollview content size to natural numbers 973237 1 222536 benjamin 2014-01-28 17:45:30 -0800 Created attachment 222536 Patch 973525 2 222536 simon.fraser 2014-01-29 16:32:54 -0800 Comment on attachment 222536 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222536&action=review > Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:110 > - CGSize contentsSizeInScrollViewCoordinates = CGSizeMake(newSize.width * zoomScale, newSize.height * zoomScale); > + CGSize contentsSizeInScrollViewCoordinates = CGSizeMake(std::round(newSize.width * zoomScale), std::round(newSize.height * zoomScale)); Should we also adjust the scale so it still reflects the scaling after rounding? 973530 3 benjamin 2014-01-29 16:55:01 -0800 (In reply to comment #2) > (From update of attachment 222536 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=222536&action=review > > > Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:110 > > - CGSize contentsSizeInScrollViewCoordinates = CGSizeMake(newSize.width * zoomScale, newSize.height * zoomScale); > > + CGSize contentsSizeInScrollViewCoordinates = CGSizeMake(std::round(newSize.width * zoomScale), std::round(newSize.height * zoomScale)); > > Should we also adjust the scale so it still reflects the scaling after rounding? That sounds like a good idea. 974072 4 222536 benjamin 2014-01-30 15:48:22 -0800 Comment on attachment 222536 Patch Simon pointed out this is incomplete. 1030211 5 benjamin 2014-08-19 22:34:35 -0700 I fixed that somewhere else IIRC. 222536 2014-01-28 17:45:30 -0800 2014-01-30 15:48:22 -0800 Patch bug-127819-20140128174529.patch text/plain 2041 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyOTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmE3MThhODE5ZDgwYjA2 OThkNTkxYmZkMWI4YjQ1MTI5ZjBhOTE4ZC4uOGJiNzA2ZDMyNDk1NWU0NDEyYmMzMmVkMzVkZTI0 MWU0NjUyZWRkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAxLTI4ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIHJvdW5k IHRoZSBzY3JvbGx2aWV3IGNvbnRlbnQgc2l6ZSB0byBuYXR1cmFsIG51bWJlcnMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzgxOQorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMTU5MjI0NDA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVmlld3BvcnQgd2lkdGggYW5kIGhlaWdodCBhcmUgcm91bmRlZCB0 byBpbnRlZ2Vycy4gVGhlIHNjcm9sbHZpZXcgY29udGVudAorICAgICAgICBzaXplIHNob3VsZCBk byB0aGUgc2FtZSBvciB3ZSB3aWxsIGhhdmUgZ2FwcyBhdCBjZXJ0YWluIHNjYWxlcy4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvaW9zL1dLVmlld0lPUy5tbToKKyAgICAgICAgKC1bV0tWaWV3 IGNvbnRlbnRWaWV3OmNvbnRlbnRzU2l6ZURpZENoYW5nZTpdKToKKwogMjAxNC0wMS0yOCAgQW5k eSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gU2V0IElOU1RBTExf UEFUSF9BQ1RVQUwgd2hlbiBidWlsZGluZyBXZWJLaXQyIGZvciB0aGUgaU9TIFNpbXVsYXRvcgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9pb3MvV0tWaWV3SU9TLm1t IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9pb3MvV0tWaWV3SU9TLm1tCmluZGV4IDk0 MGIwZTM1OTg5NGExZjQzNmJkMWUzM2UzYTQzZTNjMDU1MWViZTEuLmJmOGFiNTBkNTJhZTA0ZDRm Y2Y0NDBkZjNhOWQ5NjQ4YWM5MGY1NDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvaW9zL1dLVmlld0lPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2lvcy9XS1ZpZXdJT1MubW0KQEAgLTMzLDYgKzMzLDcgQEAKICNpbXBvcnQgPFVJS2l0L1VJ U2NyZWVuLmg+CiAjaW1wb3J0IDxVSUtpdC9VSVNjcm9sbFZpZXdfUHJpdmF0ZS5oPgogI2ltcG9y dCA8VUlLaXQvX1VJV2ViVmlld3BvcnRIYW5kbGVyLmg+CisjaW1wb3J0IDxjbWF0aD4KICNpbXBv cnQgPHd0Zi9SZXRhaW5QdHIuaD4KIAogc3RhdGljIGNvbnN0IGZsb2F0IG1pbldlYlZpZXdTY2Fs ZSA9IDAuMjU7CkBAIC0xMDYsNyArMTA3LDcgQEAgc3RhdGljIHN0cnVjdCBfVUlXZWJWaWV3cG9y dENvbmZpZ3VyYXRpb24gc3RhbmRhcmRWaWV3cG9ydENvbmZpZ3VyYXRpb24gPSB7IHsgVUkKIC0g KHZvaWQpY29udGVudFZpZXc6KFdLQ29udGVudFZpZXcgKiljb250ZW50VmlldyBjb250ZW50c1Np emVEaWRDaGFuZ2U6KENHU2l6ZSluZXdTaXplCiB7CiAgICAgQ0dGbG9hdCB6b29tU2NhbGUgPSBb X3Njcm9sbFZpZXcgem9vbVNjYWxlXTsKLSAgICBDR1NpemUgY29udGVudHNTaXplSW5TY3JvbGxW aWV3Q29vcmRpbmF0ZXMgPSBDR1NpemVNYWtlKG5ld1NpemUud2lkdGggKiB6b29tU2NhbGUsIG5l d1NpemUuaGVpZ2h0ICogem9vbVNjYWxlKTsKKyAgICBDR1NpemUgY29udGVudHNTaXplSW5TY3Jv bGxWaWV3Q29vcmRpbmF0ZXMgPSBDR1NpemVNYWtlKHN0ZDo6cm91bmQobmV3U2l6ZS53aWR0aCAq IHpvb21TY2FsZSksIHN0ZDo6cm91bmQobmV3U2l6ZS5oZWlnaHQgKiB6b29tU2NhbGUpKTsKICAg ICBbX3Njcm9sbFZpZXcgc2V0Q29udGVudFNpemU6Y29udGVudHNTaXplSW5TY3JvbGxWaWV3Q29v cmRpbmF0ZXNdOwogCiAgICAgW192aWV3cG9ydEhhbmRsZXIgdXBkYXRlOl57Cg==