127812 2014-01-28 15:51:03 -0800 Simplify WebFrame::isMainFrame 2014-01-29 10:06:49 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 973179 0 andersca 2014-01-28 15:51:03 -0800 Simplify WebFrame::isMainFrame 973181 1 222520 andersca 2014-01-28 15:51:30 -0800 Created attachment 222520 Patch 973194 2 222520 sergio 2014-01-28 16:05:27 -0800 Comment on attachment 222520 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222520&action=review > Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:372 > + return m_coreFrame->isMainFrame(); maybe a ternary here would be cleaner? return m_coreFrame ? m_coreFrame->isMainFrame() : false; 973197 3 andersca 2014-01-28 16:08:07 -0800 (In reply to comment #2) > (From update of attachment 222520 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=222520&action=review > > > Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:372 > > + return m_coreFrame->isMainFrame(); > > maybe a ternary here would be cleaner? > return m_coreFrame ? m_coreFrame->isMainFrame() : false; I think the explicit null check is easier to follow. 973203 4 andersca 2014-01-28 16:11:27 -0800 Committed r162980: <http://trac.webkit.org/changeset/162980> 973395 5 222520 darin 2014-01-29 10:06:49 -0800 Comment on attachment 222520 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222520&action=review >>> Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:372 >>> + return m_coreFrame->isMainFrame(); >> >> maybe a ternary here would be cleaner? >> return m_coreFrame ? m_coreFrame->isMainFrame() : false; > > I think the explicit null check is easier to follow. I think that && is easier to follow than the if statement or the ternary. return m_coreFrame && m_coreFrame->isMainFrame(); But tastes may differ, I suppose. 222520 2014-01-28 15:51:30 -0800 2014-01-29 10:06:48 -0800 Patch bug-127812-20140128155133.patch text/plain 1352 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyOTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmIzNWMwM2MwZDUyOGEy Yjc5M2RiOWIxYTZhMWU0N2E5ZTY1ZGNhMC4uYjRhYjJlMDUwNTVjMDZhNmQwNmEyZWMzNDNhMmNl MTkwMTU5OWY1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE0LTAxLTI4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgU2ltcGxpZnkgV2Vi RnJhbWU6OmlzTWFpbkZyYW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjc4MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJGcmFtZS5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYkZyYW1lOjppc01haW5GcmFtZSk6CisKKzIwMTQtMDEtMjggIEFuZGVycyBDYXJs c3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBSZW1vdmUgV2ViUGFnZVByb3h5 OjpjYW5Hb0JhY2sgYW5kIFdlYlBhZ2VQcm94eTo6Y2FuR29Gb3J3YXJkCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc4MDMKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJGcmFtZS5jcHAKaW5kZXggY2VkNzg2NWJmNGU3 YTAzYTI3ZTNhOTY4M2I2YmYyMzY0ODIwNTk3Zi4uMTk1NzNhOTBlN2NmM2JhNDY5NGY3ODNiNmU4 ZGRmYjVlZjRkOTY4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL1dlYkZyYW1lLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViRnJhbWUuY3BwCkBAIC0zNjYsMTAgKzM2NiwxMCBAQCBib29sIFdlYkZyYW1lOjppc0ZyYW1l U2V0KCkgY29uc3QKIAogYm9vbCBXZWJGcmFtZTo6aXNNYWluRnJhbWUoKSBjb25zdAogewotICAg IGlmIChXZWJQYWdlKiBwID0gcGFnZSgpKQotICAgICAgICByZXR1cm4gcC0+bWFpbldlYkZyYW1l KCkgPT0gdGhpczsKKyAgICBpZiAoIW1fY29yZUZyYW1lKQorICAgICAgICByZXR1cm4gZmFsc2U7 CiAKLSAgICByZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuIG1fY29yZUZyYW1lLT5pc01haW5GcmFt ZSgpOwogfQogCiBTdHJpbmcgV2ViRnJhbWU6Om5hbWUoKSBjb25zdAo=