12778 2007-02-15 15:14:21 -0800 REGRESSION: Nightly won't load Curl plugin for full page use 2007-04-03 21:37:47 -0700 1 1 1 Unclassified WebKit Plug-ins 420+ Mac OS X 10.4 VERIFIED FIXED InRadar, Regression P1 Major --- 1 wbardwel ap andersca ap oldest_to_newest 23187 0 wbardwel 2007-02-15 15:14:21 -0800 A Nightly from Feb 14 2007 won't load my plugin if you browse to a URL that is for a file handled by the plugin. The plugin is listed in the Installed Plugin-ins page, and I do seem to be able to load flash stuff from a .swf url. This plugin works in Safari 2.0.4 419.3, and it works if used from an OBJECT tag. 23188 1 ddkilzer 2007-02-15 15:21:52 -0800 Is this a Netscape plug-in? If so, does it work in Firefox on the same Mac? Are there any error/warning messages that appear on the console or in a log file when you try to load a file that uses the plug-in? What does the Activity window show? 23093 2 ap 2007-02-15 21:59:33 -0800 And, most importantly - is there a way for us to reproduce the problem? If confirmed, this would be a P1 bug. 22790 3 wbardwel 2007-02-17 16:10:22 -0800 You can download a version of my product and go to demos that use it at: www.curl.com It works with 419.3 but not with a recent nightly. 22573 4 ap 2007-02-18 02:48:15 -0800 The problem here is that WebHTMLView claims support for all "text/" MIME types, and +[WebView _viewClass:andRepresentationClass:forMIMEType:] doesn't even look at plugins if internal support is found. It's easy to suggest a number of easy fixes for this, but choosing the correct one may be more tricky. 22741 5 mjs 2007-02-19 19:46:37 -0800 What MIME type does this plugin want to use? 22752 6 wbardwel 2007-02-19 21:56:11 -0800 The key type is "text/vnd.curl" (but it registers some others that are only ever used for plugin detection JavaScript code.) 21001 7 mjs 2007-02-27 19:33:54 -0800 <rdar://problem/5028153> 16068 8 13911 ap 2007-03-31 10:22:01 -0700 Created attachment 13911 proposed fix My diagnosis was wrong - it's fine for +[WebView _viewClass:andRepresentationClass:forMIMEType:] to return WebHTMLView/WebHTMLRepresentation, as plugins are also handled by these. The actual problem seems to be in DOMImplementation::createDocument(), which hates plugins (it also mishandles Adobe SVG and any xml MIME types now). I don't know how to make a test for this fix. 15972 9 13911 darin 2007-03-31 17:35:39 -0700 Comment on attachment 13911 proposed fix Looks good. r=me 15902 10 ap 2007-03-31 22:58:59 -0700 Committed revision 20648. 15778 11 wbardwel 2007-04-03 20:46:56 -0700 This does fix the problem for me. (To make a test, you need a plugin that tries to take text/<something> and make sure that it gets loaded if you load a url with that as the mime-type.) 15780 12 ap 2007-04-03 21:37:47 -0700 (In reply to comment #11) > This does fix the problem for me. Great - so, marking as VERIFIED. IIRC, this problem was blocking you from verifying some other plugin issues with TOT (nightly) - could you please check those? > (To make a test, you need a plugin that tries to take text/<something> and > make sure that it gets loaded if you load a url with that as the mime-type.) Yes, that's how I tested when making this patch - but this doesn't translate into automated test easily, because the plugin has to be full page. 13911 2007-03-31 10:22:01 -0700 2007-03-31 17:35:39 -0700 proposed fix 12778r1_patch.txt text/plain 2703 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDY0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDctMDMtMzEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzc4CisgICAgICAgIFJF R1JFU1NJT046IE5pZ2h0bHkgd29uJ3QgbG9hZCBDdXJsIHBsdWdpbiBmb3IgZnVsbCBwYWdlIHVz ZQorCisgICAgICAgICogZG9tL0RPTUltcGxlbWVudGF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkRPTUltcGxlbWVudGF0aW9uOjpjcmVhdGVEb2N1bWVudCk6IFJlLW9yZGVyIGNhc2VzIHRv IGdpdmUgbW9yZSBwcmlvcml0eSB0byBwbHVnLWlucy4KKyAgICAgICAgVGhpcyBhbHNvIGZpeGVz IEFkb2JlIFNWRyBWaWV3ZXIgYW5kIGFueSBwbHVnaW5zIHRoYXQgcmVnaXN0ZXIgWE1MIE1JTUUg dHlwZXMuCisgICAgICAgIEFkZGVkIGEgY2FzZSBmb3IgWEhUTUwgdG8gYXZvaWQgZW51bWVyYXRp bmcgcGx1Z2lucy4KKwogMjAwNy0wMy0zMSAgTmljaG9sYXMgU2hhbmtzICA8d2Via2l0QG5pY2tz aGFua3MuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkZWxlLgpJbmRleDogV2ViQ29yZS9k b20vRE9NSW1wbGVtZW50YXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL0RPTUlt cGxlbWVudGF0aW9uLmNwcAkocmV2aXNpb24gMjA2MzMpCisrKyBXZWJDb3JlL2RvbS9ET01JbXBs ZW1lbnRhdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM0NSw4ICszNDUsMjQgQEAgUGFzc1Jl ZlB0cjxEb2N1bWVudD4gRE9NSW1wbGVtZW50YXRpb246OgogewogICAgIGlmIChpblZpZXdTb3Vy Y2VNb2RlKQogICAgICAgICByZXR1cm4gbmV3IEhUTUxWaWV3U291cmNlRG9jdW1lbnQodGhpcywg dmlldyk7CisKKyAgICAvLyBQbHVnaW5zIGNhbm5vdCB0YWtlIEhUTUwgYW5kIFhIVE1MIGZyb20g dXMsIGFuZCB3ZSBkb24ndCBldmVuIG5lZWQgdG8gaW5pdGlhbGl6ZSB0aGUgcGx1Z2luIGRhdGFi YXNlIGZvciB0aG9zZS4KICAgICBpZiAodHlwZSA9PSAidGV4dC9odG1sIikKICAgICAgICAgcmV0 dXJuIG5ldyBIVE1MRG9jdW1lbnQodGhpcywgdmlldyk7CisgICAgaWYgKHR5cGUgPT0gImFwcGxp Y2F0aW9uL3hodG1sK3htbCIpCisgICAgICAgIHJldHVybiBuZXcgRG9jdW1lbnQodGhpcywgdmll dyk7CisKKyAgICAvLyBQREYgaXMgb25lIGltYWdlIHR5cGUgZm9yIHdoaWNoIGEgcGx1Z2luIGNh biBvdmVycmlkZSBidWlsdC1pbiBzdXBwb3J0LgorICAgIC8vIFdlIGRvIG5vdCB3YW50IFF1aWNr VGltZSB0byB0YWtlIG92ZXIgYWxsIGltYWdlIHR5cGVzLCBvYnZpb3VzbHkuCisgICAgaWYgKCh0 eXBlID09ICJhcHBsaWNhdGlvbi9wZGYiIHx8IHR5cGUgPT0gInRleHQvcGRmIikgJiYgUGx1Z0lu SW5mb1N0b3JlOjpzdXBwb3J0c01JTUVUeXBlKHR5cGUpKQorICAgICAgICByZXR1cm4gbmV3IFBs dWdpbkRvY3VtZW50KHRoaXMsIHZpZXcpOworICAgIGlmIChJbWFnZTo6c3VwcG9ydHNUeXBlKHR5 cGUpKQorICAgICAgICByZXR1cm4gbmV3IEltYWdlRG9jdW1lbnQodGhpcywgdmlldyk7CisKKyAg ICAvLyBFdmVyeXRoaW5nIGVsc2UgY2FuIGJlIG92ZXJyaWRkZW4gYnkgcGx1Z2lucy4gSW4gcGFy dGljdWxhciwgQWRvYmUgU1ZHIFZpZXdlciBzaG91bGQgYmUgdXNlZCBmb3IgU1ZHLCBpZiBpbnN0 YWxsZWQuCisgICAgaWYgKFBsdWdJbkluZm9TdG9yZTo6c3VwcG9ydHNNSU1FVHlwZSh0eXBlKSkK KyAgICAgICAgcmV0dXJuIG5ldyBQbHVnaW5Eb2N1bWVudCh0aGlzLCB2aWV3KTsKKwogI2lmIEVO QUJMRShTVkcpCiAgICAgaWYgKHR5cGUgPT0gImltYWdlL3N2Zyt4bWwiKQogICAgICAgICByZXR1 cm4gbmV3IFNWR0RvY3VtZW50KHRoaXMsIHZpZXcpOwpAQCAtMzU1LDEyICszNzEsNyBAQCBQYXNz UmVmUHRyPERvY3VtZW50PiBET01JbXBsZW1lbnRhdGlvbjo6CiAgICAgICAgIHJldHVybiBuZXcg RG9jdW1lbnQodGhpcywgdmlldyk7CiAgICAgaWYgKGlzVGV4dE1JTUVUeXBlKHR5cGUpKQogICAg ICAgICByZXR1cm4gbmV3IFRleHREb2N1bWVudCh0aGlzLCB2aWV3KTsKLSAgICBpZiAoKHR5cGUg PT0gImFwcGxpY2F0aW9uL3BkZiIgfHwgdHlwZSA9PSAidGV4dC9wZGYiKSAmJiBQbHVnSW5JbmZv U3RvcmU6OnN1cHBvcnRzTUlNRVR5cGUodHlwZSkpCi0gICAgICAgIHJldHVybiBuZXcgUGx1Z2lu RG9jdW1lbnQodGhpcywgdmlldyk7Ci0gICAgaWYgKEltYWdlOjpzdXBwb3J0c1R5cGUodHlwZSkp Ci0gICAgICAgIHJldHVybiBuZXcgSW1hZ2VEb2N1bWVudCh0aGlzLCB2aWV3KTsKLSAgICBpZiAo UGx1Z0luSW5mb1N0b3JlOjpzdXBwb3J0c01JTUVUeXBlKHR5cGUpKQotICAgICAgICByZXR1cm4g bmV3IFBsdWdpbkRvY3VtZW50KHRoaXMsIHZpZXcpOworCiAgICAgcmV0dXJuIG5ldyBIVE1MRG9j dW1lbnQodGhpcywgdmlldyk7CiB9CiAK