127776 2014-01-28 06:53:06 -0800 Fix linking failure on EFL and GTK for the jsCStack branch merge 2014-01-28 09:20:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Blocker --- 127782 127763 1 ossy webkit-unassigned mhahnenberg msaboff ossy oldest_to_newest 972900 0 ossy 2014-01-28 06:53:06 -0800 After adding the missing files to the cmake buildsystem and removed the dead code I managed to build EFLWebKit. But I got linking failure with SHARED_CORE=ON build. Unfortunately it is necessary to be able run layout tests. (https://bugs.webkit.org/show_bug.cgi?id=80683) Additionally I got the same linking failure with WebKitGTK build. GTK build failure: ------------------- /usr/bin/ld: Source/JavaScriptCore/llint/.libs/libjavascriptcoregtk_3_0_la-LowLevelInterpreter.o: relocation R_X86_64_PC32 against symbol `llint_throw_stack_overflow_error' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: Bad value EFL build failure with SHARED_CORE=ON: --------------------------------------- Linking CXX shared library ../../lib/libjavascriptcore_efl.so /usr/bin/ld: CMakeFiles/JavaScriptCore.dir/llint/LowLevelInterpreter.cpp.o: relocation R_X86_64_PC32 against symbol `llint_throw_stack_overflow_error' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: Bad value 972907 1 ossy 2014-01-28 07:30:09 -0800 Additional info: The build fails on GTK always and fails on EFL bots, because ENABLE_DRT=1 environment variable forces the SHARED_CORE=ON build. 972923 2 mhahnenberg 2014-01-28 08:33:41 -0800 After reading a little bit about this error, it seems that gcc requires that code linked into a shared library should, by default, be compiled with -fpic due to the constraints of the small code model and the size of the address space on 64-bit platforms. I can see two obvious solutions: (1) Use -fpic to enable position independent code when building shared libraries. (2) Use -mcmodel=large to enable the large code model when building shared libraries. Either one of these should work. 972925 3 mhahnenberg 2014-01-28 08:36:44 -0800 (In reply to comment #2) > After reading a little bit about this error, it seems that gcc requires that code linked into a shared library should, by default, be compiled with -fpic due to the constraints of the small code model and the size of the address space on 64-bit platforms. I can see two obvious solutions: > > (1) Use -fpic to enable position independent code when building shared libraries. > (2) Use -mcmodel=large to enable the large code model when building shared libraries. > > Either one of these should work. This also might be the result of a lack of proper extern-ing for these symbols. Let me try that first. 972963 4 ossy 2014-01-28 09:20:11 -0800 It seems https://bugs.webkit.org/show_bug.cgi?id=127782 solved the linking problem. Thanks for the quick fix.