127770 2014-01-28 02:46:49 -0800 Refactoring design-mode-spellcheck-off.html to use asynchronous spellchecking 2014-02-14 05:54:05 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 125689 1 g.czajkowski g.czajkowski rniwa oldest_to_newest 972864 0 g.czajkowski 2014-01-28 02:46:49 -0800 Enable asynchronous spellchecking in design-mode-spellcheck-off.html. 972865 1 222426 g.czajkowski 2014-01-28 02:49:20 -0800 Created attachment 222426 Patch 978765 2 222426 g.czajkowski 2014-02-10 00:08:31 -0800 Comment on attachment 222426 Patch Hi Ryosuke, I am looking forward to seeing your comments. 980664 3 222426 rniwa 2014-02-13 23:42:22 -0800 Comment on attachment 222426 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222426&action=review > LayoutTests/editing/spelling/design-mode-spellcheck-off.html:4 > +<script src="../editing.js"></script> Looks like we can just include this inside body like the other script element. > LayoutTests/editing/spelling/design-mode-spellcheck-off.html:27 > + if (!window.internals) > + return; > It would be better if we had this check before shouldBecomeDifferent so that we can test it in the browser as well as DRT/WTR. 980771 4 g.czajkowski 2014-02-14 05:54:05 -0800 Committed r164101: <http://trac.webkit.org/changeset/164101> 222426 2014-01-28 02:49:20 -0800 2014-02-13 23:42:22 -0800 Patch bug-127770-20140128114916.patch text/plain 5892 g.czajkowski U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyOTIyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTI2MDJiOTg4MGE0NGYzOThmOWJl YWU5NWYyN2QyMjgxYTBmNjRiYy4uNDA5YTJmYTY2NWY3OGE3ODNhMmE0MjllMTNkMmZkN2E4ZjEw NTliYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTAxLTI3ICBHcnplZ29yeiBDemFqa293 c2tpICA8Zy5jemFqa293c2tpQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJlZmFjdG9yaW5nIGRl c2lnbi1tb2RlLXNwZWxsY2hlY2stb2ZmLmh0bWwgdG8gdXNlIGFzeW5jaHJvbm91cyBzcGVsbGNo ZWNraW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x Mjc3NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBF bmFibGUgYXN5bmNocm9ub3VzIHNwZWxsY2hlY2tpbmcgaW4gZGVzaWduLW1vZGUtc3BlbGxjaGVj ay1vZmYuaHRtbC4KKworICAgICAgICBEdWUgdG8ganMtdGVzdC1wcmUuanMgYWRkcyBzb21lIEhU TUwgZWxlbWVudHMgaW5zaWRlIHRoZSBCT0RZLCB0aGUgbWlzc3BlbGxlZAorICAgICAgICBwaHJh c2Ugd2FzIG1vdmVkIGludG8gc2VwYXJhdGVkIGRpdiBlbGVtZW50LiBJdCBhbGxvd3MgdG8gY2hl Y2sgc3BlbGxpbmcgbWFya2VyCisgICAgICAgIG9uIGRlc2lyZWQgZWxlbWVudCBpbnN0ZWFkIG9m IHdob2xlIGJvZHkuCisKKyAgICAgICAgSXQgdHVybmVkIG91dCB0aGF0IHRoZSB0ZXN0IGRvZXMg bm90IHVuZGVybGluZSAiYXNkZiIgYXMgbWlzc3BlbGxlZCBhbHRob3VnaAorICAgICAgICBzcGVs bGNoZWNrIGF0dHJpYnV0ZSBpcyBvbi4gVG8gZm9yY2Ugc3BlbGxjaGVja2luZywgdGhlIGNhcmV0 IG5lZWRzIHRvIGJlIG1vdmVkCisgICAgICAgIG91dCBvZiB0aGUgbWlzc3BlbGxlZCB3b3JkLiBU byBiZSBtb3JlIHJlbGlhYmxlLCB0aGUgdGVzdCBub3cgY29udGFpbnMgdHdvIHRlc3QKKyAgICAg ICAgY2FzZXMgaW4gJ2Rlc2luZ01vZGU9b24nIHdoZW4gc3BlbGxjaGVjayBhdHRyaWJ1dGUgaXMg b2ZmIGFuZCBvbi4KKworICAgICAgICAqIGVkaXRpbmcvc3BlbGxpbmcvZGVzaWduLW1vZGUtc3Bl bGxjaGVjay1vZmYtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGVkaXRpbmcvc3BlbGxpbmcvZGVz aWduLW1vZGUtc3BlbGxjaGVjay1vZmYuaHRtbDoKKwogMjAxNC0wMS0yNyAgQnJpYW4gQnVyZyAg PGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBjbGVhbiB1cCBpbml0 aWFsaXphdGlvbiBvZiBtYW5hZ2VycyBhbmQgb2JzZXJ2ZXJzIGluIEluc3BlY3RvclRlc3QKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvc3BlbGxpbmcvZGVzaWduLW1vZGUtc3BlbGxj aGVjay1vZmYtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zcGVsbGluZy9kZXNp Z24tbW9kZS1zcGVsbGNoZWNrLW9mZi1leHBlY3RlZC50eHQKaW5kZXggYWFhMmE4M2EzNTc0YTIz Nzg2M2Q2ZmJjN2QxNTcyYmU2MDE0OTY3Mi4uNDg1Nzk1MDk4NDMxOWJiNjY4ODc2NDMzMzhjYTU2 ZWMxNTU0ODEyYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zcGVsbGluZy9kZXNp Z24tbW9kZS1zcGVsbGNoZWNrLW9mZi1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZWRp dGluZy9zcGVsbGluZy9kZXNpZ24tbW9kZS1zcGVsbGNoZWNrLW9mZi1leHBlY3RlZC50eHQKQEAg LTEsNCArMSwxMiBAQAotYXNkZiBpcyBtaXNzcGVsbGVkLgotVG8gdGVzdCB0aGlzIG1hbnVhbGx5 LCBjbGljayAiYXNkZiIgYWJvdmUuIFRoZXJlIHNob3VsZCBiZSBubyBzcGVsbGluZyBtYXJrZXIg Zm9yICJhc2RmIiBhZnRlciB0aGUgY2xpY2suCitUaGlzIHRlc3RzIHdoZXRoZXIgV2ViS2l0IGRv ZXMgbm90IHNwZWxsIGNoZWNrIGluICdkZXNpZ25Nb2RlJyB3aGVuIHNwZWxsY2hlY2s9J2ZhbHNl Jy4gVG8gdGVzdCBtYW51YWxseSwgY2xpY2sgYXJyb3VuZCAnYXNkZicuIFRoZXJlIHNob3VsZCBi ZSBubyBzcGVsbGluZyBtYXJrZXIgZm9yICdhc2RmJyBhZnRlciB0aGUgY2xpY2suCisKK09uIHN1 Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2Vk IGJ5ICJURVNUIENPTVBMRVRFIi4KKwogCi1QQVNTCitQQVNTIGludGVybmFscy5oYXNTcGVsbGlu Z01hcmtlcigwLCA0KSBiZWNhbWUgZmFsc2UKK2RvY3VtZW50LmJvZHkuc2V0QXR0cmlidXRlKCJz cGVsbGNoZWNrIiwgInRydWUiKQorUEFTUyBpbnRlcm5hbHMuaGFzU3BlbGxpbmdNYXJrZXIoMCwg NCkgYmVjYW1lIGRpZmZlcmVudCBmcm9tIGZhbHNlCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBp cyB0cnVlCisKK1RFU1QgQ09NUExFVEUKK2FzZGYgaXMgbWlzc3BlbGxlZC4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2VkaXRpbmcvc3BlbGxpbmcvZGVzaWduLW1vZGUtc3BlbGxjaGVjay1vZmYu aHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvc3BlbGxpbmcvZGVzaWduLW1vZGUtc3BlbGxjaGVj ay1vZmYuaHRtbAppbmRleCBmZDhmOGJiYzE3NWI1M2U2MDAyYTFiZDJkZWYyNjA5ZDMyNzY5NDZi Li42NTMzZjU2M2QzOWE0YTZlZDQzZWZkNWZhNzg5MTU1ZDJiZGRjYTVlIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9lZGl0aW5nL3NwZWxsaW5nL2Rlc2lnbi1tb2RlLXNwZWxsY2hlY2stb2ZmLmh0 bWwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zcGVsbGluZy9kZXNpZ24tbW9kZS1zcGVsbGNo ZWNrLW9mZi5odG1sCkBAIC0xLDM5ICsxLDUxIEBACiA8IURPQ1RZUEUgaHRtbD4KIDxodG1sPgot PGJvZHkgc3BlbGxjaGVjaz0iZmFsc2UiPiAKLWFzZGYgaXMgbWlzc3BlbGxlZC4KLTxwPlRvIHRl c3QgdGhpcyBtYW51YWxseSwgY2xpY2sgImFzZGYiIGFib3ZlLiBUaGVyZSBzaG91bGQgYmUgbm8g c3BlbGxpbmcgbWFya2VyIGZvciAiYXNkZiIgYWZ0ZXIgdGhlIGNsaWNrLjwvcD4KKzxoZWFkPgor PHNjcmlwdCBzcmM9Ii4uL2VkaXRpbmcuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgc3Bl bGxjaGVjaz0iZmFsc2UiPgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBy ZS5qcyI+PC9zY3JpcHQ+Cis8ZGl2IGlkPSJtaXNzcGVsbGVkIiBvbm1vdXNldXA9ImNoZWNrU3Bl bGxpbmdNYXJrZXIoKSI+YXNkZiBpcyBtaXNzcGVsbGVkLjwvZGl2PgogPHNjcmlwdD4KK2Rlc2Ny aXB0aW9uKCJUaGlzIHRlc3RzIHdoZXRoZXIgV2ViS2l0IGRvZXMgbm90IHNwZWxsIGNoZWNrIGlu ICdkZXNpZ25Nb2RlJyAiCisgICAgKyAid2hlbiBzcGVsbGNoZWNrPSdmYWxzZScuIFRvIHRlc3Qg bWFudWFsbHksIGNsaWNrIGFycm91bmQgJ2FzZGYnLiAiCisgICAgKyAiVGhlcmUgc2hvdWxkIGJl IG5vIHNwZWxsaW5nIG1hcmtlciBmb3IgJ2FzZGYnIGFmdGVyIHRoZSBjbGljay4iKTsKIAotaWYg KHdpbmRvdy50ZXN0UnVubmVyKQotICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworanNUZXN0 SXNBc3luYyA9IHRydWU7CisKK2lmICh3aW5kb3cuaW50ZXJuYWxzKSB7CisgICAgaW50ZXJuYWxz LnNldHRpbmdzLnNldFVuaWZpZWRUZXh0Q2hlY2tlckVuYWJsZWQodHJ1ZSk7CisgICAgaW50ZXJu YWxzLnNldHRpbmdzLnNldEFzeW5jaHJvbm91c1NwZWxsQ2hlY2tpbmdFbmFibGVkKHRydWUpOwor fQogCiBkb2N1bWVudC5kZXNpZ25Nb2RlID0gIm9uIjsKIAotaWYgKGRvY3VtZW50LmFjdGl2ZUVs ZW1lbnQgIT0gZG9jdW1lbnQuYm9keSkKLSAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGRv Y3VtZW50LmNyZWF0ZVRleHROb2RlKCdGQUlMOiBhY3RpdmUgZWxlbWVudCBiZWZvcmUgY2xpY2sg aXMgbm90IGJvZHkgZWxlbWVudCcpKTsKLWVsc2UgaWYgKHdpbmRvdy50ZXN0UnVubmVyICYmIHdp bmRvdy5ldmVudFNlbmRlcikgewotICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworZnVu Y3Rpb24gY2hlY2tTcGVsbGluZ01hcmtlcigpCit7CisgICAgaWYgKCF3aW5kb3cuaW50ZXJuYWxz KQorICAgICAgICByZXR1cm47CiAKLSAgICBkb2N1bWVudC5ib2R5LmFkZEV2ZW50TGlzdGVuZXIo J21vdXNlZG93bicsIGZ1bmN0aW9uKCkgewotICAgICAgICBpZiAoZG9jdW1lbnQuYWN0aXZlRWxl bWVudCAhPSBkb2N1bWVudC5ib2R5KQotICAgICAgICAgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRD aGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgnRkFJTDogYWN0aXZlIGVsZW1lbnQgYWZ0ZXIg Y2xpY2sgaXMgbm90IGJvZHkgZWxlbWVudCcpKTsKLSAgICAgICAgZWxzZSBpZiAoaW50ZXJuYWxz Lmhhc1NwZWxsaW5nTWFya2VyKDAsIDQpKQotICAgICAgICAgICAgZG9jdW1lbnQuYm9keS5hcHBl bmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgnRkFJTDogc3BlbGwgY2hlY2sgd2FzIGlu dm9rZWQnKSk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIGRvY3VtZW50LmJvZHkuYXBwZW5k Q2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoJ1BBU1MnKSk7Ci0gICAgICAgIHRlc3RSdW5u ZXIubm90aWZ5RG9uZSgpOworICAgIC8vIEZpcnN0LCB2ZXJpZnkgc3BlbGxpbmcgd2l0aCBzcGVs bGNoZWNrIGF0dHJpYnV0ZSBvZmYuCisgICAgLy8gTW92ZSBzZWxlY3Rpb24gdG8gdGhlIG5leHQg d29yZCB0byBub3RpZnkgV2ViS2l0IHRoYXQgImFzZGYiIGhhcyBiZWVuIHR5cGVkL2NoYW5nZWQK KyAgICAvLyB0byBnaXZlIGEgY2hhbmNlIHRvIHNwZWxsY2hlY2suCisgICAgbW92ZVNlbGVjdGlv bkZvcndhcmRCeVdvcmRDb21tYW5kKCk7CisgICAgc2hvdWxkQmVjb21lRXF1YWwoJ2ludGVybmFs cy5oYXNTcGVsbGluZ01hcmtlcigwLCA0KScsICdmYWxzZScsIGZ1bmN0aW9uKCkgeworICAgICAg ICBldmFsQW5kTG9nKCdkb2N1bWVudC5ib2R5LnNldEF0dHJpYnV0ZSgic3BlbGxjaGVjayIsICJ0 cnVlIiknKTsKKyAgICAgICAgLy8gRG8gYW55IHNlbGVjdGlvbiBjaGFuZ2UgdG8gZm9yY2Ugc3Bl bGxjaGVja2luZyBhZnRlciBhdHRyaWJ1dGUgY2hhbmdlLgorICAgICAgICBtb3ZlU2VsZWN0aW9u Rm9yd2FyZEJ5TGluZUNvbW1hbmQoKTsKKyAgICAgICAgc2hvdWxkQmVjb21lRGlmZmVyZW50KCdp bnRlcm5hbHMuaGFzU3BlbGxpbmdNYXJrZXIoMCwgNCknLCAnZmFsc2UnLCBmaW5pc2hKU1Rlc3Qp OwogICAgIH0pOworfQogCi0gICAgdmFyIHggPSBkb2N1bWVudC5ib2R5Lm9mZnNldExlZnQgKyAx MDsKLSAgICB2YXIgeSA9IGRvY3VtZW50LmJvZHkub2Zmc2V0VG9wICsgMTA7CitpZiAod2luZG93 LmV2ZW50U2VuZGVyKSB7CisgICAgdmFyIG1pc3NwZWxsZWREaXYgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgibWlzc3BlbGxlZCIpOworICAgIHZhciB4ID0gbWlzc3BlbGxlZERpdi5vZmZzZXRM ZWZ0OworICAgIHZhciB5ID0gbWlzc3BlbGxlZERpdi5vZmZzZXRUb3A7CiAgICAgZXZlbnRTZW5k ZXIubW91c2VNb3ZlVG8oeCwgeSk7CiAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CiAgICAg ZXZlbnRTZW5kZXIubW91c2VVcCgpOwotICAgIHNldFRpbWVvdXQoInRlc3RSdW5uZXIubm90aWZ5 RG9uZSgpO2RvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUo J0ZBSUw6IHRpbWVvdXQnKSk7IiwgNTAwKTsKLX0gZWxzZQotICAgIGRvY3VtZW50LmJvZHkuYXBw ZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoJ1BBU1MnKSk7Ci0KK30KIDwvc2NyaXB0 PiAKKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Njcmlw dD4KIDwvYm9keT4KIDwvaHRtbD4K