127755 2014-01-27 19:24:12 -0800 WebGLLoadPolicy::WebGLAsk is an unnecessary value. 2014-01-30 09:58:58 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned bfulgham commit-queue dino esprehn+autocc gyuyoung.kim japhet roger_fong oldest_to_newest 972743 0 roger_fong 2014-01-27 19:24:12 -0800 WebKit only needs to know whether to block or load on the page. Getting rid of use of WebGLAsk and related values. 972745 1 222396 roger_fong 2014-01-27 19:34:38 -0800 Created attachment 222396 patch 972770 2 222402 roger_fong 2014-01-27 20:54:54 -0800 Created attachment 222402 patch 972771 3 roger_fong 2014-01-27 20:55:31 -0800 had a bit of changelog oopsy 972774 4 roger_fong 2014-01-27 21:05:50 -0800 http://trac.webkit.org/changeset/162912 973779 5 222402 bfulgham 2014-01-30 09:58:58 -0800 Comment on attachment 222402 patch r=me 222396 2014-01-27 19:34:38 -0800 2014-01-27 20:54:54 -0800 patch patch.patch text/plain 4176 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjkwNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE0LTAxLTI3ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViR0xMb2FkUG9saWN5OjpX ZWJHTEFzayBpcyBhbiB1bm5lY2Vzc2FyeSB2YWx1ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzc1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MQ2FudmFzRWxlbWVudDo6Z2V0Q29udGV4dCk6CisgICAgICAg ICogbG9hZGVyL0ZyYW1lTG9hZGVyVHlwZXMuaDoKKworMjAxNC0wMS0yNyAgUm9nZXIgRm9uZyAg PHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIFVucmV2aWV3ZWQgYnVpbGQg Zml4LiBBZGQgbWlzc2luZyBleHBvcnQgc3ltYm9sLgorCisgICAgICAgICogV2ViQ29yZS5leHAu aW46CisKIDIwMTQtMDEtMjcgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAg ICAgICAgIEFsbG93IG1tYXAgZW5jb2RlZCBkYXRhIHJlcGxhY2VtZW50IGZvciBXT0ZGIGZvbnRz LgpJbmRleDogU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4JKHJldmlzaW9uIDE2Mjg4OCkKKysrIFNvdXJjZS9X ZWJDb3JlL1dlYkNvcmUuZXhwLmluCSh3b3JraW5nIGNvcHkpCkBAIC0yNTAsNiArMjUwLDcgQEAK IF9fWk43V2ViQ29yZTEyaWNvbkRhdGFiYXNlRXYKIF9fWk43V2ViQ29yZTEzQVhPYmplY3RDYWNo ZTEwcm9vdE9iamVjdEV2CiBfX1pON1dlYkNvcmUxM0FYT2JqZWN0Q2FjaGUxOHJvb3RPYmplY3RG b3JGcmFtZUVQTlNfNUZyYW1lRQorX19aTjdXZWJDb3JlMTNBWE9iamVjdENhY2hlMTllbmFibGVB Y2Nlc3NpYmlsaXR5RXYKIF9fWk43V2ViQ29yZTEzQVhPYmplY3RDYWNoZTIwZGlzYWJsZUFjY2Vz c2liaWxpdHlFdgogX19aTjdXZWJDb3JlMTNBWE9iamVjdENhY2hlMjFnQWNjZXNzaWJpbGl0eUVu YWJsZWRFCiBfX1pON1dlYkNvcmUxM0FYT2JqZWN0Q2FjaGUyM2ZvY3VzZWRVSUVsZW1lbnRGb3JQ YWdlRVBLTlNfNFBhZ2VFCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVt ZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVt ZW50LmNwcAkocmV2aXNpb24gMTYyODg3KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2Fu dmFzRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIzMCw5ICsyMzAsNiBAQAogICAgICAg ICAgICAgICAgIGlmIChwYWdlICYmICFkb2N1bWVudCgpLnVybCgpLmlzTG9jYWxGaWxlKCkpIHsK ICAgICAgICAgICAgICAgICAgICAgV2ViR0xMb2FkUG9saWN5IHBvbGljeSA9IHBhZ2UtPm1haW5G cmFtZSgpLmxvYWRlcigpLmNsaWVudCgpLndlYkdMUG9saWN5Rm9yVVJMKGRvY3VtZW50KCkudXJs KCkpOwogCi0gICAgICAgICAgICAgICAgICAgIGlmIChwb2xpY3kgPT0gV2ViR0xBc2spCi0gICAg ICAgICAgICAgICAgICAgICAgICByZXR1cm4gbnVsbHB0cjsKLQogICAgICAgICAgICAgICAgICAg ICBpZiAocG9saWN5ID09IFdlYkdMQmxvY2spCiAgICAgICAgICAgICAgICAgICAgICAgICByZXR1 cm4gbnVsbHB0cjsKICAgICAgICAgICAgICAgICB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvRnJhbWVMb2FkZXJUeXBlcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRl ci9GcmFtZUxvYWRlclR5cGVzLmgJKHJldmlzaW9uIDE2Mjg4NykKKysrIFNvdXJjZS9XZWJDb3Jl L2xvYWRlci9GcmFtZUxvYWRlclR5cGVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwNyw5ICsxMDcs OCBAQAogICAgIH07CiAgICAgCiAgICAgZW51bSBXZWJHTExvYWRQb2xpY3kgewotICAgICAgICBX ZWJHTEFzayA9IDAsCi0gICAgICAgIFdlYkdMQWxsb3csCi0gICAgICAgIFdlYkdMQmxvY2sKKyAg ICAgICAgV2ViR0xCbG9jayA9IDAsCisgICAgICAgIFdlYkdMQWxsb3cKICAgICB9OwogCiB9Cklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjI4ODcpCisrKyBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxNC0wMS0yNyAgUm9nZXIgRm9u ZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgorCisgICAgICAgIFdlYkdMTG9hZFBvbGljeTo6V2Vi R0xBc2sgaXMgYW4gdW5uZWNlc3NhcnkgdmFsdWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc3NTUKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv Qy9XS0FQSUNhc3QuaDoKKyAgICAgICAgKFdlYktpdDo6dG9XZWJHTExvYWRQb2xpY3kpOgorICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS1BhZ2VMb2FkZXJDbGllbnQuaDoKKwogMjAxNC0wMS0y NyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIENvcHkg cmVsZXZhbnQgY29kZSBmcm9tIHRoZSBpT1MgdmVyc2lvbiBvZiBXS1ZpZXcgdG8gV0tXZWJWaWV3 CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tBUElDYXN0LmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQVBJQ2FzdC5oCShyZXZp c2lvbiAxNjI4ODcpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tBUElDYXN0 LmgJKHdvcmtpbmcgY29weSkKQEAgLTQ4MCw4ICs0ODAsNiBAQAogaW5saW5lIFdlYkNvcmU6Oldl YkdMTG9hZFBvbGljeSB0b1dlYkdMTG9hZFBvbGljeShXS1dlYkdMTG9hZFBvbGljeSB3ZWJHTExv YWRQb2xpY3kpCiB7CiAgICAgc3dpdGNoICh3ZWJHTExvYWRQb2xpY3kpIHsKLSAgICBjYXNlIGtX S1dlYkdMTG9hZFBvbGljeUluYWN0aXZlOgotICAgICAgICByZXR1cm4gV2ViQ29yZTo6V2ViR0xB c2s7CiAgICAgY2FzZSBrV0tXZWJHTExvYWRQb2xpY3lMb2FkTm9ybWFsbHk6CiAgICAgICAgIHJl dHVybiBXZWJDb3JlOjpXZWJHTEFsbG93OwogICAgIGNhc2Uga1dLV2ViR0xMb2FkUG9saWN5Qmxv Y2tlZDoKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2VMb2FkZXJD bGllbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQ YWdlTG9hZGVyQ2xpZW50LmgJKHJldmlzaW9uIDE2Mjg4NykKKysrIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQy9XS1BhZ2VMb2FkZXJDbGllbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNDMs OSArNDMsOCBAQAogdHlwZWRlZiB1aW50MzJfdCBXS1BsdWdpbkxvYWRQb2xpY3k7CiAKIGVudW0g ewotICAgIGtXS1dlYkdMTG9hZFBvbGljeUluYWN0aXZlID0gMCwKKyAgICBrV0tXZWJHTExvYWRQ b2xpY3lCbG9ja2VkID0gMCwKICAgICBrV0tXZWJHTExvYWRQb2xpY3lMb2FkTm9ybWFsbHksCi0g ICAga1dLV2ViR0xMb2FkUG9saWN5QmxvY2tlZAogfTsKIHR5cGVkZWYgdWludDMyX3QgV0tXZWJH TExvYWRQb2xpY3k7CiAK 222402 2014-01-27 20:54:54 -0800 2014-01-30 09:58:58 -0800 patch patch.patch text/plain 3541 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjkwOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAxLTI3ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViR0xMb2FkUG9saWN5OjpX ZWJHTEFzayBpcyBhbiB1bm5lY2Vzc2FyeSB2YWx1ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzc1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MQ2FudmFzRWxlbWVudDo6Z2V0Q29udGV4dCk6CisgICAgICAg ICogbG9hZGVyL0ZyYW1lTG9hZGVyVHlwZXMuaDoKKwogMjAxNC0wMS0yNyAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYkNvcmU6IEVuYWJsZSAtV2lt cGxpY2l0LWZhbGx0aHJvdWdoIGFuZCBhZGQgRkFMTFRIUk9VR0ggYW5ub3RhdGlvbiB3aGVyZSBu ZWVkZWQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCShy ZXZpc2lvbiAxNjI5MDkpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjMwLDkgKzIzMCw2IEBACiAgICAgICAgICAgICAgICAg aWYgKHBhZ2UgJiYgIWRvY3VtZW50KCkudXJsKCkuaXNMb2NhbEZpbGUoKSkgewogICAgICAgICAg ICAgICAgICAgICBXZWJHTExvYWRQb2xpY3kgcG9saWN5ID0gcGFnZS0+bWFpbkZyYW1lKCkubG9h ZGVyKCkuY2xpZW50KCkud2ViR0xQb2xpY3lGb3JVUkwoZG9jdW1lbnQoKS51cmwoKSk7CiAKLSAg ICAgICAgICAgICAgICAgICAgaWYgKHBvbGljeSA9PSBXZWJHTEFzaykKLSAgICAgICAgICAgICAg ICAgICAgICAgIHJldHVybiBudWxscHRyOwotCiAgICAgICAgICAgICAgICAgICAgIGlmIChwb2xp Y3kgPT0gV2ViR0xCbG9jaykKICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBudWxscHRy OwogICAgICAgICAgICAgICAgIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxv YWRlclR5cGVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9h ZGVyVHlwZXMuaAkocmV2aXNpb24gMTYyOTA5KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL0Zy YW1lTG9hZGVyVHlwZXMuaAkod29ya2luZyBjb3B5KQpAQCAtMTA3LDkgKzEwNyw4IEBACiAgICAg fTsKICAgICAKICAgICBlbnVtIFdlYkdMTG9hZFBvbGljeSB7Ci0gICAgICAgIFdlYkdMQXNrID0g MCwKLSAgICAgICAgV2ViR0xBbGxvdywKLSAgICAgICAgV2ViR0xCbG9jaworICAgICAgICBXZWJH TEJsb2NrID0gMCwKKyAgICAgICAgV2ViR0xBbGxvdwogICAgIH07CiAKIH0KSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cJKHJldmlzaW9uIDE2MjkwOSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAxLTI3ICBSb2dlciBGb25nICA8cm9nZXJf Zm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViR0xMb2FkUG9saWN5OjpXZWJHTEFzayBpcyBh biB1bm5lY2Vzc2FyeSB2YWx1ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyNzc1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLQVBJQ2FzdC5oOgorICAgICAgICAoV2Vi S2l0Ojp0b1dlYkdMTG9hZFBvbGljeSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLUGFn ZUxvYWRlckNsaWVudC5oOgorCiAyMDE0LTAxLTI3ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFy b0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0MjogRW5hYmxlIC1XaW1wbGljaXQtZmFsbHRo cm91Z2ggYW5kIGFkZCBGQUxMVEhST1VHSCBhbm5vdGF0aW9uIHdoZXJlIG5lZWRlZApJbmRleDog U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQVBJQ2FzdC5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0FQSUNhc3QuaAkocmV2aXNpb24gMTYy OTA5KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQVBJQ2FzdC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC00ODAsOCArNDgwLDYgQEAKIGlubGluZSBXZWJDb3JlOjpXZWJHTExvYWRQ b2xpY3kgdG9XZWJHTExvYWRQb2xpY3koV0tXZWJHTExvYWRQb2xpY3kgd2ViR0xMb2FkUG9saWN5 KQogewogICAgIHN3aXRjaCAod2ViR0xMb2FkUG9saWN5KSB7Ci0gICAgY2FzZSBrV0tXZWJHTExv YWRQb2xpY3lJbmFjdGl2ZToKLSAgICAgICAgcmV0dXJuIFdlYkNvcmU6OldlYkdMQXNrOwogICAg IGNhc2Uga1dLV2ViR0xMb2FkUG9saWN5TG9hZE5vcm1hbGx5OgogICAgICAgICByZXR1cm4gV2Vi Q29yZTo6V2ViR0xBbGxvdzsKICAgICBjYXNlIGtXS1dlYkdMTG9hZFBvbGljeUJsb2NrZWQ6Cklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlTG9hZGVyQ2xpZW50LmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZUxvYWRl ckNsaWVudC5oCShyZXZpc2lvbiAxNjI5MDkpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0MvV0tQYWdlTG9hZGVyQ2xpZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTQzLDkgKzQzLDgg QEAKIHR5cGVkZWYgdWludDMyX3QgV0tQbHVnaW5Mb2FkUG9saWN5OwogCiBlbnVtIHsKLSAgICBr V0tXZWJHTExvYWRQb2xpY3lJbmFjdGl2ZSA9IDAsCisgICAga1dLV2ViR0xMb2FkUG9saWN5Qmxv Y2tlZCA9IDAsCiAgICAga1dLV2ViR0xMb2FkUG9saWN5TG9hZE5vcm1hbGx5LAotICAgIGtXS1dl YkdMTG9hZFBvbGljeUJsb2NrZWQKIH07CiB0eXBlZGVmIHVpbnQzMl90IFdLV2ViR0xMb2FkUG9s aWN5OwogCg==