127729 2014-01-27 16:43:53 -0800 REGRESSION (r159609): Images are corrupted when hovering over buttons @ github.com 2014-07-29 11:11:36 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED AdobeTracked, InRadar P1 Normal --- 1 ggaren stavila commit-queue esprehn+autocc glenn hyatt koivisto kondapallykalyan mihnea simon.fraser webkit-bug-importer WebkitBugTracker oldest_to_newest 972665 0 ggaren 2014-01-27 16:43:53 -0800 Steps to reproduce: 1. Go to github.com 2. Log in (accounts are free) 3. Move the mouse right and left over the yellow buttons with the octopus cats on them. --> Notice flashing of background color and failure to repaint whole button/image. Bisected: Works: opensource r159608 Fails: opensource r159609 http://trac.webkit.org/log/trunk/?rev=159609&stop_rev=159609 972666 1 webkit-bug-importer 2014-01-27 16:44:42 -0800 <rdar://problem/15920727> 972873 2 stavila 2014-01-28 04:52:44 -0800 Investigating 973792 3 stavila 2014-01-30 10:14:05 -0800 Found & fixed issue, will upload patch tomorrow. 975836 4 stavila 2014-02-03 04:55:58 -0800 Altough I already have a patch that fixes this issue (by basically rolling back the changes that affected this particular case when regions are not involved), I will investigate a little bit further the actual cause of this because it could be a GraphicsContext issue. 976307 5 223106 stavila 2014-02-04 06:16:10 -0800 Created attachment 223106 Patch 976381 6 223106 commit-queue 2014-02-04 09:23:04 -0800 Comment on attachment 223106 Patch Clearing flags on attachment: 223106 Committed r163382: <http://trac.webkit.org/changeset/163382> 976382 7 commit-queue 2014-02-04 09:23:07 -0800 All reviewed patches have been landed. Closing bug. 1025522 8 simon.fraser 2014-07-29 11:11:36 -0700 This caused bug 135318. 223106 2014-02-04 06:16:10 -0800 2014-02-04 09:23:04 -0800 Patch 127729.patch text/plain 5379 stavila ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NDkzOTczLi43OTVjYWY5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDIt MDQgIFJhZHUgU3RhdmlsYSAgPHN0YXZpbGFAYWRvYmUuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04gKHIxNTk2MDkpOiBJbWFnZXMgYXJlIGNvcnJ1cHRlZCB3aGVuIGhvdmVyaW5nIG92ZXIgYnV0 dG9ucyBAIGdpdGh1Yi5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyNzcyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZGVkIHRlc3QgZm9yIHRoZSBjb3JyZWN0IHJlcGFpbnRpbmcgb2YgYnV0dG9u cyB3aXRoIGJvcmRlciByYWRpdXMgd2hlbiBob3ZlcmluZy4KKworICAgICAgICAqIGZhc3QvcmVn aW9ucy9yZXBhaW50L2hvdmVyLWJvcmRlci1yYWRpdXMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L3JlZ2lvbnMvcmVwYWludC9ob3Zlci1ib3JkZXItcmFkaXVzLmh0bWw6IEFk ZGVkLgorCiAyMDE0LTAyLTA0ICBNaWhuZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgog CiAgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6ICFvYmplY3QgfHwgKG9iamVjdC0+aXNSZW5kZXJC bG9jaygpKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3JlcGFpbnQvaG92 ZXItYm9yZGVyLXJhZGl1cy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMv cmVwYWludC9ob3Zlci1ib3JkZXItcmFkaXVzLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwLi5kNGRiODA4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9yZWdpb25zL3JlcGFpbnQvaG92ZXItYm9yZGVyLXJhZGl1cy1leHBlY3RlZC50eHQK QEAgLTAsMCArMSwxNyBAQAorVGhpcyB0ZXN0IHBhc3NlcyBpZiBtb3ZpbmcgdGhlIGN1cnNvciBm cm9tIG9uZSBvZiB0aGUgYmx1ZSBpdGVtcyB0byB0aGUgb3RoZXIgcHJvZHVjZXMgbm8gcmVwYWlu dCBlcnJvcnMgKHN1Y2ggYXMgY3JvcHBpbmcgb2Ygb25lIG9mIHRoZSBibHVlIGl0ZW1zKS4KKwor KHJlcGFpbnQgcmVjdHMKKyAgKHJlY3QgNDkgODQgMzUwIDIxNSkKKyAgKHJlY3QgNDkgODQgMzUw IDIxNSkKKyAgKHJlY3QgNDkgODQgMzUwIDIxNSkKKyAgKHJlY3QgNDkgODQgMzUwIDE4KQorICAo cmVjdCA0OSA4NCAzNTAgMjE1KQorICAocmVjdCA0OSA4NCAzNTAgMjE1KQorICAocmVjdCA0OSA4 NCAzNTAgMjE1KQorICAocmVjdCA0MDAgODQgMzUwIDIxNSkKKyAgKHJlY3QgNDAwIDg0IDM1MCAy MTUpCisgIChyZWN0IDQwMCA4NCAzNTAgMjE1KQorICAocmVjdCA0OSA4NCAzNTAgMTgpCisgIChy ZWN0IDQwMCA4NCAzNTAgMTgpCispCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVn aW9ucy9yZXBhaW50L2hvdmVyLWJvcmRlci1yYWRpdXMuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv cmVnaW9ucy9yZXBhaW50L2hvdmVyLWJvcmRlci1yYWRpdXMuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwLi4yYmE4MzQwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9yZWdpb25zL3JlcGFpbnQvaG92ZXItYm9yZGVyLXJhZGl1cy5odG1sCkBAIC0wLDAg KzEsNjQgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+CisgIDxoZWFkPgorICAgIDxzY3JpcHQg c3JjPSIuLi8uLi9yZXBhaW50L3Jlc291cmNlcy90ZXh0LWJhc2VkLXJlcGFpbnQuanMiPjwvc2Ny aXB0PgorCisgICAgPHN0eWxlPgorICAgICAgLnBhZ2VfYm9keQorICAgICAgeworICAgICAgICBi b3JkZXItYm90dG9tLWxlZnQtcmFkaXVzOiA1cHg7CisgICAgICAgIG92ZXJmbG93LXg6IGhpZGRl bjsKKyAgICAgICAgb3ZlcmZsb3cteTogaGlkZGVuOworICAgICAgfQorCisgICAgICBsaQorICAg ICAgeworICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBsaWdodGJsdWU7CisgICAgICAgIG1hcmdp bi1sZWZ0OiAxcHg7CisgICAgICAgIGJvcmRlci10b3AtbGVmdC1yYWRpdXM6IDVweDsKKyAgICAg ICAgZmxvYXQ6IGxlZnQ7CisgICAgICAgIGhlaWdodDogMjE1cHg7CisgICAgICAgIG92ZXJmbG93 LXg6IGhpZGRlbjsKKyAgICAgICAgb3ZlcmZsb3cteTogaGlkZGVuOworICAgICAgICBwb3NpdGlv bjogcmVsYXRpdmU7CisgICAgICAgIHdpZHRoOiAzNTBweDsKKyAgICAgIH0KKworICAgICAgbGk6 aG92ZXIKKyAgICAgIHsKKyAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogcmVkOworICAgICAgfQor ICAgIDwvc3R5bGU+CisKKyAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CisgICAg ICBmdW5jdGlvbiByZXBhaW50VGVzdCgpIHsKKyAgICAgICAgaWYoIXdpbmRvdy50ZXN0UnVubmVy KQorICAgICAgICAgIHJldHVybjsKKworICAgICAgICB2YXIgZmlyc3QgPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgiZmlyc3QiKTsKKyAgICAgICAgdmFyIHNlY29uZCA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJzZWNvbmQiKTsKKworICAgICAgICAvLyBob3ZlciB0aGUgMXN0IGl0ZW0KKyAg ICAgICAgdmFyIGxlZnQgPSBmaXJzdC5vZmZzZXRMZWZ0OworICAgICAgICB2YXIgdG9wID0gZmly c3Qub2Zmc2V0VG9wOworICAgICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhsZWZ0ICsgMjAs IHRvcCArIDIwKTsKKworICAgICAgICAvLyBub3cgaG92ZXIgdGhlIDJuZCBpdGVtCisgICAgICAg IGxlZnQgPSBzZWNvbmQub2Zmc2V0TGVmdDsKKyAgICAgICAgdG9wID0gc2Vjb25kLm9mZnNldFRv cDsKKyAgICAgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8obGVmdCArIDIwLCB0b3AgKyAyMCk7 CisgICAgICB9CisgICAgPC9zY3JpcHQ+CisKKyAgPC9oZWFkPgorCisgIDxib2R5IG9ubG9hZD0i cnVuUmVwYWludFRlc3QoKTsiPgorICAgIDxwPlRoaXMgdGVzdCBwYXNzZXMgaWYgbW92aW5nIHRo ZSBjdXJzb3IgZnJvbSBvbmUgb2YgdGhlIGJsdWUgaXRlbXMgdG8gdGhlIG90aGVyIHByb2R1Y2Vz IG5vIHJlcGFpbnQgZXJyb3JzIChzdWNoIGFzIGNyb3BwaW5nIG9mIG9uZSBvZiB0aGUgYmx1ZSBp dGVtcykuCisgICAgPGRpdiBjbGFzcz0icGFnZV9ib2R5Ij4KKyAgICAgIDx1bD4KKyAgICAgICAg PGxpIGlkPSJmaXJzdCI+PC9saT4KKyAgICAgICAgPGxpIGlkPSJzZWNvbmQiPjwvbGk+CisgICAg ICA8L3VsPgorICAgIDwvZGl2PgorICA8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmJl MjVmMS4uOWIzMTE2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTAyLTA0ICBS YWR1IFN0YXZpbGEgIDxzdGF2aWxhQGFkb2JlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChy MTU5NjA5KTogSW1hZ2VzIGFyZSBjb3JydXB0ZWQgd2hlbiBob3ZlcmluZyBvdmVyIGJ1dHRvbnMg QCBnaXRodWIuY29tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjc3MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBXaGVuIGNsaXBwaW5nIGEgcmVjdCwgdGhlIFJlbmRlckxheWVyIHdvdWxkIG5vdCBwcm9w ZXJseSBzYXZlIHRoZSBjb250ZXh0IHdoZW4KKyAgICAgICAgdGhlIGNsaXBwaW5nIHJlY3QgaXMg dGhlIHNhbWUgYXMgdGhlIHBhaW50IHJlY3QgYW5kIHRoZSBjbGlwcGluZyByZWN0CisgICAgICAg IGhhcyByYWRpdXMuCisKKyAgICAgICAgVGVzdDogZmFzdC9yZWdpb25zL3JlcGFpbnQvaG92ZXIt Ym9yZGVyLXJhZGl1cy5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmNsaXBUb1JlY3QpOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnJlc3RvcmVDbGlwKToKKwogMjAxNC0wMi0wNCAgTWlobmVh IE92aWRlbmllICA8bWlobmVhQGFkb2JlLmNvbT4KIAogICAgICAgICBBU1NFUlRJT04gRkFJTEVE OiAhb2JqZWN0IHx8IChvYmplY3QtPmlzUmVuZGVyQmxvY2soKSkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IGRhNjFlNmEuLjY2ZmZhMDEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtMzU2Myw3ICszNTYzLDcgQEAgc3Rh dGljIGJvb2wgaW5Db250YWluaW5nQmxvY2tDaGFpbihSZW5kZXJMYXllciogc3RhcnRMYXllciwg UmVuZGVyTGF5ZXIqIGVuZExheWUKIHZvaWQgUmVuZGVyTGF5ZXI6OmNsaXBUb1JlY3QoUmVuZGVy TGF5ZXIqIHJvb3RMYXllciwgR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBMYXlvdXRS ZWN0JiBwYWludERpcnR5UmVjdCwgY29uc3QgQ2xpcFJlY3QmIGNsaXBSZWN0LAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBCb3JkZXJSYWRpdXNDbGlwcGluZ1J1bGUgcnVsZSkKIHsKLSAg ICBpZiAoY2xpcFJlY3QucmVjdCgpICE9IHBhaW50RGlydHlSZWN0KSB7CisgICAgaWYgKGNsaXBS ZWN0LnJlY3QoKSAhPSBwYWludERpcnR5UmVjdCB8fCBjbGlwUmVjdC5oYXNSYWRpdXMoKSkgewog ICAgICAgICBjb250ZXh0LT5zYXZlKCk7CiAgICAgICAgIGNvbnRleHQtPmNsaXAocGl4ZWxTbmFw cGVkSW50UmVjdChjbGlwUmVjdC5yZWN0KCkpKTsKICAgICB9CkBAIC0zNTg4LDcgKzM1ODgsNyBA QCB2b2lkIFJlbmRlckxheWVyOjpjbGlwVG9SZWN0KFJlbmRlckxheWVyKiByb290TGF5ZXIsIEdy YXBoaWNzQ29udGV4dCogY29udGV4dCwgYwogCiB2b2lkIFJlbmRlckxheWVyOjpyZXN0b3JlQ2xp cChHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IExheW91dFJlY3QmIHBhaW50RGlydHlS ZWN0LCBjb25zdCBDbGlwUmVjdCYgY2xpcFJlY3QpCiB7Ci0gICAgaWYgKGNsaXBSZWN0LnJlY3Qo KSA9PSBwYWludERpcnR5UmVjdCkKKyAgICBpZiAoY2xpcFJlY3QucmVjdCgpID09IHBhaW50RGly dHlSZWN0ICYmICFjbGlwUmVjdC5oYXNSYWRpdXMoKSkKICAgICAgICAgcmV0dXJuOwogICAgIGNv bnRleHQtPnJlc3RvcmUoKTsKIH0K