127716 2014-01-27 15:31:10 -0800 Move underlying C++ objects to class extensions 2014-01-27 15:35:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 972610 0 andersca 2014-01-27 15:31:10 -0800 Move underlying C++ objects to class extensions 972612 1 222369 andersca 2014-01-27 15:32:11 -0800 Created attachment 222369 Patch 972613 2 commit-queue 2014-01-27 15:33:59 -0800 Attachment 222369 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/ios/WKContentViewInternal.h:49: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 972615 3 andersca 2014-01-27 15:35:14 -0800 Committed r162876: <http://trac.webkit.org/changeset/162876> 222369 2014-01-27 15:32:11 -0800 2014-01-27 15:34:10 -0800 Patch bug-127716-20140127153210.patch text/plain 3659 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyODczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTdmOGJjZTFiMTVjNTdh ZDJmZDY0ZDZiNjIxNjI0ZGY3MmY1ZTY3Ni4uMDRjMjhjZTljNTAyNTQxYjBmYmQ3MjEyNjdmOGZm ODhhYjg2MWJmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTAxLTI3ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgTW92ZSB1bmRlcmx5 aW5nIEMrKyBvYmplY3RzIHRvIGNsYXNzIGV4dGVuc2lvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzcxNgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgYWxsb3dzIHVzIHRvIGdldCBhdCB0aGUg aW50ZXJuYWxzIHdpdGhvdXQgY2FsbGluZyBhbnkgT2JqLUMgbWV0aG9kcy4KKworICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcm9jZXNzQ2xhc3MubW06CisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS1Byb2Nlc3NDbGFzc0ludGVybmFsLmg6CisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9pb3MvV0tDb250ZW50Vmlldy5tbToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJuYWwuaDoKKworMjAxNC0wMS0yNyAgQW5kZXJzIENhcmxzc29u ICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIEltcGxlbWVudCB0aGUgX2luamVjdGVk QnVuZGxlVVJMIHByb3BlcnR5CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjc3MTQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1Byb2Nlc3NDbGFzcy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvQ29jb2EvV0tQcm9jZXNzQ2xhc3MubW0KaW5kZXggMzc2YjU1ZTg1OTg5NzhjNmM5ZmZhOTQ3 YTUzZjNkZGY5ZDgwM2QwOC4uYjM3NWYzY2Y1YmQxMjBmYThhYjI4ODdlMWYxMGE5MTdkYWZmOWUw YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1Byb2Nl c3NDbGFzcy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJv Y2Vzc0NsYXNzLm1tCkBAIC0zNywxMSArMzcsNyBAQAogI2ltcG9ydCA8V2ViQ29yZS9XZWJDb3Jl VGhyZWFkU3lzdGVtSW50ZXJmYWNlLmg+CiAjZW5kaWYKIAotQGltcGxlbWVudGF0aW9uIFdLUHJv Y2Vzc0NsYXNzIHsKLSAgICBSZXRhaW5QdHI8V0tQcm9jZXNzQ2xhc3NDb25maWd1cmF0aW9uPiBf Y29uZmlndXJhdGlvbjsKLQotICAgIEFQSTo6T2JqZWN0U3RvcmFnZTxXZWJLaXQ6OldlYkNvbnRl eHQ+IF9jb250ZXh0OwotfQorQGltcGxlbWVudGF0aW9uIFdLUHJvY2Vzc0NsYXNzCiAKIC0gKGlu c3RhbmNldHlwZSlpbml0CiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLUHJvY2Vzc0NsYXNzSW50ZXJuYWwuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQ29jb2EvV0tQcm9jZXNzQ2xhc3NJbnRlcm5hbC5oCmluZGV4IDRlYzA2MTdlZDUy ODA0OWMxMTA5ODJmYjY1MzZkODhlY2VkNzI3MmYuLmE3MDc5YzY4MWYzZGVjZWJhNzVjNmE1ODAy NTkwZDkzZDMwNWRiOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Q29jb2EvV0tQcm9jZXNzQ2xhc3NJbnRlcm5hbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQ29jb2EvV0tQcm9jZXNzQ2xhc3NJbnRlcm5hbC5oCkBAIC00MCw3ICs0MCwxMiBA QCBpbmxpbmUgV0tQcm9jZXNzQ2xhc3MgKndyYXBwZXIoV2ViQ29udGV4dCYgY29udGV4dCkKIAog fQogCi1AaW50ZXJmYWNlIFdLUHJvY2Vzc0NsYXNzICgpIDxXS09iamVjdD4KK0BpbnRlcmZhY2Ug V0tQcm9jZXNzQ2xhc3MgKCkgPFdLT2JqZWN0PiB7CitAcGFja2FnZQorICAgIFJldGFpblB0cjxX S1Byb2Nlc3NDbGFzc0NvbmZpZ3VyYXRpb24+IF9jb25maWd1cmF0aW9uOworCisgICAgQVBJOjpP YmplY3RTdG9yYWdlPFdlYktpdDo6V2ViQ29udGV4dD4gX2NvbnRleHQ7Cit9CiBAZW5kCiAKICNl bmRpZiAvLyBXS19BUElfRU5BQkxFRApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9pb3MvV0tDb250ZW50Vmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvaW9zL1dLQ29udGVudFZpZXcubW0KaW5kZXggZDMzYjc0OGQwZDgyZDNkZjkyZWM1MWE3NmI5 ZTBkNjk0YzlhNGIyOS4uMGEzMGI2M2E1MWRjN2M2ZmZiNTk0NzIzOWY3YTI4OTc0MTdhYWE0MiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9pb3MvV0tDb250ZW50Vmll dy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2lvcy9XS0NvbnRlbnRWaWV3 Lm1tCkBAIC01Nyw3ICs1Nyw2IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAKIEBpbXBsZW1l bnRhdGlvbiBXS0NvbnRlbnRWaWV3IHsKICAgICBzdGQ6OnVuaXF1ZV9wdHI8UGFnZUNsaWVudElt cGw+IF9wYWdlQ2xpZW50OwotICAgIFJlZlB0cjxXZWJQYWdlUHJveHk+IF9wYWdlOwogICAgIFJl dGFpblB0cjxXS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXI+IF9icm93c2luZ0NvbnRleHRDb250 cm9sbGVyOwogCiAgICAgUmV0YWluUHRyPFVJVmlldz4gX3Jvb3RDb250ZW50VmlldzsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvaW9zL1dLQ29udGVudFZpZXdJbnRl cm5hbC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9pb3MvV0tDb250ZW50Vmlld0lu dGVybmFsLmgKaW5kZXggMjVjOTMwZTE1MWEzZjQ0YzA2ODNhZWVkM2UwNzUxNzIwYjg1NTQxNS4u ZDU4NDRkMGFmNTliZTU1ZDcyYmEyYmFhMzRkMTE5OTkyNDA3NjU5MyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9pb3MvV0tDb250ZW50Vmlld0ludGVybmFsLmgKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9pb3MvV0tDb250ZW50Vmlld0ludGVybmFs LmgKQEAgLTM5LDEzICszOSwxNyBAQCBjbGFzcyBEcmF3aW5nQXJlYVByb3h5OwogY2xhc3MgR2Vv bG9jYXRpb25QZXJtaXNzaW9uUmVxdWVzdFByb3h5OwogY2xhc3MgTGF5ZXJUcmVlQ29udGV4dDsK IGNsYXNzIFdlYkZyYW1lUHJveHk7CitjbGFzcyBXZWJQYWdlUHJveHk7CiBjbGFzcyBXZWJTZWN1 cml0eU9yaWdpbjsKIHN0cnVjdCBJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbjsKIH0K IAogQGNsYXNzIFdlYklPU0V2ZW50OwogCi1AaW50ZXJmYWNlIFdLQ29udGVudFZpZXcgKCkKK0Bp bnRlcmZhY2UgV0tDb250ZW50VmlldyAoKSB7CitAcGFja2FnZQorICAgIFJlZlB0cjxXZWJLaXQ6 OldlYlBhZ2VQcm94eT4gX3BhZ2U7Cit9CiAKIC0gKHN0ZDo6dW5pcXVlX3B0cjxXZWJLaXQ6OkRy YXdpbmdBcmVhUHJveHk+KV9jcmVhdGVEcmF3aW5nQXJlYVByb3h5OwogLSAodm9pZClfcHJvY2Vz c0RpZENyYXNoOwo=