<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>127703</bug_id>
          
          <creation_ts>2014-01-27 13:25:56 -0800</creation_ts>
          <short_desc>Windows tests broken after r162816</short_desc>
          <delta_ts>2014-01-27 15:53:56 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Roger Fong">roger_fong</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aboxhall</cc>
    
    <cc>apinheiro</cc>
    
    <cc>ap</cc>
    
    <cc>bfulgham</cc>
    
    <cc>cfleizach</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dmazzoni</cc>
    
    <cc>jcraig</cc>
    
    <cc>jdiggs</cc>
    
    <cc>mario</cc>
    
    <cc>roger_fong</cc>
    
    <cc>samuel_white</cc>
    
    <cc>thorton</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>972537</commentid>
    <comment_count>0</comment_count>
    <who name="Roger Fong">roger_fong</who>
    <bug_when>2014-01-27 13:25:56 -0800</bug_when>
    <thetext>r162816 is causing all Windows tests to crash.

The reason is because the test infrastructure now accesses the static class variable gAccessibilityEnabled variable defined in AXObjectCache.h and initialized in AXObjectCache.cpp.

However, we are accessing the variable from WebCoreTestSupport not WebCore, which does not include AXObjectCache.cpp and thus does not initialize the variable.

As a result, when we call the method, (from Internals.cpp in the WebCoreTestSupport project) we crash because we have not initialized the gAccessibilityEnabled variable in any cpp in the project.

Solutions:
We could just initialize it somewhere (like in Internals.cpp) but then we have a copy of that initializing in both WebCore/AXObjectCache.cpp and WebCoreTestSupport/Internals.cpp

Or we could just include AXObjectCache.cpp, have WebCore copy the file over to the build directory, etc etc etc, which is kind of strange because we don&apos;t do that for any other files in WebCoreTestSupport.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972544</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2014-01-27 13:46:01 -0800</bug_when>
    <thetext>gAccessibilityEnabled is exported from WebKit, so I don&apos;t see why this doesn&apos;t work. The variable should be shared across dynamic libraries.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972558</commentid>
    <comment_count>2</comment_count>
      <attachid>222356</attachid>
    <who name="Roger Fong">roger_fong</who>
    <bug_when>2014-01-27 14:12:23 -0800</bug_when>
    <thetext>Created attachment 222356
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972560</commentid>
    <comment_count>3</comment_count>
    <who name="Roger Fong">roger_fong</who>
    <bug_when>2014-01-27 14:14:27 -0800</bug_when>
    <thetext>(In reply to comment #1)
&gt; gAccessibilityEnabled is exported from WebKit, so I don&apos;t see why this doesn&apos;t work. The variable should be shared across dynamic libraries.

didn&apos;t read this before uploading the patch (which does seem to fix the issue)

That is confusing, and in fact if i&apos;m initializing the variable in WebCoreTestSupport.lib and WebKit.dll shouldn&apos;t there be some kinda multiple definition clash? (I did not see this, when running the tests with my patch in place)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972561</commentid>
    <comment_count>4</comment_count>
      <attachid>222356</attachid>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2014-01-27 14:14:40 -0800</bug_when>
    <thetext>Comment on attachment 222356
patch

Won&apos;t the two gAccessibilityEnabled get out of sync now?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972562</commentid>
    <comment_count>5</comment_count>
    <who name="Roger Fong">roger_fong</who>
    <bug_when>2014-01-27 14:20:21 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 222356 [details])
&gt; Won&apos;t the two gAccessibilityEnabled get out of sync now?

Right, which is why I was thinking about having WebCoreTestSupport compile AXObjectCache.cpp on its own. Or alternatively maybe just get rid of WebCoreTestSupport and stick it in WebCore (like it is on Mac??). 

I&apos;m not quite sure why we need the separate project.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972588</commentid>
    <comment_count>6</comment_count>
    <who name="Roger Fong">roger_fong</who>
    <bug_when>2014-01-27 14:44:47 -0800</bug_when>
    <thetext>Ignore all the things I said.

Alexey and I think that there&apos;s something odd with how Windows data exporting works.

What we should do is to make the added function non inline and then export the functions.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972623</commentid>
    <comment_count>7</comment_count>
      <attachid>222374</attachid>
    <who name="Roger Fong">roger_fong</who>
    <bug_when>2014-01-27 15:44:23 -0800</bug_when>
    <thetext>Created attachment 222374
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972626</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-01-27 15:46:54 -0800</bug_when>
    <thetext>Attachment 222374 did not pass style-queue:


ERROR: Source/WebKit/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Source/WebCore/accessibility/AXObjectCache.cpp:112:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/accessibility/AXObjectCache.h:130:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/accessibility/AXObjectCache.h:131:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972633</commentid>
    <comment_count>9</comment_count>
      <attachid>222374</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2014-01-27 15:53:56 -0800</bug_when>
    <thetext>Comment on attachment 222374
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222374&amp;action=review

&gt; Source/WebCore/ChangeLog:21
&gt; +2014-01-27  Roger Fong  &lt;roger_fong@apple.com&gt;
&gt; +
&gt; +        [Windows] Tests crashing on Windows after r162816.
&gt; +        https://bugs.webkit.org/show_bug.cgi?id=127703.
&gt; +
&gt; +        Reviewed by NOBODY (OOPS!).
&gt; +
&gt; +        * accessibility/AXObjectCache.cpp:
&gt; +        (WebCore::AXObjectCache::enableAccessibility):
&gt; +        (WebCore::AXObjectCache::disableAccessibility):
&gt; +        * accessibility/AXObjectCache.h: Un-inline some methods so that they can be exported.
&gt; +
&gt; +2014-01-27  Roger Fong  &lt;roger_fong@apple.com&gt;
&gt; +
&gt; +        [Windows] Tests crashing on Windows after r162816.
&gt; +        https://bugs.webkit.org/show_bug.cgi?id=127703.
&gt; +
&gt; +        Reviewed by NOBODY (OOPS!).
&gt; +
&gt; +        * testing/Internals.cpp: Initialize gAccessibilityEnabled in WebCoreTestSupport.
&gt; +

Double ChangeLog.

&gt; Source/WebCore/accessibility/AXObjectCache.cpp:112
&gt; +void AXObjectCache::enableAccessibility() { gAccessibilityEnabled = true; }
&gt; +void AXObjectCache::disableAccessibility() { gAccessibilityEnabled = false; };

Please format these as normal multi-line functions, and remove the trailing semicolon.

&gt; Source/WebKit/ChangeLog:4
&gt; +        Need a short description (OOPS!).
&gt; +        Need the bug URL (OOPS!).

Yup.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>222356</attachid>
            <date>2014-01-27 14:12:23 -0800</date>
            <delta_ts>2014-01-27 14:44:59 -0800</delta_ts>
            <desc>patch</desc>
            <filename>patch.patch</filename>
            <type>text/plain</type>
            <size>2619</size>
            <attacher name="Roger Fong">roger_fong</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2Mjg2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAxLTI3ICBSb2dlciBG
b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dpbmRvd3NdIFRlc3RzIGNy
YXNoaW5nIG9uIFdpbmRvd3MgYWZ0ZXIgcjE2MjgxNi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzcwMy4KKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmNwcDogSW5pdGlh
bGl6ZSBnQWNjZXNzaWJpbGl0eUVuYWJsZWQgaW4gV2ViQ29yZVRlc3RTdXBwb3J0LgorCiAyMDE0
LTAxLTI3ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBJREI6
IFJlbW92ZSB1bnVzZWQgY29uY2VwdCBvZiAiY3Vyc29yIHByZWZldGNoIgpJbmRleDogU291cmNl
L1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD
b3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAkocmV2aXNpb24gMTYyODQ4KQorKysgU291cmNlL1dl
YkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjAsNiArMjYw
LDEwIEBACiB7CiB9CiAKKyNpZiBIQVZFKEFDQ0VTU0lCSUxJVFkpICYmIFBMQVRGT1JNKFdJTikK
K2Jvb2wgV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6Z0FjY2Vzc2liaWxpdHlFbmFibGVkID0gZmFs
c2U7CisjZW5kaWYKKwogdm9pZCBJbnRlcm5hbHM6OnJlc2V0VG9Db25zaXN0ZW50U3RhdGUoUGFn
ZSogcGFnZSkKIHsKICAgICBBU1NFUlQocGFnZSk7CkluZGV4OiBTb3VyY2UvV2ViS2l0L0NoYW5n
ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwkocmV2aXNpb24gMTYy
ODY0KQorKysgU291cmNlL1dlYktpdC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr
MSwxMiBAQAorMjAxNC0wMS0yNyAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgor
CisgICAgICAgIFtXaW5kb3dzXSBUZXN0cyBjcmFzaGluZyBvbiBXaW5kb3dzIGFmdGVyIHIxNjI4
MTYuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc3
MDMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBX
ZWJLaXQudmN4cHJvai9XZWJLaXRFeHBvcnRHZW5lcmF0b3IvV2ViS2l0RXhwb3J0cy5kZWYuaW46
IFVubmVjZXNzYXJ5IGV4cG9ydC4KKwogMjAxNC0wMS0yNiAgQ2hyaXMgRmxlaXphY2ggIDxjZmxl
aXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBEaXNhYmxlIGFjY2Vzc2liaWxpdHkgYWZ0
ZXIgZXZlcnkgdGVzdCBydW4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViS2l0LnZjeHByb2ovV2Vi
S2l0RXhwb3J0R2VuZXJhdG9yL1dlYktpdEV4cG9ydHMuZGVmLmluCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv
dXJjZS9XZWJLaXQvV2ViS2l0LnZjeHByb2ovV2ViS2l0RXhwb3J0R2VuZXJhdG9yL1dlYktpdEV4
cG9ydHMuZGVmLmluCShyZXZpc2lvbiAxNjI4NDgpCisrKyBTb3VyY2UvV2ViS2l0L1dlYktpdC52
Y3hwcm9qL1dlYktpdEV4cG9ydEdlbmVyYXRvci9XZWJLaXRFeHBvcnRzLmRlZi5pbgkod29ya2lu
ZyBjb3B5KQpAQCAtNDY5LDUgKzQ2OSw1IEBACiAgICAgICAgIHN5bWJvbFdpdGhQb2ludGVyKD9j
b21wbGV0ZVVSTEBEb2N1bWVudEBXZWJDb3JlQEBVQkU/QVZVUkxAMkBBQlZTdHJpbmdAV1RGQEBA
WiwgP2NvbXBsZXRlVVJMQERvY3VtZW50QFdlYkNvcmVAQFVFQkE/QVZVUkxAMkBBRUJWU3RyaW5n
QFdURkBAQFopCiAgICAgICAgIHN5bWJvbFdpdGhQb2ludGVyKD8/MURPTVdpbmRvd0BXZWJDb3Jl
QEBVQUVAWFosID8/MURPTVdpbmRvd0BXZWJDb3JlQEBVRUFBQFhaKQogICAgICAgICBzeW1ib2xX
aXRoUG9pbnRlcig/dmlzaWJsZUNvbnRlbnRSZWN0QFNjcm9sbGFibGVBcmVhQFdlYkNvcmVAQFFC
RT9BVkludFJlY3RAMkBXNFZpc2libGVDb250ZW50UmVjdEJlaGF2aW9yQDEyQEBaLCA/dmlzaWJs
ZUNvbnRlbnRSZWN0QFNjcm9sbGFibGVBcmVhQFdlYkNvcmVAQFFFQkE/QVZJbnRSZWN0QDJAVzRW
aXNpYmxlQ29udGVudFJlY3RCZWhhdmlvckAxMkBAWikKLSAgICAgICAgc3ltYm9sV2l0aFBvaW50
ZXIoP2dBY2Nlc3NpYmlsaXR5RW5hYmxlZEBBWE9iamVjdENhY2hlQFdlYkNvcmVAQDBfTkEsID9n
QWNjZXNzaWJpbGl0eUVuYWJsZWRAQVhPYmplY3RDYWNoZUBXZWJDb3JlQEAwX05BKQogCisK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>222374</attachid>
            <date>2014-01-27 15:44:23 -0800</date>
            <delta_ts>2014-01-27 15:53:56 -0800</delta_ts>
            <desc>patch</desc>
            <filename>patch.patch</filename>
            <type>text/plain</type>
            <size>4266</size>
            <attacher name="Roger Fong">roger_fong</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2Mjg3NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE0LTAxLTI3ICBSb2dlciBG
b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dpbmRvd3NdIFRlc3RzIGNy
YXNoaW5nIG9uIFdpbmRvd3MgYWZ0ZXIgcjE2MjgxNi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzcwMy4KKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5j
cHA6CisgICAgICAgIChXZWJDb3JlOjpBWE9iamVjdENhY2hlOjplbmFibGVBY2Nlc3NpYmlsaXR5
KToKKyAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OmRpc2FibGVBY2Nlc3NpYmlsaXR5
KToKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuaDogVW4taW5saW5lIHNv
bWUgbWV0aG9kcyBzbyB0aGF0IHRoZXkgY2FuIGJlIGV4cG9ydGVkLgorCisyMDE0LTAxLTI3ICBS
b2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dpbmRvd3NdIFRl
c3RzIGNyYXNoaW5nIG9uIFdpbmRvd3MgYWZ0ZXIgcjE2MjgxNi4KKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzcwMy4KKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmNwcDog
SW5pdGlhbGl6ZSBnQWNjZXNzaWJpbGl0eUVuYWJsZWQgaW4gV2ViQ29yZVRlc3RTdXBwb3J0Lgor
CiAyMDE0LTAxLTI3ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAg
ICBSZW1vdmUgdW51c2VkIFVTRShPUEVOVFlQRV9TQU5JVElaRVIpIGNvZGUuCkluZGV4OiBTb3Vy
Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAJKHJldmlzaW9u
IDE2Mjg0OCkKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5j
cHAJKHdvcmtpbmcgY29weSkKQEAgLTEwOCw2ICsxMDgsOSBAQAogYm9vbCBBWE9iamVjdENhY2hl
OjpnQWNjZXNzaWJpbGl0eUVuYWJsZWQgPSBmYWxzZTsKIGJvb2wgQVhPYmplY3RDYWNoZTo6Z0Fj
Y2Vzc2liaWxpdHlFbmhhbmNlZFVzZXJJbnRlcmZhY2VFbmFibGVkID0gZmFsc2U7CiAKK3ZvaWQg
QVhPYmplY3RDYWNoZTo6ZW5hYmxlQWNjZXNzaWJpbGl0eSgpIHsgZ0FjY2Vzc2liaWxpdHlFbmFi
bGVkID0gdHJ1ZTsgfQordm9pZCBBWE9iamVjdENhY2hlOjpkaXNhYmxlQWNjZXNzaWJpbGl0eSgp
IHsgZ0FjY2Vzc2liaWxpdHlFbmFibGVkID0gZmFsc2U7IH07CisKIEFYT2JqZWN0Q2FjaGU6OkFY
T2JqZWN0Q2FjaGUoRG9jdW1lbnQmIGRvY3VtZW50KQogICAgIDogbV9kb2N1bWVudChkb2N1bWVu
dCkKICAgICAsIG1fbm90aWZpY2F0aW9uUG9zdFRpbWVyKHRoaXMsICZBWE9iamVjdENhY2hlOjpu
b3RpZmljYXRpb25Qb3N0VGltZXJGaXJlZCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2li
aWxpdHkvQVhPYmplY3RDYWNoZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vz
c2liaWxpdHkvQVhPYmplY3RDYWNoZS5oCShyZXZpc2lvbiAxNjI4NDgpCisrKyBTb3VyY2UvV2Vi
Q29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuaAkod29ya2luZyBjb3B5KQpAQCAtMTI3
LDggKzEyNyw4IEBACiAgICAgdm9pZCByZWNvbXB1dGVJc0lnbm9yZWQoUmVuZGVyT2JqZWN0KiBy
ZW5kZXJlcik7CiAKICNpZiBIQVZFKEFDQ0VTU0lCSUxJVFkpCi0gICAgc3RhdGljIHZvaWQgZW5h
YmxlQWNjZXNzaWJpbGl0eSgpIHsgZ0FjY2Vzc2liaWxpdHlFbmFibGVkID0gdHJ1ZTsgfQotICAg
IHN0YXRpYyB2b2lkIGRpc2FibGVBY2Nlc3NpYmlsaXR5KCkgeyBnQWNjZXNzaWJpbGl0eUVuYWJs
ZWQgPSBmYWxzZTsgfQorCXN0YXRpYyB2b2lkIGVuYWJsZUFjY2Vzc2liaWxpdHkoKTsKKwlzdGF0
aWMgdm9pZCBkaXNhYmxlQWNjZXNzaWJpbGl0eSgpOwogCiAgICAgLy8gRW5oYW5jZWQgdXNlciBp
bnRlcmZhY2UgYWNjZXNzaWJpbGl0eSBjYW4gYmUgdG9nZ2xlZCBieSB0aGUgYXNzaXN0aXZlIHRl
Y2hub2xvZ3kuCiAgICAgc3RhdGljIHZvaWQgc2V0RW5oYW5jZWRVc2VySW50ZXJmYWNlQWNjZXNz
aWJpbGl0eShib29sIGZsYWcpIHsgZ0FjY2Vzc2liaWxpdHlFbmhhbmNlZFVzZXJJbnRlcmZhY2VF
bmFibGVkID0gZmxhZzsgfQpJbmRleDogU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gU291cmNlL1dlYktpdC9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2Mjg3NikKKysrIFNvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQt
MDEtMjcgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNvbT4KKworICAgICAgICBOZWVk
IGEgc2hvcnQgZGVzY3JpcHRpb24gKE9PUFMhKS4KKyAgICAgICAgTmVlZCB0aGUgYnVnIFVSTCAo
T09QUyEpLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
ICogV2ViS2l0LnZjeHByb2ovV2ViS2l0RXhwb3J0R2VuZXJhdG9yL1dlYktpdEV4cG9ydHMuZGVm
LmluOiBSZW1vdmUgdmFyaWFibGUgZXhwb3J0IGluIGZhdm9yIG9mIGZ1bmN0aW9uIGV4cG9ydC4K
KwogMjAxNC0wMS0yNiAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAg
ICAgICAgIEFYOiBEaXNhYmxlIGFjY2Vzc2liaWxpdHkgYWZ0ZXIgZXZlcnkgdGVzdCBydW4KSW5k
ZXg6IFNvdXJjZS9XZWJLaXQvV2ViS2l0LnZjeHByb2ovV2ViS2l0RXhwb3J0R2VuZXJhdG9yL1dl
YktpdEV4cG9ydHMuZGVmLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViS2l0LnZj
eHByb2ovV2ViS2l0RXhwb3J0R2VuZXJhdG9yL1dlYktpdEV4cG9ydHMuZGVmLmluCShyZXZpc2lv
biAxNjI4NDgpCisrKyBTb3VyY2UvV2ViS2l0L1dlYktpdC52Y3hwcm9qL1dlYktpdEV4cG9ydEdl
bmVyYXRvci9XZWJLaXRFeHBvcnRzLmRlZi5pbgkod29ya2luZyBjb3B5KQpAQCAtNDY5LDUgKzQ2
OSw0IEBACiAgICAgICAgIHN5bWJvbFdpdGhQb2ludGVyKD9jb21wbGV0ZVVSTEBEb2N1bWVudEBX
ZWJDb3JlQEBVQkU/QVZVUkxAMkBBQlZTdHJpbmdAV1RGQEBAWiwgP2NvbXBsZXRlVVJMQERvY3Vt
ZW50QFdlYkNvcmVAQFVFQkE/QVZVUkxAMkBBRUJWU3RyaW5nQFdURkBAQFopCiAgICAgICAgIHN5
bWJvbFdpdGhQb2ludGVyKD8/MURPTVdpbmRvd0BXZWJDb3JlQEBVQUVAWFosID8/MURPTVdpbmRv
d0BXZWJDb3JlQEBVRUFBQFhaKQogICAgICAgICBzeW1ib2xXaXRoUG9pbnRlcig/dmlzaWJsZUNv
bnRlbnRSZWN0QFNjcm9sbGFibGVBcmVhQFdlYkNvcmVAQFFCRT9BVkludFJlY3RAMkBXNFZpc2li
bGVDb250ZW50UmVjdEJlaGF2aW9yQDEyQEBaLCA/dmlzaWJsZUNvbnRlbnRSZWN0QFNjcm9sbGFi
bGVBcmVhQFdlYkNvcmVAQFFFQkE/QVZJbnRSZWN0QDJAVzRWaXNpYmxlQ29udGVudFJlY3RCZWhh
dmlvckAxMkBAWikKLSAgICAgICAgc3ltYm9sV2l0aFBvaW50ZXIoP2dBY2Nlc3NpYmlsaXR5RW5h
YmxlZEBBWE9iamVjdENhY2hlQFdlYkNvcmVAQDBfTkEsID9nQWNjZXNzaWJpbGl0eUVuYWJsZWRA
QVhPYmplY3RDYWNoZUBXZWJDb3JlQEAwX05BKQotCisgICAgICAgIHN5bWJvbFdpdGhQb2ludGVy
KD9kaXNhYmxlQWNjZXNzaWJpbGl0eUBBWE9iamVjdENhY2hlQFdlYkNvcmVAQFNBWFhaLCA/ZGlz
YWJsZUFjY2Vzc2liaWxpdHlAQVhPYmplY3RDYWNoZUBXZWJDb3JlQEBTQVhYWikK
</data>
<flag name="review"
          id="246359"
          type_id="1"
          status="+"
          setter="ap"
    />
    <flag name="commit-queue"
          id="246361"
          type_id="3"
          status="-"
          setter="ap"
    />
          </attachment>
      

    </bug>

</bugzilla>