127702 2014-01-27 13:24:24 -0800 [iOS] preload=none prevents play() 2014-01-27 14:43:40 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson commit-queue esprehn+autocc glenn gyuyoung.kim jer.noble philipj oldest_to_newest 972535 0 eric.carlson 2014-01-27 13:24:24 -0800 play() does not work when preload=none and not using the media player proxy. 972568 1 222358 eric.carlson 2014-01-27 14:28:17 -0800 Created attachment 222358 Proposed patch 972574 2 222358 jer.noble 2014-01-27 14:33:40 -0800 Comment on attachment 222358 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=222358&action=review r=me, with nit: > Source/WebCore/html/HTMLMediaElement.cpp:4257 > #if PLATFORM(IOS) > - if (shouldBePlaying && !m_requestingPlay && !m_player->readyForPlayback()) > - shouldBePlaying = false; > - else if (!shouldBePlaying && m_requestingPlay && m_player->readyForPlayback()) > - shouldBePlaying = true; > + if (shouldUseVideoPluginProxy()) { > + if (shouldBePlaying && !m_requestingPlay && !m_player->readyForPlayback()) > + shouldBePlaying = false; > + else if (!shouldBePlaying && m_requestingPlay && m_player->readyForPlayback()) > + shouldBePlaying = true; > + } > #endif Could this #if PLATFORM(IOS) be replaced by #if ENABLE(PLUGIN_PROXY_FOR_VIDEO)? 972586 3 eric.carlson 2014-01-27 14:43:32 -0800 Committed r162870: https://trac.webkit.org/r162870 222358 2014-01-27 14:28:17 -0800 2014-01-27 14:43:40 -0800 Proposed patch patch_2.txt text/plain 2597 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2Mjg2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAxLTI3ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIHByZWxvYWQ9 bm9uZSBwcmV2ZW50cyBwbGF5KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyNzcwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKwor ICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpI VE1MTWVkaWFFbGVtZW50Ojpwb3RlbnRpYWxseVBsYXlpbmcpOiBDbGVhbnVwIGxvZ2ljIHRvIG1h a2UgaXQgc2ltcGxlciB0byB1bmRlcnN0YW5kLAorICAgICAgICAgICAgZml4IGxvZ2ljIGVycm9y IGludHJvZHVjZWQgaW4gcjE2MTk3MworICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVu dDo6dXBkYXRlUGxheVN0YXRlKTogQ29uZGl0aW9uYWxpemUgc29tZSBpT1Mtb25seSBjb2RlIG9u IHdoZXRoZXIgb3Igbm90CisgICAgICAgICAgICB3ZSBhcmUgdXNpbmcgdGhlIHBsdWctaW4gcHJv eHkuCisKIDIwMTQtMDEtMjcgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAg ICAgICAgIElEQjogUmVtb3ZlIHVudXNlZCBjb25jZXB0IG9mICJjdXJzb3IgcHJlZmV0Y2giCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHJldmlzaW9uIDE2 MjcyNSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTQxMDgsMTEgKzQxMDgsMTYgQEAgUGFzc1JlZlB0cjxUaW1lUmFuZ2VzPiBI VE1MTWVkaWFFbGVtZW50OgogCiBib29sIEhUTUxNZWRpYUVsZW1lbnQ6OnBvdGVudGlhbGx5UGxh eWluZygpIGNvbnN0CiB7Ci0gICAgLy8gV2hlbiBtZWRpYSBlbmdpbmUgcmFuIG91dCBvZiBidWZm ZXJlZCBkYXRhIGl0J3Mgbm90IHBsYXlpbmcuCi0gICAgaWYgKG1fcmVhZHlTdGF0ZU1heGltdW0g PCBIQVZFX0ZVVFVSRV9EQVRBICYmIG1fcmVhZHlTdGF0ZSA8IEhBVkVfRlVUVVJFX0RBVEEpCisg ICAgaWYgKGlzQmxvY2tlZE9uTWVkaWFDb250cm9sbGVyKCkpCiAgICAgICAgIHJldHVybiBmYWxz ZTsKKyAgICAKKyAgICBpZiAoIWNvdWxkUGxheUlmRW5vdWdoRGF0YSgpKQorICAgICAgICByZXR1 cm4gZmFsc2U7CisKKyAgICBpZiAobV9yZWFkeVN0YXRlID49IEhBVkVfRlVUVVJFX0RBVEEpCisg ICAgICAgIHJldHVybiB0cnVlOwogCi0gICAgcmV0dXJuIGNvdWxkUGxheUlmRW5vdWdoRGF0YSgp ICYmICFpc0Jsb2NrZWRPbk1lZGlhQ29udHJvbGxlcigpOworICAgIHJldHVybiBtX3JlYWR5U3Rh dGVNYXhpbXVtID49IEhBVkVfRlVUVVJFX0RBVEEgJiYgbV9yZWFkeVN0YXRlIDwgSEFWRV9GVVRV UkVfREFUQTsKIH0KIAogYm9vbCBIVE1MTWVkaWFFbGVtZW50Ojpjb3VsZFBsYXlJZkVub3VnaERh dGEoKSBjb25zdApAQCAtNDI0MywxMCArNDI0OCwxMiBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6 OnVwZGF0ZVBsYXlTdGF0ZSgpCiAgICAgYm9vbCBwbGF5ZXJQYXVzZWQgPSBtX3BsYXllci0+cGF1 c2VkKCk7CiAKICNpZiBQTEFURk9STShJT1MpCi0gICAgaWYgKHNob3VsZEJlUGxheWluZyAmJiAh bV9yZXF1ZXN0aW5nUGxheSAmJiAhbV9wbGF5ZXItPnJlYWR5Rm9yUGxheWJhY2soKSkKLSAgICAg ICAgc2hvdWxkQmVQbGF5aW5nID0gZmFsc2U7Ci0gICAgZWxzZSBpZiAoIXNob3VsZEJlUGxheWlu ZyAmJiBtX3JlcXVlc3RpbmdQbGF5ICYmIG1fcGxheWVyLT5yZWFkeUZvclBsYXliYWNrKCkpCi0g ICAgICAgIHNob3VsZEJlUGxheWluZyA9IHRydWU7CisgICAgaWYgKHNob3VsZFVzZVZpZGVvUGx1 Z2luUHJveHkoKSkgeworICAgICAgICBpZiAoc2hvdWxkQmVQbGF5aW5nICYmICFtX3JlcXVlc3Rp bmdQbGF5ICYmICFtX3BsYXllci0+cmVhZHlGb3JQbGF5YmFjaygpKQorICAgICAgICAgICAgc2hv dWxkQmVQbGF5aW5nID0gZmFsc2U7CisgICAgICAgIGVsc2UgaWYgKCFzaG91bGRCZVBsYXlpbmcg JiYgbV9yZXF1ZXN0aW5nUGxheSAmJiBtX3BsYXllci0+cmVhZHlGb3JQbGF5YmFjaygpKQorICAg ICAgICAgICAgc2hvdWxkQmVQbGF5aW5nID0gdHJ1ZTsKKyAgICB9CiAjZW5kaWYKIAogICAgIExP RyhNZWRpYSwgIkhUTUxNZWRpYUVsZW1lbnQ6OnVwZGF0ZVBsYXlTdGF0ZSAtIHNob3VsZEJlUGxh eWluZyA9ICVzLCBwbGF5ZXJQYXVzZWQgPSAlcyIsIAo=