127685 2014-01-27 09:21:51 -0800 WebCrypto keyUsage is no longer an optional argument 2016-12-01 14:55:29 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P3 Normal --- 160883 1 ap evab.u-szeged bfulgham evab.u-szeged jiewen_tan rob webkit-bug-importer oldest_to_newest 972434 0 ap 2014-01-27 09:21:51 -0800 See <https://www.w3.org/Bugs/Public/show_bug.cgi?id=19416>, it doesn't make sense for keyUsage to have the default empty value. 983054 1 ap 2014-02-20 17:52:46 -0800 https://www.w3.org/Bugs/Public/show_bug.cgi?id=19705 is the correct bug. 1045726 2 240848 evab.u-szeged 2014-11-03 06:55:09 -0800 Created attachment 240848 Patch 1045755 3 240848 ap 2014-11-03 09:22:34 -0800 Comment on attachment 240848 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240848&action=review This patch does not change behavior - everything besides the function name is essentially a comment for [Custom] properties. The actual implementation that makes these optional is in JSSubtleCryptoCustom.cpp. It is probably OK to make this particular change. But I think that the better approach would be to freeze the existing implementation under crypto.webkitSubtle, and start one that matches the new spec and is exposed as crypto.subtle. There were incompatible changes that we shouldn't be making for webkitSubtle. And generally, the spec changed so much that a clean reimplementation is probably easier than massaging the existing one. > Source/WebCore/ChangeLog:8 > + No new tests, no behavior change. There is indeed no behavior change (see above), however making arguments non-optional is definitely a behavior change that needs to be tested. 1220273 4 webkit-bug-importer 2016-08-15 18:09:42 -0700 <rdar://problem/27858197> 1255457 5 jiewen_tan 2016-12-01 14:02:50 -0800 This bug should be resolved by the following revisions: <http://trac.webkit.org/changeset/207809>, <http://trac.webkit.org/changeset/208548>, <http://trac.webkit.org/changeset/208737>, <http://trac.webkit.org/changeset/208891>, <http://trac.webkit.org/changeset/208918>, <http://trac.webkit.org/changeset/209092>, <http://trac.webkit.org/changeset/209150>, <http://trac.webkit.org/changeset/209164>, <http://trac.webkit.org/changeset/209166>, <http://trac.webkit.org/changeset/209191>, <http://trac.webkit.org/changeset/209155>, <http://trac.webkit.org/changeset/209200>. 240848 2014-11-03 06:55:09 -0800 2016-12-01 14:55:29 -0800 Patch bug-127685-20141103155516.patch text/plain 2550 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NDY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTBkYTkwMzAwYTQxZGQ1 MjczYjU4ZjBjMWYyM2ZiZDAxOTZmY2IwZC4uYmI4ZTNmOWQzZTg1NjdmMDk5OWIyM2EzYTYzOWRl Mjc3ZjQzMDMxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTExLTAzICBFdmEg QmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAg ICAgV2ViQ3J5cHRvIGtleVVzYWdlIGlzIG5vIGxvbmdlciBhbiBvcHRpb25hbCBhcmd1bWVudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3Njg1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBjcnlwdG8vU3VidGxlQ3J5cHRv LmlkbDoKKwogMjAxNC0xMS0wMyAgU3VuZ21hbm4gQ2hvICA8c3VuZ21hbm4uY2hvQG5hdmVyY29y cC5jb20+CiAKICAgICAgICAgQVg6IEZpeCBzb21lIG1pbm9yIHR5cG9zIHJlbGF0ZWQgdG8gdGhl IHdvcmQgImFjY2Vzc2liaWxpdHkiLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3J5cHRv L1N1YnRsZUNyeXB0by5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9jcnlwdG8vU3VidGxlQ3J5cHRvLmlk bAppbmRleCBjOTg1ZjM5Yzg1ZDFkZjNmY2E1NDRhM2YzMzU3ZDM0YWYyYmY3YmVhLi4wYWYwMWM2 OWM5NTZiYzUxYThhMjI3NDEzZDExNWM0ZWFmOWZjNDkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9jcnlwdG8vU3VidGxlQ3J5cHRvLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jcnlwdG8v U3VidGxlQ3J5cHRvLmlkbApAQCAtMzQsOSArMzQsOSBAQAogICAgIFtDdXN0b21dIFByb21pc2Ug c2lnbihBbGdvcml0aG1JZGVudGlmaWVyIGFsZ29yaXRobSwgS2V5IGtleSwgc2VxdWVuY2U8Q3J5 cHRvT3BlcmF0aW9uRGF0YT4gZGF0YSk7CiAgICAgW0N1c3RvbV0gUHJvbWlzZSB2ZXJpZnkoQWxn b3JpdGhtSWRlbnRpZmllciBhbGdvcml0aG0sIEtleSBrZXksIENyeXB0b09wZXJhdGlvbkRhdGEg c2lnbmF0dXJlLCBzZXF1ZW5jZTxDcnlwdG9PcGVyYXRpb25EYXRhPiBkYXRhKTsKICAgICBbQ3Vz dG9tXSBQcm9taXNlIGRpZ2VzdChBbGdvcml0aG1JZGVudGlmaWVyIGFsZ29yaXRobSwgc2VxdWVu Y2U8Q3J5cHRvT3BlcmF0aW9uRGF0YT4gZGF0YSk7Ci0gICAgW0N1c3RvbV0gUHJvbWlzZSBnZW5l cmF0ZUtleShBbGdvcml0aG1JZGVudGlmaWVyIGFsZ29yaXRobSwgb3B0aW9uYWwgYm9vbGVhbiBl eHRyYWN0YWJsZSwgb3B0aW9uYWwgS2V5VXNhZ2VbXSBrZXlVc2FnZXMpOwotICAgIFtDdXN0b21d IFByb21pc2UgaW1wb3J0S2V5KEtleUZvcm1hdCBmb3JtYXQsIENyeXB0b09wZXJhdGlvbkRhdGEg a2V5RGF0YSwgQWxnb3JpdGhtSWRlbnRpZmllcj8gYWxnb3JpdGhtLCBvcHRpb25hbCBib29sZWFu IGV4dHJhY3RhYmxlLCBvcHRpb25hbCBLZXlVc2FnZVtdIGtleVVzYWdlcyk7CisgICAgW0N1c3Rv bV0gUHJvbWlzZSBnZW5lcmF0ZUtleShBbGdvcml0aG1JZGVudGlmaWVyIGFsZ29yaXRobSwgYm9v bGVhbiBleHRyYWN0YWJsZSwgS2V5VXNhZ2VbXSBrZXlVc2FnZXMpOworICAgIFtDdXN0b21dIFBy b21pc2UgaW1wb3J0S2V5KEtleUZvcm1hdCBmb3JtYXQsIENyeXB0b09wZXJhdGlvbkRhdGEga2V5 RGF0YSwgQWxnb3JpdGhtSWRlbnRpZmllcj8gYWxnb3JpdGhtLCBib29sZWFuIGV4dHJhY3RhYmxl LCBLZXlVc2FnZVtdIGtleVVzYWdlcyk7CiAgICAgW0N1c3RvbV0gUHJvbWlzZSBleHBvcnRLZXko S2V5Rm9ybWF0IGZvcm1hdCwgS2V5IGtleSk7CiAgICAgW0N1c3RvbV0gUHJvbWlzZSB3cmFwS2V5 KEtleUZvcm1hdCBmb3JtYXQsIEtleSBrZXksIEtleSB3cmFwcGluZ0tleSwgQWxnb3JpdGhtSWRl bnRpZmllciB3cmFwQWxnb3JpdGhtKTsKLSAgICBbQ3VzdG9tXSBQcm9taXNlIHVud3JhcEtleShL ZXlGb3JtYXQgZm9ybWF0LCBDcnlwdG9PcGVyYXRpb25EYXRhIHdyYXBwZWRLZXksIEtleSB1bndy YXBwaW5nS2V5LCBBbGdvcml0aG1JZGVudGlmaWVyIHVud3JhcEFsZ29yaXRobSwgQWxnb3JpdGht SWRlbnRpZmllcj8gdW53cmFwcGVkS2V5QWxnb3JpdGhtLCBvcHRpb25hbCBib29sZWFuIGV4dHJh Y3RhYmxlLCBvcHRpb25hbCBLZXlVc2FnZVtdIGtleVVzYWdlcyk7CisgICAgW0N1c3RvbV0gUHJv bWlzZSB1bndyYXBLZXkoS2V5Rm9ybWF0IGZvcm1hdCwgQ3J5cHRvT3BlcmF0aW9uRGF0YSB3cmFw cGVkS2V5LCBLZXkgdW53cmFwcGluZ0tleSwgQWxnb3JpdGhtSWRlbnRpZmllciB1bndyYXBBbGdv cml0aG0sIEFsZ29yaXRobUlkZW50aWZpZXI/IHVud3JhcHBlZEtleUFsZ29yaXRobSwgYm9vbGVh biBleHRyYWN0YWJsZSwgS2V5VXNhZ2VbXSBrZXlVc2FnZXMpOwogfTsK