127665 2014-01-26 17:40:04 -0800 WebKit2: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed 2014-01-27 20:12:25 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned andersca commit-queue joepeck sam oldest_to_newest 972289 0 joepeck 2014-01-26 17:40:04 -0800 Looks like this catches some legit bugs. Only a few instances. 972290 1 222294 joepeck 2014-01-26 17:44:08 -0800 Created attachment 222294 [PATCH] Proposed Fix 972296 2 222294 commit-queue 2014-01-26 18:45:13 -0800 Comment on attachment 222294 [PATCH] Proposed Fix Rejecting attachment 222294 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/DynamicLinkerEnvironmentExtractor.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/UniqueIDBDatabase.o DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.appspot.com/results/5370354696454144 972301 3 joepeck 2014-01-26 19:06:45 -0800 Looks like this needs the JSC patch to land before it can land. I will land manually tomorrow. 972467 4 222294 darin 2014-01-27 10:50:31 -0800 Comment on attachment 222294 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=222294&action=review > Source/WebKit2/Shared/UserData.cpp:157 > case API::Object::Type::Point: > static_cast<const API::Point&>(object).encode(encoder); > + break; > > case API::Object::Type::Rect: > static_cast<const API::Rect&>(object).encode(encoder); > + break; Wow, it caught a real bug! 972758 5 joepeck 2014-01-27 20:12:25 -0800 Landed <http://trac.webkit.org/changeset/162909> 222294 2014-01-26 17:44:08 -0800 2014-01-27 10:50:31 -0800 [PATCH] Proposed Fix webkit2.patch text/plain 3106 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxZmQzNGE3Li5lMWRlZGRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTQtMDEtMjYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWJLaXQyOiBFbmFibGUgLVdpbXBsaWNpdC1mYWxsdGhyb3VnaCBhbmQgYWRkIEZB TExUSFJPVUdIIGFubm90YXRpb24gd2hlcmUgbmVlZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc2NjUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9Vc2VyRGF0YS5jcHA6CisgICAgICAg IChXZWJLaXQ6OlVzZXJEYXRhOjplbmNvZGUpOgorICAgICAgICBUaGVzZSBsb29rIGxpa2UgdGhl eSBzaG91bGQgbm90IGhhdmUgZmFsbGVuIHRocm91Z2ghCisKKyAgICAgICAgKiBDb25maWd1cmF0 aW9ucy9CYXNlLnhjY29uZmlnOgorICAgICAgICAqIFNoYXJlZC9tYWMvT2JqQ09iamVjdEdyYXBo Q29kZXJzLm1tOgorICAgICAgICAoV2ViS2l0OjpJbmplY3RlZEJ1bmRsZU9iakNPYmplY3RHcmFw aEVuY29kZXJJbXBsOjplbmNvZGUpOgorCiAyMDE0LTAxLTI1ICBTYW0gV2VpbmlnICA8c2FtQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCBzdXBwb3J0IGZvciBEUkFHR0FCTEVf UkVHSU9OCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0aW9ucy9CYXNlLnhj Y29uZmlnIGIvU291cmNlL1dlYktpdDIvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwppbmRl eCBjMDQ2Mjg4Li44Y2YzZDM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0 aW9ucy9CYXNlLnhjY29uZmlnCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL0Jh c2UueGNjb25maWcKQEAgLTY4LDcgKzY4LDcgQEAgR0NDX1dBUk5fVU5VU0VEX1ZBUklBQkxFID0g WUVTOwogTElOS0VSX0RJU1BMQVlTX01BTkdMRURfTkFNRVMgPSBZRVM7CiBPVEhFUl9NSUdGTEFH UyA9IC1GJChCVUlMVF9QUk9EVUNUU19ESVIpOwogUFJFQklORElORyA9IE5POwotV0FSTklOR19D RkxBR1MgPSAtV2FsbCAtV2V4dHJhIC1XY2hhci1zdWJzY3JpcHRzIC1XZXh0cmEtdG9rZW5zIC1X Zm9ybWF0LXNlY3VyaXR5IC1XaW5pdC1zZWxmIC1XbWlzc2luZy1mb3JtYXQtYXR0cmlidXRlIC1X bWlzc2luZy1ub3JldHVybiAtV25vLXVudXNlZC1wYXJhbWV0ZXIgLVdwYWNrZWQgLVdwb2ludGVy LWFyaXRoIC1XcmVkdW5kYW50LWRlY2xzIC1XdW5kZWYgLVd3cml0ZS1zdHJpbmdzIC1XZXhpdC10 aW1lLWRlc3RydWN0b3JzIC1XZ2xvYmFsLWNvbnN0cnVjdG9ycyAtV3RhdXRvbG9naWNhbC1jb21w YXJlOworV0FSTklOR19DRkxBR1MgPSAtV2FsbCAtV2V4dHJhIC1XY2hhci1zdWJzY3JpcHRzIC1X ZXh0cmEtdG9rZW5zIC1XZm9ybWF0LXNlY3VyaXR5IC1XaW5pdC1zZWxmIC1XbWlzc2luZy1mb3Jt YXQtYXR0cmlidXRlIC1XbWlzc2luZy1ub3JldHVybiAtV25vLXVudXNlZC1wYXJhbWV0ZXIgLVdw YWNrZWQgLVdwb2ludGVyLWFyaXRoIC1XcmVkdW5kYW50LWRlY2xzIC1XdW5kZWYgLVd3cml0ZS1z dHJpbmdzIC1XZXhpdC10aW1lLWRlc3RydWN0b3JzIC1XZ2xvYmFsLWNvbnN0cnVjdG9ycyAtV3Rh dXRvbG9naWNhbC1jb21wYXJlIC1XaW1wbGljaXQtZmFsbHRocm91Z2g7CiAKIFRBUkdFVF9NQUNf T1NfWF9WRVJTSU9OX01BSk9SID0gJChNQUNfT1NfWF9WRVJTSU9OX01BSk9SKTsKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1VzZXJEYXRhLmNwcCBiL1NvdXJjZS9XZWJLaXQy L1NoYXJlZC9Vc2VyRGF0YS5jcHAKaW5kZXggMWNiMzY2Zi4uNWU3OGIwOSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvU2hhcmVkL1VzZXJEYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvVXNlckRhdGEuY3BwCkBAIC0xNTAsOSArMTUwLDExIEBAIHZvaWQgVXNlckRhdGE6OmVu Y29kZShJUEM6OkFyZ3VtZW50RW5jb2RlciYgZW5jb2RlciwgY29uc3QgQVBJOjpPYmplY3QmIG9i amVjdCkKIAogICAgIGNhc2UgQVBJOjpPYmplY3Q6OlR5cGU6OlBvaW50OgogICAgICAgICBzdGF0 aWNfY2FzdDxjb25zdCBBUEk6OlBvaW50Jj4ob2JqZWN0KS5lbmNvZGUoZW5jb2Rlcik7CisgICAg ICAgIGJyZWFrOwogCiAgICAgY2FzZSBBUEk6Ok9iamVjdDo6VHlwZTo6UmVjdDoKICAgICAgICAg c3RhdGljX2Nhc3Q8Y29uc3QgQVBJOjpSZWN0Jj4ob2JqZWN0KS5lbmNvZGUoZW5jb2Rlcik7Cisg ICAgICAgIGJyZWFrOwogCiAgICAgY2FzZSBBUEk6Ok9iamVjdDo6VHlwZTo6U2VyaWFsaXplZFNj cmlwdFZhbHVlOiB7CiAgICAgICAgIGF1dG8mIHNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSA9IHN0YXRp Y19jYXN0PGNvbnN0IFdlYlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSY+KG9iamVjdCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL09iakNPYmplY3RHcmFwaENvZGVycy5tbSBi L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvT2JqQ09iamVjdEdyYXBoQ29kZXJzLm1tCmluZGV4 IGJmNTFjMDcuLmVjMzE5YzI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFj L09iakNPYmplY3RHcmFwaENvZGVycy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFj L09iakNPYmplY3RHcmFwaENvZGVycy5tbQpAQCAtNDEwLDYgKzQxMCw3IEBAIHB1YmxpYzoKICAg ICAgICAgY2FzZSBXS1R5cGVSZWZXcmFwcGVyVHlwZTogewogICAgICAgICAgICAgV0tUeXBlUmVm V3JhcHBlciAqd3JhcHBlciA9IHN0YXRpY19jYXN0PFdLVHlwZVJlZldyYXBwZXIgKj4obV9yb290 KTsKICAgICAgICAgICAgIGVuY29kZXIgPDwgSW5qZWN0ZWRCdW5kbGVVc2VyTWVzc2FnZUVuY29k ZXIodG9JbXBsKHdyYXBwZXIub2JqZWN0KSk7CisgICAgICAgICAgICBicmVhazsKICAgICAgICAg fQogI2VuZGlmCiAgICAgICAgIGRlZmF1bHQ6Cg==