127664 2014-01-26 17:31:06 -0800 WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed 2014-01-27 20:12:05 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned andersca joepeck sam oldest_to_newest 972287 0 joepeck 2014-01-26 17:31:06 -0800 Easy! Only a few instances. 972288 1 222293 joepeck 2014-01-26 17:32:23 -0800 Created attachment 222293 [PATCH] Proposed Fix 972465 2 222293 darin 2014-01-27 10:49:43 -0800 Comment on attachment 222293 [PATCH] Proposed Fix r=me assuming you deal with the JSObject.h problem that the Mac EWS bot is complaining about 972472 3 joepeck 2014-01-27 10:58:05 -0800 (In reply to comment #2) > (From update of attachment 222293 [details]) > r=me assuming you deal with the JSObject.h problem that the Mac EWS bot is complaining about That was a addressed in the JSC patch that hasn't landed yet. 972757 4 joepeck 2014-01-27 20:11:53 -0800 Landed <http://trac.webkit.org/changeset/162908> 222293 2014-01-26 17:32:23 -0800 2014-01-27 20:12:05 -0800 [PATCH] Proposed Fix webkit.patch text/plain 5091 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCA3NDY0OThiLi4wMGY3ZjJlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTQtMDEtMjYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KKworICAgICAgICBXZWJLaXQxOiBFbmFibGUgLVdpbXBsaWNpdC1mYWxsdGhyb3Vn aCBhbmQgYWRkIEZBTExUSFJPVUdIIGFubm90YXRpb24gd2hlcmUgbmVlZGVkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc2NjQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL0Jh c2UueGNjb25maWc6CisgICAgICAgICogSGlzdG9yeS9CaW5hcnlQcm9wZXJ0eUxpc3QuY3BwOgor ICAgICAgICAoQmluYXJ5UHJvcGVydHlMaXN0U2VyaWFsaXplcjo6YXBwZW5kT2JqZWN0UmVmZXJl bmNlKToKKyAgICAgICAgKEJpbmFyeVByb3BlcnR5TGlzdFNlcmlhbGl6ZXI6OnN0YXJ0T2JqZWN0 KToKKyAgICAgICAgKEJpbmFyeVByb3BlcnR5TGlzdFNlcmlhbGl6ZXI6OmFkZEFnZ3JlZ2F0ZU9i amVjdFJlZmVyZW5jZSk6CisgICAgICAgICogV2ViVmlldy9XZWJQREZWaWV3Lm1tOgorICAgICAg ICAoLVtXZWJQREZWaWV3IFBERlZpZXdXaWxsQ2xpY2tPbkxpbms6d2l0aFVSTDpdKToKKwogMjAx NC0wMS0yNSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSB1 bnVzZWQgc3VwcG9ydCBmb3IgRFJBR0dBQkxFX1JFR0lPTgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9tYWMvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZyBiL1NvdXJjZS9XZWJLaXQvbWFj L0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKaW5kZXggOTllYmE4My4uMmM2MmE0NyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwor KysgYi9Tb3VyY2UvV2ViS2l0L21hYy9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnCkBAIC02 OCw3ICs2OCw3IEBAIEdDQ19XQVJOX1VOVVNFRF9WQVJJQUJMRSA9IFlFUzsKIExJTktFUl9ESVNQ TEFZU19NQU5HTEVEX05BTUVTID0gWUVTOwogT1RIRVJfTUlHRkxBR1MgPSAtRiQoQlVJTFRfUFJP RFVDVFNfRElSKTsKIFBSRUJJTkRJTkcgPSBOTzsKLVdBUk5JTkdfQ0ZMQUdTID0gLVdhbGwgLVdl eHRyYSAtV2NoYXItc3Vic2NyaXB0cyAtV2V4dHJhLXRva2VucyAtV2Zvcm1hdC1zZWN1cml0eSAt V2luaXQtc2VsZiAtV21pc3NpbmctZm9ybWF0LWF0dHJpYnV0ZSAtV21pc3Npbmctbm9yZXR1cm4g LVduby11bnVzZWQtcGFyYW1ldGVyIC1XcGFja2VkIC1XcG9pbnRlci1hcml0aCAtV3JlZHVuZGFu dC1kZWNscyAtV3VuZGVmIC1Xd3JpdGUtc3RyaW5ncyAtV2V4aXQtdGltZS1kZXN0cnVjdG9ycyAt V2dsb2JhbC1jb25zdHJ1Y3RvcnMgLVd0YXV0b2xvZ2ljYWwtY29tcGFyZTsKK1dBUk5JTkdfQ0ZM QUdTID0gLVdhbGwgLVdleHRyYSAtV2NoYXItc3Vic2NyaXB0cyAtV2V4dHJhLXRva2VucyAtV2Zv cm1hdC1zZWN1cml0eSAtV2luaXQtc2VsZiAtV21pc3NpbmctZm9ybWF0LWF0dHJpYnV0ZSAtV21p c3Npbmctbm9yZXR1cm4gLVduby11bnVzZWQtcGFyYW1ldGVyIC1XcGFja2VkIC1XcG9pbnRlci1h cml0aCAtV3JlZHVuZGFudC1kZWNscyAtV3VuZGVmIC1Xd3JpdGUtc3RyaW5ncyAtV2V4aXQtdGlt ZS1kZXN0cnVjdG9ycyAtV2dsb2JhbC1jb25zdHJ1Y3RvcnMgLVd0YXV0b2xvZ2ljYWwtY29tcGFy ZSAtV2ltcGxpY2l0LWZhbGx0aHJvdWdoOwogCiBUQVJHRVRfTUFDX09TX1hfVkVSU0lPTl9NQUpP UiA9ICQoTUFDX09TX1hfVkVSU0lPTl9NQUpPUik7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvbWFjL0hpc3RvcnkvQmluYXJ5UHJvcGVydHlMaXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvbWFj L0hpc3RvcnkvQmluYXJ5UHJvcGVydHlMaXN0LmNwcAppbmRleCBmODQ2MjJhLi45MzA5ODI1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9IaXN0b3J5L0JpbmFyeVByb3BlcnR5TGlzdC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9tYWMvSGlzdG9yeS9CaW5hcnlQcm9wZXJ0eUxpc3QuY3Bw CkBAIC03NDksMTkgKzc0OSwyNiBAQCB2b2lkIEJpbmFyeVByb3BlcnR5TGlzdFNlcmlhbGl6ZXI6 OmFwcGVuZE9iamVjdFJlZmVyZW5jZShPYmplY3RSZWZlcmVuY2UgcmVmZXJlbgogI2lmZGVmIF9f TFA2NF9fCiAgICAgY2FzZSA4OgogICAgICAgICBhcHBlbmRCeXRlKHJlZmVyZW5jZSA+PiA1Nik7 CisgICAgICAgIEZBTExUSFJPVUdIOwogICAgIGNhc2UgNzoKICAgICAgICAgYXBwZW5kQnl0ZShy ZWZlcmVuY2UgPj4gNDgpOworICAgICAgICBGQUxMVEhST1VHSDsKICAgICBjYXNlIDY6CiAgICAg ICAgIGFwcGVuZEJ5dGUocmVmZXJlbmNlID4+IDQwKTsKKyAgICAgICAgRkFMTFRIUk9VR0g7CiAg ICAgY2FzZSA1OgogICAgICAgICBhcHBlbmRCeXRlKHJlZmVyZW5jZSA+PiAzMik7CisgICAgICAg IEZBTExUSFJPVUdIOwogI2VuZGlmCiAgICAgY2FzZSA0OgogICAgICAgICBhcHBlbmRCeXRlKHJl ZmVyZW5jZSA+PiAyNCk7CisgICAgICAgIEZBTExUSFJPVUdIOwogICAgIGNhc2UgMzoKICAgICAg ICAgYXBwZW5kQnl0ZShyZWZlcmVuY2UgPj4gMTYpOworICAgICAgICBGQUxMVEhST1VHSDsKICAg ICBjYXNlIDI6CiAgICAgICAgIGFwcGVuZEJ5dGUocmVmZXJlbmNlID4+IDgpOworICAgICAgICBG QUxMVEhST1VHSDsKICAgICBjYXNlIDE6CiAgICAgICAgIGFwcGVuZEJ5dGUocmVmZXJlbmNlKTsK ICAgICB9CkBAIC03NzgsMTkgKzc4NSwyNiBAQCB2b2lkIEJpbmFyeVByb3BlcnR5TGlzdFNlcmlh bGl6ZXI6OnN0YXJ0T2JqZWN0KCkKICNpZmRlZiBfX0xQNjRfXwogICAgIGNhc2UgODoKICAgICAg ICAgb2Zmc2V0VGFibGVFbnRyeVstOF0gPSBvZmZzZXQgPj4gNTY7CisgICAgICAgIEZBTExUSFJP VUdIOwogICAgIGNhc2UgNzoKICAgICAgICAgb2Zmc2V0VGFibGVFbnRyeVstN10gPSBvZmZzZXQg Pj4gNDg7CisgICAgICAgIEZBTExUSFJPVUdIOwogICAgIGNhc2UgNjoKICAgICAgICAgb2Zmc2V0 VGFibGVFbnRyeVstNl0gPSBvZmZzZXQgPj4gNDA7CisgICAgICAgIEZBTExUSFJPVUdIOwogICAg IGNhc2UgNToKICAgICAgICAgb2Zmc2V0VGFibGVFbnRyeVstNV0gPSBvZmZzZXQgPj4gMzI7Cisg ICAgICAgIEZBTExUSFJPVUdIOwogI2VuZGlmCiAgICAgY2FzZSA0OgogICAgICAgICBvZmZzZXRU YWJsZUVudHJ5Wy00XSA9IG9mZnNldCA+PiAyNDsKKyAgICAgICAgRkFMTFRIUk9VR0g7CiAgICAg Y2FzZSAzOgogICAgICAgICBvZmZzZXRUYWJsZUVudHJ5Wy0zXSA9IG9mZnNldCA+PiAxNjsKKyAg ICAgICAgRkFMTFRIUk9VR0g7CiAgICAgY2FzZSAyOgogICAgICAgICBvZmZzZXRUYWJsZUVudHJ5 Wy0yXSA9IG9mZnNldCA+PiA4OworICAgICAgICBGQUxMVEhST1VHSDsKICAgICBjYXNlIDE6CiAg ICAgICAgIG9mZnNldFRhYmxlRW50cnlbLTFdID0gb2Zmc2V0OwogICAgIH0KQEAgLTgwMiwxOSAr ODE2LDI2IEBAIHZvaWQgQmluYXJ5UHJvcGVydHlMaXN0U2VyaWFsaXplcjo6YWRkQWdncmVnYXRl T2JqZWN0UmVmZXJlbmNlKE9iamVjdFJlZmVyZW5jZSByCiAjaWZkZWYgX19MUDY0X18KICAgICBj YXNlIDg6CiAgICAgICAgICotLW1fY3VycmVudEFnZ3JlZ2F0ZUJ1ZmZlckJ5dGUgPSByZWZlcmVu Y2UgPj4gNTY7CisgICAgICAgIEZBTExUSFJPVUdIOwogICAgIGNhc2UgNzoKICAgICAgICAgKi0t bV9jdXJyZW50QWdncmVnYXRlQnVmZmVyQnl0ZSA9IHJlZmVyZW5jZSA+PiA0ODsKKyAgICAgICAg RkFMTFRIUk9VR0g7CiAgICAgY2FzZSA2OgogICAgICAgICAqLS1tX2N1cnJlbnRBZ2dyZWdhdGVC dWZmZXJCeXRlID0gcmVmZXJlbmNlID4+IDQwOworICAgICAgICBGQUxMVEhST1VHSDsKICAgICBj YXNlIDU6CiAgICAgICAgICotLW1fY3VycmVudEFnZ3JlZ2F0ZUJ1ZmZlckJ5dGUgPSByZWZlcmVu Y2UgPj4gMzI7CisgICAgICAgIEZBTExUSFJPVUdIOwogI2VuZGlmCiAgICAgY2FzZSA0OgogICAg ICAgICAqLS1tX2N1cnJlbnRBZ2dyZWdhdGVCdWZmZXJCeXRlID0gcmVmZXJlbmNlID4+IDI0Owor ICAgICAgICBGQUxMVEhST1VHSDsKICAgICBjYXNlIDM6CiAgICAgICAgICotLW1fY3VycmVudEFn Z3JlZ2F0ZUJ1ZmZlckJ5dGUgPSByZWZlcmVuY2UgPj4gMTY7CisgICAgICAgIEZBTExUSFJPVUdI OwogICAgIGNhc2UgMjoKICAgICAgICAgKi0tbV9jdXJyZW50QWdncmVnYXRlQnVmZmVyQnl0ZSA9 IHJlZmVyZW5jZSA+PiA4OworICAgICAgICBGQUxMVEhST1VHSDsKICAgICBjYXNlIDE6CiAgICAg ICAgICotLW1fY3VycmVudEFnZ3JlZ2F0ZUJ1ZmZlckJ5dGUgPSByZWZlcmVuY2U7CiAgICAgfQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJQREZWaWV3Lm1tIGIvU291 cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJQREZWaWV3Lm1tCmluZGV4IDg5MzUwYzUuLjhkYjQz MTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViUERGVmlldy5tbQor KysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlBERlZpZXcubW0KQEAgLTEwMzcsNiAr MTAzNyw3IEBAIHN0YXRpYyBCT09MIGlzRnJhbWVJblJhbmdlKFdlYkZyYW1lICpmcmFtZSwgRE9N UmFuZ2UgKnJhbmdlKQogICAgICAgICAgICAgUGxhdGZvcm1LZXlib2FyZEV2ZW50IHBlID0gUGxh dGZvcm1FdmVudEZhY3Rvcnk6OmNyZWF0ZVBsYXRmb3JtS2V5Ym9hcmRFdmVudChuc0V2ZW50KTsK ICAgICAgICAgICAgIHBlLmRpc2FtYmlndWF0ZUtleURvd25FdmVudChQbGF0Zm9ybUV2ZW50OjpS YXdLZXlEb3duKTsKICAgICAgICAgICAgIGV2ZW50ID0gS2V5Ym9hcmRFdmVudDo6Y3JlYXRlKHBl LCAwKTsKKyAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgIGRlZmF1bHQ6CiAg ICAgICAgICAgICBicmVhazsK