127653 2014-01-26 10:18:17 -0800 Turn WebHistoryItemPrivate back into a real Objective-C class 2014-01-26 10:49:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 972208 0 andersca 2014-01-26 10:18:17 -0800 Turn WebHistoryItemPrivate back into a real Objective-C class 972210 1 222277 andersca 2014-01-26 10:20:30 -0800 Created attachment 222277 Patch 972221 2 andersca 2014-01-26 10:49:42 -0800 Committed r162804: <http://trac.webkit.org/changeset/162804> 222277 2014-01-26 10:20:30 -0800 2014-01-26 10:43:32 -0800 Patch bug-127653-20140126102031.patch text/plain 3515 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyODAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggNzQ2NDk4Yjg5 YmExYTRiNWU2YTQ0MWMwYzA1NDk5YTg5NGU1NjcxZS4uYjViMDc1MTFiMDhlYzU5OWE3MjkzODM3 MGM1MThjMTY2Y2UwMzE4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0 LTAxLTI2ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAg VHVybiBXZWJIaXN0b3J5SXRlbVByaXZhdGUgYmFjayBpbnRvIGEgcmVhbCBPYmplY3RpdmUtQyBj bGFzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3 NjUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBpcyBhIGZpcnN0IHN0ZXAgdG93YXJkcyBtb3Zpbmcgc29tZSBoaXN0b3J5IHNwZWNpZmljIGNv ZGUgZnJvbSBXZWJDb3JlOjpIaXN0b3J5SXRlbSBiYWNrIGludG8gV2ViS2l0LgorCisgICAgICAg ICogSGlzdG9yeS9XZWJIaXN0b3J5SXRlbS5tbToKKyAgICAgICAgKC1bV2ViSGlzdG9yeUl0ZW0g ZGVhbGxvY10pOgorICAgICAgICAoLVtXZWJIaXN0b3J5SXRlbSBmaW5hbGl6ZV0pOgorICAgICAg ICAoLVtXZWJIaXN0b3J5SXRlbSBpbml0V2l0aFdlYkNvcmVIaXN0b3J5SXRlbTpdKToKKwogMjAx NC0wMS0yNSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSB1 bnVzZWQgc3VwcG9ydCBmb3IgRFJBR0dBQkxFX1JFR0lPTgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9tYWMvSGlzdG9yeS9XZWJIaXN0b3J5SXRlbS5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL0hp c3RvcnkvV2ViSGlzdG9yeUl0ZW0ubW0KaW5kZXggNjEyMDAzZjFjZDBkNDg1MGIzNTQzMDhiY2Rh ZmY4ZWVkMDJkMTIyOS4uMDc0ZTg4ZGZkMzgwOTNiZGZhYjU1OTUwMzNiYTBhOWQyM2NkMjlmNCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvSGlzdG9yeS9XZWJIaXN0b3J5SXRlbS5tbQor KysgYi9Tb3VyY2UvV2ViS2l0L21hYy9IaXN0b3J5L1dlYkhpc3RvcnlJdGVtLm1tCkBAIC05NCwx MCArOTQsMjIgQEAgTlNTdHJpbmcgKldlYkhpc3RvcnlJdGVtQ2hhbmdlZE5vdGlmaWNhdGlvbiA9 IEAiV2ViSGlzdG9yeUl0ZW1DaGFuZ2VkTm90aWZpY2F0aW8KIAogdXNpbmcgbmFtZXNwYWNlIFdl YkNvcmU7CiAKK0BpbnRlcmZhY2UgV2ViSGlzdG9yeUl0ZW1Qcml2YXRlIDogTlNPYmplY3Qgewor QHBhY2thZ2UKKyAgICBSZWZQdHI8SGlzdG9yeUl0ZW0+IF9oaXN0b3J5SXRlbTsKK30KK0BlbmQK KworQGltcGxlbWVudGF0aW9uIFdlYkhpc3RvcnlJdGVtUHJpdmF0ZQorCitAZW5kCisKIHR5cGVk ZWYgSGFzaE1hcDxIaXN0b3J5SXRlbSosIFdlYkhpc3RvcnlJdGVtKj4gSGlzdG9yeUl0ZW1NYXA7 CiAKLXN0YXRpYyBpbmxpbmUgV2ViSGlzdG9yeUl0ZW1Qcml2YXRlKiBraXRQcml2YXRlKFdlYkNv cmVIaXN0b3J5SXRlbSogbGlzdCkgeyByZXR1cm4gKFdlYkhpc3RvcnlJdGVtUHJpdmF0ZSopbGlz dDsgfQotc3RhdGljIGlubGluZSBXZWJDb3JlSGlzdG9yeUl0ZW0qIGNvcmUoV2ViSGlzdG9yeUl0 ZW1Qcml2YXRlKiBsaXN0KSB7IHJldHVybiAoV2ViQ29yZUhpc3RvcnlJdGVtKilsaXN0OyB9Citz dGF0aWMgaW5saW5lIFdlYkNvcmVIaXN0b3J5SXRlbSogY29yZShXZWJIaXN0b3J5SXRlbVByaXZh dGUqIGl0ZW1Qcml2YXRlKQoreworICAgIHJldHVybiBpdGVtUHJpdmF0ZS0+X2hpc3RvcnlJdGVt LmdldCgpOworfQogCiBzdGF0aWMgSGlzdG9yeUl0ZW1NYXAmIGhpc3RvcnlJdGVtV3JhcHBlcnMo KQogewpAQCAtMTQzLDI1ICsxNTUsMjEgQEAgdm9pZCBXS05vdGlmeUhpc3RvcnlJdGVtQ2hhbmdl ZChIaXN0b3J5SXRlbSopCiAgICAgaWYgKFdlYkNvcmVPYmpDU2NoZWR1bGVEZWFsbG9jYXRlT25N YWluVGhyZWFkKFtXZWJIaXN0b3J5SXRlbSBjbGFzc10sIHNlbGYpKQogICAgICAgICByZXR1cm47 CiAKLSAgICBpZiAoX3ByaXZhdGUpIHsKLSAgICAgICAgSGlzdG9yeUl0ZW0qIGNvcmVJdGVtID0g Y29yZShfcHJpdmF0ZSk7Ci0gICAgICAgIGNvcmVJdGVtLT5kZXJlZigpOwotICAgICAgICBoaXN0 b3J5SXRlbVdyYXBwZXJzKCkucmVtb3ZlKGNvcmVJdGVtKTsKLSAgICB9CisgICAgaGlzdG9yeUl0 ZW1XcmFwcGVycygpLnJlbW92ZShfcHJpdmF0ZS0+X2hpc3RvcnlJdGVtLmdldCgpKTsKKyAgICBb X3ByaXZhdGUgcmVsZWFzZV07CisKICAgICBbc3VwZXIgZGVhbGxvY107CiB9CiAKIC0gKHZvaWQp ZmluYWxpemUKIHsKICAgICBXZWJDb3JlVGhyZWFkVmlvbGF0aW9uQ2hlY2tSb3VuZE9uZSgpOwor CiAgICAgLy8gRklYTUU6IH5IaXN0b3J5SXRlbSBpcyB3aGF0IHJlbGVhc2VzIHRoZSBoaXN0b3J5 IGl0ZW0ncyBpY29uIGZyb20gdGhlIGljb24gZGF0YWJhc2UKICAgICAvLyBJdCdzIHByb2JhYmx5 IG5vdCBnb29kIHRvIHJlbGVhc2UgaWNvbnMgZnJvbSB0aGUgZGF0YWJhc2Ugb25seSB3aGVuIHRo ZSBvYmplY3QgaXMgZ2FyYmFnZS1jb2xsZWN0ZWQuIAogICAgIC8vIE5lZWQgdG8gY2hhbmdlIGRl c2lnbiBzbyB0aGlzIGhhcHBlbnMgYXQgYSBwcmVkaWN0YWJsZSB0aW1lLgotICAgIGlmIChfcHJp dmF0ZSkgewotICAgICAgICBIaXN0b3J5SXRlbSogY29yZUl0ZW0gPSBjb3JlKF9wcml2YXRlKTsK LSAgICAgICAgY29yZUl0ZW0tPmRlcmVmKCk7Ci0gICAgICAgIGhpc3RvcnlJdGVtV3JhcHBlcnMo KS5yZW1vdmUoY29yZUl0ZW0pOwotICAgIH0KKyAgICBoaXN0b3J5SXRlbVdyYXBwZXJzKCkucmVt b3ZlKF9wcml2YXRlLT5faGlzdG9yeUl0ZW0uZ2V0KCkpOworCiAgICAgW3N1cGVyIGZpbmFsaXpl XTsKIH0KIApAQCAtMzE3LDkgKzMyNSwxMiBAQCBXZWJIaXN0b3J5SXRlbSAqa2l0KEhpc3RvcnlJ dGVtKiBpdGVtKQogICAgIC8vIG90aGVyICJpbml0IGJlZm9yZSBXZWJLaXQgaXMgdXNlZCIgdHlw ZSB0aGluZ3MKICAgICBXZWJDb3JlOjpub3RpZnlIaXN0b3J5SXRlbUNoYW5nZWQgPSBXS05vdGlm eUhpc3RvcnlJdGVtQ2hhbmdlZDsKICAgICAKLSAgICBzZWxmID0gW3N1cGVyIGluaXRdOwotICAg IAotICAgIF9wcml2YXRlID0ga2l0UHJpdmF0ZShpdGVtLmxlYWtSZWYoKSk7CisgICAgaWYgKCEo c2VsZiA9IFtzdXBlciBpbml0XSkpCisgICAgICAgIHJldHVybiBuaWw7CisKKyAgICBfcHJpdmF0 ZSA9IFtbV2ViSGlzdG9yeUl0ZW1Qcml2YXRlIGFsbG9jXSBpbml0XTsKKyAgICBfcHJpdmF0ZS0+ X2hpc3RvcnlJdGVtID0gaXRlbTsKKwogICAgIEFTU0VSVCghaGlzdG9yeUl0ZW1XcmFwcGVycygp LmdldChjb3JlKF9wcml2YXRlKSkpOwogICAgIGhpc3RvcnlJdGVtV3JhcHBlcnMoKS5zZXQoY29y ZShfcHJpdmF0ZSksIHNlbGYpOwogICAgIHJldHVybiBzZWxmOwo=