127638 2014-01-25 19:22:35 -0800 Remove FIXME in CSSKeywordCompletions.js about "inherit" keyword 2014-01-25 20:10:57 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue dpino joepeck timothy oldest_to_newest 972106 0 joepeck 2014-01-25 19:22:35 -0800 Replace the confused FIXME comment with an answer about why "inherit" is only added some of the time despite it always being valid. 972107 1 222246 joepeck 2014-01-25 19:24:13 -0800 Created attachment 222246 [PATCH] Proposed Fix 972108 2 222246 timothy 2014-01-25 19:25:13 -0800 Comment on attachment 222246 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=222246&action=review > Source/WebInspectorUI/ChangeLog:1 > +2014-01-25 Joseph Pecoraro <joepeck02@gmail.com> Right email address? 972110 3 joepeck 2014-01-25 19:33:33 -0800 Bah good catch. The whole reason I put this up on a bug was cause I'm writing on a machine without a checkout that can commit. I'll update that! Thanks 972111 4 222247 joepeck 2014-01-25 19:35:05 -0800 Created attachment 222247 [PATCH] For Landing 972121 5 222247 commit-queue 2014-01-25 20:10:50 -0800 Comment on attachment 222247 [PATCH] For Landing Clearing flags on attachment: 222247 Committed r162794: <http://trac.webkit.org/changeset/162794> 972122 6 commit-queue 2014-01-25 20:10:57 -0800 All reviewed patches have been landed. Closing bug. 222246 2014-01-25 19:24:13 -0800 2014-01-25 19:35:05 -0800 [PATCH] Proposed Fix inherit.patch text/plain 1804 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDAyMGZhYmEuLjY4NGZiYTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAxLTI1ICBKb3NlcGggUGVjb3Jh cm8gIDxqb2VwZWNrMDJAZ21haWwuY29tPgorCisgICAgICAgIFJlbW92ZSBGSVhNRSBpbiBDU1NL ZXl3b3JkQ29tcGxldGlvbnMuanMgYWJvdXQgImluaGVyaXQiIGtleXdvcmQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzYzOAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9DU1NL ZXl3b3JkQ29tcGxldGlvbnMuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ1NTS2V5d29yZENv bXBsZXRpb25zLmZvclByb3BlcnR5KToKKyAgICAgICAgUmVwbGFjZSBGSVhNRSB3aXRoIGEgZGVz Y3JpcHRpdmUgY29tbWVudCBhYm91dCB3aHkgdGhlIGNvZGUgaXMgd2hhdCBpdCBpcy4KKwogMjAx NC0wMS0yMyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAg UmVmYWN0b3IgVGltZWxpbmVSZWNvcmRCYXIgY29tYmluaW5nIGxvZ2ljIGludG8gYSBoZWxwZXIg ZnVuY3Rpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9DU1NLZXl3b3JkQ29tcGxldGlvbnMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9DU1NLZXl3b3JkQ29tcGxldGlvbnMuanMKaW5kZXggNmRlNjQ4ZC4uMThkMGI0OSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ1NTS2V5d29y ZENvbXBsZXRpb25zLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0NTU0tleXdvcmRDb21wbGV0aW9ucy5qcwpAQCAtNDYsNyArNDYsNyBAQCBXZWJJbnNwZWN0b3Iu Q1NTS2V5d29yZENvbXBsZXRpb25zLmZvclByb3BlcnR5ID0gZnVuY3Rpb24ocHJvcGVydHlOYW1l KQogICAgIGVsc2UgaWYgKGlzTm90UHJlZml4ZWQgJiYgKCItd2Via2l0LSIgKyBwcm9wZXJ0eU5h bWUpIGluIFdlYkluc3BlY3Rvci5DU1NLZXl3b3JkQ29tcGxldGlvbnMuX2NvbG9yQXdhcmVQcm9w ZXJ0aWVzKQogICAgICAgICBhY2NlcHRlZEtleXdvcmRzID0gYWNjZXB0ZWRLZXl3b3Jkcy5jb25j YXQoV2ViSW5zcGVjdG9yLkNTU0tleXdvcmRDb21wbGV0aW9ucy5fY29sb3JzKTsKIAotICAgIC8v IEZJWE1FOiBUaGlzIGRvZXNuJ3QgbmVjZXNzYXJpbHkgbWFrZSBzZW5zZS4gU29tZSBub24taW5o ZXJpdGFibGUgcHJvcGVydGllcyBhbGxvdyAiaW5oZXJpdCIuCisgICAgLy8gT25seSBzdWdnZXN0 ICJpbmhlcml0IiBvbiBpbmhlcml0YWJsZSBwcm9wZXJ0aWVzIGV2ZW4gdGhvdWdoIGl0IGlzIHZh bGlkIG9uIGFsbCBwcm9wZXJ0aWVzLgogICAgIGlmIChwcm9wZXJ0eU5hbWUgaW4gV2ViSW5zcGVj dG9yLkNTU0tleXdvcmRDb21wbGV0aW9ucy5Jbmhlcml0ZWRQcm9wZXJ0aWVzKQogICAgICAgICBh Y2NlcHRlZEtleXdvcmRzLnB1c2goImluaGVyaXQiKTsKICAgICBlbHNlIGlmIChpc05vdFByZWZp eGVkICYmICgiLXdlYmtpdC0iICsgcHJvcGVydHlOYW1lKSBpbiBXZWJJbnNwZWN0b3IuQ1NTS2V5 d29yZENvbXBsZXRpb25zLkluaGVyaXRlZFByb3BlcnRpZXMpCg== 222247 2014-01-25 19:35:05 -0800 2014-01-25 20:10:48 -0800 [PATCH] For Landing fixme.patch text/plain 1987 joepeck Y29tbWl0IDUyNWJlZDUyMzdkNmYwZjc1MWYyMjYyY2MyNWRjMzU5OTM2YzE0ZjcKQXV0aG9yOiBK b3NlcGggUGVjb3Jhcm8gPGpvZXBlY2swMkBnbWFpbC5jb20+CkRhdGU6ICAgU2F0IEphbiAyNSAx OToyNjo0NiAyMDE0IC0wODAwCgogICAgUFJPR1JFU1M6IEZJWE1FIGluIENTU0tleXdvcmRDb21w bGV0aW9ucy5qcwoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDAyMGZhYmEuLjVkOTFhNDMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAxLTI1ICBK b3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIEZJ WE1FIGluIENTU0tleXdvcmRDb21wbGV0aW9ucy5qcyBhYm91dCAiaW5oZXJpdCIga2V5d29yZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3NjM4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9DU1NLZXl3b3JkQ29tcGxldGlvbnMuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu Q1NTS2V5d29yZENvbXBsZXRpb25zLmZvclByb3BlcnR5KToKKyAgICAgICAgUmVwbGFjZSBGSVhN RSB3aXRoIGEgZGVzY3JpcHRpdmUgY29tbWVudCBhYm91dCB3aHkgdGhlIGNvZGUgaXMgd2hhdCBp dCBpcy4KKwogMjAxNC0wMS0yMyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+ CiAKICAgICAgICAgUmVmYWN0b3IgVGltZWxpbmVSZWNvcmRCYXIgY29tYmluaW5nIGxvZ2ljIGlu dG8gYSBoZWxwZXIgZnVuY3Rpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9DU1NLZXl3b3JkQ29tcGxldGlvbnMuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9DU1NLZXl3b3JkQ29tcGxldGlvbnMuanMKaW5kZXggNmRlNjQ4 ZC4uMThkMGI0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qcwpAQCAtNDYsNyArNDYsNyBAQCBX ZWJJbnNwZWN0b3IuQ1NTS2V5d29yZENvbXBsZXRpb25zLmZvclByb3BlcnR5ID0gZnVuY3Rpb24o cHJvcGVydHlOYW1lKQogICAgIGVsc2UgaWYgKGlzTm90UHJlZml4ZWQgJiYgKCItd2Via2l0LSIg KyBwcm9wZXJ0eU5hbWUpIGluIFdlYkluc3BlY3Rvci5DU1NLZXl3b3JkQ29tcGxldGlvbnMuX2Nv bG9yQXdhcmVQcm9wZXJ0aWVzKQogICAgICAgICBhY2NlcHRlZEtleXdvcmRzID0gYWNjZXB0ZWRL ZXl3b3Jkcy5jb25jYXQoV2ViSW5zcGVjdG9yLkNTU0tleXdvcmRDb21wbGV0aW9ucy5fY29sb3Jz KTsKIAotICAgIC8vIEZJWE1FOiBUaGlzIGRvZXNuJ3QgbmVjZXNzYXJpbHkgbWFrZSBzZW5zZS4g U29tZSBub24taW5oZXJpdGFibGUgcHJvcGVydGllcyBhbGxvdyAiaW5oZXJpdCIuCisgICAgLy8g T25seSBzdWdnZXN0ICJpbmhlcml0IiBvbiBpbmhlcml0YWJsZSBwcm9wZXJ0aWVzIGV2ZW4gdGhv dWdoIGl0IGlzIHZhbGlkIG9uIGFsbCBwcm9wZXJ0aWVzLgogICAgIGlmIChwcm9wZXJ0eU5hbWUg aW4gV2ViSW5zcGVjdG9yLkNTU0tleXdvcmRDb21wbGV0aW9ucy5Jbmhlcml0ZWRQcm9wZXJ0aWVz KQogICAgICAgICBhY2NlcHRlZEtleXdvcmRzLnB1c2goImluaGVyaXQiKTsKICAgICBlbHNlIGlm IChpc05vdFByZWZpeGVkICYmICgiLXdlYmtpdC0iICsgcHJvcGVydHlOYW1lKSBpbiBXZWJJbnNw ZWN0b3IuQ1NTS2V5d29yZENvbXBsZXRpb25zLkluaGVyaXRlZFByb3BlcnRpZXMpCg==