127615 2014-01-25 01:26:08 -0800 Web Inspector: Position the completion suggestions popup below if there is room 2014-01-25 17:03:54 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Enhancement --- 1 dpino webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 971921 0 dpino 2014-01-25 01:26:08 -0800 When filling the value of a CSS property, a completion list with suggestions pops up. Currently the popup is positioned above the edited CSS property is there is more room than below. A FIXME recommends to always position the popup below if there is room enough. 971922 1 webkit-bug-importer 2014-01-25 01:26:18 -0800 <rdar://problem/15908842> 971925 2 222199 dpino 2014-01-25 01:30:43 -0800 Created attachment 222199 Patch 971965 3 222199 joepeck 2014-01-25 09:35:06 -0800 Comment on attachment 222199 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222199&action=review Nice! r=me with some style nits. > Source/WebInspectorUI/ChangeLog:6 > + Web Inspector: Position the completion suggestions popup below if > + there is room enough. > + > + https://bugs.webkit.org/show_bug.cgi?id=127615 Style: `./Tools/Scripts/prepare-ChangeLog -b 127615` would not wrap the title line and would put the bugzilla bug on the next line without an empty line between. > Source/WebInspectorUI/UserInterface/CompletionSuggestionsView.js:153 > + // Position the suggestions below the anchor. If there is no room, position the suggestions above Style: Comments in WebKit are full sentences. This second sentence should end in a period. 972053 4 222237 dpino 2014-01-25 14:49:08 -0800 Created attachment 222237 Patch 972081 5 222237 joepeck 2014-01-25 16:35:23 -0800 Comment on attachment 222237 Patch r=me 972090 6 222237 commit-queue 2014-01-25 17:03:51 -0800 Comment on attachment 222237 Patch Clearing flags on attachment: 222237 Committed r162790: <http://trac.webkit.org/changeset/162790> 972091 7 commit-queue 2014-01-25 17:03:54 -0800 All reviewed patches have been landed. Closing bug. 222199 2014-01-25 01:30:43 -0800 2014-01-25 14:48:55 -0800 Patch bug-127615-20140125103041.patch text/plain 1978 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyNjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw MjBmYWJhYzgxNjdlOTk4Mzk3NDhlNDJlZTI5Njk4MGFhN2IwOGY1Li4wMTgyNmY1OWNiNmYxMzQw ODI1NDVmMzk1ZmEwNzUyYjYyYWMwOWI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNC0wMS0yNSAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFBvc2l0aW9uIHRoZSBjb21wbGV0aW9uIHN1 Z2dlc3Rpb25zIHBvcHVwIGJlbG93IGlmCisgICAgICAgIHRoZXJlIGlzIHJvb20gZW5vdWdoLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc2MTUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvQ29tcGxldGlvblN1Z2dlc3Rpb25zVmlldy5qczoKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5Db21wbGV0aW9uU3VnZ2VzdGlvbnNWaWV3LnByb3RvdHlwZS5zaG93KToKKwogMjAxNC0w MS0yMyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVm YWN0b3IgVGltZWxpbmVSZWNvcmRCYXIgY29tYmluaW5nIGxvZ2ljIGludG8gYSBoZWxwZXIgZnVu Y3Rpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9D b21wbGV0aW9uU3VnZ2VzdGlvbnNWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvQ29tcGxldGlvblN1Z2dlc3Rpb25zVmlldy5qcwppbmRleCBhMDkwNDFjZTY2Mjg3 NzlkODBjYjJmNTZiMDQyMTg2ZGRjOGNhNmFhLi5iZWZhZDgxM2U5MDk4NTMwNWJkZDJiYzRiZjIy MTgzOTUxZTgyN2YzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Db21wbGV0aW9uU3VnZ2VzdGlvbnNWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0NvbXBsZXRpb25TdWdnZXN0aW9uc1ZpZXcuanMKQEAgLTE1MCwx MCArMTUwLDkgQEAgV2ViSW5zcGVjdG9yLkNvbXBsZXRpb25TdWdnZXN0aW9uc1ZpZXcucHJvdG90 eXBlID0gewogICAgICAgICB2YXIgbWF4aW11bUhlaWdodCA9IE1hdGgubWluKGFic29sdXRlTWF4 aW11bUhlaWdodCwgTWF0aC5tYXgodW5kZXJIZWlnaHQsIGFib3ZlSGVpZ2h0KSAtIG1hcmdpbik7 CiAgICAgICAgIHZhciBoZWlnaHQgPSBNYXRoLm1pbihjb250YWluZXJIZWlnaHQsIG1heGltdW1I ZWlnaHQpOwogCi0gICAgICAgIC8vIFBvc2l0aW9uIHRoZSBzdWdlc3N0aW9ucyBhYm92ZSB0aGUg YW5jaG9yIGlmIHRoZXJlIGlzIG1vcmUgcm9vbS4KLSAgICAgICAgLy8gRklYTUU6IFRoaXMgc2hv dWxkIGFsd2F5cyBwcmVmZXIgcG9zaXRpb25pbmcgYmVsb3cgdW50aWwgdGhlcmUgaXMgYWJzb2x1 dGVseSBubyByb29tLgotICAgICAgICBpZiAoYWJvdmVIZWlnaHQgPiB1bmRlckhlaWdodCkKLSAg ICAgICAgICAgIHkgPSBhbmNob3JCb3VuZHMub3JpZ2luLnkgLSBoZWlnaHQ7CisgICAgICAgIC8v IFBvc2l0aW9uIHRoZSBzdWdnZXN0aW9ucyBiZWxvdyB0aGUgYW5jaG9yLiBJZiB0aGVyZSBpcyBu byByb29tLCBwb3NpdGlvbiB0aGUgc3VnZ2VzdGlvbnMgYWJvdmUKKyAgICAgICAgaWYgKHVuZGVy SGVpZ2h0IC0gaGVpZ2h0IDwgMCkgCisgICAgICAgICAgICB5ID0gYWJvdmVIZWlnaHQgLSBoZWln aHQ7CiAKICAgICAgICAgdGhpcy5fZWxlbWVudC5zdHlsZS5sZWZ0ID0geCArICJweCI7CiAgICAg ICAgIHRoaXMuX2VsZW1lbnQuc3R5bGUudG9wID0geSArICJweCI7Cg== 222237 2014-01-25 14:49:08 -0800 2014-01-25 17:03:50 -0800 Patch bug-127615-20140125234907.patch text/plain 1960 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyNzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw MjBmYWJhYzgxNjdlOTk4Mzk3NDhlNDJlZTI5Njk4MGFhN2IwOGY1Li40YmYwNTNlOGExYjM4ZGUz YTFkMmUzYzQzZmJmMmE1MzY3YTNhN2NlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNC0wMS0yNSAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFBvc2l0aW9uIHRoZSBjb21wbGV0aW9uIHN1 Z2dlc3Rpb25zIHBvcHVwIGJlbG93IGlmIHRoZXJlIGlzIHJvb20KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzYxNQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db21wbGV0aW9u U3VnZ2VzdGlvbnNWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbXBsZXRpb25TdWdn ZXN0aW9uc1ZpZXcucHJvdG90eXBlLnNob3cpOgorCiAyMDE0LTAxLTIzICBUaW1vdGh5IEhhdGNo ZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBSZWZhY3RvciBUaW1lbGluZVJlY29y ZEJhciBjb21iaW5pbmcgbG9naWMgaW50byBhIGhlbHBlciBmdW5jdGlvbi4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbXBsZXRpb25TdWdnZXN0aW9u c1ZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db21wbGV0aW9u U3VnZ2VzdGlvbnNWaWV3LmpzCmluZGV4IGEwOTA0MWNlNjYyODc3OWQ4MGNiMmY1NmIwNDIxODZk ZGM4Y2E2YWEuLmNlNGM5YzNlYzRmNDJiZTU3M2ZlMWI0MDBmY2QzOWNkYTMxMWNmZWIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbXBsZXRpb25TdWdn ZXN0aW9uc1ZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Q29tcGxldGlvblN1Z2dlc3Rpb25zVmlldy5qcwpAQCAtMTUwLDEwICsxNTAsOSBAQCBXZWJJbnNw ZWN0b3IuQ29tcGxldGlvblN1Z2dlc3Rpb25zVmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZh ciBtYXhpbXVtSGVpZ2h0ID0gTWF0aC5taW4oYWJzb2x1dGVNYXhpbXVtSGVpZ2h0LCBNYXRoLm1h eCh1bmRlckhlaWdodCwgYWJvdmVIZWlnaHQpIC0gbWFyZ2luKTsKICAgICAgICAgdmFyIGhlaWdo dCA9IE1hdGgubWluKGNvbnRhaW5lckhlaWdodCwgbWF4aW11bUhlaWdodCk7CiAKLSAgICAgICAg Ly8gUG9zaXRpb24gdGhlIHN1Z2Vzc3Rpb25zIGFib3ZlIHRoZSBhbmNob3IgaWYgdGhlcmUgaXMg bW9yZSByb29tLgotICAgICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgYWx3YXlzIHByZWZlciBw b3NpdGlvbmluZyBiZWxvdyB1bnRpbCB0aGVyZSBpcyBhYnNvbHV0ZWx5IG5vIHJvb20uCi0gICAg ICAgIGlmIChhYm92ZUhlaWdodCA+IHVuZGVySGVpZ2h0KQotICAgICAgICAgICAgeSA9IGFuY2hv ckJvdW5kcy5vcmlnaW4ueSAtIGhlaWdodDsKKyAgICAgICAgLy8gUG9zaXRpb24gdGhlIHN1Z2dl c3Rpb25zIGJlbG93IHRoZSBhbmNob3IuIElmIHRoZXJlIGlzIG5vIHJvb20sIHBvc2l0aW9uIHRo ZSBzdWdnZXN0aW9ucyBhYm92ZS4KKyAgICAgICAgaWYgKHVuZGVySGVpZ2h0IC0gaGVpZ2h0IDwg MCkgCisgICAgICAgICAgICB5ID0gYWJvdmVIZWlnaHQgLSBoZWlnaHQ7CiAKICAgICAgICAgdGhp cy5fZWxlbWVudC5zdHlsZS5sZWZ0ID0geCArICJweCI7CiAgICAgICAgIHRoaXMuX2VsZW1lbnQu c3R5bGUudG9wID0geSArICJweCI7Cg==