127604 2014-01-24 20:14:53 -0800 Get rid of BackForwardController::isActive() 2014-01-25 09:12:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 971873 0 andersca 2014-01-24 20:14:53 -0800 Get rid of BackForwardController::isActive() 971874 1 222188 andersca 2014-01-24 20:22:49 -0800 Created attachment 222188 Patch 971956 2 222188 commit-queue 2014-01-25 09:12:18 -0800 Comment on attachment 222188 Patch Clearing flags on attachment: 222188 Committed r162764: <http://trac.webkit.org/changeset/162764> 971957 3 commit-queue 2014-01-25 09:12:20 -0800 All reviewed patches have been landed. Closing bug. 222188 2014-01-24 20:22:49 -0800 2014-01-25 09:12:18 -0800 Patch bug-127604-20140124202248.patch text/plain 6985 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyNzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjkwNTgwZWVhOTRmZDVm OTZkNTI4OGVmYWYyYWU4YTdlZTNhNjcyNC4uNjM4ZTI0YWM4YWFiMjJkZGYwZDM4OWQ3ZmZhMmQ2 MDU2ZTgyMTFhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE0LTAxLTI0ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgR2V0IHJpZCBvZiBC YWNrRm9yd2FyZENvbnRyb2xsZXI6OmlzQWN0aXZlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzYwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEJhY2tGb3J3YXJkQ29udHJvbGxlcjo6aXNBY3RpdmUo KSB1c2VkIHRvIG1lYW4gIm15IHBhZ2UgbWFpbnRhaW5zIGEgYmFjayBmb3J3YXJkCisgICAgICAg IGxpc3QgdGhhdCBoYXMgemVybyBjYXBhY2l0eSIuIE1vdmUgdGhhdCBsb2dpYyBpbnRvIFdlYktp dCBpbnN0ZWFkLCBuYW1lbHkgdGhlCisgICAgICAgIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpjYW5D YWNoZVBhZ2UgZnVuY3Rpb24gc28gd2UgY2FuIHNpbXBsaWZ5IFdlYkNvcmUuCisKKyAgICAgICAg KiBoaXN0b3J5L0JhY2tGb3J3YXJkQ2xpZW50Lmg6CisgICAgICAgICogaGlzdG9yeS9CYWNrRm9y d2FyZENvbnRyb2xsZXIuY3BwOgorICAgICAgICAqIGhpc3RvcnkvQmFja0ZvcndhcmRDb250cm9s bGVyLmg6CisgICAgICAgICogaGlzdG9yeS9CYWNrRm9yd2FyZExpc3QuaDoKKyAgICAgICAgKiBo aXN0b3J5L1BhZ2VDYWNoZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpsb2dDYW5DYWNoZVBhZ2VE ZWNpc2lvbik6CisgICAgICAgIChXZWJDb3JlOjpQYWdlQ2FjaGU6OmNhbkNhY2hlKToKKworMjAx NC0wMS0yNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAg IEFub3RoZXIgYXR0ZW1wdGVkIGJ1aWxkIGZpeC4KIAogICAgICAgICBVc2Ugd2lsZGNhcmRzIGlu IHRoZSB0aGUgc3RkOjpkdXJhdGlvbiBzeW1ib2wuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggZjExMDMy NzBjNWI3OGRhY2NiY2JhYTAyNWM5ZjNlODRhOTEyZmJlYS4uZDg0YzU4YTc0YThhOWVmZDY0OTll NThmZThmNWZhNGZiMmFmYWVmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAy MDE0LTAxLTI0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAg ICAgR2V0IHJpZCBvZiBCYWNrRm9yd2FyZENvbnRyb2xsZXI6OmlzQWN0aXZlKCkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzYwNAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQv V2ViRnJhbWVMb2FkZXJDbGllbnQubW06CisgICAgICAgIChXZWJGcmFtZUxvYWRlckNsaWVudDo6 Y2FuQ2FjaGVQYWdlKToKKyAgICAgICAgTW92ZSBpc0FjdGl2ZSBsb2dpYyBoZXJlLgorCisyMDE0 LTAxLTI0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAg UmVtb3ZlIGJhY2svZm9yd2FyZCBsaXN0IHJlbGF0ZWQgZnVuY3Rpb25zIGZyb20gUGFnZQogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3NTk2CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2hpc3RvcnkvQmFja0ZvcndhcmRDbGllbnQuaCBiL1Nv dXJjZS9XZWJDb3JlL2hpc3RvcnkvQmFja0ZvcndhcmRDbGllbnQuaAppbmRleCBlYjVjM2U5ZjFi Y2Y2MTdiOGJmYWY4YzAxODM2NTNmYjU2NTkxY2ZlLi44YmE1NWU1Nzg2NWQ4ZDIyNTEwMWNiNDQ2 YzYwMGJiNWM0NWQwOTcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0JhY2tG b3J3YXJkQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9CYWNrRm9yd2FyZENs aWVudC5oCkBAIC00OSw4ICs0OSw2IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGludCBiYWNrTGlz dENvdW50KCkgPSAwOwogICAgIHZpcnR1YWwgaW50IGZvcndhcmRMaXN0Q291bnQoKSA9IDA7CiAK LSAgICB2aXJ0dWFsIGJvb2wgaXNBY3RpdmUoKSA9IDA7Ci0KICAgICB2aXJ0dWFsIHZvaWQgY2xv c2UoKSA9IDA7CiAKICNpZiBQTEFURk9STShJT1MpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9oaXN0b3J5L0JhY2tGb3J3YXJkQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9oaXN0 b3J5L0JhY2tGb3J3YXJkQ29udHJvbGxlci5jcHAKaW5kZXggZDJlZjM5Y2RiYzg1ZTIwYTdiMzMx NzU5MWM1OGY5MDRlYWM0MTRmNC4uMmQxZDAyMDA5ZDk3OTQ2YmJlOWIxNDI4NGMyMGMxYjE2NTM1 ZWY5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9CYWNrRm9yd2FyZENvbnRy b2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2hpc3RvcnkvQmFja0ZvcndhcmRDb250cm9s bGVyLmNwcApAQCAtMTI3LDExICsxMjcsNiBAQCBIaXN0b3J5SXRlbSogQmFja0ZvcndhcmRDb250 cm9sbGVyOjppdGVtQXRJbmRleChpbnQgaSkKICAgICByZXR1cm4gbV9jbGllbnQtPml0ZW1BdElu ZGV4KGkpOwogfQogCi1ib29sIEJhY2tGb3J3YXJkQ29udHJvbGxlcjo6aXNBY3RpdmUoKQotewot ICAgIHJldHVybiBtX2NsaWVudC0+aXNBY3RpdmUoKTsKLX0KLQogdm9pZCBCYWNrRm9yd2FyZENv bnRyb2xsZXI6OmNsb3NlKCkKIHsKICAgICBtX2NsaWVudC0+Y2xvc2UoKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2hpc3RvcnkvQmFja0ZvcndhcmRDb250cm9sbGVyLmggYi9Tb3VyY2Uv V2ViQ29yZS9oaXN0b3J5L0JhY2tGb3J3YXJkQ29udHJvbGxlci5oCmluZGV4IGZiMDVhMzg0MzVk Y2I3YjAwZGY1MjZkMjlkNThhZGQ5NTBkNzk5ZDQuLjYzODc3NDY0MzFiZWMwZWRjNmMwYjQ0Yjcy YWI2OGUyZTU4Y2U3ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2hpc3RvcnkvQmFja0Zv cndhcmRDb250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9CYWNrRm9yd2Fy ZENvbnRyb2xsZXIuaApAQCAtNTksOCArNTksNiBAQCBwdWJsaWM6CiAKICAgICBIaXN0b3J5SXRl bSogaXRlbUF0SW5kZXgoaW50KTsKIAotICAgIGJvb2wgaXNBY3RpdmUoKTsKLQogICAgIHZvaWQg Y2xvc2UoKTsKIAogICAgIEhpc3RvcnlJdGVtKiBiYWNrSXRlbSgpIHsgcmV0dXJuIGl0ZW1BdElu ZGV4KC0xKTsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9CYWNrRm9yd2Fy ZExpc3QuaCBiL1NvdXJjZS9XZWJDb3JlL2hpc3RvcnkvQmFja0ZvcndhcmRMaXN0LmgKaW5kZXgg ZTFiM2QzNDkxYzY4ZTI1ZTRmYzFkZjYzZDQ0YTAwYWE1ODk2YmE4MS4uYWU3YWRmYTE2NmY2YTBi MDEzMDBmZTg2YjNmZTA3NmVhM2YzZWVmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaGlz dG9yeS9CYWNrRm9yd2FyZExpc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0JhY2tG b3J3YXJkTGlzdC5oCkBAIC00NSw3ICs0NSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5CYWNr Rm9yd2FyZExpc3QoKTsKIAogICAgIFBhZ2UqIHBhZ2UoKSB7IHJldHVybiBtX3BhZ2U7IH0KLSAg ICAKKwogICAgIHZpcnR1YWwgdm9pZCBhZGRJdGVtKFBhc3NSZWZQdHI8SGlzdG9yeUl0ZW0+KSBv dmVycmlkZTsKICAgICB2b2lkIGdvQmFjaygpOwogICAgIHZvaWQgZ29Gb3J3YXJkKCk7CkBAIC04 Myw4ICs4Myw2IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgZXhwbGljaXQgQmFja0ZvcndhcmRM aXN0KFBhZ2UqKTsKIAotICAgIHZpcnR1YWwgYm9vbCBpc0FjdGl2ZSgpIG92ZXJyaWRlIHsgcmV0 dXJuIGVuYWJsZWQoKSAmJiBjYXBhY2l0eSgpOyB9Ci0KICAgICBQYWdlKiBtX3BhZ2U7CiAgICAg SGlzdG9yeUl0ZW1WZWN0b3IgbV9lbnRyaWVzOwogICAgIEhpc3RvcnlJdGVtSGFzaFNldCBtX2Vu dHJ5SGFzaDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2hpc3RvcnkvUGFnZUNhY2hlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2hpc3RvcnkvUGFnZUNhY2hlLmNwcAppbmRleCAxZThmMjA4MjY3 MjUxODlhOTNiNmY5NDViMmNmMDA0YTQ2MmVhODQ3Li41N2VjMjRlZmI2ZTkyYjhjNDRiYmM3ZDE5 Yjk5ZGQwODdmM2Y1M2EyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L1BhZ2VD YWNoZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9QYWdlQ2FjaGUuY3BwCkBAIC0y MzEsMTAgKzIzMSw2IEBAIHN0YXRpYyB2b2lkIGxvZ0NhbkNhY2hlUGFnZURlY2lzaW9uKFBhZ2Uq IHBhZ2UpCiAgICAgaWYgKGZyYW1lUmVqZWN0UmVhc29ucykKICAgICAgICAgcmVqZWN0UmVhc29u cyB8PSAxIDw8IEZyYW1lQ2Fubm90QmVJblBhZ2VDYWNoZTsKICAgICAKLSAgICBpZiAoIXBhZ2Ut PmJhY2tGb3J3YXJkKCkuaXNBY3RpdmUoKSkgewotICAgICAgICBQQ0xPRygiICAgLVRoZSBiYWNr L2ZvcndhcmQgbGlzdCBpcyBkaXNhYmxlZCBvciBoYXMgMCBjYXBhY2l0eSIpOwotICAgICAgICBy ZWplY3RSZWFzb25zIHw9IDEgPDwgRGlzYWJsZWRCYWNrRm9yd2FyZExpc3Q7Ci0gICAgfQogICAg IGlmICghcGFnZS0+c2V0dGluZ3MoKS51c2VzUGFnZUNhY2hlKCkpIHsKICAgICAgICAgUENMT0co IiAgIC1QYWdlIHNldHRpbmdzIHNheXMgYi9mIGNhY2hlIGRpc2FibGVkIik7CiAgICAgICAgIHJl amVjdFJlYXNvbnMgfD0gMSA8PCBEaXNhYmxlZFBhZ2VDYWNoZTsKQEAgLTM4MCw3ICszNzYsNiBA QCBib29sIFBhZ2VDYWNoZTo6Y2FuQ2FjaGUoUGFnZSogcGFnZSkgY29uc3QKICAgICAKICAgICBy ZXR1cm4gbV9jYXBhY2l0eSA+IDAKICAgICAgICAgJiYgY2FuQ2FjaGVQYWdlQ29udGFpbmluZ1Ro aXNGcmFtZSgmcGFnZS0+bWFpbkZyYW1lKCkpCi0gICAgICAgICYmIHBhZ2UtPmJhY2tGb3J3YXJk KCkuaXNBY3RpdmUoKQogICAgICAgICAmJiBwYWdlLT5zZXR0aW5ncygpLnVzZXNQYWdlQ2FjaGUo KQogI2lmIEVOQUJMRShERVZJQ0VfT1JJRU5UQVRJT04pICYmICFQTEFURk9STShJT1MpCiAgICAg ICAgICYmICFEZXZpY2VNb3Rpb25Db250cm9sbGVyOjppc0FjdGl2ZUF0KHBhZ2UpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVu dC5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xp ZW50Lm1tCmluZGV4IGUxOWQ4MDI1NmRiZTBhZWFlM2E3M2Y3M2M4ZDQ5YTVmNmM3YjQ0NmQuLjM3 ZjI2NDQ1MGFkNDBiODY0YTRjNzU2ZDgxOTMyMTgzMTdiMWJhNjMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50Lm1tCisrKyBi L1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50Lm1t CkBAIC04MCw2ICs4MCw3IEBACiAjaW1wb3J0IDxXZWJDb3JlL0F1dGhlbnRpY2F0aW9uQ0YuaD4K ICNpbXBvcnQgPFdlYkNvcmUvQXV0aGVudGljYXRpb25NYWMuaD4KICNpbXBvcnQgPFdlYkNvcmUv QmFja0ZvcndhcmRDb250cm9sbGVyLmg+CisjaW1wb3J0IDxXZWJDb3JlL0JhY2tGb3J3YXJkTGlz dC5oPgogI2ltcG9ydCA8V2ViQ29yZS9CbG9ja0V4Y2VwdGlvbnMuaD4KICNpbXBvcnQgPFdlYkNv cmUvQ2FjaGVkRnJhbWUuaD4KICNpbXBvcnQgPFdlYkNvcmUvQ2hyb21lLmg+CkBAIC0xNjMyLDcg KzE2MzMsMjIgQEAgTlNEaWN0aW9uYXJ5ICpXZWJGcmFtZUxvYWRlckNsaWVudDo6YWN0aW9uRGlj dGlvbmFyeShjb25zdCBOYXZpZ2F0aW9uQWN0aW9uJiBhY3QKIGJvb2wgV2ViRnJhbWVMb2FkZXJD bGllbnQ6OmNhbkNhY2hlUGFnZSgpIGNvbnN0CiB7CiAgICAgLy8gV2UgY2FuIG9ubHkgY2FjaGUg SFRNTCBwYWdlcyByaWdodCBub3cKLSAgICByZXR1cm4gW1tbbV93ZWJGcmFtZS5nZXQoKSBfZGF0 YVNvdXJjZV0gcmVwcmVzZW50YXRpb25dIGlzS2luZE9mQ2xhc3M6W1dlYkhUTUxSZXByZXNlbnRh dGlvbiBjbGFzc11dOworICAgIGlmICghW1tbbV93ZWJGcmFtZSBfZGF0YVNvdXJjZV0gcmVwcmVz ZW50YXRpb25dIGlzS2luZE9mQ2xhc3M6W1dlYkhUTUxSZXByZXNlbnRhdGlvbiBjbGFzc11dKQor ICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgCisgICAgLy8gV2Ugb25seSBjYWNoZSBwYWdlcyBp ZiB0aGUgYmFjayBmb3J3YXJkIGxpc3QgaXMgZW5hYmxlZCBhbmQgaGFzIGEgbm9uLXplcm8gY2Fw YWNpdHkuCisgICAgUGFnZSogcGFnZSA9IGNvcmUobV93ZWJGcmFtZS5nZXQoKSktPnBhZ2UoKTsK KyAgICBpZiAoIXBhZ2UpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAKKyAgICBCYWNrRm9y d2FyZExpc3QgKmJhY2tGb3J3YXJkTGlzdCA9IHN0YXRpY19jYXN0PEJhY2tGb3J3YXJkTGlzdCo+ KHBhZ2UtPmJhY2tGb3J3YXJkKCkuY2xpZW50KCkpOworICAgIGlmICghYmFja0ZvcndhcmRMaXN0 LT5lbmFibGVkKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAKKyAgICBpZiAoIWJhY2tG b3J3YXJkTGlzdC0+Y2FwYWNpdHkoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIAorICAg IHJldHVybiB0cnVlOwogfQogCiBQYXNzUmVmUHRyPEZyYW1lPiBXZWJGcmFtZUxvYWRlckNsaWVu dDo6Y3JlYXRlRnJhbWUoY29uc3QgVVJMJiB1cmwsIGNvbnN0IFN0cmluZyYgbmFtZSwgSFRNTEZy YW1lT3duZXJFbGVtZW50KiBvd25lckVsZW1lbnQsCg==