127602 2014-01-24 19:17:26 -0800 WebKit2 View Gestures (Smart Zoom): Can't double-tap zoom-out on the body 2014-01-24 21:57:02 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca commit-queue sam simon.fraser oldest_to_newest 971863 0 thorton 2014-01-24 19:17:26 -0800 Steps to Reproduce: 1. Go to nyt.com. 2. Double tap in the very top left corner, in the whitespace. 3. Double tap in the same place again. Expected: 3 should zoom you back out Actual: 3 has no effect <rdar://problem/15852224> 971868 1 222186 thorton 2014-01-24 19:23:53 -0800 Created attachment 222186 patch a patch, but I want to figure out if renderRect() should return something smarter for <body> 971888 2 thorton 2014-01-24 21:44:04 -0800 (In reply to comment #1) > Created an attachment (id=222186) [details] > patch > > a patch, but I want to figure out if renderRect() should return something smarter for <body> Filed https://bugs.webkit.org/show_bug.cgi?id=127603 about that oddity. 971890 3 222186 commit-queue 2014-01-24 21:57:00 -0800 Comment on attachment 222186 patch Clearing flags on attachment: 222186 Committed r162758: <http://trac.webkit.org/changeset/162758> 971891 4 commit-queue 2014-01-24 21:57:02 -0800 All reviewed patches have been landed. Closing bug. 222186 2014-01-24 19:23:53 -0800 2014-01-24 21:57:00 -0800 patch smartzoom.diff text/plain 3121 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxZjJkMzYyLi43NTkzY2EyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTQtMDEtMjQgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgV2ViS2l0MiBWaWV3IEdlc3R1cmVzIChTbWFydCBab29tKTogQ2FuJ3QgZG91Ymxl LXRhcCB6b29tLW91dCBvbiB0aGUgYm9keQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI3NjAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlci5o OgorICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvVmlld0dlc3R1cmVDb250cm9sbGVyLm1tOgorICAg ICAgICAoV2ViS2l0OjpWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OlZpZXdHZXN0dXJlQ29udHJvbGxl cik6CisgICAgICAgIChXZWJLaXQ6OlZpZXdHZXN0dXJlQ29udHJvbGxlcjo6ZGlkQ29sbGVjdEdl b21ldHJ5Rm9yU21hcnRNYWduaWZpY2F0aW9uR2VzdHVyZSk6CisgICAgICAgIFVzZSBhbiBleHBs aWNpdCBib29sZWFuIGluc3RlYWQgb2YgdGhlIGVtcHRpbmVzcyBvZiB0aGUgcmVuZGVyUmVjdCgp IHRvIGRldGVybWluZQorICAgICAgICB3aGV0aGVyIG9yIG5vdCB0aGUgdXNlciBoYXMgYWxyZWFk eSBzbWFydC16b29tZWQuIHJlbmRlclJlY3QoKSBjYW4gYmUgMHgwCisgICAgICAgIGlmIG91ciBo aXQtdGVzdCBoaXRzIHRoZSBib2R5IGVsZW1lbnQuCisKIDIwMTQtMDEtMjQgIEFuZGVycyBDYXJs c3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBUcnkgdG8gZml4IHRoZSBHVEsr IGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9WaWV3R2Vz dHVyZUNvbnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvVmlld0dlc3R1 cmVDb250cm9sbGVyLmgKaW5kZXggMmJiYzJmMy4uYzdkN2IwYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xsZXIuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlci5oCkBAIC02OSw2 ICs2OSw3IEBAIHByaXZhdGU6CiAgICAgV2ViQ29yZTo6RmxvYXRQb2ludCBtX21hZ25pZmljYXRp b25PcmlnaW47CiAKICAgICBXZWJDb3JlOjpGbG9hdFJlY3QgbV9sYXN0U21hcnRNYWduaWZpY2F0 aW9uVW5zY2FsZWRUYXJnZXRSZWN0OworICAgIGJvb2wgbV9sYXN0U21hcnRNYWduaWZpY2F0aW9u VW5zY2FsZWRUYXJnZXRSZWN0SXNWYWxpZDsKIAogICAgIFZpZXdHZXN0dXJlVHlwZSBtX2FjdGl2 ZUdlc3R1cmVUeXBlOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFj L1ZpZXdHZXN0dXJlQ29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMv Vmlld0dlc3R1cmVDb250cm9sbGVyLm1tCmluZGV4IDdjZWZjYzEuLmVlNWViZDQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvVmlld0dlc3R1cmVDb250cm9sbGVyLm1t CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvVmlld0dlc3R1cmVDb250cm9sbGVy Lm1tCkBAIC00OSw2ICs0OSw3IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogCiBWaWV3R2VzdHVyZUNv bnRyb2xsZXI6OlZpZXdHZXN0dXJlQ29udHJvbGxlcihXZWJQYWdlUHJveHkmIHdlYlBhZ2VQcm94 eSkKICAgICA6IG1fd2ViUGFnZVByb3h5KHdlYlBhZ2VQcm94eSkKKyAgICAsIG1fbGFzdFNtYXJ0 TWFnbmlmaWNhdGlvblVuc2NhbGVkVGFyZ2V0UmVjdElzVmFsaWQoZmFsc2UpCiAgICAgLCBtX2Fj dGl2ZUdlc3R1cmVUeXBlKFZpZXdHZXN0dXJlVHlwZTo6Tm9uZSkKICAgICAsIG1fdmlzaWJsZUNv bnRlbnRSZWN0SXNWYWxpZChmYWxzZSkKICAgICAsIG1fZnJhbWVIYW5kbGVzTWFnbmlmaWNhdGlv bkdlc3R1cmUoZmFsc2UpCkBAIC0xNzcsNyArMTc4LDcgQEAgdm9pZCBWaWV3R2VzdHVyZUNvbnRy b2xsZXI6OmRpZENvbGxlY3RHZW9tZXRyeUZvclNtYXJ0TWFnbmlmaWNhdGlvbkdlc3R1cmUoRmxv YXQKICAgICAvLyBBbGxvdyBwYW5uaW5nIGJldHdlZW4gZWxlbWVudHMgdmlhIGRvdWJsZS10YXAg d2hpbGUgbWFnbmlmaWVkLCB1bmxlc3MgdGhlIHRhcmdldCByZWN0IGlzCiAgICAgLy8gc2ltaWxh ciB0byB0aGUgbGFzdCBvbmUsIGluIHdoaWNoIGNhc2Ugd2UnbGwgem9vbSBhbGwgdGhlIHdheSBv dXQuCiAgICAgaWYgKGN1cnJlbnRTY2FsZUZhY3RvciA+IDEKLSAgICAgICAgJiYgIW1fbGFzdFNt YXJ0TWFnbmlmaWNhdGlvblVuc2NhbGVkVGFyZ2V0UmVjdC5pc0VtcHR5KCkKKyAgICAgICAgJiYg bV9sYXN0U21hcnRNYWduaWZpY2F0aW9uVW5zY2FsZWRUYXJnZXRSZWN0SXNWYWxpZAogICAgICAg ICAmJiBtYXhpbXVtUmVjdGFuZ2xlQ29tcG9uZW50RGVsdGEobV9sYXN0U21hcnRNYWduaWZpY2F0 aW9uVW5zY2FsZWRUYXJnZXRSZWN0LCB1bnNjYWxlZFRhcmdldFJlY3QpIDwgc21hcnRNYWduaWZp Y2F0aW9uUGFuU2Nyb2xsVGhyZXNob2xkKQogICAgICAgICB0YXJnZXRNYWduaWZpY2F0aW9uID0g MTsKIApAQCAtMTkwLDYgKzE5MSw3IEBAIHZvaWQgVmlld0dlc3R1cmVDb250cm9sbGVyOjpkaWRD b2xsZWN0R2VvbWV0cnlGb3JTbWFydE1hZ25pZmljYXRpb25HZXN0dXJlKEZsb2F0CiAgICAgbV93 ZWJQYWdlUHJveHkuZHJhd2luZ0FyZWEoKS0+Y29tbWl0VHJhbnNpZW50Wm9vbSh0YXJnZXRNYWdu aWZpY2F0aW9uLCB0YXJnZXRPcmlnaW4pOwogCiAgICAgbV9sYXN0U21hcnRNYWduaWZpY2F0aW9u VW5zY2FsZWRUYXJnZXRSZWN0ID0gdW5zY2FsZWRUYXJnZXRSZWN0OworICAgIG1fbGFzdFNtYXJ0 TWFnbmlmaWNhdGlvblVuc2NhbGVkVGFyZ2V0UmVjdElzVmFsaWQgPSB0cnVlOwogfQogCiB2b2lk IFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6ZW5kQWN0aXZlR2VzdHVyZSgpCg==