127595 2014-01-24 17:38:40 -0800 Cleaning the JSStaticScopeObject files left behind after renaming their objects to JSNameScope 2014-02-14 03:15:41 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 agomez webkit-unassigned agomez commit-queue ggaren mario oliver oldest_to_newest 971824 0 agomez 2014-01-24 17:38:40 -0800 On bug 95166 there was a re-factorization which renamed JSStaticScopeObject into JSNameScope. However, its commit didn't actually remove the files but left them empty behind: http://trac.webkit.org/changeset/126893/trunk/Source/JavaScriptCore/runtime/JSStaticScopeObject.cpp http://trac.webkit.org/changeset/126893/trunk/Source/JavaScriptCore/runtime/JSStaticScopeObject.h On http://trac.webkit.org/changeset/153298 there were re-introduced into the CMake compilation. These files seem safe to be removed. 971832 1 222177 agomez 2014-01-24 17:55:49 -0800 Created attachment 222177 Patch 972418 2 222177 commit-queue 2014-01-27 08:01:59 -0800 Comment on attachment 222177 Patch Rejecting attachment 222177 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 222177, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: t 1 with fuzz 3. patching file Source/JavaScriptCore/CMakeLists.txt Hunk #1 succeeded at 391 (offset 7 lines). patch: **** Only garbage was found in the patch input. rm 'Source/JavaScriptCore/runtime/JSStaticScopeObject.cpp' patch: **** Only garbage was found in the patch input. rm 'Source/JavaScriptCore/runtime/JSStaticScopeObject.h' Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Mario Sanchez Prada']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5210177649246208 980490 3 agomez 2014-02-13 15:18:11 -0800 After a conversation with Mario, he said he could not remove the files since they were not there in SVN. I've double checked and they happen to be there in the git clone and also in SVN: https://trac.webkit.org/browser/trunk/Source/JavaScriptCore/runtime/JSStaticScopeObject.cpp https://trac.webkit.org/browser/trunk/Source/JavaScriptCore/runtime/JSStaticScopeObject.h Hence, the patch is still valid although maybe it has to be applied by hand. 980721 4 mario 2014-02-14 03:05:28 -0800 Committed r164096: <http://trac.webkit.org/changeset/164096> 980723 5 mario 2014-02-14 03:06:26 -0800 (In reply to comment #3) > After a conversation with Mario, he said he could not remove the files since they were not there in SVN. > > I've double checked and they happen to be there in the git clone and also in SVN: > https://trac.webkit.org/browser/trunk/Source/JavaScriptCore/runtime/JSStaticScopeObject.cpp > https://trac.webkit.org/browser/trunk/Source/JavaScriptCore/runtime/JSStaticScopeObject.h > > Hence, the patch is still valid although maybe it has to be applied by hand. Yes, the patch is indeed still valid. The reason why I could not see those files in my local checkout was... ehem... whatever :) Committed manually then. 980729 6 agomez 2014-02-14 03:15:41 -0800 Thanks for the time and your patience ;) 222177 2014-01-24 17:55:49 -0800 2014-01-27 08:01:59 -0800 Patch bug-127595-20140125035548.patch text/plain 2072 agomez U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyNzQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 OGRlYzk2MjQ1ODFhZjFlODk0NjNjMmM4YjFhYmRlYWE4MmExOTIxLi4xM2I1YjczMzU0NGYzMTIx MmRhZTgyMTY3Y2YxODU0YzIyZWMxNGE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNC0wMS0yNCAgQW5kcmVzIEdvbWV6ICA8YWdvbWV6QGlnYWxpYS5jb20+ CisKKyAgICAgICAgQ2xlYW5pbmcgdGhlIEpTU3RhdGljU2NvcGVPYmplY3QgZmlsZXMgbGVmdCBi ZWhpbmQgYWZ0ZXIgcmVuYW1pbmcgdGhlaXIgb2JqZWN0cyB0byBKU05hbWVTY29wZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3NTk1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSlNTdGF0aWNTY29wZU9i amVjdCB3YXMgcmVuYW1lZCB0byBKU05hbWVTY29wZSBhbmQgcmVtb3ZlZCBsb25nCisgICAgICAg IGFnbyBidXQgdGhlIGZpbGVzIHdlcmUgbGVmdCBiZWhpbmQgZW1wdHkgYW5kIHRoZSBDTWFrZSBj b21waWxhdGlvbgorICAgICAgICBpbiBuZWVkIG9mIGl0cyBleGlzdGFuY2UuIE5vdywgd2UgYXJl IGRlZmluaXRlbHkgZ2V0dGluZyByaWQgb2YKKyAgICAgICAgdGhlbS4KKworICAgICAgICAqIENN YWtlTGlzdHMudHh0OgorICAgICAgICAqIHJ1bnRpbWUvSlNTdGF0aWNTY29wZU9iamVjdC5jcHA6 IFJlbW92ZWQuCisgICAgICAgICogcnVudGltZS9KU1N0YXRpY1Njb3BlT2JqZWN0Lmg6IFJlbW92 ZWQuCisKIDIwMTQtMDEtMjQgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAg ICAgICBHZW5lcmljIEpTT2JqZWN0OjpwdXQgc2hvdWxkIGhhbmRsZSBzdGF0aWMgcHJvcGVydGll cyBpbiB0aGUgY2xhc3NpbmZvIGhpZXJhcmNoeQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMu dHh0CmluZGV4IDlhMWM2OTk2NTQ2ZDVlOTFhNTBjZjVhMTg1YjYzMzliNDk2MzViNDIuLmE1MDY3 OTdjYTQ2NTI4MDlhZjM2Mjk0N2Y0NzM0NmU0MGYwZmRhY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv Q01ha2VMaXN0cy50eHQKQEAgLTM4NCw3ICszODQsNiBAQCBzZXQoSmF2YVNjcmlwdENvcmVfU09V UkNFUwogICAgIHJ1bnRpbWUvSlNTZWdtZW50ZWRWYXJpYWJsZU9iamVjdC5jcHAKICAgICBydW50 aW1lL0pTU2V0LmNwcAogICAgIHJ1bnRpbWUvSlNTZXRJdGVyYXRvci5jcHAKLSAgICBydW50aW1l L0pTU3RhdGljU2NvcGVPYmplY3QuY3BwCiAgICAgcnVudGltZS9KU1N0cmluZy5jcHAKICAgICBy dW50aW1lL0pTU3RyaW5nSm9pbmVyLmNwcAogICAgIHJ1bnRpbWUvSlNTeW1ib2xUYWJsZU9iamVj dC5jcHAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RhdGlj U2NvcGVPYmplY3QuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdGF0aWNT Y29wZU9iamVjdC5jcHAKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IGU2OWRlMjliYjJk MWQ2NDM0YjhiMjlhZTc3NWFkOGMyZTQ4YzUzOTEuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTU3RhdGljU2NvcGVPYmplY3QuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT U3RhdGljU2NvcGVPYmplY3QuaApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggZTY5ZGUy OWJiMmQxZDY0MzRiOGIyOWFlNzc1YWQ4YzJlNDhjNTM5MS4uMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMAo=