127577 2014-01-24 13:08:05 -0800 Use a side table to map WebPageProxy objects to WKBrowsingContextController objects 2014-01-24 13:21:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 971717 0 andersca 2014-01-24 13:08:05 -0800 Use a side table to map WebPageProxy objects to WKBrowsingContextController objects 971718 1 222145 andersca 2014-01-24 13:08:50 -0800 Created attachment 222145 Patch 971719 2 commit-queue 2014-01-24 13:10:26 -0800 Attachment 222145 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h:33: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 971727 3 andersca 2014-01-24 13:21:00 -0800 Committed r162719: <http://trac.webkit.org/changeset/162719> 222145 2014-01-24 13:08:50 -0800 2014-01-24 13:19:10 -0800 Patch bug-127577-20140124130848.patch text/plain 4625 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyNzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTI1NjRhMTVkZGNlZmI1 NzA3OGI5NDg3NmFlNTUwOTYwNmJiOTMwMi4uM2JhYWM4MTMwNzNhYjY3NWE0ZDNmZDc2YTQ3OTk4 MWY2ZGI4NDdiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAxLTI0ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGEgc2lkZSB0 YWJsZSB0byBtYXAgV2ViUGFnZVByb3h5IG9iamVjdHMgdG8gV0tCcm93c2luZ0NvbnRleHRDb250 cm9sbGVyIG9iamVjdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyNzU3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIu bW06CisgICAgICAgIChicm93c2luZ0NvbnRleHRDb250cm9sbGVyTWFwKToKKyAgICAgICAgKC1b V0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVyIGRlYWxsb2NdKToKKyAgICAgICAgKC1bV0tCcm93 c2luZ0NvbnRleHRDb250cm9sbGVyIF9pbml0V2l0aFBhZ2VSZWY6XSk6CisgICAgICAgICgrW1dL QnJvd3NpbmdDb250ZXh0Q29udHJvbGxlciBfYnJvd3NpbmdDb250ZXh0Q29udHJvbGxlckZvclBh Z2VSZWY6XSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS0Jyb3dzaW5nQ29udGV4 dENvbnRyb2xsZXJJbnRlcm5hbC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHku aDoKKwogMjAxNC0wMS0yNCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4K IAogICAgICAgICBpT1MgYnVpbGQgZml4IGFmdGVyIHIxNjI3MTAuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxl ci5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tCcm93c2luZ0NvbnRl eHRDb250cm9sbGVyLm1tCmluZGV4IGNlMjUxZTIxZWE4ZWU5YzM2ZGUxZTQ3ZTE0NjUwN2YzYWMw ZWJkMTguLjYxNmJkY2FmMmU1Njc2NzNhYjYzOTBmMzJhY2ExMjcxMjc2Nzc0NzggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tCcm93c2luZ0NvbnRleHRD b250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tC cm93c2luZ0NvbnRleHRDb250cm9sbGVyLm1tCkBAIC01OCw2ICs1OCw3IEBACiAjaW1wb3J0ICJX ZWJDZXJ0aWZpY2F0ZUluZm8uaCIKICNpbXBvcnQgIldlYkNvbnRleHQuaCIKICNpbXBvcnQgIldl YlBhZ2VQcm94eS5oIgorI2ltcG9ydCA8d3RmL05ldmVyRGVzdHJveWVkLmg+CiAKIHVzaW5nIG5h bWVzcGFjZSBXZWJDb3JlOwogdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKQEAgLTE0OSwxMCArMTUw LDE4IEBAIHN0YXRpYyBOU1N0cmluZyAqIGNvbnN0IGZyYW1lRXJyb3JLZXkgPSBAIldLQnJvd3Np bmdDb250ZXh0RnJhbWVFcnJvcktleSI7CiAgICAgUmV0YWluUHRyPFdLUmVtb3RlT2JqZWN0UmVn aXN0cnk+IF9yZW1vdGVPYmplY3RSZWdpc3RyeTsKIH0KIAorc3RhdGljIEhhc2hNYXA8V2ViUGFn ZVByb3h5KiwgV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVyICo+JiBicm93c2luZ0NvbnRleHRD b250cm9sbGVyTWFwKCkKK3sKKyAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8SGFzaE1hcDxXZWJQ YWdlUHJveHkqLCBXS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIgKj4+IGJyb3dzaW5nQ29udGV4 dENvbnRyb2xsZXJNYXA7CisgICAgcmV0dXJuIGJyb3dzaW5nQ29udGV4dENvbnRyb2xsZXJNYXA7 Cit9CisKIC0gKHZvaWQpZGVhbGxvYwogeworICAgIEFTU0VSVChicm93c2luZ0NvbnRleHRDb250 cm9sbGVyTWFwKCkuZ2V0KF9wYWdlLmdldCgpKSA9PSBzZWxmKTsKKyAgICBicm93c2luZ0NvbnRl eHRDb250cm9sbGVyTWFwKCkucmVtb3ZlKF9wYWdlLmdldCgpKTsKKwogICAgIF9wYWdlLT5wYWdl TG9hZFN0YXRlKCkucmVtb3ZlT2JzZXJ2ZXIoKl9wYWdlTG9hZFN0YXRlT2JzZXJ2ZXIpOwotICAg IF9wYWdlLT5+V2ViUGFnZVByb3h5KCk7CiAKICAgICBbX3JlbW90ZU9iamVjdFJlZ2lzdHJ5IF9p bnZhbGlkYXRlXTsKIApAQCAtNzg1LDEyICs3OTQsNiBAQCBzdGF0aWMgdm9pZCBzZXRVcFBhZ2VQ b2xpY3lDbGllbnQoV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVyICpicm93c2luZ0NvbnRleHQs CiAgICAgcmV0dXJuIFlFUzsKIH0KIAotI3ByYWdtYSBtYXJrIFdLT2JqZWN0IHByb3RvY29sIGlt cGxlbWVudGF0aW9uCi0KLS0gKEFQSTo6T2JqZWN0JilfYXBpT2JqZWN0Ci17Ci0gICAgcmV0dXJu ICpyZWludGVycHJldF9jYXN0PEFQSTo6T2JqZWN0Kj4oJl9wYWdlKTsKLX0KIAogLSAoaW5zdGFu Y2V0eXBlKV9pbml0V2l0aFBhZ2VSZWY6KFdLUGFnZVJlZilwYWdlUmVmCiB7CkBAIC04MDIsMTIg KzgwNSwxNSBAQCBzdGF0aWMgdm9pZCBzZXRVcFBhZ2VQb2xpY3lDbGllbnQoV0tCcm93c2luZ0Nv bnRleHRDb250cm9sbGVyICpicm93c2luZ0NvbnRleHQsCiAgICAgX3BhZ2VMb2FkU3RhdGVPYnNl cnZlciA9IHN0ZDo6bWFrZV91bmlxdWU8UGFnZUxvYWRTdGF0ZU9ic2VydmVyPihzZWxmKTsKICAg ICBfcGFnZS0+cGFnZUxvYWRTdGF0ZSgpLmFkZE9ic2VydmVyKCpfcGFnZUxvYWRTdGF0ZU9ic2Vy dmVyKTsKIAorICAgIEFTU0VSVCghYnJvd3NpbmdDb250ZXh0Q29udHJvbGxlck1hcCgpLmNvbnRh aW5zKF9wYWdlLmdldCgpKSk7CisgICAgYnJvd3NpbmdDb250ZXh0Q29udHJvbGxlck1hcCgpLnNl dChfcGFnZS5nZXQoKSwgc2VsZik7CisKICAgICByZXR1cm4gc2VsZjsKIH0KIAogKyAoV0tCcm93 c2luZ0NvbnRleHRDb250cm9sbGVyICopX2Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXJGb3JQYWdl UmVmOihXS1BhZ2VSZWYpcGFnZVJlZgogewotICAgIHJldHVybiAoV0tCcm93c2luZ0NvbnRleHRD b250cm9sbGVyICopc3RhdGljX2Nhc3Q8Y29uc3QgV2ViTG9hZGVyQ2xpZW50Kj4oV2ViS2l0Ojp0 b0ltcGwocGFnZVJlZiktPmxvYWRlckNsaWVudCgpKS0+Y2xpZW50KCkuYmFzZS5jbGllbnRJbmZv OworICAgIHJldHVybiBicm93c2luZ0NvbnRleHRDb250cm9sbGVyTWFwKCkuZ2V0KHRvSW1wbChw YWdlUmVmKSk7CiB9CiAKIEBlbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVySW50ZXJuYWwuaCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVy SW50ZXJuYWwuaAppbmRleCBjYjM2MTY0NzMyNzU2NjdiYTZjNGNiMWZkYzhlNDE4YTZkYTIyOTRm Li4wMjcxZjVjZGM5NmMwNTJjZDA4MWYwODM0ODRkMjA0YjIyYTQ0OTM4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLQnJvd3NpbmdDb250ZXh0Q29udHJv bGxlckludGVybmFsLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9X S0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXJJbnRlcm5hbC5oCkBAIC0yNywxMSArMjcsMTAgQEAK IAogI2lmIFdLX0FQSV9FTkFCTEVECiAKLSNpbXBvcnQgIldLT2JqZWN0LmgiCiAjaW1wb3J0ICJX ZWFrT2JqQ1B0ci5oIgogI2ltcG9ydCAiV2ViUGFnZVByb3h5LmgiCiAKLUBpbnRlcmZhY2UgV0tC cm93c2luZ0NvbnRleHRDb250cm9sbGVyICgpIDxXS09iamVjdD4geworQGludGVyZmFjZSBXS0Jy b3dzaW5nQ29udGV4dENvbnRyb2xsZXIgKCkgewogQHBhY2thZ2UKICAgICBXZWJLaXQ6OldlYWtP YmpDUHRyPGlkIDxXS0Jyb3dzaW5nQ29udGV4dEhpc3RvcnlEZWxlZ2F0ZT4+IF9oaXN0b3J5RGVs ZWdhdGU7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKaW5kZXggMGZh YjY0NjFmMmQxM2VmZGU5MTkwN2UyNjhhZTMyYjFkNzA1NzBhMy4uN2FiYjI2Zjk1Zjk1YjczZTA2 ZjdiZGU1ZjQ2OTBkMDVkOWUyYjlkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYlBhZ2VQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdl UHJveHkuaApAQCAtODM0LDggKzgzNCw2IEBAIHB1YmxpYzoKICAgICB2b2lkIGVuZENvbG9yUGlj a2VyKCk7CiAjZW5kaWYKIAotICAgIGNvbnN0IEFQSTo6TG9hZGVyQ2xpZW50KiBsb2FkZXJDbGll bnQoKSB7IHJldHVybiBtX2xvYWRlckNsaWVudC5nZXQoKTsgfQotCiAgICAgV2ViQ29yZTo6SW50 U2l6ZSBtaW5pbXVtTGF5b3V0U2l6ZSgpIGNvbnN0IHsgcmV0dXJuIG1fbWluaW11bUxheW91dFNp emU7IH0KICAgICB2b2lkIHNldE1pbmltdW1MYXlvdXRTaXplKGNvbnN0IFdlYkNvcmU6OkludFNp emUmKTsKIAo=