127574 2014-01-24 12:29:30 -0800 Move MediaQueryMatcher, SelectorFilter to std::unique_ptr 2014-01-25 10:49:40 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble macpherson menard oldest_to_newest 971699 0 zan 2014-01-24 12:29:30 -0800 Move MediaQueryMatcher, SelectorFilter to std::unique_ptr 971701 1 222138 zan 2014-01-24 12:31:13 -0800 Created attachment 222138 Patch 971986 2 222138 zan 2014-01-25 10:49:31 -0800 Comment on attachment 222138 Patch Clearing flags on attachment: 222138 Committed r162772: <http://trac.webkit.org/changeset/162772> 971987 3 zan 2014-01-25 10:49:40 -0800 All reviewed patches have been landed. Closing bug. 222138 2014-01-24 12:31:13 -0800 2014-01-25 10:49:31 -0800 Patch bug-127574-20140124123111.patch text/plain 6269 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyNjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2M5Njk0ZGI0NzZlMThk M2FkMWJmZDhhNjRhZjA1YTM1Y2IxNjZhZi4uOGZhOTYyYThmZWQ3NDc4Y2I3MDI3NGQwZGY3ZTU2 Y2M4NjhhNWJkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE0LTAxLTI0ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAorICAgICAgICBNb3ZlIE1lZGlhUXVl cnlNYXRjaGVyLCBTZWxlY3RvckZpbHRlciB0byBzdGQ6OnVuaXF1ZV9wdHIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzU3NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcGxhY2UgdGhlIHVzZSBvZiBP d25QdHIgYW5kIGFkb3B0UHRyIHdpdGggc3RkOjp1bmlxdWVfcHRyIGFuZCBzdGQ6Om1ha2VfdW5p cXVlCisgICAgICAgIGluIHRoZSBNZWRpYVF1ZXJ5TWF0Y2hlciBhbmQgU2VsZWN0b3JGaWx0ZXIg Y2xhc3Nlcy4KKworICAgICAgICAqIGNzcy9NZWRpYVF1ZXJ5TWF0Y2hlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpNZWRpYVF1ZXJ5TWF0Y2hlcjo6cHJlcGFyZUV2YWx1YXRvcik6CisgICAgICAg IChXZWJDb3JlOjpNZWRpYVF1ZXJ5TWF0Y2hlcjo6ZXZhbHVhdGUpOgorICAgICAgICAoV2ViQ29y ZTo6TWVkaWFRdWVyeU1hdGNoZXI6OmFkZExpc3RlbmVyKToKKyAgICAgICAgKFdlYkNvcmU6Ok1l ZGlhUXVlcnlNYXRjaGVyOjpzdHlsZVJlc29sdmVyQ2hhbmdlZCk6CisgICAgICAgICogY3NzL01l ZGlhUXVlcnlNYXRjaGVyLmg6CisgICAgICAgICogY3NzL1NlbGVjdG9yRmlsdGVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNlbGVjdG9yRmlsdGVyOjpwb3BQYXJlbnRTdGFja0ZyYW1lKToKKyAg ICAgICAgKFdlYkNvcmU6OlNlbGVjdG9yRmlsdGVyOjpzZXR1cFBhcmVudFN0YWNrKToKKyAgICAg ICAgKiBjc3MvU2VsZWN0b3JGaWx0ZXIuaDoKKworMjAxNC0wMS0yNCAgWmFuIERvYmVyc2VrICA8 emRvYmVyc2VrQGlnYWxpYS5jb20+CisKICAgICAgICAgVW5yZXZpZXdlZCBHVEsgYnVpbGQgZml4 IGFmdGVyIHIxNjI2NjMuCiAKICAgICAgICAgKiBwbGF0Zm9ybS9ndGsvU2Nyb2xsVmlld0d0ay5j cHA6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvTWVkaWFRdWVyeU1hdGNoZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlNYXRjaGVyLmNwcAppbmRleCA0NGQ5MDU3 YjE5ZWYxOGM4NmQ5YjQ4MmI5NzZhYzljNTVjOGYyNjQzLi4yMTg0OTI5MmZlZDIyYzJkMDBhZjZl ZDg2Y2EwMzhlNWEyMTRjMTYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvTWVkaWFR dWVyeU1hdGNoZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9NZWRpYVF1ZXJ5TWF0Y2hl ci5jcHAKQEAgLTc1LDcgKzc1LDcgQEAgU3RyaW5nIE1lZGlhUXVlcnlNYXRjaGVyOjptZWRpYVR5 cGUoKSBjb25zdAogICAgIHJldHVybiBtX2RvY3VtZW50LT5mcmFtZSgpLT52aWV3KCktPm1lZGlh VHlwZSgpOwogfQogCi1QYXNzT3duUHRyPE1lZGlhUXVlcnlFdmFsdWF0b3I+IE1lZGlhUXVlcnlN YXRjaGVyOjpwcmVwYXJlRXZhbHVhdG9yKCkgY29uc3QKK3N0ZDo6dW5pcXVlX3B0cjxNZWRpYVF1 ZXJ5RXZhbHVhdG9yPiBNZWRpYVF1ZXJ5TWF0Y2hlcjo6cHJlcGFyZUV2YWx1YXRvcigpIGNvbnN0 CiB7CiAgICAgaWYgKCFtX2RvY3VtZW50IHx8ICFtX2RvY3VtZW50LT5mcmFtZSgpKQogICAgICAg ICByZXR1cm4gbnVsbHB0cjsKQEAgLTg2LDcgKzg2LDcgQEAgUGFzc093blB0cjxNZWRpYVF1ZXJ5 RXZhbHVhdG9yPiBNZWRpYVF1ZXJ5TWF0Y2hlcjo6cHJlcGFyZUV2YWx1YXRvcigpIGNvbnN0CiAK ICAgICBSZWZQdHI8UmVuZGVyU3R5bGU+IHJvb3RTdHlsZSA9IG1fZG9jdW1lbnQtPmVuc3VyZVN0 eWxlUmVzb2x2ZXIoKS5zdHlsZUZvckVsZW1lbnQoZG9jdW1lbnRFbGVtZW50LCAwIC8qZGVmYXVs dFBhcmVudCovLCBEaXNhbGxvd1N0eWxlU2hhcmluZywgTWF0Y2hPbmx5VXNlckFnZW50UnVsZXMp OwogCi0gICAgcmV0dXJuIGFkb3B0UHRyKG5ldyBNZWRpYVF1ZXJ5RXZhbHVhdG9yKG1lZGlhVHlw ZSgpLCBtX2RvY3VtZW50LT5mcmFtZSgpLCByb290U3R5bGUuZ2V0KCkpKTsKKyAgICByZXR1cm4g c3RkOjptYWtlX3VuaXF1ZTxNZWRpYVF1ZXJ5RXZhbHVhdG9yPihtZWRpYVR5cGUoKSwgbV9kb2N1 bWVudC0+ZnJhbWUoKSwgcm9vdFN0eWxlLmdldCgpKTsKIH0KIAogYm9vbCBNZWRpYVF1ZXJ5TWF0 Y2hlcjo6ZXZhbHVhdGUoY29uc3QgTWVkaWFRdWVyeVNldCogbWVkaWEpCkBAIC05NCw3ICs5NCw3 IEBAIGJvb2wgTWVkaWFRdWVyeU1hdGNoZXI6OmV2YWx1YXRlKGNvbnN0IE1lZGlhUXVlcnlTZXQq IG1lZGlhKQogICAgIGlmICghbWVkaWEpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIE93 blB0cjxNZWRpYVF1ZXJ5RXZhbHVhdG9yPiBldmFsdWF0b3IocHJlcGFyZUV2YWx1YXRvcigpKTsK KyAgICBzdGQ6OnVuaXF1ZV9wdHI8TWVkaWFRdWVyeUV2YWx1YXRvcj4gZXZhbHVhdG9yID0gcHJl cGFyZUV2YWx1YXRvcigpOwogICAgIHJldHVybiBldmFsdWF0b3IgJiYgZXZhbHVhdG9yLT5ldmFs KG1lZGlhKTsKIH0KIApAQCAtMTIxLDcgKzEyMSw3IEBAIHZvaWQgTWVkaWFRdWVyeU1hdGNoZXI6 OmFkZExpc3RlbmVyKFBhc3NSZWZQdHI8TWVkaWFRdWVyeUxpc3RMaXN0ZW5lcj4gbGlzdGVuZXIs CiAgICAgICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgbV9saXN0ZW5lcnMuYXBwZW5kKGFk b3B0UHRyKG5ldyBMaXN0ZW5lcihsaXN0ZW5lciwgcXVlcnkpKSk7CisgICAgbV9saXN0ZW5lcnMu YXBwZW5kKHN0ZDo6bWFrZV91bmlxdWU8TGlzdGVuZXI+KGxpc3RlbmVyLCBxdWVyeSkpOwogfQog CiB2b2lkIE1lZGlhUXVlcnlNYXRjaGVyOjpyZW1vdmVMaXN0ZW5lcihNZWRpYVF1ZXJ5TGlzdExp c3RlbmVyKiBsaXN0ZW5lciwgTWVkaWFRdWVyeUxpc3QqIHF1ZXJ5KQpAQCAtMTQyLDcgKzE0Miw3 IEBAIHZvaWQgTWVkaWFRdWVyeU1hdGNoZXI6OnN0eWxlUmVzb2x2ZXJDaGFuZ2VkKCkKICAgICBB U1NFUlQobV9kb2N1bWVudCk7CiAKICAgICArK21fZXZhbHVhdGlvblJvdW5kOwotICAgIE93blB0 cjxNZWRpYVF1ZXJ5RXZhbHVhdG9yPiBldmFsdWF0b3IgPSBwcmVwYXJlRXZhbHVhdG9yKCk7Cisg ICAgc3RkOjp1bmlxdWVfcHRyPE1lZGlhUXVlcnlFdmFsdWF0b3I+IGV2YWx1YXRvciA9IHByZXBh cmVFdmFsdWF0b3IoKTsKICAgICBpZiAoIWV2YWx1YXRvcikKICAgICAgICAgcmV0dXJuOwogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvTWVkaWFRdWVyeU1hdGNoZXIuaCBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9NZWRpYVF1ZXJ5TWF0Y2hlci5oCmluZGV4IGYyZWM2YTVkYmUyYTliOTlj NmU0ZjQ1NWQ0OWUwMmNlM2EzOTllNGYuLjRkNTQ5Yjk2YTE0M2E0ZjVlMDhmNTllYzEwZTRiY2Nm NTRmYTQ1MTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9NZWRpYVF1ZXJ5TWF0Y2hl ci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9NZWRpYVF1ZXJ5TWF0Y2hlci5oCkBAIC0yMCw2 ICsyMCw3IEBACiAjaWZuZGVmIE1lZGlhUXVlcnlNYXRjaGVyX2gKICNkZWZpbmUgTWVkaWFRdWVy eU1hdGNoZXJfaAogCisjaW5jbHVkZSA8bWVtb3J5PgogI2luY2x1ZGUgPHd0Zi9Gb3J3YXJkLmg+ CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CkBA IC02OSwxMSArNzAsMTEgQEAgcHJpdmF0ZToKICAgICB9OwogCiAgICAgTWVkaWFRdWVyeU1hdGNo ZXIoRG9jdW1lbnQqKTsKLSAgICBQYXNzT3duUHRyPE1lZGlhUXVlcnlFdmFsdWF0b3I+IHByZXBh cmVFdmFsdWF0b3IoKSBjb25zdDsKKyAgICBzdGQ6OnVuaXF1ZV9wdHI8TWVkaWFRdWVyeUV2YWx1 YXRvcj4gcHJlcGFyZUV2YWx1YXRvcigpIGNvbnN0OwogICAgIFN0cmluZyBtZWRpYVR5cGUoKSBj b25zdDsKIAogICAgIERvY3VtZW50KiBtX2RvY3VtZW50OwotICAgIFZlY3RvcjxPd25QdHI8TGlz dGVuZXI+PiBtX2xpc3RlbmVyczsKKyAgICBWZWN0b3I8c3RkOjp1bmlxdWVfcHRyPExpc3RlbmVy Pj4gbV9saXN0ZW5lcnM7CiAKICAgICAvLyBUaGlzIHZhbHVlIGlzIGluY3JlbWVudGVkIGF0IHN0 eWxlIHNlbGVjdG9yIGNoYW5nZXMuCiAgICAgLy8gSXQgaXMgdXNlZCB0byBhdm9pZCBldmFsdWF0 aW5nIHF1ZXJpZXMgbW9yZSB0aGVuIG9uY2UgYW5kIHRvIG1ha2Ugc3VyZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yRmlsdGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9TZWxlY3RvckZpbHRlci5jcHAKaW5kZXggZWM3ZjNkMDk5ZDM0ZDJjOTRiMWVmY2M1YzZkZmM4 OWYyYjY5YjI4Ni4uMmZhNWQwM2FlNDQzYmEzZjI3ZmUyNzc2NGMwOGQ3MTAxM2Q2OWNlOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yRmlsdGVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JGaWx0ZXIuY3BwCkBAIC03Nyw3ICs3Nyw3IEBAIHZvaWQg U2VsZWN0b3JGaWx0ZXI6OnBvcFBhcmVudFN0YWNrRnJhbWUoKQogICAgIG1fcGFyZW50U3RhY2su cmVtb3ZlTGFzdCgpOwogICAgIGlmIChtX3BhcmVudFN0YWNrLmlzRW1wdHkoKSkgewogICAgICAg ICBBU1NFUlQobV9hbmNlc3RvcklkZW50aWZpZXJGaWx0ZXItPmxpa2VseUVtcHR5KCkpOwotICAg ICAgICBtX2FuY2VzdG9ySWRlbnRpZmllckZpbHRlci5jbGVhcigpOworICAgICAgICBtX2FuY2Vz dG9ySWRlbnRpZmllckZpbHRlciA9IG51bGxwdHI7CiAgICAgfQogfQogCkBAIC04Niw3ICs4Niw3 IEBAIHZvaWQgU2VsZWN0b3JGaWx0ZXI6OnNldHVwUGFyZW50U3RhY2soRWxlbWVudCogcGFyZW50 KQogICAgIEFTU0VSVChtX3BhcmVudFN0YWNrLmlzRW1wdHkoKSA9PSAhbV9hbmNlc3RvcklkZW50 aWZpZXJGaWx0ZXIpOwogICAgIC8vIEtpbGwgd2hhdGV2ZXIgd2Ugc3RvcmVkIGJlZm9yZS4KICAg ICBtX3BhcmVudFN0YWNrLnNocmluaygwKTsKLSAgICBtX2FuY2VzdG9ySWRlbnRpZmllckZpbHRl ciA9IGFkb3B0UHRyKG5ldyBCbG9vbUZpbHRlcjxibG9vbUZpbHRlcktleUJpdHM+KTsKKyAgICBt X2FuY2VzdG9ySWRlbnRpZmllckZpbHRlciA9IHN0ZDo6bWFrZV91bmlxdWU8Qmxvb21GaWx0ZXI8 Ymxvb21GaWx0ZXJLZXlCaXRzPj4oKTsKICAgICAvLyBGYXN0IHZlcnNpb24gaWYgcGFyZW50IGlz IGEgcm9vdCBlbGVtZW50OgogICAgIGlmICghcGFyZW50LT5wYXJlbnROb2RlKCkgJiYgIXBhcmVu dC0+aXNTaGFkb3dSb290KCkpIHsKICAgICAgICAgcHVzaFBhcmVudFN0YWNrRnJhbWUocGFyZW50 KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckZpbHRlci5oIGIvU291 cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yRmlsdGVyLmgKaW5kZXggY2Y5YzBlMDNjZDE5MjAyMWI0 OGVhMzFiYjQ4MWMxZDEzY2I0MzgxZi4uYTU5ZTJjYzQyOTBlYjA5MDYyMzE2NGYyNDNmNWVmYTZk NWFlNWU4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yRmlsdGVyLmgK KysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yRmlsdGVyLmgKQEAgLTMwLDYgKzMwLDcg QEAKICNkZWZpbmUgU2VsZWN0b3JGaWx0ZXJfaAogCiAjaW5jbHVkZSAiRWxlbWVudC5oIgorI2lu Y2x1ZGUgPG1lbW9yeT4KICNpbmNsdWRlIDx3dGYvQmxvb21GaWx0ZXIuaD4KICNpbmNsdWRlIDx3 dGYvVmVjdG9yLmg+CiAKQEAgLTYzLDcgKzY0LDcgQEAgcHJpdmF0ZToKIAogICAgIC8vIFdpdGgg MTAwIHVuaXF1ZSBzdHJpbmdzIGluIHRoZSBmaWx0ZXIsIDJeMTIgc2xvdCB0YWJsZSBoYXMgZmFs c2UgcG9zaXRpdmUgcmF0ZSBvZiB+MC4yJS4KICAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgYmxv b21GaWx0ZXJLZXlCaXRzID0gMTI7Ci0gICAgT3duUHRyPEJsb29tRmlsdGVyPGJsb29tRmlsdGVy S2V5Qml0cz4+IG1fYW5jZXN0b3JJZGVudGlmaWVyRmlsdGVyOworICAgIHN0ZDo6dW5pcXVlX3B0 cjxCbG9vbUZpbHRlcjxibG9vbUZpbHRlcktleUJpdHM+PiBtX2FuY2VzdG9ySWRlbnRpZmllckZp bHRlcjsKIH07CiAKIHRlbXBsYXRlIDx1bnNpZ25lZCBtYXhpbXVtSWRlbnRpZmllckNvdW50Pgo=