127570 2014-01-24 11:25:18 -0800 Move StyleProperties, StyleResolver to std::unique_ptr 2014-01-25 10:46:58 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan allan.jensen commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard oldest_to_newest 971670 0 zan 2014-01-24 11:25:18 -0800 Move StyleProperties, StyleResolver to std::unique_ptr 971685 1 222132 zan 2014-01-24 12:01:16 -0800 Created attachment 222132 Patch 971981 2 222132 zan 2014-01-25 10:46:51 -0800 Comment on attachment 222132 Patch Clearing flags on attachment: 222132 Committed r162770: <http://trac.webkit.org/changeset/162770> 971982 3 zan 2014-01-25 10:46:58 -0800 All reviewed patches have been landed. Closing bug. 222132 2014-01-24 12:01:16 -0800 2014-01-25 10:46:51 -0800 Patch bug-127570-20140124120109.patch text/plain 7094 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyNjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2M5Njk0ZGI0NzZlMThk M2FkMWJmZDhhNjRhZjA1YTM1Y2IxNjZhZi4uY2ZjOTlkYjBhYjU0YmM4Y2IxMmMzNTk1NzQ4MjE5 YWM3M2RmN2RhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE0LTAxLTI0ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAorICAgICAgICBNb3ZlIFN0eWxlUHJv cGVydGllcywgU3R5bGVSZXNvbHZlciB0byBzdGQ6OnVuaXF1ZV9wdHIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzU3MAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgdGhlIFN0eWxlUHJvcGVydGll cyBhbmQgU3R5bGVSZXNvbHZlciBjbGFzc2VzIGZyb20gdXNpbmcgT3duUHRyIGFuZCBhZG9wdFB0 cgorICAgICAgICB0byB1c2luZyBzdGQ6OnVuaXF1ZV9wdHIgYW5kIHN0ZDo6bWFrZV91bmlxdWUu CisKKyAgICAgICAgKiBjc3MvU3R5bGVJbnZhbGlkYXRpb25BbmFseXNpcy5oOiBSZW1vdmUgdGhl IFBhc3NPd25QdHIuaCBoZWFkZXIgaW5jbHVzaW9uLgorICAgICAgICAqIGNzcy9TdHlsZVByb3Bl cnRpZXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TXV0YWJsZVN0eWxlUHJvcGVydGllczo6ZW5z dXJlQ1NTU3R5bGVEZWNsYXJhdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpNdXRhYmxlU3R5bGVQ cm9wZXJ0aWVzOjplbnN1cmVJbmxpbmVDU1NTdHlsZURlY2xhcmF0aW9uKToKKyAgICAgICAgKiBj c3MvU3R5bGVQcm9wZXJ0aWVzLmg6CisgICAgICAgICogY3NzL1N0eWxlUmVzb2x2ZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U3R5bGVSZXNvbHZlcjo6U3R5bGVSZXNvbHZlcik6CisgICAgICAg IChXZWJDb3JlOjpTdHlsZVJlc29sdmVyOjphZGRWaWV3cG9ydERlcGVuZGVudE1lZGlhUXVlcnlS ZXN1bHQpOgorICAgICAgICAqIGNzcy9TdHlsZVJlc29sdmVyLmg6CisgICAgICAgICogY3NzL1N0 eWxlU2NvcGVSZXNvbHZlci5oOgorCisyMDE0LTAxLTI0ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJz ZWtAaWdhbGlhLmNvbT4KKwogICAgICAgICBVbnJldmlld2VkIEdUSyBidWlsZCBmaXggYWZ0ZXIg cjE2MjY2My4KIAogICAgICAgICAqIHBsYXRmb3JtL2d0ay9TY3JvbGxWaWV3R3RrLmNwcDoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZUludmFsaWRhdGlvbkFuYWx5c2lzLmgg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVJbnZhbGlkYXRpb25BbmFseXNpcy5oCmluZGV4IGUz MTY2NjMxYzBiZmJkYmRjNGZlYTc2YTg2ZDUxY2ZjOWRjMWJjYTIuLmNiMjQyZDI1M2UxYmIwNTcw NzYyZGYzYjYwN2Q4ODMwNDgwMDMwNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9T dHlsZUludmFsaWRhdGlvbkFuYWx5c2lzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxl SW52YWxpZGF0aW9uQW5hbHlzaXMuaApAQCAtMjcsNyArMjcsNiBAQAogI2RlZmluZSBTdHlsZUlu dmFsaWRhdGlvbkFuYWx5c2lzX2gKIAogI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+Ci0jaW5jbHVk ZSA8d3RmL1Bhc3NPd25QdHIuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9BdG9taWNTdHJpbmdJbXBs Lmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9TdHlsZVByb3BlcnRpZXMuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydGll cy5jcHAKaW5kZXggMzJhM2FmYWM0MjNmZDZhNDllYmEwZmUwMTdkYmEzYjJhMmJjNDhkYi4uOWMx NGUwZDkzNmFkNGExYmMxNWJmMjgyNDg0MGQzZGU4YzFjNGQwZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydGllcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L1N0eWxlUHJvcGVydGllcy5jcHAKQEAgLTEyMTIsNyArMTIxMiw3IEBAIENTU1N0eWxlRGVjbGFy YXRpb24qIE11dGFibGVTdHlsZVByb3BlcnRpZXM6OmVuc3VyZUNTU1N0eWxlRGVjbGFyYXRpb24o KQogICAgICAgICBBU1NFUlQoIW1fY3Nzb21XcmFwcGVyLT5wYXJlbnRFbGVtZW50KCkpOwogICAg ICAgICByZXR1cm4gbV9jc3NvbVdyYXBwZXIuZ2V0KCk7CiAgICAgfQotICAgIG1fY3Nzb21XcmFw cGVyID0gYWRvcHRQdHIobmV3IFByb3BlcnR5U2V0Q1NTU3R5bGVEZWNsYXJhdGlvbih0aGlzKSk7 CisgICAgbV9jc3NvbVdyYXBwZXIgPSBzdGQ6Om1ha2VfdW5pcXVlPFByb3BlcnR5U2V0Q1NTU3R5 bGVEZWNsYXJhdGlvbj4odGhpcyk7CiAgICAgcmV0dXJuIG1fY3Nzb21XcmFwcGVyLmdldCgpOwog fQogCkBAIC0xMjIyLDcgKzEyMjIsNyBAQCBDU1NTdHlsZURlY2xhcmF0aW9uKiBNdXRhYmxlU3R5 bGVQcm9wZXJ0aWVzOjplbnN1cmVJbmxpbmVDU1NTdHlsZURlY2xhcmF0aW9uKFN0eQogICAgICAg ICBBU1NFUlQobV9jc3NvbVdyYXBwZXItPnBhcmVudEVsZW1lbnQoKSA9PSBwYXJlbnRFbGVtZW50 KTsKICAgICAgICAgcmV0dXJuIG1fY3Nzb21XcmFwcGVyLmdldCgpOwogICAgIH0KLSAgICBtX2Nz c29tV3JhcHBlciA9IGFkb3B0UHRyKG5ldyBJbmxpbmVDU1NTdHlsZURlY2xhcmF0aW9uKHRoaXMs IHBhcmVudEVsZW1lbnQpKTsKKyAgICBtX2Nzc29tV3JhcHBlciA9IHN0ZDo6bWFrZV91bmlxdWU8 SW5saW5lQ1NTU3R5bGVEZWNsYXJhdGlvbj4odGhpcywgcGFyZW50RWxlbWVudCk7CiAgICAgcmV0 dXJuIG1fY3Nzb21XcmFwcGVyLmdldCgpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvU3R5bGVQcm9wZXJ0aWVzLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0 aWVzLmgKaW5kZXggZWVjNTU5N2EwZmQ4YTdkNjFiZmYyYmFhNjQzZGFlNDk0MWRhNTAxMi4uNzAw MjRhMzNmNTc5YTQ4ZTlmMTczNWI0MzY2YmNhZmIyYTJhNzc4ZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydGllcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9T dHlsZVByb3BlcnRpZXMuaApAQCAtMjcsNiArMjcsNyBAQAogI2luY2x1ZGUgIkNTU1Byb3BlcnR5 LmgiCiAjaW5jbHVkZSAiQ1NTUHJvcGVydHlOYW1lcy5oIgogI2luY2x1ZGUgIkNTU1ZhbHVlS2V5 d29yZHMuaCIKKyNpbmNsdWRlIDxtZW1vcnk+CiAjaW5jbHVkZSA8d3RmL0xpc3RIYXNoU2V0Lmg+ CiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5o PgpAQCAtMjMwLDcgKzIzMSw3IEBAIHByaXZhdGU6CiAKICAgICBib29sIHJlbW92ZVNob3J0aGFu ZFByb3BlcnR5KENTU1Byb3BlcnR5SUQpOwogICAgIENTU1Byb3BlcnR5KiBmaW5kQ1NTUHJvcGVy dHlXaXRoSUQoQ1NTUHJvcGVydHlJRCk7Ci0gICAgT3duUHRyPFByb3BlcnR5U2V0Q1NTU3R5bGVE ZWNsYXJhdGlvbj4gbV9jc3NvbVdyYXBwZXI7CisgICAgc3RkOjp1bmlxdWVfcHRyPFByb3BlcnR5 U2V0Q1NTU3R5bGVEZWNsYXJhdGlvbj4gbV9jc3NvbVdyYXBwZXI7CiAKICAgICBmcmllbmQgY2xh c3MgU3R5bGVQcm9wZXJ0aWVzOwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9T dHlsZVJlc29sdmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcApp bmRleCBmZWEwNzQ5ODE5NWI5ZjcwOThkNDc1NjZjNjUxZWE3ODdlODg5YWNkLi5mOGEwMmZjOWFm NzBmMWZjMDQwZjc5MGFiOGY2OGYxNWMwNTc2ODI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVz b2x2ZXIuY3BwCkBAIC0yNzcsMTUgKzI3NywxNSBAQCBTdHlsZVJlc29sdmVyOjpTdHlsZVJlc29s dmVyKERvY3VtZW50JiBkb2N1bWVudCwgYm9vbCBtYXRjaEF1dGhvckFuZFVzZXJTdHlsZXMpCiAg ICAgLy8gaXMgYWx3YXlzIGZyb20gdGhlIGRvY3VtZW50IHRoYXQgb3ducyB0aGUgc3R5bGUgc2Vs ZWN0b3IKICAgICBGcmFtZVZpZXcqIHZpZXcgPSBtX2RvY3VtZW50LnZpZXcoKTsKICAgICBpZiAo dmlldykKLSAgICAgICAgbV9tZWRpdW0gPSBhZG9wdFB0cihuZXcgTWVkaWFRdWVyeUV2YWx1YXRv cih2aWV3LT5tZWRpYVR5cGUoKSkpOworICAgICAgICBtX21lZGl1bSA9IHN0ZDo6bWFrZV91bmlx dWU8TWVkaWFRdWVyeUV2YWx1YXRvcj4odmlldy0+bWVkaWFUeXBlKCkpOwogICAgIGVsc2UKLSAg ICAgICAgbV9tZWRpdW0gPSBhZG9wdFB0cihuZXcgTWVkaWFRdWVyeUV2YWx1YXRvcigiYWxsIikp OworICAgICAgICBtX21lZGl1bSA9IHN0ZDo6bWFrZV91bmlxdWU8TWVkaWFRdWVyeUV2YWx1YXRv cj4oImFsbCIpOwogCiAgICAgaWYgKHJvb3QpCiAgICAgICAgIG1fcm9vdERlZmF1bHRTdHlsZSA9 IHN0eWxlRm9yRWxlbWVudChyb290LCAwLCBEaXNhbGxvd1N0eWxlU2hhcmluZywgTWF0Y2hPbmx5 VXNlckFnZW50UnVsZXMpOwogCiAgICAgaWYgKG1fcm9vdERlZmF1bHRTdHlsZSAmJiB2aWV3KQot ICAgICAgICBtX21lZGl1bSA9IGFkb3B0UHRyKG5ldyBNZWRpYVF1ZXJ5RXZhbHVhdG9yKHZpZXct Pm1lZGlhVHlwZSgpLCAmdmlldy0+ZnJhbWUoKSwgbV9yb290RGVmYXVsdFN0eWxlLmdldCgpKSk7 CisgICAgICAgIG1fbWVkaXVtID0gc3RkOjptYWtlX3VuaXF1ZTxNZWRpYVF1ZXJ5RXZhbHVhdG9y Pih2aWV3LT5tZWRpYVR5cGUoKSwgJnZpZXctPmZyYW1lKCksIG1fcm9vdERlZmF1bHRTdHlsZS5n ZXQoKSk7CiAKICAgICBtX3J1bGVTZXRzLnJlc2V0QXV0aG9yU3R5bGUoKTsKIApAQCAtMzMzMiw3 ICszMzMyLDcgQEAgQ29sb3IgU3R5bGVSZXNvbHZlcjo6Y29sb3JGcm9tUHJpbWl0aXZlVmFsdWUo Q1NTUHJpbWl0aXZlVmFsdWUqIHZhbHVlLCBib29sIGZvclYKIAogdm9pZCBTdHlsZVJlc29sdmVy OjphZGRWaWV3cG9ydERlcGVuZGVudE1lZGlhUXVlcnlSZXN1bHQoY29uc3QgTWVkaWFRdWVyeUV4 cCogZXhwciwgYm9vbCByZXN1bHQpCiB7Ci0gICAgbV92aWV3cG9ydERlcGVuZGVudE1lZGlhUXVl cnlSZXN1bHRzLmFwcGVuZChhZG9wdFB0cihuZXcgTWVkaWFRdWVyeVJlc3VsdCgqZXhwciwgcmVz dWx0KSkpOworICAgIG1fdmlld3BvcnREZXBlbmRlbnRNZWRpYVF1ZXJ5UmVzdWx0cy5hcHBlbmQo c3RkOjptYWtlX3VuaXF1ZTxNZWRpYVF1ZXJ5UmVzdWx0PigqZXhwciwgcmVzdWx0KSk7CiB9CiAK IGJvb2wgU3R5bGVSZXNvbHZlcjo6YWZmZWN0ZWRCeVZpZXdwb3J0Q2hhbmdlKCkgY29uc3QKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmggYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvU3R5bGVSZXNvbHZlci5oCmluZGV4IDZhMmMyZmYzMjY3NGMwZTVhZjIwMmMwOTFl YmI5MjljYTM5YWExZmEuLmVhYTJkOThmNTUzNWE5MTU2M2IyN2VlMDliMTc5MDEwZjQ3NTVmOTAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuaApAQCAtMzgsNiArMzgsNyBAQAogI2luY2x1 ZGUgIlN0eWxlSW5oZXJpdGVkRGF0YS5oIgogI2luY2x1ZGUgIlN0eWxlU2NvcGVSZXNvbHZlci5o IgogI2luY2x1ZGUgIlZpZXdwb3J0U3R5bGVSZXNvbHZlci5oIgorI2luY2x1ZGUgPG1lbW9yeT4K ICNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgogI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+CiAjaW5j bHVkZSA8d3RmL1JlZlB0ci5oPgpAQCAtMTgzLDcgKzE4NCw3IEBAIHB1YmxpYzoKICAgICB7CiAg ICAgICAgIEFTU0VSVChSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJlcygpLnNo YWRvd0RPTUVuYWJsZWQoKSk7CiAgICAgICAgIGlmICghbV9zY29wZVJlc29sdmVyKQotICAgICAg ICAgICAgbV9zY29wZVJlc29sdmVyID0gYWRvcHRQdHIobmV3IFN0eWxlU2NvcGVSZXNvbHZlcigp KTsKKyAgICAgICAgICAgIG1fc2NvcGVSZXNvbHZlciA9IHN0ZDo6bWFrZV91bmlxdWU8U3R5bGVT Y29wZVJlc29sdmVyPigpOwogICAgICAgICByZXR1cm4gbV9zY29wZVJlc29sdmVyLmdldCgpOwog ICAgIH0KICNlbmRpZgpAQCAtNTI3LDcgKzUyOCw3IEBAIHByaXZhdGU6CiAKICAgICBUaW1lcjxT dHlsZVJlc29sdmVyPiBtX21hdGNoZWRQcm9wZXJ0aWVzQ2FjaGVTd2VlcFRpbWVyOwogCi0gICAg T3duUHRyPE1lZGlhUXVlcnlFdmFsdWF0b3I+IG1fbWVkaXVtOworICAgIHN0ZDo6dW5pcXVlX3B0 cjxNZWRpYVF1ZXJ5RXZhbHVhdG9yPiBtX21lZGl1bTsKICAgICBSZWZQdHI8UmVuZGVyU3R5bGU+ IG1fcm9vdERlZmF1bHRTdHlsZTsKIAogICAgIERvY3VtZW50JiBtX2RvY3VtZW50OwpAQCAtNTM2 LDcgKzUzNyw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX21hdGNoQXV0aG9yQW5kVXNlclN0eWxl czsKIAogICAgIFJlZlB0cjxDU1NGb250U2VsZWN0b3I+IG1fZm9udFNlbGVjdG9yOwotICAgIFZl Y3RvcjxPd25QdHI8TWVkaWFRdWVyeVJlc3VsdD4+IG1fdmlld3BvcnREZXBlbmRlbnRNZWRpYVF1 ZXJ5UmVzdWx0czsKKyAgICBWZWN0b3I8c3RkOjp1bmlxdWVfcHRyPE1lZGlhUXVlcnlSZXN1bHQ+ PiBtX3ZpZXdwb3J0RGVwZW5kZW50TWVkaWFRdWVyeVJlc3VsdHM7CiAKICNpZiBFTkFCTEUoQ1NT X0RFVklDRV9BREFQVEFUSU9OKQogICAgIFJlZlB0cjxWaWV3cG9ydFN0eWxlUmVzb2x2ZXI+IG1f dmlld3BvcnRTdHlsZVJlc29sdmVyOwpAQCAtNTQ0LDcgKzU0NSw3IEBAIHByaXZhdGU6CiAKICAg ICBjb25zdCBEZXByZWNhdGVkU3R5bGVCdWlsZGVyJiBtX2RlcHJlY2F0ZWRTdHlsZUJ1aWxkZXI7 CiAKLSAgICBPd25QdHI8U3R5bGVTY29wZVJlc29sdmVyPiBtX3Njb3BlUmVzb2x2ZXI7CisgICAg c3RkOjp1bmlxdWVfcHRyPFN0eWxlU2NvcGVSZXNvbHZlcj4gbV9zY29wZVJlc29sdmVyOwogICAg IENTU1RvU3R5bGVNYXAgbV9zdHlsZU1hcDsKICAgICBJbnNwZWN0b3JDU1NPTVdyYXBwZXJzIG1f aW5zcGVjdG9yQ1NTT01XcmFwcGVyczsKIAo=