127566 2014-01-24 10:39:31 -0800 fast/profiler tests ASSERTing after moving recompileAllJSFunctions off a timer 2014-01-24 13:31:40 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned dbates ggaren joepeck mark.lam timothy oldest_to_newest 971646 0 joepeck 2014-01-24 10:39:31 -0800 http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r162690%20(2192)/results.html Another internal method causing recompilation within a JS stack: window.internals.setJavaScriptProfilingEnabled(bool) This Enables/Disables the Profiler which now recompiles synchronously within a JS stack. I can add a timer here in window.internals and do this after a loop. But its looking more and more like it might be better if the VM handled recompiling when appropriate instead of us trying to avoid calling it within a JS stack. 971667 1 ggaren 2014-01-24 11:19:51 -0800 OK. 971674 2 222128 joepeck 2014-01-24 11:35:49 -0800 Created attachment 222128 [PATCH] Naive Approach - Does not work running multiple tests The naive approach of just making window.internals.setJavaScriptProfilerEnabled did not work. shell> Tools/Scripts/run-webkit-tests --debug fast/profiler/anonymous-event-handler.html PASS shell> Tools/Scripts/run-webkit-tests --debug fast/profiler/anonymous-event-handler.html --iterations=2 FAILs I could spend some more time looking into this, but we've already tried to work around it twice. I think it might be better for the JSC VM to handle recompiling when appropriate. No timers involved. 971675 3 joepeck 2014-01-24 11:36:15 -0800 > The naive approach of just making window.internals.setJavaScriptProfilerEnabled did not work. window.internals.setJavaScriptProfilerEnabled *use a timer* did not work. 971684 4 222131 joepeck 2014-01-24 12:00:56 -0800 Created attachment 222131 [PATCH] Proposed Fix - Let the VM manage recompilation Suggestions on how I should measure the performance of this? 971689 5 222131 oliver 2014-01-24 12:03:25 -0800 Comment on attachment 222131 [PATCH] Proposed Fix - Let the VM manage recompilation View in context: https://bugs.webkit.org/attachment.cgi?id=222131&action=review > Source/JavaScriptCore/runtime/VMEntryScope.cpp:66 > + if (UNLIKELY(m_recompilationNeeded)) { You can't do this unless .entryScope is null. Otherwise you have to set the parent's entry scope recompile flag. 971690 6 222131 joepeck 2014-01-24 12:05:55 -0800 Comment on attachment 222131 [PATCH] Proposed Fix - Let the VM manage recompilation View in context: https://bugs.webkit.org/attachment.cgi?id=222131&action=review >> Source/JavaScriptCore/runtime/VMEntryScope.cpp:66 >> + if (UNLIKELY(m_recompilationNeeded)) { > > You can't do this unless .entryScope is null. Otherwise you have to set the parent's entry scope recompile flag. The next line ASSERTs that. 971694 7 222134 joepeck 2014-01-24 12:16:29 -0800 Created attachment 222134 [PATCH] Proposed Fix - Let VM manage recompilation More straightforward approach, instead of just adjusting the topEntryScope. 971731 8 joepeck 2014-01-24 13:31:40 -0800 Landed <http://trac.webkit.org/changeset/162720>. 222128 2014-01-24 11:35:49 -0800 2014-01-24 12:00:56 -0800 [PATCH] Naive Approach - Does not work running multiple tests naive-approach.patch text/plain 2627 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAppbmRleCA3MzkwYzJkLi4xOTk4Yzk2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCkBAIC02NCw4ICs2NCw4IEBACiAjaW5j bHVkZSAiSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uLmgiCiAjaW5jbHVkZSAiSW5zcGVjdG9yT3Zl cmxheS5oIgogI2luY2x1ZGUgIkluc3RydW1lbnRpbmdBZ2VudHMuaCIKLSNpbmNsdWRlICJJbnRl cm5hbFNldHRpbmdzLmgiCiAjaW5jbHVkZSAiSW50UmVjdC5oIgorI2luY2x1ZGUgIkludGVybmFs U2V0dGluZ3MuaCIKICNpbmNsdWRlICJMYW5ndWFnZS5oIgogI2luY2x1ZGUgIk1haW5GcmFtZS5o IgogI2luY2x1ZGUgIk1hbGxvY1N0YXRpc3RpY3MuaCIKQEAgLTI5NSw2ICsyOTUsOCBAQCB2b2lk IEludGVybmFsczo6cmVzZXRUb0NvbnNpc3RlbnRTdGF0ZShQYWdlKiBwYWdlKQogCiBJbnRlcm5h bHM6OkludGVybmFscyhEb2N1bWVudCogZG9jdW1lbnQpCiAgICAgOiBDb250ZXh0RGVzdHJ1Y3Rp b25PYnNlcnZlcihkb2N1bWVudCkKKyAgICAsIG1fZW5hYmxlUHJvZmlsZXIoZmFsc2UpCisgICAg LCBtX2VuYWJsZVByb2ZpbGVyVGltZXIodGhpcywgJkludGVybmFsczo6ZW5hYmxlUHJvZmlsZXJU aW1lckZpcmVkKQogewogI2lmIEVOQUJMRShWSURFT19UUkFDSykgJiYgIVBMQVRGT1JNKFdJTikK ICAgICBpZiAoZG9jdW1lbnQgJiYgZG9jdW1lbnQtPnBhZ2UoKSkKQEAgLTE0OTIsNyArMTQ5NCwy MSBAQCB2b2lkIEludGVybmFsczo6c2V0SmF2YVNjcmlwdFByb2ZpbGluZ0VuYWJsZWQoYm9vbCBl bmFibGVkLCBFeGNlcHRpb25Db2RlJiBlYykKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAg IHBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKS5zZXRQcm9maWxlckVuYWJsZWQoZW5hYmxlZCk7 CisgICAgLy8gRW5hYmxpbmcgdGhlIHByb2ZpbGVyIHdpbGwgc3luY2hyb25vdXNseSB0cnkgdG8g cmVjb21waWxlIEphdmFTY3JpcHQgZnVuY3Rpb25zLgorICAgIC8vIFRoYXQgY2Fubm90IGJlIGRv bmUgd2hpbGUgaW5zaWRlIG9mIGFuIGV4aXN0aW5nIEphdmFTY3JpcHQgZXhlY3V0aW9uIHN0YWNr LgorICAgIC8vIFNpbmNlIHRoaXMgd2luZG93LmludGVybmFscyBjYWxsIGlzIGNhbGxlZCB0aHJv dWdoIEphdmFTY3JpcHQsIGluc3RlYWQgZG8gdGhlCisgICAgLy8gcHJvZmlsZXIgaW5pdGlhbGl6 YXRpb24gb24gYSB0aW1lci4KKyAgICBtX2VuYWJsZVByb2ZpbGVyID0gZW5hYmxlZDsKKyAgICBt X2VuYWJsZVByb2ZpbGVyVGltZXIuc3RhcnRPbmVTaG90KDApOworfQorCit2b2lkIEludGVybmFs czo6ZW5hYmxlUHJvZmlsZXJUaW1lckZpcmVkKFRpbWVyPEludGVybmFscz4mKQoreworICAgIFBh Z2UqIHBhZ2UgPSBjb250ZXh0RG9jdW1lbnQoKS0+ZnJhbWUoKS0+cGFnZSgpOworICAgIGlmICgh cGFnZSkKKyAgICAgICAgcmV0dXJuOworCisgICAgcGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigp LnNldFByb2ZpbGVyRW5hYmxlZChtX2VuYWJsZVByb2ZpbGVyKTsKIH0KICNlbmRpZiAvLyBFTkFC TEUoSU5TUEVDVE9SKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVy bmFscy5oIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaAppbmRleCAzYWM4OWY0 Li43NWM5ZjNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmgKQEAgLTMxLDYgKzMxLDcg QEAKICNpbmNsdWRlICJDb250ZXh0RGVzdHJ1Y3Rpb25PYnNlcnZlci5oIgogI2luY2x1ZGUgIkV4 Y2VwdGlvbkNvZGVQbGFjZWhvbGRlci5oIgogI2luY2x1ZGUgIk5vZGVMaXN0LmgiCisjaW5jbHVk ZSAiVGltZXIuaCIKICNpbmNsdWRlIDxiaW5kaW5ncy9TY3JpcHRWYWx1ZS5oPgogI2luY2x1ZGUg PHJ1bnRpbWUvQXJyYXlCdWZmZXIuaD4KICNpbmNsdWRlIDxydW50aW1lL0Zsb2F0MzJBcnJheS5o PgpAQCAtMzM0LDExICszMzUsMTUgQEAgcHJpdmF0ZToKICAgICBGcmFtZSogZnJhbWUoKSBjb25z dDsKICAgICBWZWN0b3I8U3RyaW5nPiBpY29uVVJMcyhEb2N1bWVudCosIGludCBpY29uVHlwZXNN YXNrKSBjb25zdDsKIAorICAgIHZvaWQgZW5hYmxlUHJvZmlsZXJUaW1lckZpcmVkKFRpbWVyPElu dGVybmFscz4mKTsKKwogICAgIERvY3VtZW50TWFya2VyKiBtYXJrZXJBdChOb2RlKiwgY29uc3Qg U3RyaW5nJiBtYXJrZXJUeXBlLCB1bnNpZ25lZCBpbmRleCwgRXhjZXB0aW9uQ29kZSYpOwogI2lm IEVOQUJMRShJTlNQRUNUT1IpCiAgICAgUmVmUHRyPERPTVdpbmRvdz4gbV9mcm9udGVuZFdpbmRv dzsKICAgICBPd25QdHI8SW5zcGVjdG9yRnJvbnRlbmRDaGFubmVsRHVtbXk+IG1fZnJvbnRlbmRD aGFubmVsOwogI2VuZGlmCisgICAgYm9vbCBtX2VuYWJsZVByb2ZpbGVyOworICAgIFRpbWVyPElu dGVybmFscz4gbV9lbmFibGVQcm9maWxlclRpbWVyOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2Vi Q29yZQo= 222131 2014-01-24 12:00:56 -0800 2014-01-24 12:16:29 -0800 [PATCH] Proposed Fix - Let the VM manage recompilation vm.patch text/plain 5723 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDUzNDhiMDMuLjk2ODI1ZDkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE0LTAxLTI0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgZmFzdC9wcm9maWxlciB0ZXN0cyBB U1NFUlRpbmcgYWZ0ZXIgbW92aW5nIHJlY29tcGlsZUFsbEpTRnVuY3Rpb25zIG9mZiBhIHRpbWVy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc1NjYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHRo ZSBWTSBoYW5kbGUgcmVjb21waWxhdGlvbiBhcyBzb29uIGFzIHBvc3NpYmxlIGFmdGVyIGl0IGlz IHJlcXVlc3RlZC4KKworICAgICAgICAqIGRlYnVnZ2VyL0RlYnVnZ2VyLmNwcDoKKyAgICAgICAg KEpTQzo6RGVidWdnZXI6OnJlY29tcGlsZUFsbEpTRnVuY3Rpb25zKToKKyAgICAgICAgV2hlbiBp biBhIEphdmFTY3JpcHQgc3RhY2ssIG1hcmsgdGhlIHRvcCBvZiB0aGUgc3RhY2sgZm9yCisgICAg ICAgIHJlY29tcGlsYXRpb24gd2hlbiBpdCBpcyBwb3BwZWQuCisKKyAgICAgICAgKiBydW50aW1l L1ZNRW50cnlTY29wZS5jcHA6CisgICAgICAgIChKU0M6OlZNRW50cnlTY29wZTo6Vk1FbnRyeVNj b3BlKToKKyAgICAgICAgKEpTQzo6Vk1FbnRyeVNjb3BlOjp+Vk1FbnRyeVNjb3BlKToKKyAgICAg ICAgKEpTQzo6Vk1FbnRyeVNjb3BlOjp0b3BFbnRyeVNjb3BlKToKKyAgICAgICAgKiBydW50aW1l L1ZNRW50cnlTY29wZS5oOgorICAgICAgICAoSlNDOjpWTUVudHJ5U2NvcGU6OnNldFJlY29tcGls YXRpb25OZWVkZWQpOgorICAgICAgICBIYW5kbGUgcmVjb21waWxhdGlvbiB3aGVuIHRoZSB0b3Ag Vk1FbnRyeVNjb3BlIGlzIHBvcHBlZC4KKwogMjAxNC0wMS0yMyAgSm9zZXBoIFBlY29yYXJvICA8 cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgSmF2YVNjcmlwdENhbGxGcmFtZSBh bmQgU2NyaXB0RGVidWdTZXJ2ZXIgaW50byBKYXZhU2NyaXB0Q29yZSBmb3IgaW5zcGVjdG9yCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXIuY3BwIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmNwcAppbmRleCBmMGY5NzBk Li5lYzU5ZDk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVi dWdnZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlci5j cHAKQEAgLTI5MSwxMCArMjkxLDExIEBAIHZvaWQgRGVidWdnZXI6OnJlY29tcGlsZUFsbEpTRnVu Y3Rpb25zKFZNKiB2bSkKIHsKICAgICAvLyBJZiBKYXZhU2NyaXB0IGlzIHJ1bm5pbmcsIGl0J3Mg bm90IHNhZmUgdG8gcmVjb21waWxlLCBzaW5jZSB3ZSdsbCBlbmQKICAgICAvLyB1cCB0aHJvd2lu ZyBhd2F5IGNvZGUgdGhhdCBpcyBsaXZlIG9uIHRoZSBzdGFjay4KLSAgICBBU1NFUlQoIXZtLT5l bnRyeVNjb3BlKTsKLSAgICBpZiAodm0tPmVudHJ5U2NvcGUpCisgICAgaWYgKHZtLT5lbnRyeVNj b3BlKSB7CisgICAgICAgIFZNRW50cnlTY29wZTo6dG9wRW50cnlTY29wZSh2bS0+ZW50cnlTY29w ZSktPnNldFJlY29tcGlsYXRpb25OZWVkZWQodHJ1ZSk7CiAgICAgICAgIHJldHVybjsKLSAgICAK KyAgICB9CisKICAgICB2bS0+cHJlcGFyZVRvRGlzY2FyZENvZGUoKTsKIAogICAgIFJlY29tcGls ZXIgcmVjb21waWxlcih0aGlzKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1ZNRW50cnlTY29wZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9W TUVudHJ5U2NvcGUuY3BwCmluZGV4IDI2YjAwMjguLjc1MjI5MTQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNRW50cnlTY29wZS5jcHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvVk1FbnRyeVNjb3BlLmNwcApAQCAtMjYsNiArMjYsNyBAQAog I2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlZNRW50cnlTY29wZS5oIgogCisjaW5jbHVk ZSAiRGVidWdnZXIuaCIKICNpbmNsdWRlICJWTS5oIgogI2luY2x1ZGUgPHd0Zi9TdGFja0JvdW5k cy5oPgogCkBAIC0zNyw2ICszOCw3IEBAIFZNRW50cnlTY29wZTo6Vk1FbnRyeVNjb3BlKFZNJiB2 bSwgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCkKICAgICAsIG1fZ2xvYmFsT2JqZWN0KGds b2JhbE9iamVjdCkKICAgICAsIG1fcHJldih2bS5lbnRyeVNjb3BlKQogICAgICwgbV9wcmV2U3Rh Y2tMaW1pdCh2bS5zdGFja0xpbWl0KCkpCisgICAgLCBtX3JlY29tcGlsYXRpb25OZWVkZWQoZmFs c2UpCiB7CiAgICAgaWYgKCF2bS5lbnRyeVNjb3BlKSB7CiAjaWYgRU5BQkxFKEFTU0VNQkxFUikK QEAgLTYwLDYgKzYyLDEyIEBAIFZNRW50cnlTY29wZTo6flZNRW50cnlTY29wZSgpCiB7CiAgICAg bV92bS5lbnRyeVNjb3BlID0gbV9wcmV2OwogICAgIG1fdm0uc2V0U3RhY2tMaW1pdChtX3ByZXZT dGFja0xpbWl0KTsKKworICAgIGlmIChVTkxJS0VMWShtX3JlY29tcGlsYXRpb25OZWVkZWQpKSB7 CisgICAgICAgIEFTU0VSVCghbV92bS5lbnRyeVNjb3BlKTsKKyAgICAgICAgaWYgKERlYnVnZ2Vy KiBkZWJ1Z2dlciA9IG1fZ2xvYmFsT2JqZWN0LT5kZWJ1Z2dlcigpKQorICAgICAgICAgICAgZGVi dWdnZXItPnJlY29tcGlsZUFsbEpTRnVuY3Rpb25zKCZtX3ZtKTsKKyAgICB9CiB9CiAKIHNpemVf dCBWTUVudHJ5U2NvcGU6OnJlcXVpcmVkQ2FwYWNpdHkoKSBjb25zdApAQCAtNzgsNyArODYsMTYg QEAgc2l6ZV90IFZNRW50cnlTY29wZTo6cmVxdWlyZWRDYXBhY2l0eSgpIGNvbnN0CiAKICAgICBz aXplX3QgcmVxdWlyZWRDYXBhY2l0eSA9IGludGVycHJldGVyLT5pc0luRXJyb3JIYW5kbGluZ01v ZGUoKSA/IGVycm9yTW9kZVJlcXVpcmVkU3RhY2sgOiByZXF1aXJlZFN0YWNrOwogICAgIFJFTEVB U0VfQVNTRVJUKG1fc3RhY2suc2l6ZSgpID49IHJlcXVpcmVkQ2FwYWNpdHkpOwotICAgIHJldHVy biByZXF1aXJlZENhcGFjaXR5OyAKKyAgICByZXR1cm4gcmVxdWlyZWRDYXBhY2l0eTsKK30KKwor Vk1FbnRyeVNjb3BlKiBWTUVudHJ5U2NvcGU6OnRvcEVudHJ5U2NvcGUoVk1FbnRyeVNjb3BlKiBl bnRyeVNjb3BlKQoreworICAgIGlmICghZW50cnlTY29wZSkKKyAgICAgICAgcmV0dXJuIG51bGxw dHI7CisgICAgd2hpbGUgKGVudHJ5U2NvcGUtPm1fcHJldikKKyAgICAgICAgZW50cnlTY29wZSA9 IGVudHJ5U2NvcGUtPm1fcHJldjsKKyAgICByZXR1cm4gZW50cnlTY29wZTsKIH0KIAogfSAvLyBu YW1lc3BhY2UgSlNDCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9W TUVudHJ5U2NvcGUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNRW50cnlTY29w ZS5oCmluZGV4IDhlMWM0NGEuLjYyYjNiYjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1ZNRW50cnlTY29wZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1ZNRW50cnlTY29wZS5oCkBAIC00Miw2ICs0MiwxMCBAQCBwdWJsaWM6CiAKICAgICBK U0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0KCkgY29uc3QgeyByZXR1cm4gbV9nbG9iYWxPYmpl Y3Q7IH0KIAorICAgIHN0YXRpYyBWTUVudHJ5U2NvcGUqIHRvcEVudHJ5U2NvcGUoVk1FbnRyeVNj b3BlKik7CisKKyAgICB2b2lkIHNldFJlY29tcGlsYXRpb25OZWVkZWQoYm9vbCByZWNvbXBpbGVO ZWVkZWQpIHsgbV9yZWNvbXBpbGF0aW9uTmVlZGVkID0gcmVjb21waWxlTmVlZGVkOyB9CisKIHBy aXZhdGU6CiAgICAgc2l6ZV90IHJlcXVpcmVkQ2FwYWNpdHkoKSBjb25zdDsKIApAQCAtNTMsNiAr NTcsNyBAQCBwcml2YXRlOgogICAgIC8vIG1fcHJldiBhbmQgbV9wcmV2U3RhY2tMaW1pdCBtYXkg YmVsb25nIHRvIGEgZGlmZmVyZW50IHRocmVhZCdzIHN0YWNrLgogICAgIFZNRW50cnlTY29wZSog bV9wcmV2OwogICAgIHZvaWQqIG1fcHJldlN0YWNrTGltaXQ7CisgICAgYm9vbCBtX3JlY29tcGls YXRpb25OZWVkZWQ7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBKU0MKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5ZjA3 NTk2Li5kNzE5MmIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTQtMDEtMjQgIEpv c2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBmYXN0L3Byb2Zp bGVyIHRlc3RzIEFTU0VSVGluZyBhZnRlciBtb3ZpbmcgcmVjb21waWxlQWxsSlNGdW5jdGlvbnMg b2ZmIGEgdGltZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyNzU2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVy bmFscy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnRlcm5hbHM6OmNsb3NlRHVtbXlJbnNwZWN0 b3JGcm9udGVuZCk6CisgICAgICAgIE5vdyB0aGF0IHdlIGRvbid0IGhhdmUgdG8gZmFrZSB0aGF0 IHRoaXMgaXMgYSBwYWdlIGJlaW5nIGRlc3Ryb3llZCB0bworICAgICAgICBhdm9pZCByZWNvbXBp bGF0aW9uLiBVc2UgdGhlIEluc3BlY3RvckRlc3Ryb3llZCByZWFzb24uCisKIDIwMTQtMDEtMjMg IEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIEph dmFTY3JpcHRDYWxsRnJhbWUgYW5kIFNjcmlwdERlYnVnU2VydmVyIGludG8gSmF2YVNjcmlwdENv cmUgZm9yIGluc3BlY3RvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRl cm5hbHMuY3BwIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCmluZGV4IDcz OTBjMmQuLjI4Y2JiNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJu YWxzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKQEAgLTE0 NjUsOCArMTQ2NSw3IEBAIHZvaWQgSW50ZXJuYWxzOjpjbG9zZUR1bW15SW5zcGVjdG9yRnJvbnRl bmQoKQogICAgIEFTU0VSVChwYWdlKTsKICAgICBBU1NFUlQobV9mcm9udGVuZFdpbmRvdyk7CiAK LSAgICAvLyBUcmVhdCB0aGlzIGFzIGlmIHRoZSBwYWdlIHdlIGFyZSBpbnNwZWN0aW5nIGlzIGNs b3NpbmcuCi0gICAgcGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigpLmRpc2Nvbm5lY3RGcm9udGVu ZChJbnNwZWN0b3JEaXNjb25uZWN0UmVhc29uOjpJbnNwZWN0ZWRUYXJnZXREZXN0cm95ZWQpOwor ICAgIHBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKS5kaXNjb25uZWN0RnJvbnRlbmQoSW5zcGVj dG9yRGlzY29ubmVjdFJlYXNvbjo6SW5zcGVjdG9yRGVzdHJveWVkKTsKIAogICAgIG1fZnJvbnRl bmRDaGFubmVsLnJlbGVhc2UoKTsKIAo= 222134 2014-01-24 12:16:29 -0800 2014-01-24 12:17:55 -0800 [PATCH] Proposed Fix - Let VM manage recompilation vm2.patch text/plain 5482 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDUzNDhiMDMuLmJiMmIzNTggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTAxLTI0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgZmFzdC9wcm9maWxlciB0ZXN0cyBB U1NFUlRpbmcgYWZ0ZXIgbW92aW5nIHJlY29tcGlsZUFsbEpTRnVuY3Rpb25zIG9mZiBhIHRpbWVy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc1NjYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHRo ZSBWTSBoYW5kbGUgcmVjb21waWxhdGlvbiBhcyBzb29uIGFzIHBvc3NpYmxlIGFmdGVyIGl0IGlz IHJlcXVlc3RlZC4KKworICAgICAgICAqIGRlYnVnZ2VyL0RlYnVnZ2VyLmNwcDoKKyAgICAgICAg KEpTQzo6RGVidWdnZXI6OnJlY29tcGlsZUFsbEpTRnVuY3Rpb25zKToKKyAgICAgICAgV2hlbiBp biBhIEphdmFTY3JpcHQgc3RhY2ssIG1hcmsgZm9yIHJlY29tcGlsYXRpb24gd2hlbiBwb3NzaWJs ZS4KKworICAgICAgICAqIHJ1bnRpbWUvVk1FbnRyeVNjb3BlLmg6CisgICAgICAgIChKU0M6OlZN RW50cnlTY29wZTo6c2V0UmVjb21waWxhdGlvbk5lZWRlZCk6CisgICAgICAgICogcnVudGltZS9W TUVudHJ5U2NvcGUuY3BwOgorICAgICAgICAoSlNDOjpWTUVudHJ5U2NvcGU6OlZNRW50cnlTY29w ZSk6CisgICAgICAgIChKU0M6OlZNRW50cnlTY29wZTo6flZNRW50cnlTY29wZSk6CisgICAgICAg IEhhbmRsZSByZWNvbXBpbGF0aW9uIHdoZW4gdGhlIHRvcCBWTUVudHJ5U2NvcGUgaXMgcG9wcGVk LgorICAgICAgICBQYXNzIHRoZSBuZWVkcyByZWNvbXBpbGF0aW9uIGZsYWcgdXAgdGhlIHN0YWNr IGlmIG5lZWRlZC4KKwogMjAxNC0wMS0yMyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBw bGUuY29tPgogCiAgICAgICAgIE1vdmUgSmF2YVNjcmlwdENhbGxGcmFtZSBhbmQgU2NyaXB0RGVi dWdTZXJ2ZXIgaW50byBKYXZhU2NyaXB0Q29yZSBmb3IgaW5zcGVjdG9yCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXIuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyLmNwcAppbmRleCBmMGY5NzBkLi40ZDQ2NDI5IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXIuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlci5jcHAKQEAgLTI5MSwx MCArMjkxLDExIEBAIHZvaWQgRGVidWdnZXI6OnJlY29tcGlsZUFsbEpTRnVuY3Rpb25zKFZNKiB2 bSkKIHsKICAgICAvLyBJZiBKYXZhU2NyaXB0IGlzIHJ1bm5pbmcsIGl0J3Mgbm90IHNhZmUgdG8g cmVjb21waWxlLCBzaW5jZSB3ZSdsbCBlbmQKICAgICAvLyB1cCB0aHJvd2luZyBhd2F5IGNvZGUg dGhhdCBpcyBsaXZlIG9uIHRoZSBzdGFjay4KLSAgICBBU1NFUlQoIXZtLT5lbnRyeVNjb3BlKTsK LSAgICBpZiAodm0tPmVudHJ5U2NvcGUpCisgICAgaWYgKHZtLT5lbnRyeVNjb3BlKSB7CisgICAg ICAgIHZtLT5lbnRyeVNjb3BlLT5zZXRSZWNvbXBpbGF0aW9uTmVlZGVkKHRydWUpOwogICAgICAg ICByZXR1cm47Ci0gICAgCisgICAgfQorCiAgICAgdm0tPnByZXBhcmVUb0Rpc2NhcmRDb2RlKCk7 CiAKICAgICBSZWNvbXBpbGVyIHJlY29tcGlsZXIodGhpcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9WTUVudHJ5U2NvcGUuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvVk1FbnRyeVNjb3BlLmNwcAppbmRleCAyNmIwMDI4Li40Nzc4MmNlIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTUVudHJ5U2NvcGUuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNRW50cnlTY29wZS5jcHAKQEAg LTI2LDYgKzI2LDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJWTUVudHJ5U2Nv cGUuaCIKIAorI2luY2x1ZGUgIkRlYnVnZ2VyLmgiCiAjaW5jbHVkZSAiVk0uaCIKICNpbmNsdWRl IDx3dGYvU3RhY2tCb3VuZHMuaD4KIApAQCAtMzcsNiArMzgsNyBAQCBWTUVudHJ5U2NvcGU6OlZN RW50cnlTY29wZShWTSYgdm0sIEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QpCiAgICAgLCBt X2dsb2JhbE9iamVjdChnbG9iYWxPYmplY3QpCiAgICAgLCBtX3ByZXYodm0uZW50cnlTY29wZSkK ICAgICAsIG1fcHJldlN0YWNrTGltaXQodm0uc3RhY2tMaW1pdCgpKQorICAgICwgbV9yZWNvbXBp bGF0aW9uTmVlZGVkKGZhbHNlKQogewogICAgIGlmICghdm0uZW50cnlTY29wZSkgewogI2lmIEVO QUJMRShBU1NFTUJMRVIpCkBAIC02MCw2ICs2MiwxNSBAQCBWTUVudHJ5U2NvcGU6On5WTUVudHJ5 U2NvcGUoKQogewogICAgIG1fdm0uZW50cnlTY29wZSA9IG1fcHJldjsKICAgICBtX3ZtLnNldFN0 YWNrTGltaXQobV9wcmV2U3RhY2tMaW1pdCk7CisKKyAgICBpZiAobV9yZWNvbXBpbGF0aW9uTmVl ZGVkKSB7CisgICAgICAgIGlmIChtX3ZtLmVudHJ5U2NvcGUpCisgICAgICAgICAgICBtX3ZtLmVu dHJ5U2NvcGUtPnNldFJlY29tcGlsYXRpb25OZWVkZWQodHJ1ZSk7CisgICAgICAgIGVsc2Ugewor ICAgICAgICAgICAgaWYgKERlYnVnZ2VyKiBkZWJ1Z2dlciA9IG1fZ2xvYmFsT2JqZWN0LT5kZWJ1 Z2dlcigpKQorICAgICAgICAgICAgICAgIGRlYnVnZ2VyLT5yZWNvbXBpbGVBbGxKU0Z1bmN0aW9u cygmbV92bSk7CisgICAgICAgIH0KKyAgICB9CiB9CiAKIHNpemVfdCBWTUVudHJ5U2NvcGU6OnJl cXVpcmVkQ2FwYWNpdHkoKSBjb25zdApAQCAtNzgsOCArODksNyBAQCBzaXplX3QgVk1FbnRyeVNj b3BlOjpyZXF1aXJlZENhcGFjaXR5KCkgY29uc3QKIAogICAgIHNpemVfdCByZXF1aXJlZENhcGFj aXR5ID0gaW50ZXJwcmV0ZXItPmlzSW5FcnJvckhhbmRsaW5nTW9kZSgpID8gZXJyb3JNb2RlUmVx dWlyZWRTdGFjayA6IHJlcXVpcmVkU3RhY2s7CiAgICAgUkVMRUFTRV9BU1NFUlQobV9zdGFjay5z aXplKCkgPj0gcmVxdWlyZWRDYXBhY2l0eSk7Ci0gICAgcmV0dXJuIHJlcXVpcmVkQ2FwYWNpdHk7 IAorICAgIHJldHVybiByZXF1aXJlZENhcGFjaXR5OwogfQogCiB9IC8vIG5hbWVzcGFjZSBKU0MK LQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk1FbnRyeVNjb3Bl LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTUVudHJ5U2NvcGUuaAppbmRleCA4 ZTFjNDRhLi5kNWJhODIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9WTUVudHJ5U2NvcGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTUVu dHJ5U2NvcGUuaApAQCAtNDIsNiArNDIsOCBAQCBwdWJsaWM6CiAKICAgICBKU0dsb2JhbE9iamVj dCogZ2xvYmFsT2JqZWN0KCkgY29uc3QgeyByZXR1cm4gbV9nbG9iYWxPYmplY3Q7IH0KIAorICAg IHZvaWQgc2V0UmVjb21waWxhdGlvbk5lZWRlZChib29sIHJlY29tcGlsZU5lZWRlZCkgeyBtX3Jl Y29tcGlsYXRpb25OZWVkZWQgPSByZWNvbXBpbGVOZWVkZWQ7IH0KKwogcHJpdmF0ZToKICAgICBz aXplX3QgcmVxdWlyZWRDYXBhY2l0eSgpIGNvbnN0OwogCkBAIC01Myw2ICs1NSw3IEBAIHByaXZh dGU6CiAgICAgLy8gbV9wcmV2IGFuZCBtX3ByZXZTdGFja0xpbWl0IG1heSBiZWxvbmcgdG8gYSBk aWZmZXJlbnQgdGhyZWFkJ3Mgc3RhY2suCiAgICAgVk1FbnRyeVNjb3BlKiBtX3ByZXY7CiAgICAg dm9pZCogbV9wcmV2U3RhY2tMaW1pdDsKKyAgICBib29sIG1fcmVjb21waWxhdGlvbk5lZWRlZDsK IH07CiAKIH0gLy8gbmFtZXNwYWNlIEpTQwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDlmMDc1OTYuLmQ3MTkyYjMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNC0wMS0yNCAgSm9zZXBoIFBlY29yYXJv ICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIGZhc3QvcHJvZmlsZXIgdGVzdHMgQVNT RVJUaW5nIGFmdGVyIG1vdmluZyByZWNvbXBpbGVBbGxKU0Z1bmN0aW9ucyBvZmYgYSB0aW1lcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3NTY2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBi eSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkludGVybmFsczo6Y2xvc2VEdW1teUluc3BlY3RvckZyb250ZW5kKToK KyAgICAgICAgTm93IHRoYXQgd2UgZG9uJ3QgaGF2ZSB0byBmYWtlIHRoYXQgdGhpcyBpcyBhIHBh Z2UgYmVpbmcgZGVzdHJveWVkIHRvCisgICAgICAgIGF2b2lkIHJlY29tcGlsYXRpb24uIFVzZSB0 aGUgSW5zcGVjdG9yRGVzdHJveWVkIHJlYXNvbi4KKwogMjAxNC0wMS0yMyAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgSmF2YVNjcmlwdENhbGxG cmFtZSBhbmQgU2NyaXB0RGVidWdTZXJ2ZXIgaW50byBKYXZhU2NyaXB0Q29yZSBmb3IgaW5zcGVj dG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAgYi9T b3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKaW5kZXggNzM5MGMyZC4uMjhjYmI1 ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcApAQCAtMTQ2NSw4ICsxNDY1LDcg QEAgdm9pZCBJbnRlcm5hbHM6OmNsb3NlRHVtbXlJbnNwZWN0b3JGcm9udGVuZCgpCiAgICAgQVNT RVJUKHBhZ2UpOwogICAgIEFTU0VSVChtX2Zyb250ZW5kV2luZG93KTsKIAotICAgIC8vIFRyZWF0 IHRoaXMgYXMgaWYgdGhlIHBhZ2Ugd2UgYXJlIGluc3BlY3RpbmcgaXMgY2xvc2luZy4KLSAgICBw YWdlLT5pbnNwZWN0b3JDb250cm9sbGVyKCkuZGlzY29ubmVjdEZyb250ZW5kKEluc3BlY3RvckRp c2Nvbm5lY3RSZWFzb246Okluc3BlY3RlZFRhcmdldERlc3Ryb3llZCk7CisgICAgcGFnZS0+aW5z cGVjdG9yQ29udHJvbGxlcigpLmRpc2Nvbm5lY3RGcm9udGVuZChJbnNwZWN0b3JEaXNjb25uZWN0 UmVhc29uOjpJbnNwZWN0b3JEZXN0cm95ZWQpOwogCiAgICAgbV9mcm9udGVuZENoYW5uZWwucmVs ZWFzZSgpOwogCg==