127556 2014-01-24 07:24:29 -0800 Rename various RenderFlexibleBox variables and arguments to match the naming from the spec 2021-09-13 01:14:44 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED WORKSFORME BlinkMergeCandidate P2 Normal --- 1 pmolnar.u-szeged webkit-unassigned commit-queue esprehn+autocc glenn hyatt kondapallykalyan simon.fraser svillar syoichi oldest_to_newest 971599 0 pmolnar.u-szeged 2014-01-24 07:24:29 -0800 This should make it easier to understand the code. I have also simplified some calculations and gave some expressions their own variables. Merged from Blink: https://src.chromium.org/viewvc/blink?revision=153288&view=revision 971600 1 222107 pmolnar.u-szeged 2014-01-24 07:25:28 -0800 Created attachment 222107 patch 1230838 2 222107 mcatanzaro 2016-09-17 07:19:03 -0700 Comment on attachment 222107 patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug. 1792879 3 svillar 2021-09-13 01:14:44 -0700 Right, this was already fixed in r213149 BTW. 222107 2014-01-24 07:25:28 -0800 2016-09-17 07:19:03 -0700 patch renderflexible.patch text/plain 7155 pmolnar.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3Yzk2OTRkLi40NWNhMWNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTQtMDEtMjQgIFBldGVyIE1vbG5hciAgPHBtb2xuYXIudS1zemVnZWRAcGFydG5lci5z YW1zdW5nLmNvbT4KKworICAgICAgICBSZW5hbWUgdmFyaW91cyB2YXJpYWJsZXMgYW5kIGFyZ3Vt ZW50cyB0byBtYXRjaCB0aGUgbmFtaW5nIGZyb20gdGhlIHNwZWMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzU1NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgc2hvdWxkIG1ha2UgaXQgZWFzaWVy IHRvIHVuZGVyc3RhbmQgdGhlIGNvZGUuIEkgaGF2ZSBhbHNvIHNpbXBsaWZpZWQgc29tZSBjYWxj dWxhdGlvbnMKKyAgICAgICAgYW5kIGdhdmUgc29tZSBleHByZXNzaW9ucyB0aGVpciBvd24gdmFy aWFibGVzLgorCisgICAgICAgIE1lcmdlZCBmcm9tIEJsaW5rOiBodHRwczovL3NyYy5jaHJvbWl1 bS5vcmcvdmlld3ZjL2JsaW5rP3JldmlzaW9uPTE1MzI4OCZ2aWV3PXJldmlzaW9uCisKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyRmxleGlibGVCb3g6OmxheW91dEZsZXhJdGVtcyk6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJGbGV4aWJsZUJveDo6Y29tcHV0ZU5leHRGbGV4TGluZSk6CisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckZsZXhpYmxlQm94Lmg6CisKIDIwMTQtMDEtMjQgIFphbiBEb2JlcnNlayAgPHpk b2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgR1RLIGJ1aWxkIGZpeCBh ZnRlciByMTYyNjYzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckZsZXhpYmxlQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJs ZUJveC5jcHAKaW5kZXggNjc4MzAyMy4uNDcxNDM1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwCkBAIC02ODgsMTcgKzY4OCwxOCBAQCBMYXlv dXRVbml0IFJlbmRlckZsZXhpYmxlQm94OjpwcmVmZXJyZWRNYWluQXhpc0NvbnRlbnRFeHRlbnRG b3JDaGlsZChSZW5kZXJCb3gmCiB2b2lkIFJlbmRlckZsZXhpYmxlQm94OjpsYXlvdXRGbGV4SXRl bXMoYm9vbCByZWxheW91dENoaWxkcmVuLCBWZWN0b3I8TGluZUNvbnRleHQ+JiBsaW5lQ29udGV4 dHMpCiB7CiAgICAgT3JkZXJlZEZsZXhJdGVtTGlzdCBvcmRlcmVkQ2hpbGRyZW47Ci0gICAgTGF5 b3V0VW5pdCBwcmVmZXJyZWRNYWluQXhpc0V4dGVudDsKKyAgICBMYXlvdXRVbml0IHN1bUZsZXhC YXNlU2l6ZTsKICAgICBkb3VibGUgdG90YWxGbGV4R3JvdzsKICAgICBkb3VibGUgdG90YWxXZWln aHRlZEZsZXhTaHJpbms7Ci0gICAgTGF5b3V0VW5pdCBtaW5NYXhBcHBsaWVkTWFpbkF4aXNFeHRl bnQ7CisgICAgTGF5b3V0VW5pdCBzdW1IeXBvdGhldGljYWxNYWluU2l6ZTsKIAogICAgIG1fb3Jk ZXJJdGVyYXRvci5maXJzdCgpOwogICAgIExheW91dFVuaXQgY3Jvc3NBeGlzT2Zmc2V0ID0gZmxv d0F3YXJlQm9yZGVyQmVmb3JlKCkgKyBmbG93QXdhcmVQYWRkaW5nQmVmb3JlKCk7CiAgICAgYm9v bCBoYXNJbmZpbml0ZUxpbmVMZW5ndGggPSBmYWxzZTsKLSAgICB3aGlsZSAoY29tcHV0ZU5leHRG bGV4TGluZShvcmRlcmVkQ2hpbGRyZW4sIHByZWZlcnJlZE1haW5BeGlzRXh0ZW50LCB0b3RhbEZs ZXhHcm93LCB0b3RhbFdlaWdodGVkRmxleFNocmluaywgbWluTWF4QXBwbGllZE1haW5BeGlzRXh0 ZW50LCBoYXNJbmZpbml0ZUxpbmVMZW5ndGgpKSB7Ci0gICAgICAgIExheW91dFVuaXQgYXZhaWxh YmxlRnJlZVNwYWNlID0gbWFpbkF4aXNDb250ZW50RXh0ZW50KHByZWZlcnJlZE1haW5BeGlzRXh0 ZW50KSAtIHByZWZlcnJlZE1haW5BeGlzRXh0ZW50OwotICAgICAgICBGbGV4U2lnbiBmbGV4U2ln biA9IChtaW5NYXhBcHBsaWVkTWFpbkF4aXNFeHRlbnQgPCBwcmVmZXJyZWRNYWluQXhpc0V4dGVu dCArIGF2YWlsYWJsZUZyZWVTcGFjZSkgPyBQb3NpdGl2ZUZsZXhpYmlsaXR5IDogTmVnYXRpdmVG bGV4aWJpbGl0eTsKKyAgICB3aGlsZSAoY29tcHV0ZU5leHRGbGV4TGluZShvcmRlcmVkQ2hpbGRy ZW4sIHN1bUZsZXhCYXNlU2l6ZSwgdG90YWxGbGV4R3JvdywgdG90YWxXZWlnaHRlZEZsZXhTaHJp bmssIHN1bUh5cG90aGV0aWNhbE1haW5TaXplLCBoYXNJbmZpbml0ZUxpbmVMZW5ndGgpKSB7Cisg ICAgICAgIExheW91dFVuaXQgY29udGFpbmVyTWFpbklubmVyU2l6ZSA9IG1haW5BeGlzQ29udGVu dEV4dGVudChzdW1GbGV4QmFzZVNpemUpOworICAgICAgICBMYXlvdXRVbml0IGF2YWlsYWJsZUZy ZWVTcGFjZSA9IGNvbnRhaW5lck1haW5Jbm5lclNpemUgLSBzdW1GbGV4QmFzZVNpemU7CisgICAg ICAgIEZsZXhTaWduIGZsZXhTaWduID0gKHN1bUh5cG90aGV0aWNhbE1haW5TaXplIDwgY29udGFp bmVyTWFpbklubmVyU2l6ZSkgPyBQb3NpdGl2ZUZsZXhpYmlsaXR5IDogTmVnYXRpdmVGbGV4aWJp bGl0eTsKICAgICAgICAgSW5mbGV4aWJsZUZsZXhJdGVtU2l6ZSBpbmZsZXhpYmxlSXRlbXM7CiAg ICAgICAgIFZlY3RvcjxMYXlvdXRVbml0PiBjaGlsZFNpemVzOwogICAgICAgICB3aGlsZSAoIXJl c29sdmVGbGV4aWJsZUxlbmd0aHMoZmxleFNpZ24sIG9yZGVyZWRDaGlsZHJlbiwgYXZhaWxhYmxl RnJlZVNwYWNlLCB0b3RhbEZsZXhHcm93LCB0b3RhbFdlaWdodGVkRmxleFNocmluaywgaW5mbGV4 aWJsZUl0ZW1zLCBjaGlsZFNpemVzLCBoYXNJbmZpbml0ZUxpbmVMZW5ndGgpKSB7CkBAIC04Nzgs MTIgKzg3OSwxMiBAQCBMYXlvdXRVbml0IFJlbmRlckZsZXhpYmxlQm94OjphZGp1c3RDaGlsZFNp emVGb3JNaW5BbmRNYXgoUmVuZGVyQm94JiBjaGlsZCwgTGF5bwogICAgIHJldHVybiBzdGQ6Om1h eChjaGlsZFNpemUsIG1pbkV4dGVudCk7CiB9CiAKLWJvb2wgUmVuZGVyRmxleGlibGVCb3g6OmNv bXB1dGVOZXh0RmxleExpbmUoT3JkZXJlZEZsZXhJdGVtTGlzdCYgb3JkZXJlZENoaWxkcmVuLCBM YXlvdXRVbml0JiBwcmVmZXJyZWRNYWluQXhpc0V4dGVudCwgZG91YmxlJiB0b3RhbEZsZXhHcm93 LCBkb3VibGUmIHRvdGFsV2VpZ2h0ZWRGbGV4U2hyaW5rLCBMYXlvdXRVbml0JiBtaW5NYXhBcHBs aWVkTWFpbkF4aXNFeHRlbnQsIGJvb2wmIGhhc0luZmluaXRlTGluZUxlbmd0aCkKK2Jvb2wgUmVu ZGVyRmxleGlibGVCb3g6OmNvbXB1dGVOZXh0RmxleExpbmUoT3JkZXJlZEZsZXhJdGVtTGlzdCYg b3JkZXJlZENoaWxkcmVuLCBMYXlvdXRVbml0JiBzdW1GbGV4QmFzZVNpemUsIGRvdWJsZSYgdG90 YWxGbGV4R3JvdywgZG91YmxlJiB0b3RhbFdlaWdodGVkRmxleFNocmluaywgTGF5b3V0VW5pdCYg c3VtSHlwb3RoZXRpY2FsTWFpblNpemUsIGJvb2wmIGhhc0luZmluaXRlTGluZUxlbmd0aCkKIHsK ICAgICBvcmRlcmVkQ2hpbGRyZW4uY2xlYXIoKTsKLSAgICBwcmVmZXJyZWRNYWluQXhpc0V4dGVu dCA9IDA7CisgICAgc3VtRmxleEJhc2VTaXplID0gMDsKICAgICB0b3RhbEZsZXhHcm93ID0gdG90 YWxXZWlnaHRlZEZsZXhTaHJpbmsgPSAwOwotICAgIG1pbk1heEFwcGxpZWRNYWluQXhpc0V4dGVu dCA9IDA7CisgICAgc3VtSHlwb3RoZXRpY2FsTWFpblNpemUgPSAwOwogCiAgICAgaWYgKCFtX29y ZGVySXRlcmF0b3IuY3VycmVudENoaWxkKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTkw MCwxOSArOTAxLDIwIEBAIGJvb2wgUmVuZGVyRmxleGlibGVCb3g6OmNvbXB1dGVOZXh0RmxleExp bmUoT3JkZXJlZEZsZXhJdGVtTGlzdCYgb3JkZXJlZENoaWxkcmVuCiAgICAgICAgIH0KIAogICAg ICAgICBMYXlvdXRVbml0IGNoaWxkTWFpbkF4aXNFeHRlbnQgPSBwcmVmZXJyZWRNYWluQXhpc0Nv bnRlbnRFeHRlbnRGb3JDaGlsZCgqY2hpbGQsIGhhc0luZmluaXRlTGluZUxlbmd0aCk7Ci0gICAg ICAgIExheW91dFVuaXQgY2hpbGRNYWluQXhpc01hcmdpbkJveEV4dGVudCA9IG1haW5BeGlzQm9y ZGVyQW5kUGFkZGluZ0V4dGVudEZvckNoaWxkKCpjaGlsZCkgKyBjaGlsZE1haW5BeGlzRXh0ZW50 OwotICAgICAgICBjaGlsZE1haW5BeGlzTWFyZ2luQm94RXh0ZW50ICs9IGlzSG9yaXpvbnRhbEZs b3coKSA/IGNoaWxkLT5tYXJnaW5XaWR0aCgpIDogY2hpbGQtPm1hcmdpbkhlaWdodCgpOworICAg ICAgICBMYXlvdXRVbml0IGNoaWxkTWFpbkF4aXNNYXJnaW5Cb3JkZXJQYWRkaW5nID0gbWFpbkF4 aXNCb3JkZXJBbmRQYWRkaW5nRXh0ZW50Rm9yQ2hpbGQoKmNoaWxkKQorICAgICAgICAgICAgKyAo aXNIb3Jpem9udGFsRmxvdygpID8gY2hpbGQtPm1hcmdpbldpZHRoKCkgOiBjaGlsZC0+bWFyZ2lu SGVpZ2h0KCkpOworICAgICAgICBMYXlvdXRVbml0IGNoaWxkTWFpbkF4aXNNYXJnaW5Cb3hFeHRl bnQgPSBjaGlsZE1haW5BeGlzRXh0ZW50ICsgY2hpbGRNYWluQXhpc01hcmdpbkJvcmRlclBhZGRp bmc7CiAKLSAgICAgICAgaWYgKGlzTXVsdGlsaW5lKCkgJiYgcHJlZmVycmVkTWFpbkF4aXNFeHRl bnQgKyBjaGlsZE1haW5BeGlzTWFyZ2luQm94RXh0ZW50ID4gbGluZUJyZWFrTGVuZ3RoICYmIGxp bmVIYXNJbkZsb3dJdGVtKQorICAgICAgICBpZiAoaXNNdWx0aWxpbmUoKSAmJiBzdW1GbGV4QmFz ZVNpemUgKyBjaGlsZE1haW5BeGlzTWFyZ2luQm94RXh0ZW50ID4gbGluZUJyZWFrTGVuZ3RoICYm IGxpbmVIYXNJbkZsb3dJdGVtKQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIG9yZGVyZWRD aGlsZHJlbi5hcHBlbmQoY2hpbGQpOwogICAgICAgICBsaW5lSGFzSW5GbG93SXRlbSAgPSB0cnVl OwotICAgICAgICBwcmVmZXJyZWRNYWluQXhpc0V4dGVudCArPSBjaGlsZE1haW5BeGlzTWFyZ2lu Qm94RXh0ZW50OworICAgICAgICBzdW1GbGV4QmFzZVNpemUgKz0gY2hpbGRNYWluQXhpc01hcmdp bkJveEV4dGVudDsKICAgICAgICAgdG90YWxGbGV4R3JvdyArPSBjaGlsZC0+c3R5bGUoKS5mbGV4 R3JvdygpOwogICAgICAgICB0b3RhbFdlaWdodGVkRmxleFNocmluayArPSBjaGlsZC0+c3R5bGUo KS5mbGV4U2hyaW5rKCkgKiBjaGlsZE1haW5BeGlzRXh0ZW50OwogCiAgICAgICAgIExheW91dFVu aXQgY2hpbGRNaW5NYXhBcHBsaWVkTWFpbkF4aXNFeHRlbnQgPSBhZGp1c3RDaGlsZFNpemVGb3JN aW5BbmRNYXgoKmNoaWxkLCBjaGlsZE1haW5BeGlzRXh0ZW50KTsKLSAgICAgICAgbWluTWF4QXBw bGllZE1haW5BeGlzRXh0ZW50ICs9IGNoaWxkTWluTWF4QXBwbGllZE1haW5BeGlzRXh0ZW50IC0g Y2hpbGRNYWluQXhpc0V4dGVudCArIGNoaWxkTWFpbkF4aXNNYXJnaW5Cb3hFeHRlbnQ7CisgICAg ICAgIHN1bUh5cG90aGV0aWNhbE1haW5TaXplICs9IGNoaWxkTWluTWF4QXBwbGllZE1haW5BeGlz RXh0ZW50ICsgY2hpbGRNYWluQXhpc01hcmdpbkJvcmRlclBhZGRpbmc7CiAgICAgfQogICAgIHJl dHVybiB0cnVlOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckZsZXhpYmxlQm94LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVC b3guaAppbmRleCA5OTg3MWM1Li44ZDA0MTUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyRmxleGlibGVCb3guaApAQCAtMTM2LDcgKzEzNiw4IEBAIHByaXZhdGU6CiAgICAg TGF5b3V0VW5pdCBjb21wdXRlQ2hpbGRNYXJnaW5WYWx1ZShjb25zdCBMZW5ndGgmIG1hcmdpbik7 CiAgICAgdm9pZCBjb21wdXRlTWFpbkF4aXNQcmVmZXJyZWRTaXplcyhPcmRlckl0ZXJhdG9yOjpP cmRlclZhbHVlcyYpOwogICAgIExheW91dFVuaXQgYWRqdXN0Q2hpbGRTaXplRm9yTWluQW5kTWF4 KFJlbmRlckJveCYsIExheW91dFVuaXQgY2hpbGRTaXplKTsKLSAgICBib29sIGNvbXB1dGVOZXh0 RmxleExpbmUoT3JkZXJlZEZsZXhJdGVtTGlzdCYgb3JkZXJlZENoaWxkcmVuLCBMYXlvdXRVbml0 JiBwcmVmZXJyZWRNYWluQXhpc0V4dGVudCwgZG91YmxlJiB0b3RhbEZsZXhHcm93LCBkb3VibGUm IHRvdGFsV2VpZ2h0ZWRGbGV4U2hyaW5rLCBMYXlvdXRVbml0JiBtaW5NYXhBcHBsaWVkTWFpbkF4 aXNFeHRlbnQsIGJvb2wmIGhhc0luZmluaXRlTGluZUxlbmd0aCk7CisgICAgLy8gVGhlIGh5cG90 aGV0aWNhbCBtYWluIHNpemUgb2YgYW4gaXRlbSBpcyB0aGUgZmxleCBiYXNlIHNpemUgY2xhbXBl ZCBhY2NvcmRpbmcgdG8gaXRzIG1pbiBhbmQgbWF4IG1haW4gc2l6ZSBwcm9wZXJ0aWVzCisgICAg Ym9vbCBjb21wdXRlTmV4dEZsZXhMaW5lKE9yZGVyZWRGbGV4SXRlbUxpc3QmIG9yZGVyZWRDaGls ZHJlbiwgTGF5b3V0VW5pdCYgc3VtRmxleEJhc2VTaXplLCBkb3VibGUmIHRvdGFsRmxleEdyb3cs IGRvdWJsZSYgdG90YWxXZWlnaHRlZEZsZXhTaHJpbmssIExheW91dFVuaXQmIHN1bUh5cG90aGV0 aWNhbE1haW5TaXplLCBib29sJiBoYXNJbmZpbml0ZUxpbmVMZW5ndGgpOwogCiAgICAgYm9vbCBy ZXNvbHZlRmxleGlibGVMZW5ndGhzKEZsZXhTaWduLCBjb25zdCBPcmRlcmVkRmxleEl0ZW1MaXN0 JiwgTGF5b3V0VW5pdCYgYXZhaWxhYmxlRnJlZVNwYWNlLCBkb3VibGUmIHRvdGFsRmxleEdyb3cs IGRvdWJsZSYgdG90YWxXZWlnaHRlZEZsZXhTaHJpbmssIEluZmxleGlibGVGbGV4SXRlbVNpemUm LCBWZWN0b3I8TGF5b3V0VW5pdD4mIGNoaWxkU2l6ZXMsIGJvb2wgaGFzSW5maW5pdGVMaW5lTGVu Z3RoKTsKICAgICB2b2lkIGZyZWV6ZVZpb2xhdGlvbnMoY29uc3QgVmVjdG9yPFZpb2xhdGlvbj4m LCBMYXlvdXRVbml0JiBhdmFpbGFibGVGcmVlU3BhY2UsIGRvdWJsZSYgdG90YWxGbGV4R3Jvdywg ZG91YmxlJiB0b3RhbFdlaWdodGVkRmxleFNocmluaywgSW5mbGV4aWJsZUZsZXhJdGVtU2l6ZSYs IGJvb2wgaGFzSW5maW5pdGVMaW5lTGVuZ3RoKTsK