127553 2014-01-24 04:24:32 -0800 [SVG] Vector-effect updates require a re-layout 2014-02-07 02:39:18 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 pmolnar.u-szeged webkit-unassigned commit-queue esprehn+autocc glenn kondapallykalyan zimmermann oldest_to_newest 971573 0 pmolnar.u-szeged 2014-01-24 04:24:32 -0800 As noted in the stale SVGRenderStyle::diff() comment, now that layout() observes vector-effect we need to trigger a re-layout on attribute changes. Merged from Blink: https://src.chromium.org/viewvc/blink?revision=152570&view=revision 971575 1 222091 pmolnar.u-szeged 2014-01-24 04:26:04 -0800 Created attachment 222091 patch 977767 2 222091 kling 2014-02-07 02:08:45 -0800 Comment on attachment 222091 patch r=me 977780 3 222091 commit-queue 2014-02-07 02:39:16 -0800 Comment on attachment 222091 patch Clearing flags on attachment: 222091 Committed r163618: <http://trac.webkit.org/changeset/163618> 977781 4 commit-queue 2014-02-07 02:39:18 -0800 All reviewed patches have been landed. Closing bug. 222091 2014-01-24 04:26:04 -0800 2014-02-07 02:39:16 -0800 patch svg-vectoreffect.patch text/plain 4928 pmolnar.u-szeged ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5MDQ5OWMzLi45NmMxNGUxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTQtMDEt MjQgIFBldGVyIE1vbG5hciAgPHBtb2xuYXIudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4K KworICAgICAgICBWZWN0b3ItZWZmZWN0IHVwZGF0ZXMgcmVxdWlyZSBhIHJlLWxheW91dAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3NTUzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXMgbm90ZWQgaW4g dGhlIHN0YWxlIFNWR1JlbmRlclN0eWxlOjpkaWZmKCkgY29tbWVudCwgbm93IHRoYXQgbGF5b3V0 KCkgb2JzZXJ2ZXMgdmVjdG9yLWVmZmVjdAorICAgICAgICB3ZSBuZWVkIHRvIHRyaWdnZXIgYSBy ZS1sYXlvdXQgb24gYXR0cmlidXRlIGNoYW5nZXMuCisKKyAgICAgICAgTWVyZ2VkIGZyb20gQmxp bms6IGh0dHBzOi8vc3JjLmNocm9taXVtLm9yZy92aWV3dmMvYmxpbms/cmV2aXNpb249MTUyNTcw JnZpZXc9cmV2aXNpb24KKworICAgICAgICAqIHN2Zy9jdXN0b20vbm9uLXNjYWxpbmctc3Ryb2tl LXVwZGF0ZS1leHBlY3RlZC5zdmc6IEFkZGVkLgorICAgICAgICAqIHN2Zy9jdXN0b20vbm9uLXNj YWxpbmctc3Ryb2tlLXVwZGF0ZS5zdmc6IEFkZGVkLgorCiAyMDE0LTAxLTI0ICBKaW53b28gU29u ZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIEVGTCBn YXJkZW5pbmcuIFJlbW92ZSBmYWlsdXJlIGV4cGVjdGF0aW9ucyB3aGljaCBhcmUgcGFzc2luZyBu b3cuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL25vbi1zY2FsaW5nLXN0cm9r ZS11cGRhdGUtZXhwZWN0ZWQuc3ZnIGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9ub24tc2NhbGlu Zy1zdHJva2UtdXBkYXRlLWV4cGVjdGVkLnN2ZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi4wNzQyZWQ0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3Rv bS9ub24tc2NhbGluZy1zdHJva2UtdXBkYXRlLWV4cGVjdGVkLnN2ZwpAQCAtMCwwICsxLDUgQEAK KzxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxuczp4bGluaz0iaHR0 cDovL3d3dy53My5vcmcvMTk5OS94bGluayIgb25sb2FkPSJydW5UZXN0KCkiPgorICA8ZyB0cmFu c2Zvcm09InNjYWxlKDQpIj4KKyAgICA8cmVjdCBpZD0icmVjdCIgeD0iMjUiIHk9IjI1IiB3aWR0 aD0iMjUiIGhlaWdodD0iMjUiIGZpbGw9ImdyZWVuIiBzdHJva2Utd2lkdGg9IjEiIHN0cm9rZT0i YmxhY2siIHZlY3Rvci1lZmZlY3Q9Im5vbi1zY2FsaW5nLXN0cm9rZSIvPgorICA8L2c+Cis8L3N2 Zz4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vbm9uLXNjYWxpbmctc3Ryb2tl LXVwZGF0ZS5zdmcgYi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL25vbi1zY2FsaW5nLXN0cm9rZS11 cGRhdGUuc3ZnCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmEzYjAyOGYKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL25vbi1zY2FsaW5nLXN0cm9r ZS11cGRhdGUuc3ZnCkBAIC0wLDAgKzEsMjQgQEAKKzxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMu b3JnLzIwMDAvc3ZnIiB4bWxuczp4bGluaz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluayI+ CisgIDwhLS0gVGVzdCBmb3IgY3JidWcuY29tLzI1MDAwMSAtLT4KKyAgPGcgdHJhbnNmb3JtPSJz Y2FsZSg0KSI+CisgICAgPHJlY3QgaWQ9ImNsZWFyX3JlY3QiIHdpZHRoPSIxMDAlIiBoZWlnaHQ9 IjEwMCUiLz4KKyAgICA8cmVjdCBpZD0icmVjdCIgeD0iMjUiIHk9IjI1IiB3aWR0aD0iMjUiIGhl aWdodD0iMjUiIGZpbGw9ImdyZWVuIiBzdHJva2Utd2lkdGg9IjEiIHN0cm9rZT0iYmxhY2siLz4K KyAgPC9nPgorCisgIDxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAg ICAgIHRlc3RSdW5uZXIuZGlzcGxheSgpOworICAgICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERv bmUoKTsKKyAgICAgICAgc2V0VGltZW91dChydW5UZXN0LCAwKTsKKyAgICB9IGVsc2UgeworICAg ICAgICBzZXRUaW1lb3V0KHJ1blRlc3QsIDIwMCk7CisgICAgfQorCisgICAgZnVuY3Rpb24gcnVu VGVzdCgpIHsKK2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjbGVhcl9yZWN0Jykuc2V0QXR0cmli dXRlKCdmaWxsJywgJ3doaXRlJyk7Citkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVjdCcpLnNl dEF0dHJpYnV0ZSgndmVjdG9yLWVmZmVjdCcsICdub24tc2NhbGluZy1zdHJva2UnKTsKK2lmICh3 aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKKyAgICB9Cisg IDwvc2NyaXB0PgorPC9zdmc+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjUxZmQ4OS4uOTA1YThmYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTAxLTI0ICBQZXRlciBNb2xuYXIgIDxwbW9sbmFy LnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAgICAgVmVjdG9yLWVmZmVjdCB1 cGRhdGVzIHJlcXVpcmUgYSByZS1sYXlvdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNzU1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFzIG5vdGVkIGluIHRoZSBzdGFsZSBTVkdSZW5kZXJTdHlsZTo6 ZGlmZigpIGNvbW1lbnQsIG5vdyB0aGF0IGxheW91dCgpIG9ic2VydmVzIHZlY3Rvci1lZmZlY3QK KyAgICAgICAgd2UgbmVlZCB0byB0cmlnZ2VyIGEgcmUtbGF5b3V0IG9uIGF0dHJpYnV0ZSBjaGFu Z2VzLgorCisgICAgICAgIE1lcmdlZCBmcm9tIEJsaW5rOiBodHRwczovL3NyYy5jaHJvbWl1bS5v cmcvdmlld3ZjL2JsaW5rP3JldmlzaW9uPTE1MjU3MCZ2aWV3PXJldmlzaW9uCisKKyAgICAgICAg VGVzdHM6IHN2Zy9jdXN0b20vbm9uLXNjYWxpbmctc3Ryb2tlLXVwZGF0ZS1leHBlY3RlZC5zdmcK KyAgICAgICAgICAgICAgIHN2Zy9jdXN0b20vbm9uLXNjYWxpbmctc3Ryb2tlLXVwZGF0ZS5zdmcK KworICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9TVkdSZW5kZXJTdHlsZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTVkdSZW5kZXJTdHlsZTo6ZGlmZik6CisKIDIwMTQtMDEtMjMgIE1vcnRlbiBT dGVuc2hvcm5lICA8bXN0ZW5zaG9Ab3BlcmEuY29tPgogCiAgICAgICAgIFJlZ2lvbiBiYXNlZCBt dWx0aWNvbDogdW5yZXNvbHZhYmxlIHBlcmNlbnQgaGVpZ2h0IHJlc3VsdHMgaW4gMXB4IHRhbGwg bXVsdGljb2wKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TVkdS ZW5kZXJTdHlsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU1ZHUmVuZGVy U3R5bGUuY3BwCmluZGV4IDA2Yzc5M2YuLjIyNDJiMTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdHlsZS9TVkdSZW5kZXJTdHlsZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL3N0eWxlL1NWR1JlbmRlclN0eWxlLmNwcApAQCAtMjA0LDYgKzIwNCwxMCBA QCBTdHlsZURpZmZlcmVuY2UgU1ZHUmVuZGVyU3R5bGU6OmRpZmYoY29uc3QgU1ZHUmVuZGVyU3R5 bGUqIG90aGVyKSBjb25zdAogICAgICAgICByZXR1cm4gU3R5bGVEaWZmZXJlbmNlUmVwYWludDsK ICAgICB9CiAKKyAgICAvLyB2ZWN0b3ItZWZmZWN0IGNoYW5nZXMgcmVxdWlyZSBhIHJlLWxheW91 dC4KKyAgICBpZiAoc3ZnX25vbmluaGVyaXRlZF9mbGFncy5mLl92ZWN0b3JFZmZlY3QgIT0gb3Ro ZXItPnN2Z19ub25pbmhlcml0ZWRfZmxhZ3MuZi5fdmVjdG9yRWZmZWN0KQorICAgICAgICByZXR1 cm4gU3R5bGVEaWZmZXJlbmNlTGF5b3V0OworCiAgICAgLy8gTk9URTogQWxsIGNvbXBhcmlzaW9u cyBiZWxvdyBtYXkgb25seSByZXR1cm4gU3R5bGVEaWZmZXJlbmNlUmVwYWludAogCiAgICAgLy8g UGFpbnRpbmcgcmVsYXRlZCBwcm9wZXJ0aWVzIG9ubHkgbmVlZCByZXBhaW50cy4gCkBAIC0yMzIs MTAgKzIzNiw2IEBAIFN0eWxlRGlmZmVyZW5jZSBTVkdSZW5kZXJTdHlsZTo6ZGlmZihjb25zdCBT VkdSZW5kZXJTdHlsZSogb3RoZXIpIGNvbnN0CiAgICAgICAgIHx8IHN2Z19pbmhlcml0ZWRfZmxh Z3MuX2NvbG9ySW50ZXJwb2xhdGlvbkZpbHRlcnMgIT0gb3RoZXItPnN2Z19pbmhlcml0ZWRfZmxh Z3MuX2NvbG9ySW50ZXJwb2xhdGlvbkZpbHRlcnMpCiAgICAgICAgIHJldHVybiBTdHlsZURpZmZl cmVuY2VSZXBhaW50OwogCi0gICAgLy8gRklYTUU6IHZlY3Rvci1lZmZlY3QgaXMgbm90IHRha2Vu IGludG8gYWNjb3VudCBpbiB0aGUgbGF5b3V0LXBoYXNlLiBPbmNlIHRoaXMgaXMgZml4ZWQsIHdl IHNob3VsZCByZWxheW91dCBoZXJlLgotICAgIGlmIChzdmdfbm9uaW5oZXJpdGVkX2ZsYWdzLmYu X3ZlY3RvckVmZmVjdCAhPSBvdGhlci0+c3ZnX25vbmluaGVyaXRlZF9mbGFncy5mLl92ZWN0b3JF ZmZlY3QpCi0gICAgICAgIHJldHVybiBTdHlsZURpZmZlcmVuY2VSZXBhaW50OwotCiAgICAgaWYg KHN2Z19ub25pbmhlcml0ZWRfZmxhZ3MuZi5idWZmZXJlZFJlbmRlcmluZyAhPSBvdGhlci0+c3Zn X25vbmluaGVyaXRlZF9mbGFncy5mLmJ1ZmZlcmVkUmVuZGVyaW5nKQogICAgICAgICByZXR1cm4g U3R5bGVEaWZmZXJlbmNlUmVwYWludDsKIAo=