127549 2014-01-24 01:36:44 -0800 [WK2][EFL] Fix a build break on debug mode 2014-01-24 08:03:50 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 127496 P2 Normal --- 1 gyuyoung.kim gyuyoung.kim ossy oldest_to_newest 971551 0 gyuyoung.kim 2014-01-24 01:36:44 -0800 There are below build error when building WK2 EFL on debug mode. It looks we need to use static_cast<uint64_t> for the SessionTracker's const variables. [ 86%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebPage.cpp.o /home/gyuyoung/webkit/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:617:26: warning: unused parameter ‘frame’ [-Wunused-parameter] /home/gyuyoung/webkit/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2090:6: warning: unused parameter ‘isInitialState’ [-Wunused-parameter] Linking CXX shared library ../../lib/libewebkit2.so CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebPage.cpp.o: In function `WebKit::WebPage::sessionID() const': /home/gyuyoung/webkit/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2132: undefined reference to `WebKit::SessionTracker::legacyPrivateSessionID' /home/gyuyoung/webkit/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2132: undefined reference to `WebKit::SessionTracker::defaultSessionID' collect2: error: ld returned 1 exit status make[2]: *** [lib/libewebkit2.so.0.1.0] Error 1 971552 1 222088 gyuyoung.kim 2014-01-24 01:39:04 -0800 Created attachment 222088 Patch 971562 2 ossy 2014-01-24 03:50:01 -0800 I already have a fix for it: https://bugs.webkit.org/show_bug.cgi?id=127496 A little bit different solution, but both of them work. 971564 3 gyuyoung.kim 2014-01-24 03:51:59 -0800 (In reply to comment #2) > I already have a fix for it: https://bugs.webkit.org/show_bug.cgi?id=127496 > A little bit different solution, but both of them work. Looks better solution than me ! 971565 4 gyuyoung.kim 2014-01-24 03:55:04 -0800 *** This bug has been marked as a duplicate of bug 127496 *** 222088 2014-01-24 01:39:04 -0800 2014-01-24 08:03:50 -0800 Patch bug-127549-20140124183902.patch text/plain 1536 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyNjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzllNDM3MzUxMWY5MzBj NGM3NjU3YTk5NzY1MjIxOTg0YTkxYzZmZS4uNDg5ZTE4NTUwYzk5YjgzYzg1NDQ3NzA5YTVhYTI1 OWUwNDA2OGJkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAxLTI0ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1dLMl1bRUZM XSBGaXggYSBidWlsZCBicmVhayBvbiBkZWJ1ZyBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc1NDkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNw cDogVXNlIHN0YXRpY19jYXN0PHVpbnQ2NF90Pi4KKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6 c2Vzc2lvbklEKToKKwogMjAxNC0wMS0yMyAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5j b20+CiAKICAgICAgICAgSURCOiBTdXBwb3J0IElEQk9iamVjdFN0b3JlLmNsZWFyKCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRleCAwYTNhNDZh ZmEwZjJiMzg0NWRhNjY0YWFiMGRmNjA2YjYzYjMxZDYzLi5mZWQzMDY0YmRmMmViYmZiNjNhM2Ji ZTUwYjFlNTkxMDFkNTgxMTU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL1dlYlBhZ2UuY3BwCkBAIC0yMTI4LDcgKzIxMjgsNyBAQCB1aW50NjRfdCBXZWJQYWdlOjpz ZXNzaW9uSUQoKSBjb25zdAogICAgIGlmIChtX3Nlc3Npb25JRCkKICAgICAgICAgcmV0dXJuIG1f c2Vzc2lvbklEOwogCi0gICAgcmV0dXJuIG1fcGFnZS0+c2V0dGluZ3MoKS5wcml2YXRlQnJvd3Np bmdFbmFibGVkKCkgPyBTZXNzaW9uVHJhY2tlcjo6bGVnYWN5UHJpdmF0ZVNlc3Npb25JRCA6IFNl c3Npb25UcmFja2VyOjpkZWZhdWx0U2Vzc2lvbklEOworICAgIHJldHVybiBtX3BhZ2UtPnNldHRp bmdzKCkucHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCgpID8gc3RhdGljX2Nhc3Q8dWludDY0X3Q+KFNl c3Npb25UcmFja2VyOjpsZWdhY3lQcml2YXRlU2Vzc2lvbklEKSA6IHN0YXRpY19jYXN0PHVpbnQ2 NF90PihTZXNzaW9uVHJhY2tlcjo6ZGVmYXVsdFNlc3Npb25JRCk7CiB9CiAKIHZvaWQgV2ViUGFn ZTo6ZGlkUmVjZWl2ZVBvbGljeURlY2lzaW9uKHVpbnQ2NF90IGZyYW1lSUQsIHVpbnQ2NF90IGxp c3RlbmVySUQsIHVpbnQzMl90IHBvbGljeUFjdGlvbiwgdWludDY0X3QgZG93bmxvYWRJRCkK