127528 2014-01-23 17:54:01 -0800 Set full URLs for kLSActivePageUserVisibleOriginsKey 2014-02-10 01:18:24 -0800 1 1 1 Unclassified WebKit WebKit2 525.x (Safari 3.1) Unspecified Unspecified NEW P2 Normal --- 1 barraclough barraclough oldest_to_newest 971422 0 barraclough 2014-01-23 17:54:01 -0800 In many cases the domain name is not sufficiently useful. 971423 1 222052 barraclough 2014-01-23 17:55:22 -0800 Created attachment 222052 Fix 972042 2 222052 mrowe 2014-01-25 14:35:09 -0800 Comment on attachment 222052 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=222052&action=review > Source/WebKit2/WebProcess/mac/WebProcessMac.mm:240 > + NSURL *originAsNSURL = [NSURL URLWithString:mainFrame->url()]; Elsewhere in WebKit2 we use +_web_URLWithWTFString: to convert from a String representation of a URL to NSURL. Should we do the same here? 222052 2014-01-23 17:55:22 -0800 2014-02-10 01:18:24 -0800 Fix 127528.1.patch text/plain 1982 barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjY2OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAxLTIzICBHYXZpbiBC YXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KKworICAgICAgICBTZXQgZnVsbCBV UkxzIGZvciBrTFNBY3RpdmVQYWdlVXNlclZpc2libGVPcmlnaW5zS2V5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc1MjgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvbWFjL1dlYlBy b2Nlc3NNYWMubW06CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6OnVwZGF0ZUFjdGl2ZVBh Z2VzKToKKyAgICAgICAgICAgIC0gcmVtb3ZlZCBjb2RlIHRvIHRydW5jYXRlIHRvIHNlY3VyaXR5 IG9yaWdpbi4KKwogMjAxNC0wMS0yMyAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5j b20+CiAKICAgICAgICAgQnVpbGQgYnJlYWsgYWZ0ZXIgcjE2MjY1MApJbmRleDogU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9tYWMvV2ViUHJvY2Vzc01hYy5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL21hYy9XZWJQcm9jZXNzTWFjLm1tCShyZXZpc2lvbiAxNjI1 NTgpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL21hYy9XZWJQcm9jZXNzTWFjLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC0yMzYsMTQgKzIzNiw4IEBAIHZvaWQgV2ViUHJvY2Vzczo6dXBkYXRl QWN0aXZlUGFnZXMoKQogICAgICAgICBXZWJGcmFtZSogbWFpbkZyYW1lID0gcGFnZS0+bWFpbldl YkZyYW1lKCk7CiAgICAgICAgIGlmICghbWFpbkZyYW1lKQogICAgICAgICAgICAgY29udGludWU7 Ci0gICAgICAgIFN0cmluZyBtYWluRnJhbWVPcmlnaW5TdHJpbmc7Ci0gICAgICAgIFJlZlB0cjxT ZWN1cml0eU9yaWdpbj4gbWFpbkZyYW1lT3JpZ2luID0gU2VjdXJpdHlPcmlnaW46OmNyZWF0ZUZy b21TdHJpbmcobWFpbkZyYW1lLT51cmwoKSk7Ci0gICAgICAgIGlmICghbWFpbkZyYW1lT3JpZ2lu LT5pc1VuaXF1ZSgpKQotICAgICAgICAgICAgbWFpbkZyYW1lT3JpZ2luU3RyaW5nID0gbWFpbkZy YW1lT3JpZ2luLT50b1Jhd1N0cmluZygpOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICBtYWlu RnJhbWVPcmlnaW5TdHJpbmcgPSBVUkwoVVJMKCksIG1haW5GcmFtZS0+dXJsKCkpLnByb3RvY29s KCkgKyAnOic7IC8vIHRvUmF3U3RyaW5nKCkgaXMgbm90IHN1cHBvc2VkIHRvIHdvcmsgd2l0aCB1 bmlxdWUgb3JpZ2lucywgYW5kIHdvdWxkIGp1c3QgcmV0dXJuICI6Ly8iLgogCi0gICAgICAgIE5T VVJMICpvcmlnaW5Bc05TVVJMID0gW05TVVJMIFVSTFdpdGhTdHJpbmc6bWFpbkZyYW1lT3JpZ2lu U3RyaW5nXTsKKyAgICAgICAgTlNVUkwgKm9yaWdpbkFzTlNVUkwgPSBbTlNVUkwgVVJMV2l0aFN0 cmluZzptYWluRnJhbWUtPnVybCgpXTsKICAgICAgICAgLy8gK1tOU1VSTCBVUkxXaXRoU3RyaW5n Ol0gcmV0dXJucyBuaWwgd2hlbiBpdHMgYXJndW1lbnQgaXMgbWFsZm9ybWVkLiBJdCdzIHVuY2xl YXIgaG93IHdlIGNhbiBwb3NzaWJseSBoYXZlIGEgbWFsZm9ybWVkIFVSTCBoZXJlLAogICAgICAg ICAvLyBidXQgaXQgaGFwcGVucyBpbiBwcmFjdGljZSBhY2NvcmRpbmcgdG8gPHJkYXI6Ly9wcm9i bGVtLzE0MTczMzg5Pi4gTGVhdmluZyBhbiBhc3NlcnRpb24gaW4gdG8gY2F0Y2ggYSByZXByb2R1 Y2libGUgY2FzZS4KICAgICAgICAgQVNTRVJUKG9yaWdpbkFzTlNVUkwpOwo=