127520 2014-01-23 15:51:39 -0800 Explicitly link XPC services with AppKit 2014-01-23 15:57:09 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 971370 0 andersca 2014-01-23 15:51:39 -0800 Explicitly link XPC services with AppKit 971371 1 222034 andersca 2014-01-23 15:53:21 -0800 Created attachment 222034 Patch 971374 2 222034 mrowe 2014-01-23 15:55:19 -0800 Comment on attachment 222034 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222034&action=review > Source/WebKit2/ChangeLog:3 > + Explicitly link XPC services with AppKit You're only doing this to a subset of the XPC services. It might be worth mentioning why that subset is special. > Source/WebKit2/Configurations/PluginService.64.xcconfig:38 > +FRAMEWORK_LDFLAGS = -framework Foundation $(FRAMEWORK_LDFLAGS_$(DEBUG_OR_RELEASE)); May as well revert this bit. 971375 3 andersca 2014-01-23 15:57:09 -0800 Committed r162658: <http://trac.webkit.org/changeset/162658> 222034 2014-01-23 15:53:21 -0800 2014-01-23 15:55:19 -0800 Patch bug-127520-20140123155320.patch text/plain 5204 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyNjU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjY4Yjk5OGNiMDRkZjE5 YzUxMjRlNDRjYzhjZWQ3NmNiZmYxM2RmOS4uNzAyZjJlNjRjNjkyMTQ2YTZiNWJkNmRkYmM3NTg0 NTU5NGIyZTI3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTAxLTIzICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgRXhwbGljaXRseSBs aW5rIFhQQyBzZXJ2aWNlcyB3aXRoIEFwcEtpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3NTIwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNTc1 OTcxOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IENvbmZpZ3VyYXRpb25zL1BsdWdpblNlcnZpY2UuMzIueGNjb25maWc6CisgICAgICAgICogQ29u ZmlndXJhdGlvbnMvUGx1Z2luU2VydmljZS42NC54Y2NvbmZpZzoKKyAgICAgICAgKiBDb25maWd1 cmF0aW9ucy9QbHVnaW5TZXJ2aWNlLkRldmVsb3BtZW50LnhjY29uZmlnOgorICAgICAgICAqIENv bmZpZ3VyYXRpb25zL1dlYkNvbnRlbnRTZXJ2aWNlLkRldmVsb3BtZW50LnhjY29uZmlnOgorICAg ICAgICAqIENvbmZpZ3VyYXRpb25zL1dlYkNvbnRlbnRTZXJ2aWNlLnhjY29uZmlnOgorCisyMDE0 LTAxLTIzICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAg Rml4IGJ1aWxkIGFnYWluLgogCiAgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1t OgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ29uZmlndXJhdGlvbnMvUGx1Z2luU2Vydmlj ZS4zMi54Y2NvbmZpZyBiL1NvdXJjZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL1BsdWdpblNlcnZp Y2UuMzIueGNjb25maWcKaW5kZXggZTAwMzA2YmE3OWUwY2UxNDQyYWMyZGMzMzVlZGNjYmRlNGYy YzJmZi4uZGMxOWQ0MzBmY2ZjZGJmMTQyYTg3MzExOWJmZTlmNzNiNWMwY2QyNSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvQ29uZmlndXJhdGlvbnMvUGx1Z2luU2VydmljZS4zMi54Y2NvbmZp ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0aW9ucy9QbHVnaW5TZXJ2aWNlLjMyLnhj Y29uZmlnCkBAIC00MCw3ICs0MCw4IEBAIEZSQU1FV09SS19MREZMQUdTXyA9IC1mcmFtZXdvcmsg V2ViS2l0MjsKIEZSQU1FV09SS19MREZMQUdTX05PID0gLWZyYW1ld29yayBXZWJLaXQyOwogRlJB TUVXT1JLX0xERkxBR1NfWUVTID0gOwogCi1PVEhFUl9MREZMQUdTID0gJChGUkFNRVdPUktfTERG TEFHUykgJChPVEhFUl9MREZMQUdTKSAkKE9USEVSX0xERkxBR1NfVkVSU0lPTkVEX0ZSQU1FV09S S19QQVRIKTsKK09USEVSX0xERkxBR1MgPSAkKEZSQU1FV09SS19MREZMQUdTKSAkKE9USEVSX0xE RkxBR1MpICQoT1RIRVJfTERGTEFHU18kKFBMQVRGT1JNX05BTUUpKSAkKE9USEVSX0xERkxBR1Nf VkVSU0lPTkVEX0ZSQU1FV09SS19QQVRIKTsKK09USEVSX0xERkxBR1NfbWFjb3N4ID0gLWZyYW1l d29yayBBcHBLaXQ7CiAKIENPREVfU0lHTl9FTlRJVExFTUVOVFMgPSBDb25maWd1cmF0aW9ucy9Q bHVnaW5TZXJ2aWNlLmVudGl0bGVtZW50czsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv Q29uZmlndXJhdGlvbnMvUGx1Z2luU2VydmljZS42NC54Y2NvbmZpZyBiL1NvdXJjZS9XZWJLaXQy L0NvbmZpZ3VyYXRpb25zL1BsdWdpblNlcnZpY2UuNjQueGNjb25maWcKaW5kZXggZDgxMDAyNWQ3 YjBjNjE2Mjg1YmE4Mzc5MGEyMTkwYmI2YjViZGYzOS4uOWQ2ODAzMWMyYTVlZjM1NjVkMjM4NmI4 NWNkZmJkYTdmOWZmODM0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ29uZmlndXJhdGlv bnMvUGx1Z2luU2VydmljZS42NC54Y2NvbmZpZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9Db25maWd1 cmF0aW9ucy9QbHVnaW5TZXJ2aWNlLjY0LnhjY29uZmlnCkBAIC0zNSwxMiArMzUsMTMgQEAgSU5G T1BMSVNUX0ZJTEUgPSBQbHVnaW5Qcm9jZXNzL0VudHJ5UG9pbnQvbWFjL1hQQ1NlcnZpY2UvUGx1 Z2luU2VydmljZS4zMi02NC5JbmYKIC8vIHdlIGRvbid0IGxpbmsgYWdhaW5zdCBXZWJLaXQyLCB0 byBhdm9pZCBsaW5raW5nIGVycm9ycyBkdWUgdG8gbm90IGhhdmluZyBhIFdlYktpdDIKIC8vIG9m IHRoZSByaWdodCBhcmNoaXRlY3R1cmUuCiAKLUZSQU1FV09SS19MREZMQUdTID0gLWZyYW1ld29y ayBGb3VuZGF0aW9uICQoRlJBTUVXT1JLX0xERkxBR1NfJChERUJVR19PUl9SRUxFQVNFKSk7CitG UkFNRVdPUktfTERGTEFHUyA9IC1mcmFtZXdvcmsgRm91bmRhdGlvbiAgJChGUkFNRVdPUktfTERG TEFHU18kKERFQlVHX09SX1JFTEVBU0UpKTsKIEZSQU1FV09SS19MREZMQUdTXyA9IC1mcmFtZXdv cmsgV2ViS2l0MjsKIEZSQU1FV09SS19MREZMQUdTX05PID0gLWZyYW1ld29yayBXZWJLaXQyOwog RlJBTUVXT1JLX0xERkxBR1NfWUVTID0gOwogCi1PVEhFUl9MREZMQUdTID0gJChGUkFNRVdPUktf TERGTEFHUykgJChPVEhFUl9MREZMQUdTKSAkKE9USEVSX0xERkxBR1NfVkVSU0lPTkVEX0ZSQU1F V09SS19QQVRIKTsKK09USEVSX0xERkxBR1MgPSAkKEZSQU1FV09SS19MREZMQUdTKSAkKE9USEVS X0xERkxBR1MpICQoT1RIRVJfTERGTEFHU18kKFBMQVRGT1JNX05BTUUpKSAkKE9USEVSX0xERkxB R1NfVkVSU0lPTkVEX0ZSQU1FV09SS19QQVRIKTsKK09USEVSX0xERkxBR1NfbWFjb3N4ID0gLWZy YW1ld29yayBBcHBLaXQ7CiAKIENPREVfU0lHTl9FTlRJVExFTUVOVFMgPSBDb25maWd1cmF0aW9u cy9QbHVnaW5TZXJ2aWNlLmVudGl0bGVtZW50czsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvQ29uZmlndXJhdGlvbnMvUGx1Z2luU2VydmljZS5EZXZlbG9wbWVudC54Y2NvbmZpZyBiL1Nv dXJjZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL1BsdWdpblNlcnZpY2UuRGV2ZWxvcG1lbnQueGNj b25maWcKaW5kZXggNjUyZmU4NzQwMDRlZmI5NWY5NzI3NDY3MWYwN2IzZWM3OTVlN2Q0YS4uNjU2 N2VhMTEwNTM1YjFjZjg5NTE3MWM3NWM3ZmJiNzA4YjM1NDE1OSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvQ29uZmlndXJhdGlvbnMvUGx1Z2luU2VydmljZS5EZXZlbG9wbWVudC54Y2NvbmZp ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0aW9ucy9QbHVnaW5TZXJ2aWNlLkRldmVs b3BtZW50LnhjY29uZmlnCkBAIC0zMiwzICszMiw2IEBAIFNLSVBfSU5TVEFMTCA9ICQoU0tJUF9J TlNUQUxMXyQoUExBVEZPUk1fTkFNRSkpOwogU0tJUF9JTlNUQUxMX21hY29zeCA9ICQoaW5oZXJp dGVkKTsKIFNLSVBfSU5TVEFMTF9pcGhvbmVvcyA9IFlFUzsKIFNLSVBfSU5TVEFMTF9pcGhvbmVz aW11bGF0b3IgPSAkKFNLSVBfSU5TVEFMTF9pcGhvbmVvcyk7CisKK09USEVSX0xERkxBR1MgPSAk KGluaGVyaXRlZCkgJChPVEhFUl9MREZMQUdTX1ZFUlNJT05FRF9GUkFNRVdPUktfUEFUSCkgJChP VEhFUl9MREZMQUdTXyQoUExBVEZPUk1fTkFNRSkpOworT1RIRVJfTERGTEFHU19tYWNvc3ggPSAt ZnJhbWV3b3JrIEFwcEtpdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NvbmZpZ3VyYXRp b25zL1dlYkNvbnRlbnRTZXJ2aWNlLkRldmVsb3BtZW50LnhjY29uZmlnIGIvU291cmNlL1dlYktp dDIvQ29uZmlndXJhdGlvbnMvV2ViQ29udGVudFNlcnZpY2UuRGV2ZWxvcG1lbnQueGNjb25maWcK aW5kZXggMzQyNTFhNDAwZDk1YjVlMWExMGJmMjcyZDRmZDM3YzYyMzcxNWEwMC4uODIwMWI2MjM5 ODg4MWY5MzQ3ZjhiMzQ4ZGYyOTgyOTRkODM5ZDE0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ29uZmlndXJhdGlvbnMvV2ViQ29udGVudFNlcnZpY2UuRGV2ZWxvcG1lbnQueGNjb25maWcK KysrIGIvU291cmNlL1dlYktpdDIvQ29uZmlndXJhdGlvbnMvV2ViQ29udGVudFNlcnZpY2UuRGV2 ZWxvcG1lbnQueGNjb25maWcKQEAgLTI1LDMgKzI1LDYgQEAKIAogUFJPRFVDVF9OQU1FID0gY29t LmFwcGxlLldlYktpdC5XZWJDb250ZW50LkRldmVsb3BtZW50OwogSU5GT1BMSVNUX0ZJTEUgPSBX ZWJQcm9jZXNzL0VudHJ5UG9pbnQvbWFjL1hQQ1NlcnZpY2UvV2ViQ29udGVudFNlcnZpY2UuRGV2 ZWxvcG1lbnQvSW5mby5wbGlzdDsKKworT1RIRVJfTERGTEFHUyA9ICQoaW5oZXJpdGVkKSAkKE9U SEVSX0xERkxBR1NfVkVSU0lPTkVEX0ZSQU1FV09SS19QQVRIKSAkKE9USEVSX0xERkxBR1NfJChQ TEFURk9STV9OQU1FKSk7CitPVEhFUl9MREZMQUdTX21hY29zeCA9IC1mcmFtZXdvcmsgQXBwS2l0 OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ29uZmlndXJhdGlvbnMvV2ViQ29udGVudFNl cnZpY2UueGNjb25maWcgYi9Tb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0aW9ucy9XZWJDb250ZW50 U2VydmljZS54Y2NvbmZpZwppbmRleCBmZTFjNDRhYWY0NGEzMmI4N2Q0MGY0ZjRjNzYxNDhiNWYy ZmQ2YjkxLi5hNjdlY2IzN2M3YmFhZDE4NjAxNmI1ODZkNWMyNzEwOTk1NDA0NDg3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0aW9ucy9XZWJDb250ZW50U2VydmljZS54Y2Nv bmZpZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0aW9ucy9XZWJDb250ZW50U2Vydmlj ZS54Y2NvbmZpZwpAQCAtMjgsMyArMjgsNiBAQCBQUk9EVUNUX05BTUUgPSBjb20uYXBwbGUuV2Vi S2l0LldlYkNvbnRlbnQ7CiBJTkZPUExJU1RfRklMRSA9ICQoSU5GT1BMSVNUX0ZJTEVfJChQTEFU Rk9STV9OQU1FKSk7CiBJTkZPUExJU1RfRklMRV9tYWNvc3ggPSBXZWJQcm9jZXNzL0VudHJ5UG9p bnQvbWFjL1hQQ1NlcnZpY2UvV2ViQ29udGVudFNlcnZpY2UvSW5mby1PU1gucGxpc3Q7CiBJTkZP UExJU1RfRklMRV9pcGhvbmVvcyA9IFdlYlByb2Nlc3MvRW50cnlQb2ludC9tYWMvWFBDU2Vydmlj ZS9XZWJDb250ZW50U2VydmljZS9JbmZvLWlPUy5wbGlzdDsKKworT1RIRVJfTERGTEFHUyA9ICQo aW5oZXJpdGVkKSAkKE9USEVSX0xERkxBR1NfVkVSU0lPTkVEX0ZSQU1FV09SS19QQVRIKSAkKE9U SEVSX0xERkxBR1NfJChQTEFURk9STV9OQU1FKSk7CitPVEhFUl9MREZMQUdTX21hY29zeCA9IC1m cmFtZXdvcmsgQXBwS2l0Owo=