127504 2014-01-23 12:19:14 -0800 Loads started soon after main frame completion should be considered part of the main load 2014-01-23 13:19:56 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned commit-queue japhet oldest_to_newest 971279 0 koivisto 2014-01-23 12:19:14 -0800 ProgressTracker currently decides that main load is complete when the main frame stops loading. However it is common that timers and onload events trigger more loads immediately (for example by inserting iframes) and loading continues visually. These should be considered as part of the main load for paint throttling and speculative tiling coverage purposes. 971284 1 222015 koivisto 2014-01-23 12:29:32 -0800 Created attachment 222015 patch 971305 2 222015 kling 2014-01-23 13:12:46 -0800 Comment on attachment 222015 patch r=me, but please switch this over to using monotonically increasing time instead of WTF::currentTime(). 971311 3 koivisto 2014-01-23 13:19:56 -0800 https://trac.webkit.org/r162637 222015 2014-01-23 12:29:32 -0800 2014-01-23 13:12:46 -0800 patch progress-main-load-subframe.patch text/plain 4274 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjYzMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBACisyMDE0LTAxLTIzICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBMb2FkcyBzdGFydGVkIHNvb24g YWZ0ZXIgbWFpbiBmcmFtZSBjb21wbGV0aW9uIHNob3VsZCBiZSBjb25zaWRlcmVkIHBhcnQgb2Yg dGhlIG1haW4gbG9hZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI3NTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUHJvZ3Jlc3NUcmFja2VyIGN1cnJlbnRseSBkZWNpZGVzIHRoYXQgbWFpbiBsb2FkIGlz IGNvbXBsZXRlIHdoZW4gdGhlIG1haW4gZnJhbWUgc3RvcHMgbG9hZGluZy4gCisgICAgICAgIEhv d2V2ZXIgaXQgaXMgY29tbW9uIHRoYXQgdGltZXJzIGFuZCBvbmxvYWQgZXZlbnRzIHRyaWdnZXIg bW9yZSBsb2FkcyBpbW1lZGlhdGVseSAoZm9yIGV4YW1wbGUgCisgICAgICAgIGJ5IGluc2VydGlu ZyBpZnJhbWVzKSBhbmQgbG9hZGluZyBjb250aW51ZXMgdmlzdWFsbHkuIFRoZXNlIHNob3VsZCBi ZSBjb25zaWRlcmVkIGFzIHBhcnQgb2YgdGhlCisgICAgICAgIG1haW4gbG9hZCBmb3IgcGFpbnQg dGhyb3R0bGluZyBhbmQgc3BlY3VsYXRpdmUgdGlsaW5nIGNvdmVyYWdlIHB1cnBvc2VzLgorCisg ICAgICAgICogbG9hZGVyL1Byb2dyZXNzVHJhY2tlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQ cm9ncmVzc1RyYWNrZXI6OlByb2dyZXNzVHJhY2tlcik6CisgICAgICAgIChXZWJDb3JlOjpQcm9n cmVzc1RyYWNrZXI6OnByb2dyZXNzU3RhcnRlZCk6CisgICAgICAgIAorICAgICAgICAgICAgVHJh Y2sgd2hldGhlciB0aGlzIGlzIGNvbnNpZGVyZWQgcGFydCBvZiB0aGUgbWFpbiBsb2FkIG9yIG5v dCB3aXRoIGEgYm9vbGVhbi4gCisgICAgICAgICAgICBJdCBpcyBzZXQgZm9yIHN1YmZyYW1lIGxv YWRzIHRvbyBpZiB0aGV5IHN0YXJ0IGxvYWRpbmcgc29vbiAod2l0aGluIDFzKSBhZnRlciB0aGUg bWFpbiBmcmFtZSBsb2FkIGNvbXBsZXRlcy4KKworICAgICAgICAoV2ViQ29yZTo6UHJvZ3Jlc3NU cmFja2VyOjpmaW5hbFByb2dyZXNzQ29tcGxldGUpOgorICAgICAgICAKKyAgICAgICAgICAgIEdl dCBhIHRpbWVzdGFtcC4KKworICAgICAgICAoV2ViQ29yZTo6UHJvZ3Jlc3NUcmFja2VyOjppc01h aW5Mb2FkUHJvZ3Jlc3NpbmcpOgorCisgICAgICAgICAgICBOZXcgZGVmaW5pdGlvbiBvZiAibWFp biBsb2FkIi4KKworICAgICAgICAqIGxvYWRlci9Qcm9ncmVzc1RyYWNrZXIuaDoKKwogMjAxNC0w MS0yMyAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbTVNFXVtN YWNdIEFkb3B0IG5ldyBBVlN0cmVhbURhdGFQYXJzZXIgZGVsZWdhdGUgQVBJCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvUHJvZ3Jlc3NUcmFja2VyLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvUHJvZ3Jlc3NUcmFja2VyLmNwcAkocmV2aXNpb24gMTYyNTE0KQor KysgU291cmNlL1dlYkNvcmUvbG9hZGVyL1Byb2dyZXNzVHJhY2tlci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTMzLDYgKzMzLDcgQEAKICNpbmNsdWRlICJGcmFtZUxvYWRlckNsaWVudC5oIgogI2lu Y2x1ZGUgIkluc3BlY3Rvckluc3RydW1lbnRhdGlvbi5oIgogI2luY2x1ZGUgIkxvZ2dpbmcuaCIK KyNpbmNsdWRlICJNYWluRnJhbWUuaCIKICNpbmNsdWRlICJQcm9ncmVzc1RyYWNrZXJDbGllbnQu aCIKICNpbmNsdWRlICJSZXNvdXJjZVJlc3BvbnNlLmgiCiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0 cmluZy5oPgpAQCAtODgsNiArODksOCBAQCBQcm9ncmVzc1RyYWNrZXI6OlByb2dyZXNzVHJhY2tl cihQcm9ncmVzCiAgICAgLCBtX3Byb2dyZXNzSGVhcnRiZWF0VGltZXIodGhpcywgJlByb2dyZXNz VHJhY2tlcjo6cHJvZ3Jlc3NIZWFydGJlYXRUaW1lckZpcmVkKQogICAgICwgbV9oZWFydGJlYXRz V2l0aE5vUHJvZ3Jlc3MoMCkKICAgICAsIG1fdG90YWxCeXRlc1JlY2VpdmVkQmVmb3JlUHJldmlv dXNIZWFydGJlYXQoMCkKKyAgICAsIG1fbWFpbkxvYWRDb21wbGV0aW9uVGltZVN0YW1wKDApCisg ICAgLCBtX2lzTWFpbkxvYWQoZmFsc2UpCiB7CiB9CiAKQEAgLTEzMyw2ICsxMzYsMTIgQEAgdm9p ZCBQcm9ncmVzc1RyYWNrZXI6OnByb2dyZXNzU3RhcnRlZChGcgogICAgICAgICBtX3Byb2dyZXNz SGVhcnRiZWF0VGltZXIuc3RhcnRSZXBlYXRpbmcocHJvZ3Jlc3NIZWFydGJlYXRJbnRlcnZhbCk7 CiAgICAgICAgIG1fb3JpZ2luYXRpbmdQcm9ncmVzc0ZyYW1lLT5sb2FkZXIoKS5sb2FkUHJvZ3Jl c3NpbmdTdGF0dXNDaGFuZ2VkKCk7CiAKKyAgICAgICAgYm9vbCBpc01haW5GcmFtZSA9ICFtX29y aWdpbmF0aW5nUHJvZ3Jlc3NGcmFtZS0+dHJlZSgpLnBhcmVudCgpOworICAgICAgICBkb3VibGUg ZWxhcHNlZFRpbWVTaW5jZU1haW5Mb2FkQ29tcGxldGUgPSBjdXJyZW50VGltZSgpIC0gbV9tYWlu TG9hZENvbXBsZXRpb25UaW1lU3RhbXA7CisKKyAgICAgICAgc3RhdGljIGNvbnN0IGRvdWJsZSBz dWJmcmFtZVBhcnRPZk1haW5Mb2FkVGhyZXNob2xkID0gMTsKKyAgICAgICAgbV9pc01haW5Mb2Fk ID0gaXNNYWluRnJhbWUgfHwgZWxhcHNlZFRpbWVTaW5jZU1haW5Mb2FkQ29tcGxldGUgPCBzdWJm cmFtZVBhcnRPZk1haW5Mb2FkVGhyZXNob2xkOworCiAgICAgICAgIG1fY2xpZW50LnByb2dyZXNz U3RhcnRlZCgqbV9vcmlnaW5hdGluZ1Byb2dyZXNzRnJhbWUpOwogICAgIH0KICAgICBtX251bVBy b2dyZXNzVHJhY2tlZEZyYW1lcysrOwpAQCAtMTcyLDYgKzE4MSw5IEBAIHZvaWQgUHJvZ3Jlc3NU cmFja2VyOjpmaW5hbFByb2dyZXNzQ29tcGwKIAogICAgIHJlc2V0KCk7CiAKKyAgICBpZiAobV9p c01haW5Mb2FkKQorICAgICAgICBtX21haW5Mb2FkQ29tcGxldGlvblRpbWVTdGFtcCA9IGN1cnJl bnRUaW1lKCk7CisKICAgICBmcmFtZS0+bG9hZGVyKCkuY2xpZW50KCkuc2V0TWFpbkZyYW1lRG9j dW1lbnRSZWFkeSh0cnVlKTsKICAgICBtX2NsaWVudC5wcm9ncmVzc0ZpbmlzaGVkKCpmcmFtZSk7 CiAgICAgZnJhbWUtPmxvYWRlcigpLmxvYWRQcm9ncmVzc2luZ1N0YXR1c0NoYW5nZWQoKTsKQEAg LTI5MSw5ICszMDMsMTAgQEAgYm9vbCBQcm9ncmVzc1RyYWNrZXI6OmlzTWFpbkxvYWRQcm9ncmVz cwogewogICAgIGlmICghbV9vcmlnaW5hdGluZ1Byb2dyZXNzRnJhbWUpCiAgICAgICAgIHJldHVy biBmYWxzZTsKLSAgICAvLyBTZWUgaWYgdGhlIGxvYWQgb3JpZ2luYXRlZCBmcm9tIGEgc3ViZnJh bWUuCi0gICAgaWYgKG1fb3JpZ2luYXRpbmdQcm9ncmVzc0ZyYW1lLT50cmVlKCkucGFyZW50KCkp CisKKyAgICBpZiAoIW1faXNNYWluTG9hZCkKICAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAg cmV0dXJuIG1fcHJvZ3Jlc3NWYWx1ZSAmJiBtX3Byb2dyZXNzVmFsdWUgPCBmaW5hbFByb2dyZXNz VmFsdWUgJiYgbV9oZWFydGJlYXRzV2l0aE5vUHJvZ3Jlc3MgPCBsb2FkU3RhbGxlZEhlYXJ0YmVh dENvdW50OwogfQogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvUHJvZ3Jlc3NUcmFja2Vy LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL1Byb2dyZXNzVHJhY2tlci5o CShyZXZpc2lvbiAxNjI1MTQpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvUHJvZ3Jlc3NUcmFj a2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTg3LDYgKzg3LDggQEAgcHJpdmF0ZToKICAgICBUaW1l cjxQcm9ncmVzc1RyYWNrZXI+IG1fcHJvZ3Jlc3NIZWFydGJlYXRUaW1lcjsKICAgICB1bnNpZ25l ZCBtX2hlYXJ0YmVhdHNXaXRoTm9Qcm9ncmVzczsKICAgICBsb25nIGxvbmcgbV90b3RhbEJ5dGVz UmVjZWl2ZWRCZWZvcmVQcmV2aW91c0hlYXJ0YmVhdDsKKyAgICBkb3VibGUgbV9tYWluTG9hZENv bXBsZXRpb25UaW1lU3RhbXA7CisgICAgYm9vbCBtX2lzTWFpbkxvYWQ7CiB9OwogICAgIAogfQo=