127496 2014-01-23 10:46:11 -0800 [EFL][WK2] Debug buildfix 2014-01-24 04:04:40 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy gyuyoung.kim ossy oldest_to_newest 971229 0 ossy 2014-01-23 10:46:11 -0800 On Ubuntu 12.04 with GCC 4.7.3 (Ubuntu/Linaro 4.7.3-2ubuntu1~12.04) I got the following build failure only in debug mode: $ Tools/Scripts/build-webkit --debug --efl --cmakeargs="-DSHARED_CORE=ON" Linking CXX shared library ../../lib/libewebkit2.so CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebPage.cpp.o: In function `WebKit::WebPage::sessionID() const': /home/ossy/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2130: undefined reference to `WebKit::SessionTracker::legacyPrivateSessionID' /home/ossy/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2130: undefined reference to `WebKit::SessionTracker::defaultSessionID' collect2: error: ld returned 1 exit status make[2]: *** [lib/libewebkit2.so.0.1.0] Error 1 make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2 make: *** [all] Error 2 971233 1 222002 ossy 2014-01-23 10:50:03 -0800 Created attachment 222002 Patch 971566 2 gyuyoung.kim 2014-01-24 03:55:04 -0800 *** Bug 127549 has been marked as a duplicate of this bug. *** 971568 3 ossy 2014-01-24 03:59:12 -0800 landed in r162699 971569 4 gyuyoung.kim 2014-01-24 04:01:37 -0800 (In reply to comment #3) > landed in r162699 This patch belong to WK2 owner area, this patch is to fix build error. So, I believe this doesn't violate WK2 owner policy. 971570 5 ossy 2014-01-24 04:03:37 -0800 Trivial buildfixes don't need owner review. 971572 6 gyuyoung.kim 2014-01-24 04:04:40 -0800 (In reply to comment #5) > Trivial buildfixes don't need owner review. I see. :D Thanks. 222002 2014-01-23 10:50:03 -0800 2014-01-24 03:59:22 -0800 Patch bug-127496-20140123195001.patch text/plain 1185 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyNjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDI2NWZkZTkxNTMwOWUx NTk1ZDhiZDQ2YmEyMDgzNGI5OWEzYjRlYi4uNjM4Y2Q1YzQ2OTdmYzllZDliZjc4NmUyNjVlNGFm Yzg5ZTQ0MThkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAxLTIzICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0VGTF1bV0syXSBE ZWJ1ZyBidWlsZGZpeAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI3NDk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTaGFyZWQvU2Vzc2lvblRyYWNrZXIuY3BwOgorCiAyMDE0LTAxLTIzICBUaW0gSG9y dG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFtXSzJdIFdL Q29udGVudFZpZXcgaGFzIGEgYmxhY2sgYmFja2dyb3VuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvU2hhcmVkL1Nlc3Npb25UcmFja2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9T ZXNzaW9uVHJhY2tlci5jcHAKaW5kZXggYmFhZmY5YjM5NDZkNzQwYTc4MDc4YTRmOTBiMTIwMzY0 NDk1ZTg3YS4uM2VkNTk2Zjk3YWMzMWFkZTVlOGUwYTllY2I4ZDY2NWI2NTI4NTYzNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1Nlc3Npb25UcmFja2VyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9TaGFyZWQvU2Vzc2lvblRyYWNrZXIuY3BwCkBAIC0zMyw2ICszMyw5IEBAIHVz aW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAorY29uc3QgdWlu dDY0X3QgU2Vzc2lvblRyYWNrZXI6OmRlZmF1bHRTZXNzaW9uSUQ7Citjb25zdCB1aW50NjRfdCBT ZXNzaW9uVHJhY2tlcjo6bGVnYWN5UHJpdmF0ZVNlc3Npb25JRDsKKwogc3RhdGljIEhhc2hNYXA8 dWludDY0X3QsIHN0ZDo6dW5pcXVlX3B0cjxOZXR3b3JrU3RvcmFnZVNlc3Npb24+PiYgc3RhdGlj U2Vzc2lvbk1hcCgpCiB7CiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsK