127471 2014-01-23 01:15:16 -0800 [iOS] [WK2] WKContentView has a black background 2014-01-23 10:47:49 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca sam simon.fraser oldest_to_newest 971074 0 thorton 2014-01-23 01:15:16 -0800 ... which is frequently exposed during loading. It shouldn't be black (it shouldn't need a background at all!). <rdar://problem/12287363> 971076 1 221961 thorton 2014-01-23 01:19:25 -0800 Created attachment 221961 patch 971085 2 221961 ian 2014-01-23 02:20:06 -0800 Comment on attachment 221961 patch View in context: https://bugs.webkit.org/attachment.cgi?id=221961&action=review > Source/WebKit2/UIProcess/API/ios/WKContentView.mm:52 > +@end Is this how we deal with private headers on the Mac? Why even include the private header if we're going to make this category? 971129 3 221961 sam 2014-01-23 07:44:16 -0800 Comment on attachment 221961 patch View in context: https://bugs.webkit.org/attachment.cgi?id=221961&action=review >> Source/WebKit2/UIProcess/API/ios/WKContentView.mm:52 >> +@end > > Is this how we deal with private headers on the Mac? Why even include the private header if we're going to make this category? I think we usually do the category as an #else clause. 971131 4 sam 2014-01-23 07:45:11 -0800 (In reply to comment #3) > (From update of attachment 221961 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=221961&action=review > > >> Source/WebKit2/UIProcess/API/ios/WKContentView.mm:52 > >> +@end > > > > Is this how we deal with private headers on the Mac? Why even include the private header if we're going to make this category? > > I think we usually do the category as an #else clause. Oh, and reason we do it is to catch errors for people who have the header. 971157 5 thorton 2014-01-23 08:58:28 -0800 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 221961 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=221961&action=review > > > > >> Source/WebKit2/UIProcess/API/ios/WKContentView.mm:52 > > >> +@end > > > > > > Is this how we deal with private headers on the Mac? Why even include the private header if we're going to make this category? > > > > I think we usually do the category as an #else clause. > > Oh, and reason we do it is to catch errors for people who have the header. Exactly. If we put it in an #else, we wouldn't (as readily) catch signature changes. I think the only case we use a #else is if we need to magic the class itself into existence (when the class itself is also private). 971213 6 221961 andersca 2014-01-23 10:10:26 -0800 Comment on attachment 221961 patch View in context: https://bugs.webkit.org/attachment.cgi?id=221961&action=review > Source/WebKit2/UIProcess/API/ios/WKContentView.mm:46 > +#if defined(__has_include) && __has_include(<QuartzCore/QuartzCorePrivate.h>) Do we really need the #if defined(__has_include) part here? 971228 7 thorton 2014-01-23 10:40:02 -0800 (In reply to comment #6) > (From update of attachment 221961 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=221961&action=review > > > Source/WebKit2/UIProcess/API/ios/WKContentView.mm:46 > > +#if defined(__has_include) && __has_include(<QuartzCore/QuartzCorePrivate.h>) > > Do we really need the #if defined(__has_include) part here? I don’t think we do anymore (or maybe ever?) 971231 8 thorton 2014-01-23 10:47:49 -0800 http://trac.webkit.org/changeset/162626 221961 2014-01-23 01:19:25 -0800 2014-01-23 10:10:26 -0800 patch blackbackground.diff text/plain 2223 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3Y2QwODg1Li41NDhhNzI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDEtMjMgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgW2lPU10gW1dLMl0gV0tDb250ZW50VmlldyBoYXMgYSBibGFjayBiYWNrZ3JvdW5k CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc0NzEK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyMjg3MzYzPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9pb3MvV0tDb250ZW50 Vmlldy5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfY29tbW9uSW5pdGlhbGl6YXRpb25X aXRoQ29udGV4dFJlZjpwYWdlR3JvdXBSZWY6cmVsYXRlZFRvUGFnZTpdKToKKyAgICAgICAgSW5z dGVhZCBvZiBnaXZpbmcgaXQgYSAoYmxhY2shKSBiYWNrZ3JvdW5kIHRvIG1ha2UgaGl0LXRlc3Rp bmcgd29yaywgdXNlIENBTGF5ZXIgU1BJCisgICAgICAgIHRvIHRlbGwgQ0EgdGhhdCB0aGUgd2hv bGUgbGF5ZXIgc2hvdWxkIGJlIHRyZWF0ZWQgYXMgb3BhcXVlIHdoZW4gaXQgY29tZXMgdG8gaGl0 LXRlc3RpbmcuCisKIDIwMTQtMDEtMjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtHTElCXSBVc2UgR1VuaXF1ZVB0ciBpbnN0ZWFkIG9mIEdP d25QdHIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvaW9zL1dLQ29u dGVudFZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2lvcy9XS0NvbnRlbnRW aWV3Lm1tCmluZGV4IGU5ZDA5YTguLjlmNzE2ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvaW9zL1dLQ29udGVudFZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9pb3MvV0tDb250ZW50Vmlldy5tbQpAQCAtNDMsNiArNDMsMTQgQEAKICNp bXBvcnQgPFdlYkNvcmUvVmlld3BvcnRBcmd1bWVudHMuaD4KICNpbXBvcnQgPHd0Zi9SZXRhaW5Q dHIuaD4KIAorI2lmIGRlZmluZWQoX19oYXNfaW5jbHVkZSkgJiYgX19oYXNfaW5jbHVkZSg8UXVh cnR6Q29yZS9RdWFydHpDb3JlUHJpdmF0ZS5oPikKKyNpbXBvcnQgPFF1YXJ0ekNvcmUvUXVhcnR6 Q29yZVByaXZhdGUuaD4KKyNlbmRpZgorCitAaW50ZXJmYWNlIENBTGF5ZXIgKERldGFpbHMpCitA cHJvcGVydHkgQk9PTCBoaXRUZXN0c0FzT3BhcXVlOworQGVuZAorCiB1c2luZyBuYW1lc3BhY2Ug V2ViQ29yZTsKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAKQEAgLTE4MCwxMCArMTg4LDYgQEAg dXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKIAogLSAodm9pZClfY29tbW9uSW5pdGlhbGl6YXRpb25X aXRoQ29udGV4dFJlZjooV0tDb250ZXh0UmVmKWNvbnRleHRSZWYgcGFnZUdyb3VwUmVmOihXS1Bh Z2VHcm91cFJlZilwYWdlR3JvdXBSZWYgcmVsYXRlZFRvUGFnZTooV0tQYWdlUmVmKXJlbGF0ZWRQ YWdlCiB7Ci0gICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIG5vdCBiZSBuZWNlc3NhcnksIGZpbmQg d2h5IGhpdCB0ZXN0aW5nIGRvZXMgbm90IHdvcmsgb3RoZXJ3aXNlLgotICAgIC8vIDxyZGFyOi8v cHJvYmxlbS8xMjI4NzM2Mz4KLSAgICBzZWxmLmJhY2tncm91bmRDb2xvciA9IFtVSUNvbG9yIGJs YWNrQ29sb3JdOwotCiAgICAgSW5pdGlhbGl6ZVdlYktpdDIoKTsKICAgICBSdW5Mb29wOjppbml0 aWFsaXplTWFpblJ1bkxvb3AoKTsKIApAQCAtMjA0LDYgKzIwOCw4IEBAIHVzaW5nIG5hbWVzcGFj ZSBXZWJLaXQ7CiAgICAgX2ludGVyYWN0aW9uVmlldyA9IGFkb3B0TlMoW1tXS0ludGVyYWN0aW9u VmlldyBhbGxvY10gaW5pdF0pOwogICAgIFtfaW50ZXJhY3Rpb25WaWV3IHNldFBhZ2U6X3BhZ2Vd OwogICAgIFtzZWxmIGFkZFN1YnZpZXc6X2ludGVyYWN0aW9uVmlldy5nZXQoKV07CisKKyAgICBz ZWxmLmxheWVyLmhpdFRlc3RzQXNPcGFxdWUgPSBZRVM7CiB9CiAKIC0gKHZvaWQpX3dpbmRvd0Rp ZE1vdmVUb1NjcmVlbk5vdGlmaWNhdGlvbjooTlNOb3RpZmljYXRpb24gKilub3RpZmljYXRpb24K