127470 2014-01-23 01:14:47 -0800 Remove unused RuntimeEnabledFeatures 2014-01-24 00:07:01 -0800 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 allan.jensen allan.jensen kling oldest_to_newest 971072 0 allan.jensen 2014-01-23 01:14:47 -0800 Remove the unused indexedDBEnabled(), webSocketEnabled() and sharedWorkerEnabled(). Their presence is only confusing. 971075 1 221960 allan.jensen 2014-01-23 01:16:47 -0800 Created attachment 221960 Patch 971343 2 221960 ap 2014-01-23 14:38:07 -0800 Comment on attachment 221960 Patch EWS is red, saying that these are used in generated code: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSDOMWindow.cpp:4922:51: error: no member named 'webSocketEnabled' in 'WebCore::RuntimeEnabledFeatures' if (!RuntimeEnabledFeatures::sharedFeatures().webSocketEnabled()) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSDOMWindow.cpp:8984:51: error: no member named 'sharedWorkerEnabled' in 'WebCore::RuntimeEnabledFeatures' if (!RuntimeEnabledFeatures::sharedFeatures().sharedWorkerEnabled()) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ IndexedDB is disabled IIRC, otherwise it would almost certainly fail too. 221960 2014-01-23 01:16:47 -0800 2014-01-23 14:38:06 -0800 Patch bug-127470-20140123101646.patch text/plain 3273 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyNjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2JlOWE0NjM1MGM5NDMz NzU0MjgyMzgxZTIzZjI2ODkxOTI1ZWZiZC4uMDk2MzM5MGMyNjgxNmZhMTM5OWM5ZmUxODE1YjQx ZWQ4OTE3ODRlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAxLTIzICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFJl bW92ZSB1bnVzZWQgUnVudGltZUVuYWJsZWRGZWF0dXJlcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3NDcwCisKKyAgICAgICAgUmVtb3ZlIHRoZSB1 bnVzZWQgaW5kZXhlZERCRW5hYmxlZCgpLCB3ZWJTb2NrZXRFbmFibGVkKCkgYW5kIHNoYXJlZFdv cmtlckVuYWJsZWQoKSBtZXRob2RzLgorCisgICAgICAgICogYmluZGluZ3MvZ2VuZXJpYy9SdW50 aW1lRW5hYmxlZEZlYXR1cmVzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJ1bnRpbWVFbmFibGVk RmVhdHVyZXM6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXMpOgorICAgICAgICAqIGJpbmRpbmdzL2dl bmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oOgorCiAyMDE0LTAxLTIzICBMw6FzemzDsyBM YW5nw7MgIDxsbGFuZ28udS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KIAogICAgICAgICBS YW5nZSBzaG91bGQgYmUgY29uc3RydWN0YWJsZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuY3BwCmluZGV4IDgy Yjk4ODYzYWQ3YWE0YjY0MmJlZDlhOGM0ODVhMzIwNTYwZGMyYTIuLjE5N2MxODI5MzhkYmM4YTEx NDc2NDI3YTYxMzhjNzAzNmZlOGY0OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNwcApAQCAtNDcsNyAr NDcsNiBAQCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpSdW50aW1lRW5hYmxlZEZlYXR1cmVzKCkK ICAgICAsIG1faXNBcHBsaWNhdGlvbkNhY2hlRW5hYmxlZCh0cnVlKQogICAgICwgbV9pc0RhdGFU cmFuc2Zlckl0ZW1zRW5hYmxlZCh0cnVlKQogICAgICwgbV9pc0dlb2xvY2F0aW9uRW5hYmxlZCh0 cnVlKQotICAgICwgbV9pc0luZGV4ZWREQkVuYWJsZWQoZmFsc2UpCiAgICAgLCBtX2lzVG91Y2hF bmFibGVkKHRydWUpCiAgICAgLCBtX2lzRGV2aWNlTW90aW9uRW5hYmxlZCh0cnVlKQogICAgICwg bV9pc0RldmljZU9yaWVudGF0aW9uRW5hYmxlZCh0cnVlKQpAQCAtMTYzLDE4ICsxNjIsNCBAQCBi b29sIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnRpbWVSYW5nZXNFbmFibGVkKCkgY29uc3QKIH0K ICNlbmRpZgogCi0jaWYgRU5BQkxFKFNIQVJFRF9XT1JLRVJTKQotYm9vbCBSdW50aW1lRW5hYmxl ZEZlYXR1cmVzOjpzaGFyZWRXb3JrZXJFbmFibGVkKCkgY29uc3QKLXsKLSAgICByZXR1cm4gU2hh cmVkV29ya2VyUmVwb3NpdG9yeTo6aXNBdmFpbGFibGUoKTsKLX0KLSNlbmRpZgotCi0jaWYgRU5B QkxFKFdFQl9TT0NLRVRTKQotYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjp3ZWJTb2NrZXRF bmFibGVkKCkgY29uc3QKLXsKLSAgICByZXR1cm4gV2ViU29ja2V0Ojppc0F2YWlsYWJsZSgpOwot fQotI2VuZGlmCi0KIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmgKaW5kZXgg MjcyMDkwMWU1NWFmMjJmMGQ4ODZmZTc1OTVlNmIzMzJlMmM3Y2ZlYi4uNTdiYzc1MjliMmIwMzlh NGE2YWUwMzdjNWQyNDBlNTM1MzgwYmQwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmgKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmgKQEAgLTYyLDEwICs2 Miw2IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldEdlb2xvY2F0aW9uRW5hYmxlZChib29sIGlzRW5h YmxlZCkgeyBtX2lzR2VvbG9jYXRpb25FbmFibGVkID0gaXNFbmFibGVkOyB9CiAgICAgYm9vbCBn ZW9sb2NhdGlvbkVuYWJsZWQoKSBjb25zdCB7IHJldHVybiBtX2lzR2VvbG9jYXRpb25FbmFibGVk OyB9CiAKLSAgICB2b2lkIHNldFdlYmtpdEluZGV4ZWREQkVuYWJsZWQoYm9vbCBpc0VuYWJsZWQp IHsgbV9pc0luZGV4ZWREQkVuYWJsZWQgPSBpc0VuYWJsZWQ7IH0KLSAgICBib29sIHdlYmtpdElu ZGV4ZWREQkVuYWJsZWQoKSBjb25zdCB7IHJldHVybiBtX2lzSW5kZXhlZERCRW5hYmxlZDsgfQot ICAgIGJvb2wgaW5kZXhlZERCRW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1faXNJbmRleGVkREJF bmFibGVkOyB9Ci0KICNpZiBFTkFCTEUoQ1NTX0VYQ0xVU0lPTlMpCiAgICAgdm9pZCBzZXRDU1NF eGNsdXNpb25zRW5hYmxlZChib29sIGlzRW5hYmxlZCkgeyBtX2lzQ1NTRXhjbHVzaW9uc0VuYWJs ZWQgPSBpc0VuYWJsZWQ7IH0KICAgICBib29sIGNzc0V4Y2x1c2lvbnNFbmFibGVkKCkgY29uc3Qg eyByZXR1cm4gbV9pc0NTU0V4Y2x1c2lvbnNFbmFibGVkOyB9CkBAIC0xMTIsMTQgKzEwOCw2IEBA IHB1YmxpYzoKICAgICBib29sIHRpbWVSYW5nZXNFbmFibGVkKCkgY29uc3Q7CiAjZW5kaWYKIAot I2lmIEVOQUJMRShTSEFSRURfV09SS0VSUykKLSAgICBib29sIHNoYXJlZFdvcmtlckVuYWJsZWQo KSBjb25zdDsKLSNlbmRpZgotCi0jaWYgRU5BQkxFKFdFQl9TT0NLRVRTKQotICAgIGJvb2wgd2Vi U29ja2V0RW5hYmxlZCgpIGNvbnN0OwotI2VuZGlmCi0KICNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRT KQogICAgIGJvb2wgdG91Y2hFbmFibGVkKCkgY29uc3QgeyByZXR1cm4gbV9pc1RvdWNoRW5hYmxl ZDsgfQogICAgIHZvaWQgc2V0VG91Y2hFbmFibGVkKGJvb2wgaXNFbmFibGVkKSB7IG1faXNUb3Vj aEVuYWJsZWQgPSBpc0VuYWJsZWQ7IH0K