<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>127463</bug_id>
          
          <creation_ts>2014-01-22 22:09:11 -0800</creation_ts>
          <short_desc>3x splay regression in FTL with experimental coverage that is entirely due to Bartlett weirdness</short_desc>
          <delta_ts>2014-01-23 17:14:19 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>112840</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Filip Pizlo">fpizlo</assigned_to>
          <cc>atrick</cc>
    
    <cc>barraclough</cc>
    
    <cc>ggaren</cc>
    
    <cc>mark.lam</cc>
    
    <cc>mhahnenberg</cc>
    
    <cc>mmirman</cc>
    
    <cc>msaboff</cc>
    
    <cc>nrotem</cc>
    
    <cc>oliver</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>971026</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2014-01-22 22:09:11 -0800</bug_when>
    <thetext>Hopefully, I&apos;ll find the right place to zero the stack or do other stuff just like all of the other times.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>971027</commentid>
    <comment_count>1</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2014-01-22 22:10:51 -0800</bug_when>
    <thetext>O_o</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>971028</commentid>
    <comment_count>2</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2014-01-22 22:16:24 -0800</bug_when>
    <thetext>(In reply to comment #1)
&gt; O_o

Dude, it&apos;s hilarious.  We get one of these every few months.

Splay trees imply essentially always inserting at the root and then having the root point at everything else.  Broadly speaking any node that was ever a root will continue to indefinitely have a transitive reference to every node that had been part of the tree at that time.

So, if you have a benchmark, like Splay, and at some point some pointer to the tree gets stuck on the stack and then you add and remove a bunch of things to the tree, then you end up doubling your heap size.  This is because that one stuck pointer will refer to all of the nodes that were the &quot;old&quot; tree at the time it got stuck, even if all of the nodes in that old tree get removed from the actual current tree.

But wait, there&apos;s more.  Because of how removal happens, the stuck pointer will be likely to transitively refer to every node that had ever been part of the tree since when the pointer got stuck until the present time.  So, in V8v7/splay, after a pointer gets stuck, you cease to be able to collect any garbage.

Interestingly, this almost never happens in-browser and only happens with the way I run splay in my harness.  So, it&apos;s not all that alarming.

In all cases when this happens, it&apos;s because a pointer gets stuck due to a goof in either OSR entry or in the GC&apos;s stack scan.  I&apos;m guessing that this bug is due to FTL OSR entry.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>971034</commentid>
    <comment_count>3</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2014-01-22 22:34:36 -0800</bug_when>
    <thetext>It looks like it requires that both splay_() and remove() get compiled with the FTL.  I can see the regression if just those two get compiled.  If I remove either one of them then the regression disappears.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>971349</commentid>
    <comment_count>4</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2014-01-23 14:45:59 -0800</bug_when>
    <thetext>Ha!  This is entirely due to some sloppiness with scratch buffers.  I think that we claim to be using one at some point, then we dump a bunch of pointers into it, and then we never &quot;free&quot; it - so the GC keeps rescanning it ad infinitum.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>971368</commentid>
    <comment_count>5</comment_count>
      <attachid>222033</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2014-01-23 15:40:38 -0800</bug_when>
    <thetext>Created attachment 222033
the patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>971369</commentid>
    <comment_count>6</comment_count>
      <attachid>222033</attachid>
    <who name="Mark Hahnenberg">mhahnenberg</who>
    <bug_when>2014-01-23 15:42:41 -0800</bug_when>
    <thetext>Comment on attachment 222033
the patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>971404</commentid>
    <comment_count>7</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2014-01-23 17:14:19 -0800</bug_when>
    <thetext>Landed in http://trac.webkit.org/changeset/162666</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>222033</attachid>
            <date>2014-01-23 15:40:38 -0800</date>
            <delta_ts>2014-01-23 15:42:40 -0800</delta_ts>
            <desc>the patch</desc>
            <filename>blah.patch</filename>
            <type>text/plain</type>
            <size>7560</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYyNjU1KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM0IEBA
CisyMDE0LTAxLTIzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg
M3ggc3BsYXkgcmVncmVzc2lvbiBpbiBGVEwgd2l0aCBleHBlcmltZW50YWwgY292ZXJhZ2UgdGhh
dCBpcyBlbnRpcmVseSBkdWUgdG8gQmFydGxldHQgd2VpcmRuZXNzCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc0NjMKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoaXMgdHVybmVkIG91dCB0
byBiZSBlbnRpcmVseSBkdWUgdG8gbWlzdXNlIG9mIHRoZSBzY3JhdGNoIGJ1ZmZlciBpbiBhbiBG
VEwgdGh1bmsuCisgICAgICAgIFdlIG5lZWQgdG8gbWFyayBhIHNjcmF0Y2ggYnVmZmVyIGFzIHVu
dXNlZCBhZnRlciB3ZSdyZSBkb25lIHdpdGggaXQgb3IgZWxzZSB0aGUgR0MKKyAgICAgICAgd2ls
bCBoYXZlIGEgYmFkIHRpbWUuCisgICAgICAgIAorICAgICAgICBCdXQsIHRoaXMgYWxzbyBpbnRy
b2R1Y2VzIHNvbWUgZGVidWdnaW5nLXJlbGF0ZWQgdGhpbmdzIHRoYXQgd2VyZSB1c2VmdWwgb24g
bXkKKyAgICAgICAgam91cm5leS4KKyAgICAgICAgCisgICAgICAgIEZpbmFsbHksIHRoaXMgdHVy
bnMgYWxsIGV4cGVyaW1lbnRhbCBGVEwgY292ZXJhZ2UgaW50byBub24tZXhwZXJpbWVudGFsIGNv
dmVyYWdlIGZvcgorICAgICAgICBub3cuIEknbSBrZWVwaW5nIHRoZSBvcHRpb24gYmVjYXVzZSB3
ZSB3aWxsIHByb2JhYmx5IG1ha2Ugb3RoZXIgdGhpbmdzICJleHBlcmltZW50YWwiCisgICAgICAg
IGluIHRoZSBuZWFyIGZ1dHVyZSwgaWYgdGhleSBjYXVzZSByZWdyZXNzaW9ucy4KKworICAgICAg
ICAqIGRmZy9ERkdUaWVyVXBDaGVja0luamVjdGlvblBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6
REZHOjpUaWVyVXBDaGVja0luamVjdGlvblBoYXNlOjpydW4pOiBNYWRlIGl0IHBvc3NpYmxlIHRv
IGRpc2FibGUgRlRMIE9TUiBlbnRyeS4KKyAgICAgICAgKiBmdGwvRlRMQ2FwYWJpbGl0aWVzLmNw
cDoKKyAgICAgICAgKEpTQzo6RlRMOjpjYW5Db21waWxlKTogTWFrZSB0aGUgbmV3IE5vZGVUeXBl
cyBub24tZXhwZXJpbWVudGFsLgorICAgICAgICAqIGZ0bC9GVExUaHVua3MuY3BwOgorICAgICAg
ICAoSlNDOjpGVEw6Om9zckV4aXRHZW5lcmF0aW9uVGh1bmtHZW5lcmF0b3IpOiBGaXggdGhlIGFj
dHVhbCBidWcuCisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc206CisgICAg
ICAgICogcnVudGltZS9PcHRpb25zLmg6CisgICAgICAgICogcnVudGltZS9WTS5jcHA6CisgICAg
ICAgIChKU0M6OmxvZ1Nhbml0aXplU3RhY2spOgorICAgICAgICAqIHJ1bnRpbWUvVk0uaDoKKyAg
ICAgICAgKEpTQzo6c2FuaXRpemVTdGFja0ZvclZNKTogVGhpcyBpcyBhbGwgYWJvdXQgbWFraW5n
IGl0IHBvc3NpYmxlIHRvIHByaW50IHRoaW5ncyB3aGVuIHRoZSBzdGFjayBpcyBzYW5pdGl6ZWQu
CisKIDIwMTQtMDEtMjMgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4K
IAogICAgICAgICBNZXJnZSBicmFuY2ggdXAgdG8gVG9UIHIxNjE2NTguCkluZGV4OiBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvZGZnL0RGR1RpZXJVcENoZWNrSW5qZWN0aW9uUGhhc2UuY3BwCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHVGllclVwQ2hlY2tJbmplY3Rp
b25QaGFzZS5jcHAJKHJldmlzaW9uIDE2MjU1MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k
ZmcvREZHVGllclVwQ2hlY2tJbmplY3Rpb25QaGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU4
LDYgKzU4LDkgQEAgcHVibGljOgogICAgICAgICBpZiAobGV2ZWwgPT0gRlRMOjpDYW5ub3RDb21w
aWxlKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAKKyAgICAgICAgaWYgKCFP
cHRpb25zOjplbmFibGVPU1JFbnRyeVRvRlRMKCkpCisgICAgICAgICAgICBsZXZlbCA9IEZUTDo6
Q2FuQ29tcGlsZTsKKyAgICAgICAgCiAgICAgICAgIEluc2VydGlvblNldCBpbnNlcnRpb25TZXQo
bV9ncmFwaCk7CiAgICAgICAgIGZvciAoQmxvY2tJbmRleCBibG9ja0luZGV4ID0gbV9ncmFwaC5u
dW1CbG9ja3MoKTsgYmxvY2tJbmRleC0tOykgewogICAgICAgICAgICAgQmFzaWNCbG9jayogYmxv
Y2sgPSBtX2dyYXBoLmJsb2NrKGJsb2NrSW5kZXgpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRD
b3JlL2Z0bC9GVExDYXBhYmlsaXRpZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny
aXB0Q29yZS9mdGwvRlRMQ2FwYWJpbGl0aWVzLmNwcAkocmV2aXNpb24gMTYyNTk1KQorKysgU291
cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExDYXBhYmlsaXRpZXMuY3BwCSh3b3JraW5nIGNvcHkp
CkBAIC0xMjIsNiArMTIyLDExIEBAIGlubGluZSBDYXBhYmlsaXR5TGV2ZWwgY2FuQ29tcGlsZShO
b2RlKiAKICAgICBjYXNlIENvdW50RXhlY3V0aW9uOgogICAgIGNhc2UgQ2hlY2tFeGVjdXRhYmxl
OgogICAgIGNhc2UgR2V0U2NvcGU6CisgICAgY2FzZSBBbGxvY2F0aW9uUHJvZmlsZVdhdGNocG9p
bnQ6CisgICAgY2FzZSBDaGVja0FyZ3VtZW50c05vdENyZWF0ZWQ6CisgICAgY2FzZSBHZXRDYWxs
ZWU6CisgICAgY2FzZSBUb1N0cmluZzoKKyAgICBjYXNlIE1ha2VSb3BlOgogICAgICAgICAvLyBU
aGVzZSBhcmUgT0suCiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgR2V0QnlJZDoKQEAgLTIzNSwx
NCArMjQwLDYgQEAgaW5saW5lIENhcGFiaWxpdHlMZXZlbCBjYW5Db21waWxlKE5vZGUqIAogICAg
ICAgICAgICAgcmV0dXJuIENhbm5vdENvbXBpbGU7CiAgICAgICAgIH0KICAgICAgICAgYnJlYWs7
Ci0gICAgY2FzZSBBbGxvY2F0aW9uUHJvZmlsZVdhdGNocG9pbnQ6Ci0gICAgY2FzZSBDaGVja0Fy
Z3VtZW50c05vdENyZWF0ZWQ6Ci0gICAgY2FzZSBHZXRDYWxsZWU6Ci0gICAgY2FzZSBUb1N0cmlu
ZzoKLSAgICBjYXNlIE1ha2VSb3BlOgotICAgICAgICBpZiAoIU9wdGlvbnM6OmVuYWJsZUV4cGVy
aW1lbnRhbEZUTENvdmVyYWdlKCkpCi0gICAgICAgICAgICByZXR1cm4gQ2Fubm90Q29tcGlsZTsK
LSAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKICAgICAgICAgLy8gRG9uJ3Qga25vdyBob3cg
dG8gaGFuZGxlIGFueXRoaW5nIGVsc2UuCiAgICAgICAgIHJldHVybiBDYW5ub3RDb21waWxlOwpJ
bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExUaHVua3MuY3BwCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMVGh1bmtzLmNwcAkocmV2aXNpb24gMTYy
NTUwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExUaHVua3MuY3BwCSh3b3JraW5n
IGNvcHkpCkBAIC03MSwxMCArNzEsMTMgQEAgTWFjcm9Bc3NlbWJsZXJDb2RlUmVmIG9zckV4aXRH
ZW5lcmF0aW9uVAogICAgIAogICAgIGppdC5tb3ZlKEdQUkluZm86OnJldHVyblZhbHVlR1BSLCBH
UFJJbmZvOjpyZWdUMCk7CiAgICAgCisgICAgLy8gTWFrZSBzdXJlIHdlIHRlbGwgdGhlIEdDIHRo
YXQgd2UncmUgbm90IHVzaW5nIHRoZSBzY3JhdGNoIGJ1ZmZlciBhbnltb3JlLgorICAgIGppdC5t
b3ZlKE1hY3JvQXNzZW1ibGVyOjpUcnVzdGVkSW1tUHRyKHNjcmF0Y2hCdWZmZXItPmFjdGl2ZUxl
bmd0aFB0cigpKSwgR1BSSW5mbzo6cmVnVDEpOworICAgIGppdC5zdG9yZVB0cihNYWNyb0Fzc2Vt
Ymxlcjo6VHJ1c3RlZEltbVB0cigwKSwgR1BSSW5mbzo6cmVnVDEpOworICAgIAogICAgIC8vIFBy
ZXBhcmUgZm9yIHRhaWwgY2FsbC4KICAgICBqaXQucG9wKEdQUkluZm86OnJlZ1QxKTsKICAgICBq
aXQucG9wKEdQUkluZm86OnJlZ1QxKTsKLSAgICAvLyBGSVhNRTogQ1N0YWNrIC0gTmVlZCB0byBh
ZGRyZXNzIHRoZSByaWdodCB3YXkgdG8gYWRqdXN0IENGUiBhbmQgU1AKICAgICBqaXQucG9wKE1h
Y3JvQXNzZW1ibGVyOjpmcmFtZVBvaW50ZXJSZWdpc3Rlcik7CiAgICAgCiAgICAgLy8gQXQgdGhp
cyBwb2ludCB3ZSdyZSBzaXR0aW5nIG9uIHRoZSByZXR1cm4gYWRkcmVzcyAtIHNvIGlmIHdlIGRp
ZCBhIGp1bXAgcmlnaHQgbm93LCB0aGUKQEAgLTgyLDcgKzg1LDYgQEAgTWFjcm9Bc3NlbWJsZXJD
b2RlUmVmIG9zckV4aXRHZW5lcmF0aW9uVAogICAgIC8vIHJlc3RvcmUgYWxsIHJlZ2lzdGVycy4K
ICAgICAKICAgICBqaXQucmVzdG9yZVJldHVybkFkZHJlc3NCZWZvcmVSZXR1cm4oR1BSSW5mbzo6
cmVnVDApOwotICAgIC8vIEZJWE1FOiBDU3RhY2sgLSBUaHJvdWdoIGhlcmUKIAogICAgIHJlc3Rv
cmVBbGxSZWdpc3RlcnMoaml0LCBidWZmZXIpOwogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20KPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph
dmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCShyZXZpc2lvbiAxNjI1
NTApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5h
c20JKHdvcmtpbmcgY29weSkKQEAgLTU5Myw4ICs1OTMsOCBAQCBlbmQKIAogaWYgQ19MT09QCiBl
bHNlCi0jIHZvaWQgc2FuaXRpemVTdGFja0ZvclZNKFZNKiB2bSkKLV9zYW5pdGl6ZVN0YWNrRm9y
Vk06CisjIHZvaWQgc2FuaXRpemVTdGFja0ZvclZNSW1wbChWTSogdm0pCitfc2FuaXRpemVTdGFj
a0ZvclZNSW1wbDoKICAgICBpZiBYODZfNjQKICAgICAgICAgY29uc3Qgdm0gPSB0NAogICAgICAg
ICBjb25zdCBhZGRyZXNzID0gdDEKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l
L09wdGlvbnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9P
cHRpb25zLmgJKHJldmlzaW9uIDE2MjU1MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50
aW1lL09wdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtMTI5LDggKzEyOSwxMCBAQCB0eXBlZGVm
IE9wdGlvblJhbmdlIG9wdGlvblJhbmdlOwogICAgIHYoYm9vbCwgdmVyYm9zZUZUTEZhaWx1cmUs
IGZhbHNlKSBcCiAgICAgdihib29sLCBhbHdheXNDb21wdXRlSGFzaCwgZmFsc2UpIFwKICAgICB2
KGJvb2wsIHRlc3RUaGVGVEwsIGZhbHNlKSBcCisgICAgdihib29sLCB2ZXJib3NlU2FuaXRpemVT
dGFjaywgZmFsc2UpIFwKICAgICBcCiAgICAgdihib29sLCBlbmFibGVPU1JFbnRyeVRvREZHLCB0
cnVlKSBcCisgICAgdihib29sLCBlbmFibGVPU1JFbnRyeVRvRlRMLCB0cnVlKSBcCiAgICAgXAog
ICAgIHYoYm9vbCwgdXNlRXhwZXJpbWVudGFsRlRMLCBmYWxzZSkgXAogICAgIHYoYm9vbCwgZW5h
YmxlRXhwZXJpbWVudGFsRlRMQ292ZXJhZ2UsIGZhbHNlKSBcCkluZGV4OiBTb3VyY2UvSmF2YVNj
cmlwdENvcmUvcnVudGltZS9WTS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD
b3JlL3J1bnRpbWUvVk0uY3BwCShyZXZpc2lvbiAxNjI1NTApCisrKyBTb3VyY2UvSmF2YVNjcmlw
dENvcmUvcnVudGltZS9WTS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc3MSwxMiArNzcxLDE3IEBA
IHZvaWQgVk06OmdhdGhlckNvbnNlcnZhdGl2ZVJvb3RzKENvbnNlcnYKIH0KICNlbmRpZgogCi0j
aWYgRU5BQkxFKExMSU5UX0NfTE9PUCkKLXZvaWQgc2FuaXRpemVTdGFja0ZvclZNKFZNKiB2bSkK
K3ZvaWQgbG9nU2FuaXRpemVTdGFjayhWTSogdm0pCiB7Ci0gICAgdm0tPmludGVycHJldGVyLT5z
dGFjaygpLnNhbml0aXplU3RhY2soKTsKKyAgICBpZiAoT3B0aW9uczo6dmVyYm9zZVNhbml0aXpl
U3RhY2soKSAmJiB2bS0+dG9wQ2FsbEZyYW1lKSB7CisgICAgICAgIGludCBkdW1teTsKKyAgICAg
ICAgZGF0YUxvZygKKyAgICAgICAgICAgICJTYW5pdGl6aW5nIHN0YWNrIHdpdGggdG9wIGNhbGwg
ZnJhbWUgYXQgIiwgUmF3UG9pbnRlcih2bS0+dG9wQ2FsbEZyYW1lKSwKKyAgICAgICAgICAgICIs
IGN1cnJlbnQgc3RhY2sgcG9pbnRlciBhdCAiLCBSYXdQb2ludGVyKCZkdW1teSksICIsIGluICIs
CisgICAgICAgICAgICBwb2ludGVyRHVtcCh2bS0+dG9wQ2FsbEZyYW1lLT5jb2RlQmxvY2soKSks
ICIgYW5kIGxhc3QgY29kZSBvcmlnaW4gPSAiLAorICAgICAgICAgICAgdm0tPnRvcENhbGxGcmFt
ZS0+Y29kZU9yaWdpbigpLCAiXG4iKTsKKyAgICB9CiB9Ci0jZW5kaWYKIAogI2lmIEVOQUJMRShS
RUdFWFBfVFJBQ0lORykKIHZvaWQgVk06OmFkZFJlZ0V4cFRvVHJhY2UoUmVnRXhwKiByZWdFeHAp
CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5oCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmgJKHJldmlzaW9uIDE2MjU1MCkKKysr
IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmgJKHdvcmtpbmcgY29weSkKQEAgLTU0
MywxMyArNTQzLDIxIEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICByZXR1cm4gJm1fdm0tPmhl
YXA7CiAgICAgfQogCi0jaWYgRU5BQkxFKExMSU5UKQorI2lmICFFTkFCTEUoTExJTlRfQ19MT09Q
KQorICAgIGV4dGVybiAiQyIgdm9pZCBzYW5pdGl6ZVN0YWNrRm9yVk1JbXBsKFZNKik7CisjZW5k
aWYKKworICAgIHZvaWQgbG9nU2FuaXRpemVTdGFjayhWTSopOworCisgICAgQUxXQVlTX0lOTElO
RSB2b2lkIHNhbml0aXplU3RhY2tGb3JWTShWTSogdm0pCisgICAgeworICAgICAgICBsb2dTYW5p
dGl6ZVN0YWNrKHZtKTsKICNpZiBFTkFCTEUoTExJTlRfQ19MT09QKQotICAgIHZvaWQgc2FuaXRp
emVTdGFja0ZvclZNKFZNKik7CisgICAgICAgIHZtLT5pbnRlcnByZXRlci0+c3RhY2soKS5zYW5p
dGl6ZVN0YWNrKCk7CiAjZWxzZQotICAgIGV4dGVybiAiQyIgdm9pZCBzYW5pdGl6ZVN0YWNrRm9y
Vk0oVk0qKTsKLSNlbmRpZgorICAgICAgICBzYW5pdGl6ZVN0YWNrRm9yVk1JbXBsKHZtKTsKICNl
bmRpZgorICAgIH0KIAogfSAvLyBuYW1lc3BhY2UgSlNDCiAK
</data>
<flag name="review"
          id="246013"
          type_id="1"
          status="+"
          setter="mhahnenberg"
    />
          </attachment>
      

    </bug>

</bugzilla>