127451 2014-01-22 15:34:48 -0800 AX: Can't always increment web sliders. 2014-01-22 20:08:31 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Mac (Intel) OS X 10.9 RESOLVED FIXED InRadar P2 Normal --- 1 samuel_white samuel_white aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario webkit-bug-importer oldest_to_newest 970910 0 samuel_white 2014-01-22 15:34:48 -0800 If a slider has no step size and a very small range, for example: min = 0, max = 10 AXIncrement and AXDecrement fail. This is because we try and increment by a percent in this case, and the percent results in a value of less than 1. Since 1 is the implicit step size in this case we need to adjust. 970911 1 samuel_white 2014-01-22 15:35:10 -0800 <rdar://problem/15336081> 970917 2 221917 samuel_white 2014-01-22 15:42:48 -0800 Created attachment 221917 Initial patch for feedback. Added some basic logic to make sure we step by at least one. I'm doing this to match the keyboard behavior. 970921 3 221917 cfleizach 2014-01-22 15:52:46 -0800 Comment on attachment 221917 Initial patch for feedback. is this the same thing that happens in the keyboard handler. do you have a layout test ready 970958 4 221929 samuel_white 2014-01-22 17:55:50 -0800 Created attachment 221929 Patch. Added layout test and updated logs. 970960 5 samuel_white 2014-01-22 17:56:36 -0800 (In reply to comment #3) > (From update of attachment 221917 [details]) > is this the same thing that happens in the keyboard handler. do you have a layout test ready Keyboard code also clamps to one in this situation. Layout test has been added. 970995 6 221929 commit-queue 2014-01-22 20:08:28 -0800 Comment on attachment 221929 Patch. Clearing flags on attachment: 221929 Committed r162587: <http://trac.webkit.org/changeset/162587> 970996 7 commit-queue 2014-01-22 20:08:31 -0800 All reviewed patches have been landed. Closing bug. 221917 2014-01-22 15:42:48 -0800 2014-01-22 17:55:50 -0800 Initial patch for feedback. patch.diff text/plain 955 samuel_white ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5v ZGVPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5 Tm9kZU9iamVjdC5jcHAKaW5kZXggNDc0N2M5MS4uMDVlMTIxNiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAK QEAgLTEwOTYsOSArMTA5NiwxNCBAQCB2b2lkIEFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0OjpjaGFu Z2VWYWx1ZUJ5U3RlcChib29sIGluY3JlYXNlKQogdm9pZCBBY2Nlc3NpYmlsaXR5Tm9kZU9iamVj dDo6Y2hhbmdlVmFsdWVCeVBlcmNlbnQoZmxvYXQgcGVyY2VudENoYW5nZSkKIHsKICAgICBmbG9h dCByYW5nZSA9IG1heFZhbHVlRm9yUmFuZ2UoKSAtIG1pblZhbHVlRm9yUmFuZ2UoKTsKKyAgICBm bG9hdCBzdGVwID0gcmFuZ2UgKiAocGVyY2VudENoYW5nZSAvIDEwMCk7CiAgICAgZmxvYXQgdmFs dWUgPSB2YWx1ZUZvclJhbmdlKCk7CiAKLSAgICB2YWx1ZSArPSByYW5nZSAqIChwZXJjZW50Q2hh bmdlIC8gMTAwKTsKKyAgICAvLyBNYWtlIHN1cmUgdGhlIHNwZWNpZmllZCBwZXJjZW50IHdpbGwg Y2F1c2UgYSBjaGFuZ2Ugb2Ygb25lIGludGVnZXIgc3RlcCBvciBsYXJnZXIuCisgICAgaWYgKGZh YnMoc3RlcCkgPCAxKQorICAgICAgICBzdGVwID0gZmFicyhwZXJjZW50Q2hhbmdlKSAqICgxIC8g cGVyY2VudENoYW5nZSk7CisKKyAgICB2YWx1ZSArPSBzdGVwOwogICAgIHNldFZhbHVlKFN0cmlu Zzo6bnVtYmVyKHZhbHVlKSk7CiAKICAgICBheE9iamVjdENhY2hlKCktPnBvc3ROb3RpZmljYXRp b24obm9kZSgpLCBBWE9iamVjdENhY2hlOjpBWFZhbHVlQ2hhbmdlZCk7Cg== 221929 2014-01-22 17:55:50 -0800 2014-01-22 20:08:28 -0800 Patch. range.patch text/plain 5529 samuel_white ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzMmMzNzIyLi5mMWE2N2UzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDEt MjIgIFNhbXVlbCBXaGl0ZSAgPHNhbXVlbF93aGl0ZUBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6 IENhbid0IGFsd2F5cyBpbmNyZW1lbnQgd2ViIHNsaWRlcnMuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc0NTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgcmFuZ2UtYWx0ZXItYnktcGVyY2Vu dC5odG1sIHRvIGNvbXBsaW1lbnQgdGhlIGV4aXN0aW5nIHJhbmdlLWFsdGVyLWJ5LXN0ZXAuaHRt bCB0ZXN0LgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9yYW5nZS1hbHRlci1ieS1wZXJjZW50 LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9yYW5nZS1hbHRl ci1ieS1wZXJjZW50Lmh0bWw6IEFkZGVkLgorCiAyMDE0LTAxLTIyICBaYWxhbiBCdWp0YXMgIDx6 YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBBcHBsZSBXaW5kb3dzIHBvcnQg Z2FyZGVyaW5nIGFmdGVyIHIxNjI1NTMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9hY2Nlc3Np YmlsaXR5L3JhbmdlLWFsdGVyLWJ5LXBlcmNlbnQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv YWNjZXNzaWJpbGl0eS9yYW5nZS1hbHRlci1ieS1wZXJjZW50LWV4cGVjdGVkLnR4dApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4yZGE1YzllCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9yYW5nZS1hbHRlci1ieS1wZXJjZW50LWV4cGVjdGVk LnR4dApAQCAtMCwwICsxLDIwIEBACisgIAorVGhpcyB0ZXN0cyB0aGF0IGRlY3JlbWVudCBhbmQg aW5jcmVtZW50IGFsdGVyIGEgcmFuZ2UgdHlwZSBpbnB1dCBlbGVtZW50IGJ5IGZpdmUgcGVyY2Vu dCBvciBvbmUgKHdoaWNoZXZlciBpcyBsYXJnZXIpIHdoZW4gbm8gc3RlcCBpcyBzcGVjaWZpZWQu CisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMs IGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGxhcmdlUmFuZ2UuaW50VmFs dWUgaXMgNTAKK1BBU1MgbGFyZ2VSYW5nZS5pbnRWYWx1ZSBpcyA1NQorUEFTUyBsYXJnZVJhbmdl LmludFZhbHVlIGlzIDYwCitQQVNTIGxhcmdlUmFuZ2UuaW50VmFsdWUgaXMgNTUKK1BBU1MgbGFy Z2VSYW5nZS5pbnRWYWx1ZSBpcyA1MAorUEFTUyBzbWFsbFJhbmdlLmludFZhbHVlIGlzIDUKK1BB U1Mgc21hbGxSYW5nZS5pbnRWYWx1ZSBpcyA2CitQQVNTIHNtYWxsUmFuZ2UuaW50VmFsdWUgaXMg NworUEFTUyBzbWFsbFJhbmdlLmludFZhbHVlIGlzIDYKK1BBU1Mgc21hbGxSYW5nZS5pbnRWYWx1 ZSBpcyA1CitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUK KwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9yYW5nZS1hbHRlci1ieS1w ZXJjZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3JhbmdlLWFsdGVyLWJ5LXBl cmNlbnQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi45ZjRmN2RhCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9yYW5nZS1hbHRlci1i eS1wZXJjZW50Lmh0bWwKQEAgLTAsMCArMSw1MSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4K KzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3Jp cHQ+Cis8dGl0bGU+UmFuZ2UgQWx0ZXIgYnkgUGVyY2VudDwvdGl0bGU+Cis8L2hlYWQ+Cis8Ym9k eT4KKworPCEtLSBSYW5nZSB0eXBlIGlucHV0IGVsZW1lbnRzIGFyZSBhbHRlcmVkIGJ5IGZpdmUg cGVyY2VudCBpZiB0aGV5IGhhdmUgbm8gc3RlcCBzcGVjaWZpZWQuIC0tPgorCis8IS0tIEltcGxp Y2l0IHN0ZXAgc2l6ZSBvZiBmaXZlIHdoZW4gZGVjcmVtZW50L2luY3JlbWVudCBpcyBjYWxsZWQu IC0tPgorPGlucHV0IGlkPSJsYXJnZVJhbmdlIiBtYXg9IjEwMCIgbWluPSIwIiB0eXBlPSJyYW5n ZSIgdmFsdWU9IjUwIj4KKzwhLS0gSW1wbGljaXQgc3RlcCBzaXplIG9mIG9uZSB3aGVuIGRlY3Jl bWVudC9pbmNyZW1lbnQgaXMgY2FsbGVkIChiZWNhdXNlIGZpdmUgcGVyY2VudCB3b3VsZCBnaXZl IHVzIGxlc3MgdGhhbiBvbmUpLiAtLT4KKzxpbnB1dCBpZD0ic21hbGxSYW5nZSIgbWF4PSIxMCIg bWluPSIwIiB0eXBlPSJyYW5nZSIgdmFsdWU9IjUiPgorCis8cCBpZD0iZGVzY3JpcHRpb24iPjwv cD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorCis8c2NyaXB0PgorICAgIGRlc2NyaXB0aW9u KCJUaGlzIHRlc3RzIHRoYXQgZGVjcmVtZW50IGFuZCBpbmNyZW1lbnQgYWx0ZXIgYSByYW5nZSB0 eXBlIGlucHV0IGVsZW1lbnQgYnkgZml2ZSBwZXJjZW50IG9yIG9uZSAod2hpY2hldmVyIGlzIGxh cmdlcikgd2hlbiBubyBzdGVwIGlzIHNwZWNpZmllZC4iKTsKKyAgICAKKyAgICBpZiAod2luZG93 LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisgICAgICAgIC8vIExhcmdlIHJhbmdlLgorICAg ICAgICB2YXIgbGFyZ2VSYW5nZSA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmFjY2Vzc2libGVF bGVtZW50QnlJZCgibGFyZ2VSYW5nZSIpOworICAgICAgICBzaG91bGRCZSgibGFyZ2VSYW5nZS5p bnRWYWx1ZSIsICI1MCIpOworICAgICAgICBsYXJnZVJhbmdlLmluY3JlbWVudCgpOworICAgICAg ICBzaG91bGRCZSgibGFyZ2VSYW5nZS5pbnRWYWx1ZSIsICI1NSIpOworICAgICAgICBsYXJnZVJh bmdlLmluY3JlbWVudCgpOworICAgICAgICBzaG91bGRCZSgibGFyZ2VSYW5nZS5pbnRWYWx1ZSIs ICI2MCIpOworICAgICAgICBsYXJnZVJhbmdlLmRlY3JlbWVudCgpOworICAgICAgICBzaG91bGRC ZSgibGFyZ2VSYW5nZS5pbnRWYWx1ZSIsICI1NSIpOworICAgICAgICBsYXJnZVJhbmdlLmRlY3Jl bWVudCgpOworICAgICAgICBzaG91bGRCZSgibGFyZ2VSYW5nZS5pbnRWYWx1ZSIsICI1MCIpOwor ICAgICAgICAKKyAgICAgICAgLy8gU21hbGwgcmFuZ2UuCisgICAgICAgIHZhciBzbWFsbFJhbmdl ID0gYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCJzbWFsbFJh bmdlIik7CisgICAgICAgIHNob3VsZEJlKCJzbWFsbFJhbmdlLmludFZhbHVlIiwgIjUiKTsKKyAg ICAgICAgc21hbGxSYW5nZS5pbmNyZW1lbnQoKTsKKyAgICAgICAgc2hvdWxkQmUoInNtYWxsUmFu Z2UuaW50VmFsdWUiLCAiNiIpOworICAgICAgICBzbWFsbFJhbmdlLmluY3JlbWVudCgpOworICAg ICAgICBzaG91bGRCZSgic21hbGxSYW5nZS5pbnRWYWx1ZSIsICI3Iik7CisgICAgICAgIHNtYWxs UmFuZ2UuZGVjcmVtZW50KCk7CisgICAgICAgIHNob3VsZEJlKCJzbWFsbFJhbmdlLmludFZhbHVl IiwgIjYiKTsKKyAgICAgICAgc21hbGxSYW5nZS5kZWNyZW1lbnQoKTsKKyAgICAgICAgc2hvdWxk QmUoInNtYWxsUmFuZ2UuaW50VmFsdWUiLCAiNSIpOworICAgIH0KKzwvc2NyaXB0PgorCis8c2Ny aXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+ Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDAzMzg4Ny4uNjdlMzhkYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE3IEBACisyMDE0LTAxLTIyICBTYW11ZWwgV2hpdGUgIDxzYW11ZWxfd2hpdGVAYXBw bGUuY29tPgorCisgICAgICAgIEFYOiBDYW4ndCBhbHdheXMgaW5jcmVtZW50IHdlYiBzbGlkZXJz LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3NDUx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xhbXBp bmcgdGhlIGRlY3JlbWVudC9pbmNyZW1lbnQgYW1vdW50IHRvIG9uZSB3aGVuIG5lY2Vzc2FyeSAo aWYgYSBwZXJjZW50IGNoYW5nZSB3b3VsZCByZXN1bHQgaW4gYSBjaGFuZ2Ugb2YgbGVzcyB0aGFu IG9uZSkuCisKKyAgICAgICAgVGVzdDogYWNjZXNzaWJpbGl0eS9yYW5nZS1hbHRlci1ieS1wZXJj ZW50Lmh0bWwKKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5vZGVPYmpl Y3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU5vZGVPYmplY3Q6OmNoYW5n ZVZhbHVlQnlQZXJjZW50KToKKwogMjAxNC0wMS0yMiAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBw bGUuY29tPgogCiAgICAgICAgIFtDU1MgU2hhcGVzXSBzaGFwZS1pbnNpZGUgcmVjdGFuZ2xlIGxh eW91dCBjYW4gZmFpbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L0FjY2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNwcAppbmRleCA0NzQ3YzkxLi4wNWUxMjE2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2RlT2Jq ZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlO b2RlT2JqZWN0LmNwcApAQCAtMTA5Niw5ICsxMDk2LDE0IEBAIHZvaWQgQWNjZXNzaWJpbGl0eU5v ZGVPYmplY3Q6OmNoYW5nZVZhbHVlQnlTdGVwKGJvb2wgaW5jcmVhc2UpCiB2b2lkIEFjY2Vzc2li aWxpdHlOb2RlT2JqZWN0OjpjaGFuZ2VWYWx1ZUJ5UGVyY2VudChmbG9hdCBwZXJjZW50Q2hhbmdl KQogewogICAgIGZsb2F0IHJhbmdlID0gbWF4VmFsdWVGb3JSYW5nZSgpIC0gbWluVmFsdWVGb3JS YW5nZSgpOworICAgIGZsb2F0IHN0ZXAgPSByYW5nZSAqIChwZXJjZW50Q2hhbmdlIC8gMTAwKTsK ICAgICBmbG9hdCB2YWx1ZSA9IHZhbHVlRm9yUmFuZ2UoKTsKIAotICAgIHZhbHVlICs9IHJhbmdl ICogKHBlcmNlbnRDaGFuZ2UgLyAxMDApOworICAgIC8vIE1ha2Ugc3VyZSB0aGUgc3BlY2lmaWVk IHBlcmNlbnQgd2lsbCBjYXVzZSBhIGNoYW5nZSBvZiBvbmUgaW50ZWdlciBzdGVwIG9yIGxhcmdl ci4KKyAgICBpZiAoZmFicyhzdGVwKSA8IDEpCisgICAgICAgIHN0ZXAgPSBmYWJzKHBlcmNlbnRD aGFuZ2UpICogKDEgLyBwZXJjZW50Q2hhbmdlKTsKKworICAgIHZhbHVlICs9IHN0ZXA7CiAgICAg c2V0VmFsdWUoU3RyaW5nOjpudW1iZXIodmFsdWUpKTsKIAogICAgIGF4T2JqZWN0Q2FjaGUoKS0+ cG9zdE5vdGlmaWNhdGlvbihub2RlKCksIEFYT2JqZWN0Q2FjaGU6OkFYVmFsdWVDaGFuZ2VkKTsK