127450 2014-01-22 15:32:26 -0800 Update JS whitespace definition for changes in Unicode 6.3 2014-02-03 13:48:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap barraclough commit-queue ggaren oliver oldest_to_newest 970908 0 ap 2014-01-22 15:32:26 -0800 Unicode 6.3 changes character type of U+180E MONGOLIAN VOWEL SEPARATOR, so that it's no longer whitespace for the purposes of number parsing. But EcmaScript says that we should keep recognizing it as whitespace, because that's why Unicode 3.0 said: "ECMAScript implementations must recognise all of the white space characters defined in Unicode 3.0. Later editions of the Unicode Standard may define other white space characters. ECMAScript implementations may recognise white space characters from later editions of the Unicode Standard." <rdar://15863457> 970913 1 221916 ap 2014-01-22 15:36:30 -0800 Created attachment 221916 proposed fix 970915 2 commit-queue 2014-01-22 15:39:27 -0800 Attachment 221916 did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] ERROR: Source/JavaScriptCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 970920 3 221918 ap 2014-01-22 15:46:15 -0800 Created attachment 221918 without tabs 970949 4 221918 commit-queue 2014-01-22 17:31:26 -0800 Comment on attachment 221918 without tabs Clearing flags on attachment: 221918 Committed r162575: <http://trac.webkit.org/changeset/162575> 970950 5 commit-queue 2014-01-22 17:31:28 -0800 All reviewed patches have been landed. Closing bug. 975967 6 ap 2014-02-03 12:42:21 -0800 There is one more place to update. 975969 7 223009 ap 2014-02-03 12:43:44 -0800 Created attachment 223009 part 2 976000 8 223009 commit-queue 2014-02-03 13:48:08 -0800 Comment on attachment 223009 part 2 Clearing flags on attachment: 223009 Committed r163325: <http://trac.webkit.org/changeset/163325> 976001 9 commit-queue 2014-02-03 13:48:11 -0800 All reviewed patches have been landed. Closing bug. 221916 2014-01-22 15:36:30 -0800 2014-01-22 15:46:15 -0800 proposed fix Mongolian.txt text/plain 1568 ap SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYyNTY0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE0LTAxLTIyICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAg ICAgIFVwZGF0ZSBKUyB3aGl0ZXNwYWNlIGRlZmluaXRpb24gZm9yIGNoYW5nZXMgaW4gVW5pY29k ZSA2LjMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NzQ1MAorICAgICAgICA8cmRhcjovLzE1ODYzNDU3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisJCUNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMgd2hlbiBydW5uaW5n IGFnYWluc3QgYSBVbmljb2RlIGJhY2stZW5kIHRoYXQgc3VwcG9ydHMKKwkJVW5pY29kZSA2LjMg b3IgaGlnaGVyLgorCisgICAgICAgICogcnVudGltZS9KU0dsb2JhbE9iamVjdEZ1bmN0aW9ucy5j cHA6IChKU0M6OmlzU3RyV2hpdGVTcGFjZSk6IEV4cGxpY2l0bHkgYWxsb3cKKyAgICAgICAgVSsx ODBFIE1PTkdPTElBTiBWT1dFTCBTRVBBUkFUT1IsIGJlY2F1c2Ugd2UgbmVlZCB0byBrZWVwIHJl Y29nbml6aW5nIGFsbCBjaGFyYWN0ZXJzCisgICAgICAgIHRoYXQgdXNlZCB0byBiZSB3aGl0ZXNw YWNlLgorCiAyMDE0LTAxLTIxICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5j b20+CiAKICAgICAgICAgUmVnaXN0ZXJzIHVzZWQgaW4gd3JpdGVCYXJyaWVyT25PcGVyYW5kIGNh biBjYXVzZSBjbG9iYmVyaW5nIG9uIHNvbWUgcGxhdGZvcm1zCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdEZ1bmN0aW9ucy5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3RGdW5jdGlvbnMu Y3BwCShyZXZpc2lvbiAxNjIzOTMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U0dsb2JhbE9iamVjdEZ1bmN0aW9ucy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2NCw2ICsxNjQs NyBAQCBib29sIGlzU3RyV2hpdGVTcGFjZShVQ2hhciBjKQogICAgICAgICBjYXNlIDB4MDAwRDoK ICAgICAgICAgY2FzZSAweDAwMjA6CiAgICAgICAgIGNhc2UgMHgwMEEwOgorICAgICAgICBjYXNl IDB4MTgwRTogLy8gVGhpcyBjaGFyYWN0ZXIgdXNlZCB0byBiZSBpbiBacyBjYXRlZ29yeSBiZWZv cmUgVW5pY29kZSA2LjMsIGFuZCBFY21hU2NyaXB0IHNheXMgdGhhdCB3ZSBzaG91bGQga2VlcCB0 cmVhdGluZyBpdCBhcyBzdWNoLgogICAgICAgICBjYXNlIDB4MjAyODoKICAgICAgICAgY2FzZSAw eDIwMjk6CiAgICAgICAgIGNhc2UgMHhGRUZGOgo= 221918 2014-01-22 15:46:15 -0800 2014-01-22 17:31:26 -0800 without tabs Mongolian.txt text/plain 1580 ap SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYyNTY0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE0LTAxLTIyICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAg ICAgIFVwZGF0ZSBKUyB3aGl0ZXNwYWNlIGRlZmluaXRpb24gZm9yIGNoYW5nZXMgaW4gVW5pY29k ZSA2LjMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NzQ1MAorICAgICAgICA8cmRhcjovLzE1ODYzNDU3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMgd2hlbiBy dW5uaW5nIGFnYWluc3QgYSBVbmljb2RlIGJhY2stZW5kIHRoYXQgc3VwcG9ydHMKKyAgICAgICAg VW5pY29kZSA2LjMgb3IgaGlnaGVyLgorCisgICAgICAgICogcnVudGltZS9KU0dsb2JhbE9iamVj dEZ1bmN0aW9ucy5jcHA6IChKU0M6OmlzU3RyV2hpdGVTcGFjZSk6IEV4cGxpY2l0bHkgYWxsb3cK KyAgICAgICAgVSsxODBFIE1PTkdPTElBTiBWT1dFTCBTRVBBUkFUT1IsIGJlY2F1c2Ugd2UgbmVl ZCB0byBrZWVwIHJlY29nbml6aW5nIGFsbCBjaGFyYWN0ZXJzCisgICAgICAgIHRoYXQgdXNlZCB0 byBiZSB3aGl0ZXNwYWNlLgorCiAyMDE0LTAxLTIxICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVu YmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVnaXN0ZXJzIHVzZWQgaW4gd3JpdGVCYXJyaWVy T25PcGVyYW5kIGNhbiBjYXVzZSBjbG9iYmVyaW5nIG9uIHNvbWUgcGxhdGZvcm1zCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdEZ1bmN0aW9ucy5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmpl Y3RGdW5jdGlvbnMuY3BwCShyZXZpc2lvbiAxNjIzOTMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU0dsb2JhbE9iamVjdEZ1bmN0aW9ucy5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE2NCw2ICsxNjQsNyBAQCBib29sIGlzU3RyV2hpdGVTcGFjZShVQ2hhciBjKQogICAgICAgICBj YXNlIDB4MDAwRDoKICAgICAgICAgY2FzZSAweDAwMjA6CiAgICAgICAgIGNhc2UgMHgwMEEwOgor ICAgICAgICBjYXNlIDB4MTgwRTogLy8gVGhpcyBjaGFyYWN0ZXIgdXNlZCB0byBiZSBpbiBacyBj YXRlZ29yeSBiZWZvcmUgVW5pY29kZSA2LjMsIGFuZCBFY21hU2NyaXB0IHNheXMgdGhhdCB3ZSBz aG91bGQga2VlcCB0cmVhdGluZyBpdCBhcyBzdWNoLgogICAgICAgICBjYXNlIDB4MjAyODoKICAg ICAgICAgY2FzZSAweDIwMjk6CiAgICAgICAgIGNhc2UgMHhGRUZGOgo= 223009 2014-02-03 12:43:44 -0800 2014-02-03 13:48:08 -0800 part 2 Mongolian2.txt text/plain 1444 ap SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzMzIxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDE0LTAyLTAzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAg ICAgIFVwZGF0ZSBKUyB3aGl0ZXNwYWNlIGRlZmluaXRpb24gZm9yIGNoYW5nZXMgaW4gVW5pY29k ZSA2LjMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NzQ1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cGFyc2VyL0xleGVyLmg6IChKU0M6OkxleGVyPFVDaGFyPjo6aXNXaGl0ZVNwYWNlKTogUGFydCAy IG9mIHRoZSBmaXgsIHVwZGF0ZSBsZXhlciB0b28uCisKIDIwMTQtMDEtMzEgIEdlb2ZmcmV5IEdh cmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBTaW1wbGlmaWVkIG5hbWUgc2NvcGUg Y3JlYXRpb24gZm9yIGZ1bmN0aW9uIGV4cHJlc3Npb25zCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcGFyc2VyL0xleGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L3BhcnNlci9MZXhlci5oCShyZXZpc2lvbiAxNjMzMTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcGFyc2VyL0xleGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTI0OCw3ICsyNDgsOCBAQCBBTFdB WVNfSU5MSU5FIGJvb2wgTGV4ZXI8TENoYXI+Ojppc1doaXRlCiB0ZW1wbGF0ZSA8PgogQUxXQVlT X0lOTElORSBib29sIExleGVyPFVDaGFyPjo6aXNXaGl0ZVNwYWNlKFVDaGFyIGNoKQogewotICAg IHJldHVybiAoY2ggPCAyNTYpID8gTGV4ZXI8TENoYXI+Ojppc1doaXRlU3BhY2Uoc3RhdGljX2Nh c3Q8TENoYXI+KGNoKSkgOiAodV9jaGFyVHlwZShjaCkgPT0gVV9TUEFDRV9TRVBBUkFUT1IgfHwg Y2ggPT0gMHhGRUZGKTsKKyAgICAvLyAweDE4MEUgdXNlZCB0byBiZSBpbiBacyBjYXRlZ29yeSBi ZWZvcmUgVW5pY29kZSA2LjMsIGFuZCBFY21hU2NyaXB0IHNheXMgdGhhdCB3ZSBzaG91bGQga2Vl cCB0cmVhdGluZyBpdCBhcyBzdWNoLgorICAgIHJldHVybiAoY2ggPCAyNTYpID8gTGV4ZXI8TENo YXI+Ojppc1doaXRlU3BhY2Uoc3RhdGljX2Nhc3Q8TENoYXI+KGNoKSkgOiAodV9jaGFyVHlwZShj aCkgPT0gVV9TUEFDRV9TRVBBUkFUT1IgfHwgY2ggPT0gMHgxODBFIHx8IGNoID09IDB4RkVGRik7 CiB9CiAKIHRlbXBsYXRlIDw+Cg==