127445 2014-01-22 13:58:13 -0800 Crashes in DrawingAreaProxy::setExposedRect (null DrawingAreaProxy) 2014-01-22 14:38:42 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca simon.fraser oldest_to_newest 970861 0 thorton 2014-01-22 13:58:13 -0800 When the WebPageProxy is closed, it nulls out the DrawingAreaProxy; we should avoid trying to call setExposedRect on a null DrawingAreaProxy for obvious reasons. <rdar://problem/15807127> 970865 1 221903 thorton 2014-01-22 14:04:01 -0800 Created attachment 221903 patch 970878 2 thorton 2014-01-22 14:38:42 -0800 http://trac.webkit.org/changeset/162556 221903 2014-01-22 14:04:01 -0800 2014-01-22 14:10:02 -0800 patch null-check.diff text/plain 2256 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwODNmMDdhLi40NjFlNzFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDEtMjIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgQ3Jhc2hlcyBpbiBEcmF3aW5nQXJlYVByb3h5OjpzZXRFeHBvc2VkUmVjdCAobnVs bCBEcmF3aW5nQXJlYVByb3h5KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTI3NDQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2lvcy9XS0NvbnRlbnRWaWV3Lm1tOgorICAgICAg ICAoLVtXS0NvbnRlbnRWaWV3IF91cGRhdGVWaWV3RXhwb3NlZFJlY3RdKToKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW06CisgICAgICAgICgtW1dLVmlldyBfdXBkYXRlVmll d0V4cG9zZWRSZWN0XSk6CisgICAgICAgIE51bGwtY2hlY2suCisKIDIwMTQtMDEtMjEgIFRpbSBI b3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0MiBWaWV3 IEdlc3R1cmVzOiBGbHVpZCBiYWNrLWZvcndhcmQgc3dpcGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvaW9zL1dLQ29udGVudFZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2lvcy9XS0NvbnRlbnRWaWV3Lm1tCmluZGV4IDZmMmUwMDMuLjRmZTc5 NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvaW9zL1dLQ29udGVu dFZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9pb3MvV0tDb250ZW50 Vmlldy5tbQpAQCAtMTQyLDcgKzE0Miw5IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiB7CiAg ICAgRmxvYXRQb2ludCBleHBvc2VkUmVjdFBvc2l0aW9uID0gX2N1cnJlbnRFeHBvc2VkUmVjdFBv c2l0aW9uOwogICAgIGV4cG9zZWRSZWN0UG9zaXRpb24uc2NhbGUoX3BhZ2UtPnBhZ2VTY2FsZUZh Y3RvcigpLCBfcGFnZS0+cGFnZVNjYWxlRmFjdG9yKCkpOwotICAgIF9wYWdlLT5kcmF3aW5nQXJl YSgpLT5zZXRFeHBvc2VkUmVjdChGbG9hdFJlY3QoZXhwb3NlZFJlY3RQb3NpdGlvbiwgX3BhZ2Ut PmRyYXdpbmdBcmVhKCktPnNpemUoKSkpOworCisgICAgaWYgKGF1dG8gZHJhd2luZ0FyZWEgPSBf cGFnZS0+ZHJhd2luZ0FyZWEoKSkKKyAgICAgICAgZHJhd2luZ0FyZWEtPnNldEV4cG9zZWRSZWN0 KEZsb2F0UmVjdChleHBvc2VkUmVjdFBvc2l0aW9uLCBfcGFnZS0+ZHJhd2luZ0FyZWEoKS0+c2l6 ZSgpKSk7CiB9CiAKIC0gKHZvaWQpc2V0Vmlld3BvcnRTaXplOihDR1NpemUpc2l6ZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCmluZGV4IDBiZGY5NWUuLjk1NjE2 ZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5t bQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KQEAgLTM5 NCw3ICszOTQsOCBAQCBzdHJ1Y3QgV0tWaWV3SW50ZXJwcmV0S2V5RXZlbnRzUGFyYW1ldGVycyB7 CiAgICAgaWYgKF9kYXRhLT5fdXNlQ29udGVudFByZXBhcmF0aW9uUmVjdEZvclZpc2libGVSZWN0 KQogICAgICAgICBleHBvc2VkUmVjdCA9IE5TVW5pb25SZWN0KF9kYXRhLT5fY29udGVudFByZXBh cmF0aW9uUmVjdCwgZXhwb3NlZFJlY3QpOwogCi0gICAgX2RhdGEtPl9wYWdlLT5kcmF3aW5nQXJl YSgpLT5zZXRFeHBvc2VkUmVjdChfZGF0YS0+X2NsaXBzVG9WaXNpYmxlUmVjdCA/IEZsb2F0UmVj dChleHBvc2VkUmVjdCkgOiBGbG9hdFJlY3Q6OmluZmluaXRlUmVjdCgpKTsKKyAgICBpZiAoYXV0 byBkcmF3aW5nQXJlYSA9IF9kYXRhLT5fcGFnZS0+ZHJhd2luZ0FyZWEoKSkKKyAgICAgICAgZHJh d2luZ0FyZWEtPnNldEV4cG9zZWRSZWN0KF9kYXRhLT5fY2xpcHNUb1Zpc2libGVSZWN0ID8gRmxv YXRSZWN0KGV4cG9zZWRSZWN0KSA6IEZsb2F0UmVjdDo6aW5maW5pdGVSZWN0KCkpOwogfQogCiAt ICh2b2lkKXNldEZyYW1lU2l6ZTooTlNTaXplKXNpemUK