127426 2014-01-22 07:24:23 -0800 Avoid unthrottled layer flushes triggered by RenderLayerCompositor::ensureRootLayer 2014-01-22 08:12:08 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 970686 0 koivisto 2014-01-22 07:24:23 -0800 Avoid unnecessary work during page loading. 970687 1 221865 koivisto 2014-01-22 07:31:25 -0800 Created attachment 221865 patch 970693 2 koivisto 2014-01-22 08:12:08 -0800 http://trac.webkit.org/changeset/162518 221865 2014-01-22 07:31:25 -0800 2014-01-22 07:33:18 -0800 patch layer-flush-ensure-root-avoid.patch text/plain 4146 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjUxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTAxLTIyICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBdm9pZCB1bnRocm90dGxlZCBs YXllciBmbHVzaGVzIHRyaWdnZXJlZCBieSBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmVuc3VyZVJv b3RMYXllcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTI3NDI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjp1cGRhdGVTY3JvbGxMYXllclBvc2l0aW9u KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6ZnJhbWVWaWV3RGlk U2Nyb2xsKToKKworICAgICAgICAgICAgRmFjdG9yIHNjcm9sbCBsYXllciBwb3NpdGlvbiB1cGRh dGUgdG8gYSBmdW5jdGlvbi4KKworICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3Np dG9yOjplbnN1cmVSb290TGF5ZXIpOgorICAgICAgICAKKyAgICAgICAgICAgIFN0b3AgY2FsbGlu ZyBmcmFtZVZpZXdEaWRDaGFuZ2VTaXplL2ZyYW1lVmlld0RpZFNjcm9sbC4gSW5zdGVhZCBjYWxs IHRoZSByZWxldmVudCBmdW5jdGlvbnMKKyAgICAgICAgICAgIGRpcmVjdGx5LiBUaGlzIGF2b2lk IHVudGhyb3R0bGVkIGxheWVyIGZsdXNoIHRoYXQgaXMgZG9uZSB3aGVuIHRoZSB2aWV3IGFjdHVh bGx5IHNjcm9sbHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9y Lmg6CisKIDIwMTQtMDEtMjIgIE1paGFpIFRpY2EgIDxtaXRpY2FAYWRvYmUuY29tPgogCiAgICAg ICAgIFtDU1MgQmFja2dyb3VuZCBCbGVuZGluZ10gLXdlYmtpdC1iYWNrZ3JvdW5kLWJsZW5kLW1v ZGUgZmFpbHMgZm9yIGNlcnRhaW4gU1ZHIGZpbGVzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAkocmV2aXNpb24gMTYyNTE0 KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE0OTYsMTggKzE0OTYsOSBAQCBib29sIFJlbmRlckxheWVyQ29t cG9zaXRvcjo6aGFzQ29vcmRpbmF0CiAgICAgcmV0dXJuIHNjcm9sbGluZ0Nvb3JkaW5hdG9yICYm IHNjcm9sbGluZ0Nvb3JkaW5hdG9yLT5jb29yZGluYXRlc1Njcm9sbGluZ0ZvckZyYW1lVmlldygm bV9yZW5kZXJWaWV3LmZyYW1lVmlldygpKTsKIH0KIAotdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0 b3I6OmZyYW1lVmlld0RpZFNjcm9sbCgpCit2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6dXBk YXRlU2Nyb2xsTGF5ZXJQb3NpdGlvbigpCiB7Ci0gICAgaWYgKCFtX3Njcm9sbExheWVyKQotICAg ICAgICByZXR1cm47Ci0KLSAgICAvLyBJZiB0aGVyZSdzIGEgc2Nyb2xsaW5nIGNvb3JkaW5hdG9y IHRoYXQgbWFuYWdlcyBzY3JvbGxpbmcgZm9yIHRoaXMgZnJhbWUgdmlldywKLSAgICAvLyBpdCB3 aWxsIGFsc28gbWFuYWdlIHVwZGF0aW5nIHRoZSBzY3JvbGwgbGF5ZXIgcG9zaXRpb24uCi0gICAg aWYgKGhhc0Nvb3JkaW5hdGVkU2Nyb2xsaW5nKCkpIHsKLSAgICAgICAgLy8gV2UgaGF2ZSB0byBz Y2hlZHVsZSBhIGZsdXNoIGluIG9yZGVyIGZvciB0aGUgbWFpbiBUaWxlZEJhY2tpbmcgdG8gdXBk YXRlIGl0cyB0aWxlIGNvdmVyYWdlLgotICAgICAgICBzY2hlZHVsZUxheWVyRmx1c2hOb3coKTsK LSAgICAgICAgcmV0dXJuOwotICAgIH0KKyAgICBBU1NFUlQobV9zY3JvbGxMYXllcik7CiAKICAg ICBGcmFtZVZpZXcmIGZyYW1lVmlldyA9IG1fcmVuZGVyVmlldy5mcmFtZVZpZXcoKTsKICAgICBJ bnRQb2ludCBzY3JvbGxQb3NpdGlvbiA9IGZyYW1lVmlldy5zY3JvbGxQb3NpdGlvbigpOwpAQCAt MTUyNCw2ICsxNTE1LDIyIEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpmcmFtZVZpZXdE aWQKICAgICAgICAgZml4ZWRCYWNrZ3JvdW5kTGF5ZXItPnNldFBvc2l0aW9uKEludFBvaW50KGZy YW1lVmlldy5zY3JvbGxPZmZzZXRGb3JGaXhlZFBvc2l0aW9uKCkpKTsKIH0KIAordm9pZCBSZW5k ZXJMYXllckNvbXBvc2l0b3I6OmZyYW1lVmlld0RpZFNjcm9sbCgpCit7CisgICAgaWYgKCFtX3Nj cm9sbExheWVyKQorICAgICAgICByZXR1cm47CisKKyAgICAvLyBJZiB0aGVyZSdzIGEgc2Nyb2xs aW5nIGNvb3JkaW5hdG9yIHRoYXQgbWFuYWdlcyBzY3JvbGxpbmcgZm9yIHRoaXMgZnJhbWUgdmll dywKKyAgICAvLyBpdCB3aWxsIGFsc28gbWFuYWdlIHVwZGF0aW5nIHRoZSBzY3JvbGwgbGF5ZXIg cG9zaXRpb24uCisgICAgaWYgKGhhc0Nvb3JkaW5hdGVkU2Nyb2xsaW5nKCkpIHsKKyAgICAgICAg Ly8gV2UgaGF2ZSB0byBzY2hlZHVsZSBhIGZsdXNoIGluIG9yZGVyIGZvciB0aGUgbWFpbiBUaWxl ZEJhY2tpbmcgdG8gdXBkYXRlIGl0cyB0aWxlIGNvdmVyYWdlLgorICAgICAgICBzY2hlZHVsZUxh eWVyRmx1c2hOb3coKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIHVwZGF0ZVNjcm9s bExheWVyUG9zaXRpb24oKTsKK30KKwogdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmZyYW1l Vmlld0RpZEFkZE9yUmVtb3ZlU2Nyb2xsYmFycygpCiB7CiAgICAgdXBkYXRlT3ZlcmZsb3dDb250 cm9sc0xheWVycygpOwpAQCAtMzEzNSw4ICszMTQyLDE0IEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21w b3NpdG9yOjplbnN1cmVSb290TGEKICAgICAgICAgICAgIG1fY2xpcExheWVyLT5hZGRDaGlsZCht X3Njcm9sbExheWVyLmdldCgpKTsKICAgICAgICAgICAgIG1fc2Nyb2xsTGF5ZXItPmFkZENoaWxk KG1fcm9vdENvbnRlbnRMYXllci5nZXQoKSk7CiAKLSAgICAgICAgICAgIGZyYW1lVmlld0RpZENo YW5nZVNpemUoKTsKLSAgICAgICAgICAgIGZyYW1lVmlld0RpZFNjcm9sbCgpOworICAgICAgICAg ICAgbV9jbGlwTGF5ZXItPnNldFNpemUobV9yZW5kZXJWaWV3LmZyYW1lVmlldygpLnVuc2NhbGVk VmlzaWJsZUNvbnRlbnRTaXplKCkpOworCisgICAgICAgICAgICB1cGRhdGVPdmVyZmxvd0NvbnRy b2xzTGF5ZXJzKCk7CisKKyAgICAgICAgICAgIGlmIChoYXNDb29yZGluYXRlZFNjcm9sbGluZygp KQorICAgICAgICAgICAgICAgIHNjaGVkdWxlTGF5ZXJGbHVzaCh0cnVlKTsKKyAgICAgICAgICAg IGVsc2UKKyAgICAgICAgICAgICAgICB1cGRhdGVTY3JvbGxMYXllclBvc2l0aW9uKCk7CiAgICAg ICAgIH0KICAgICB9IGVsc2UgewogICAgICAgICBpZiAobV9vdmVyZmxvd0NvbnRyb2xzSG9zdExh eWVyKSB7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3Np dG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVy Q29tcG9zaXRvci5oCShyZXZpc2lvbiAxNjI1MTQpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTM3NSw2ICszNzUs OCBAQCBwcml2YXRlOgogCiAgICAgdm9pZCB1cGRhdGVPdmVyZmxvd0NvbnRyb2xzTGF5ZXJzKCk7 CiAKKyAgICB2b2lkIHVwZGF0ZVNjcm9sbExheWVyUG9zaXRpb24oKTsKKwogICAgIHZvaWQgbm90 aWZ5SUZyYW1lc09mQ29tcG9zaXRpbmdDaGFuZ2UoKTsKIAogICAgIGJvb2wgaXNGbHVzaGluZ0xh eWVycygpIGNvbnN0IHsgcmV0dXJuIG1fZmx1c2hpbmdMYXllcnM7IH0K