127391 2014-01-21 18:11:48 -0800 [WK2] add cocoa API for private browsing setting 2014-01-22 12:04:37 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alice.barraclough alice.barraclough ap commit-queue mhock sam oldest_to_newest 970515 0 alice.barraclough 2014-01-21 18:11:48 -0800 WK2 doesn't have Cocoa API for reading and writing the setting for private browsing. 970520 1 221818 alice.barraclough 2014-01-21 18:15:49 -0800 Created attachment 221818 patch 970727 2 221818 ap 2014-01-22 09:54:04 -0800 Comment on attachment 221818 patch View in context: https://bugs.webkit.org/attachment.cgi?id=221818&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextGroup.h:62 > +@property BOOL privateBrowsingEnabled; Shouldn't this be private/deprecated because of sessions? 970800 3 alice.barraclough 2014-01-22 11:41:09 -0800 (In reply to comment #2) > (From update of attachment 221818 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=221818&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextGroup.h:62 > > +@property BOOL privateBrowsingEnabled; > > Shouldn't this be private/deprecated because of sessions? This possibly doesn't answer your question completely, but I was told to add this property to the browsingContextGroup as a temporary measure until websitedata api has been designed and fleshed out. In other words, yes it is somewhat already deprecated considering near-future plans. 970814 4 221818 commit-queue 2014-01-22 12:04:34 -0800 Comment on attachment 221818 patch Clearing flags on attachment: 221818 Committed r162546: <http://trac.webkit.org/changeset/162546> 970815 5 commit-queue 2014-01-22 12:04:37 -0800 All reviewed patches have been landed. Closing bug. 221818 2014-01-21 18:15:49 -0800 2014-01-22 12:04:34 -0800 patch 127391.patch text/plain 2336 alice.barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjQ5MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAxLTIxICBBbGljZSBC YXJyYWNsb3VnaCAgPGFsaWNlLmxpdUBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl0gYWRkIGNv Y29hIEFQSSBmb3IgcHJpdmF0ZSBicm93c2luZyBzZXR0aW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjczOTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tCcm93 c2luZ0NvbnRleHRHcm91cC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tCcm93 c2luZ0NvbnRleHRHcm91cC5tbToKKyAgICAgICAgKC1bV0tCcm93c2luZ0NvbnRleHRHcm91cCBw cml2YXRlQnJvd3NpbmdFbmFibGVkXSk6CisgICAgICAgICgtW1dLQnJvd3NpbmdDb250ZXh0R3Jv dXAgc2V0UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZDpdKToKKyAgICAgICAgQWRkaW5nIHNvbWUgQVBJ IGZvciB0aGUgcHJpdmF0ZSBCcm93c2luZyBzZXR0aW5nLiBSZWFjaGVzIHRocm91Z2gKKyAgICAg ICAgdG8gdGhlIFdLUGFnZUdyb3VwJ3MgcHJlZmVyZW5jZXMuCisKIDIwMTQtMDEtMjEgIEppbndv byBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdW1dLMl0g VXNlIG5hbm9zZWNvbmRzIGluIFRpbWVyV29ya0l0ZW0gY2xhc3MgY29uc2lzdGVudGx5CkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLQnJvd3NpbmdDb250ZXh0R3Jv dXAuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dL QnJvd3NpbmdDb250ZXh0R3JvdXAuaAkocmV2aXNpb24gMTYyNDkwKQorKysgU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS0Jyb3dzaW5nQ29udGV4dEdyb3VwLmgJKHdvcmtpbmcg Y29weSkKQEAgLTU2LDYgKzU2LDExIEBAIFdLX0FQSV9DTEFTUwogKi8KIEBwcm9wZXJ0eSBCT09M IGFsbG93c1BsdWdJbnM7CiAKKy8qIFNldHRpbmcgdG8gY29udHJvbCB3aGV0aGVyIHByaXZhdGUg YnJvd3NpbmcgaXMgZW5hYmxlZC4KKyBEZWZhdWx0OiBOTworICovCitAcHJvcGVydHkgQk9PTCBw cml2YXRlQnJvd3NpbmdFbmFibGVkOworCiBAZW5kCiAKICNlbmRpZiAvLyBXS19BUElfRU5BQkxF RApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS0Jyb3dzaW5nQ29u dGV4dEdyb3VwLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Q29jb2EvV0tCcm93c2luZ0NvbnRleHRHcm91cC5tbQkocmV2aXNpb24gMTYyNDkwKQorKysgU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS0Jyb3dzaW5nQ29udGV4dEdyb3VwLm1t CSh3b3JraW5nIGNvcHkpCkBAIC0xMDEsNiArMTAxLDE2IEBAIC0gKHZvaWQpc2V0QWxsb3dzUGx1 Z0luczooQk9PTClhbGxvd3NQbHUKICAgICBXS1ByZWZlcmVuY2VzU2V0UGx1Z2luc0VuYWJsZWQo V0tQYWdlR3JvdXBHZXRQcmVmZXJlbmNlcyh0b0FQSShfcGFnZUdyb3VwLmdldCgpKSksIGFsbG93 c1BsdWdJbnMpOwogfQogCistIChCT09MKXByaXZhdGVCcm93c2luZ0VuYWJsZWQKK3sKKyAgICBy ZXR1cm4gV0tQcmVmZXJlbmNlc0dldFByaXZhdGVCcm93c2luZ0VuYWJsZWQoV0tQYWdlR3JvdXBH ZXRQcmVmZXJlbmNlcyh0b0FQSShfcGFnZUdyb3VwLmdldCgpKSkpOworfQorCistICh2b2lkKXNl dFByaXZhdGVCcm93c2luZ0VuYWJsZWQ6KEJPT0wpZW5hYmxlUHJpdmF0ZUJyb3dzaW5nCit7Cisg ICAgV0tQcmVmZXJlbmNlc1NldFByaXZhdGVCcm93c2luZ0VuYWJsZWQoV0tQYWdlR3JvdXBHZXRQ cmVmZXJlbmNlcyh0b0FQSShfcGFnZUdyb3VwLmdldCgpKSksIGVuYWJsZVByaXZhdGVCcm93c2lu Zyk7Cit9CisKIHN0YXRpYyBXS1JldGFpblB0cjxXS0FycmF5UmVmPiBjcmVhdGVXS0FycmF5KE5T QXJyYXkgKmFycmF5KQogewogICAgIE5TVUludGVnZXIgY291bnQgPSBbYXJyYXkgY291bnRdOwo=