127381 2014-01-21 16:22:57 -0800 REGRESSION (r161580): Some PDFs render outside their <img> 2014-01-21 17:30:01 -0800 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca commit-queue mitz sam simon.fraser oldest_to_newest 970472 0 thorton 2014-01-21 16:22:57 -0800 In r161580, I made an adjustment to how we choose the final scale for PDF-in-<img>, to fix unexpected non-uniform scaling due to integer rounding at layout/paint time. Two issues with this: 1. It was happening for all PDFs, even if they had equal scale. 2. It was using the average of the endpoints of the intersection of the possible integer-rounded scale ranges, which is usually greater than the minimum original scale, which means that sometimes the scale we chose would cause the image to be painted outside of the bounds of the <img>. This broke icons in the Web Inspector on a branch where we have r161580 but the Inspector icons are still PDF (not true on ToT). <rdar://problem/15872168> 970474 1 221805 thorton 2014-01-21 16:25:07 -0800 Created attachment 221805 patch 970497 2 221805 thorton 2014-01-21 17:29:23 -0800 Comment on attachment 221805 patch Gonna land it by hand. 970498 3 thorton 2014-01-21 17:30:01 -0800 http://trac.webkit.org/changeset/162486 221805 2014-01-21 16:25:07 -0800 2014-01-21 17:29:23 -0800 patch pdfscale.diff text/plain 2620 thorton SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjQ4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAxLTIxICBUaW0gSG9y dG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIx NjE1ODApOiBTb21lIFBERnMgcmVuZGVyIG91dHNpZGUgdGhlaXIgPGltZz4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzM4MQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMTU4NzIxNjg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9QREZEb2N1bWVudEltYWdlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OnRyYW5zZm9ybUNvbnRleHRGb3JQYWludGluZyk6CisgICAg ICAgIE9ubHkgdHJ5IHRvIG1ha2UgdGhlIHNjYWxlIHVuaWZvcm0gaWYgaXQgaXNuJ3QgYWxyZWFk eSwgYW5kIHVzZSB0aGUgbWluaW11bQorICAgICAgICBvZiB0aGUgdHdvIG9yaWdpbmFsIHNjYWxl cyB3aGVuIGRvaW5nIHNvLCBzbyB0aGF0IGl0IGlzIGFic29sdXRlbHkgY2VydGFpbgorICAgICAg ICB0byBmaXQgaW5zaWRlIHNwYWNlIGFsbG9jYXRlZCBmb3IgdGhlIGltYWdlIGR1cmluZyBsYXlv dXQuCisKIDIwMTQtMDEtMjEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+ CiAKICAgICAgICAgUmVtb3ZlICNpZiBQTEFURk9STShJT1MpIGluIHZhcmlvdXMgcGxhY2VzIGFy b3VuZCBjdXN0b21GaXhlZFBvc2l0aW9uTGF5b3V0UmVjdCgpIGNvZGUKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL1BERkRvY3VtZW50SW1hZ2UuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL1BERkRvY3VtZW50SW1h Z2UuY3BwCShyZXZpc2lvbiAxNjI0ODIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jZy9QREZEb2N1bWVudEltYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTIzLDE0ICsx MjMsMTcgQEAKICAgICBmbG9hdCBoU2NhbGUgPSBkc3RSZWN0LndpZHRoKCkgLyBzcmNSZWN0Lndp ZHRoKCk7CiAgICAgZmxvYXQgdlNjYWxlID0gZHN0UmVjdC5oZWlnaHQoKSAvIHNyY1JlY3QuaGVp Z2h0KCk7CiAKLSAgICBmbG9hdCBtaW5pbXVtU2NhbGUgPSBzdGQ6Om1heCgoZHN0UmVjdC53aWR0 aCgpIC0gMC41KSAvIHNyY1JlY3Qud2lkdGgoKSwgKGRzdFJlY3QuaGVpZ2h0KCkgLSAwLjUpIC8g c3JjUmVjdC5oZWlnaHQoKSk7Ci0gICAgZmxvYXQgbWF4aW11bVNjYWxlID0gc3RkOjptaW4oKGRz dFJlY3Qud2lkdGgoKSArIDAuNSkgLyBzcmNSZWN0LndpZHRoKCksIChkc3RSZWN0LmhlaWdodCgp ICsgMC41KSAvIHNyY1JlY3QuaGVpZ2h0KCkpOworICAgIGlmIChoU2NhbGUgIT0gdlNjYWxlKSB7 CisgICAgICAgIGZsb2F0IG1pbmltdW1TY2FsZSA9IHN0ZDo6bWF4KChkc3RSZWN0LndpZHRoKCkg LSAwLjUpIC8gc3JjUmVjdC53aWR0aCgpLCAoZHN0UmVjdC5oZWlnaHQoKSAtIDAuNSkgLyBzcmNS ZWN0LmhlaWdodCgpKTsKKyAgICAgICAgZmxvYXQgbWF4aW11bVNjYWxlID0gc3RkOjptaW4oKGRz dFJlY3Qud2lkdGgoKSArIDAuNSkgLyBzcmNSZWN0LndpZHRoKCksIChkc3RSZWN0LmhlaWdodCgp ICsgMC41KSAvIHNyY1JlY3QuaGVpZ2h0KCkpOwogCi0gICAgLy8gSWYgdGhlIGRpZmZlcmVuY2Ug YmV0d2VlbiB0aGUgdHdvIHNjYWxlcyBpcyBkdWUgdG8gaW50ZWdlciByb3VuZGluZyBvZiBpbWFn ZSBzaXplcywKLSAgICAvLyB1c2UgdGhlIGF2ZXJhZ2Ugc2NhbGUgZm9yIGJvdGggYXhlcy4KLSAg ICBpZiAobWluaW11bVNjYWxlIDw9IG1heGltdW1TY2FsZSkgewotICAgICAgICBoU2NhbGUgPSAo bWF4aW11bVNjYWxlICsgbWluaW11bVNjYWxlKSAvIDI7Ci0gICAgICAgIHZTY2FsZSA9IGhTY2Fs ZTsKKyAgICAgICAgLy8gSWYgdGhlIGRpZmZlcmVuY2UgYmV0d2VlbiB0aGUgdHdvIHNjYWxlcyBp cyBkdWUgdG8gaW50ZWdlciByb3VuZGluZyBvZiBpbWFnZSBzaXplcywKKyAgICAgICAgLy8gdXNl IHRoZSBzbWFsbGVyIG9mIHRoZSB0d28gb3JpZ2luYWwgc2NhbGVzIHRvIGVuc3VyZSB0aGF0IHRo ZSBpbWFnZSBmaXRzIGluc2lkZSB0aGUKKyAgICAgICAgLy8gc3BhY2Ugb3JpZ2luYWxseSBhbGxv Y2F0ZWQgZm9yIGl0LgorICAgICAgICBpZiAobWluaW11bVNjYWxlIDw9IG1heGltdW1TY2FsZSkg eworICAgICAgICAgICAgaFNjYWxlID0gc3RkOjptaW4oaFNjYWxlLCB2U2NhbGUpOworICAgICAg ICAgICAgdlNjYWxlID0gaFNjYWxlOworICAgICAgICB9CiAgICAgfQogCiAgICAgY29udGV4dC0+ dHJhbnNsYXRlKHNyY1JlY3QueCgpICogaFNjYWxlLCBzcmNSZWN0LnkoKSAqIHZTY2FsZSk7Cg==