127377 2014-01-21 15:58:59 -0800 uint causing problems on Windows 2014-01-21 22:31:49 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P5 Trivial --- 1 alex.christensen webkit-unassigned cdumez cgarcia commit-queue danw dbates gustavo mrobinson oldest_to_newest 970460 0 alex.christensen 2014-01-21 15:58:59 -0800 There are a few places in the soup code that use uint instead of guint and it's causing problems when I'm playing with soup on Windows. 970462 1 221801 alex.christensen 2014-01-21 16:00:10 -0800 Created attachment 221801 Patch 970463 2 221801 mrobinson 2014-01-21 16:01:31 -0800 Comment on attachment 221801 Patch Probably a better choice is "unsigned int" 970549 3 221823 alex.christensen 2014-01-21 20:31:36 -0800 Created attachment 221823 Patch 970573 4 221823 dbates 2014-01-21 21:57:58 -0800 Comment on attachment 221823 Patch This patch looks straightforward to me and is consistent with Martin Robinson's suggestion (comment 2) to explicitly use unsigned instead of the typedef guint. 970584 5 221823 commit-queue 2014-01-21 22:31:46 -0800 Comment on attachment 221823 Patch Clearing flags on attachment: 221823 Committed r162506: <http://trac.webkit.org/changeset/162506> 970585 6 commit-queue 2014-01-21 22:31:49 -0800 All reviewed patches have been landed. Closing bug. 221801 2014-01-21 16:00:10 -0800 2014-01-21 20:31:31 -0800 Patch bug-127377-20140121170010.patch text/plain 2419 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjQ4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAxLTIxICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ29tcGlsZSBm aXggZm9yIHVzaW5nIGxpYnNvdXAgb24gV2luZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzM3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1Byb3h5UmVz b2x2ZXJTb3VwLmNwcDoKKyAgICAgICAgKHNvdXBQcm94eVJlc29sdmVyV2tTZXRQcm9wZXJ0eSk6 CisgICAgICAgIChzb3VwUHJveHlSZXNvbHZlcldrR2V0UHJvcGVydHkpOgorICAgICAgICAoc291 cFByb3h5UmVzb2x2ZXJXa0dldFByb3h5VVJJU3luYyk6CisgICAgICAgIFJlcGxhY2VkIHVpbnQg d2l0aCBndWludC4KKwogMjAxNC0wMS0yMSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFw cGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgI2lmIFBMQVRGT1JNKElPUykgaW4gdmFyaW91cyBw bGFjZXMgYXJvdW5kIGN1c3RvbUZpeGVkUG9zaXRpb25MYXlvdXRSZWN0KCkgY29kZQpJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Byb3h5UmVzb2x2ZXJTb3VwLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUHJv eHlSZXNvbHZlclNvdXAuY3BwCShyZXZpc2lvbiAxNjI0NzgpCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3NvdXAvUHJveHlSZXNvbHZlclNvdXAuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC02OCw3ICs2OCw3IEBAIHN0YXRpYyB2b2lkIHNvdXBQcm94eVJlc29sdmVyV2tGaW5hbGl6 ZSgKICAgICBHX09CSkVDVF9DTEFTUyhzb3VwX3Byb3h5X3Jlc29sdmVyX3drX3BhcmVudF9jbGFz cyktPmZpbmFsaXplKG9iamVjdCk7CiB9CiAKLXN0YXRpYyB2b2lkIHNvdXBQcm94eVJlc29sdmVy V2tTZXRQcm9wZXJ0eShHT2JqZWN0KiBvYmplY3QsIHVpbnQgcHJvcElELCBjb25zdCBHVmFsdWUq IHZhbHVlLCBHUGFyYW1TcGVjKiBwc3BlYykKK3N0YXRpYyB2b2lkIHNvdXBQcm94eVJlc29sdmVy V2tTZXRQcm9wZXJ0eShHT2JqZWN0KiBvYmplY3QsIGd1aW50IHByb3BJRCwgY29uc3QgR1ZhbHVl KiB2YWx1ZSwgR1BhcmFtU3BlYyogcHNwZWMpCiB7CiAgICAgU291cFByb3h5UmVzb2x2ZXJXa1By aXZhdGUqIHByaXYgPSBTT1VQX1BST1hZX1JFU09MVkVSX1dLX0dFVF9QUklWQVRFKG9iamVjdCk7 CiAKQEAgLTkyLDcgKzkyLDcgQEAgc3RhdGljIHZvaWQgc291cFByb3h5UmVzb2x2ZXJXa1NldFBy b3BlcgogICAgIH0KIH0KIAotc3RhdGljIHZvaWQgc291cFByb3h5UmVzb2x2ZXJXa0dldFByb3Bl cnR5KEdPYmplY3QqIG9iamVjdCwgdWludCBwcm9wSUQsIEdWYWx1ZSogdmFsdWUsIEdQYXJhbVNw ZWMqIHBzcGVjKQorc3RhdGljIHZvaWQgc291cFByb3h5UmVzb2x2ZXJXa0dldFByb3BlcnR5KEdP YmplY3QqIG9iamVjdCwgZ3VpbnQgcHJvcElELCBHVmFsdWUqIHZhbHVlLCBHUGFyYW1TcGVjKiBw c3BlYykKIHsKICAgICBTb3VwUHJveHlSZXNvbHZlcldrUHJpdmF0ZSogcHJpdiA9IFNPVVBfUFJP WFlfUkVTT0xWRVJfV0tfR0VUX1BSSVZBVEUob2JqZWN0KTsKIApAQCAtMTU2LDcgKzE1Niw3IEBA IHN0YXRpYyB2b2lkIHNvdXBQcm94eVJlc29sdmVyV2tHZXRQcm94eVUKICAgICBzb3VwX2FkZF9j b21wbGV0aW9uKGFzeW5jQ29udGV4dCwgaWRsZV9yZXR1cm5fcHJveHlfdXJpLCBzc2FkKTsKIH0K IAotc3RhdGljIHVpbnQgc291cFByb3h5UmVzb2x2ZXJXa0dldFByb3h5VVJJU3luYyhTb3VwUHJv eHlVUklSZXNvbHZlciogcHJveHlSZXNvbHZlciwgU291cFVSSSogdXJpLCBHQ2FuY2VsbGFibGUq LCBTb3VwVVJJKiogcHJveHlVUkkpCitzdGF0aWMgZ3VpbnQgc291cFByb3h5UmVzb2x2ZXJXa0dl dFByb3h5VVJJU3luYyhTb3VwUHJveHlVUklSZXNvbHZlciogcHJveHlSZXNvbHZlciwgU291cFVS SSogdXJpLCBHQ2FuY2VsbGFibGUqLCBTb3VwVVJJKiogcHJveHlVUkkpCiB7CiAgICAgU291cFBy b3h5UmVzb2x2ZXJXa1ByaXZhdGUqIHByaXYgPSBTT1VQX1BST1hZX1JFU09MVkVSX1dLX0dFVF9Q UklWQVRFKHByb3h5UmVzb2x2ZXIpOwogCg== 221823 2014-01-21 20:31:36 -0800 2014-01-21 22:31:46 -0800 Patch bug-127377-20140121213137.patch text/plain 2431 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjQ4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAxLTIxICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ29tcGlsZSBm aXggZm9yIHVzaW5nIGxpYnNvdXAgb24gV2luZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzM3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1Byb3h5UmVz b2x2ZXJTb3VwLmNwcDoKKyAgICAgICAgKHNvdXBQcm94eVJlc29sdmVyV2tTZXRQcm9wZXJ0eSk6 CisgICAgICAgIChzb3VwUHJveHlSZXNvbHZlcldrR2V0UHJvcGVydHkpOgorICAgICAgICAoc291 cFByb3h5UmVzb2x2ZXJXa0dldFByb3h5VVJJU3luYyk6CisgICAgICAgIFJlcGxhY2VkIHVpbnQg d2l0aCB1bnNpZ25lZC4KKwogMjAxNC0wMS0yMSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2Vy QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgI2lmIFBMQVRGT1JNKElPUykgaW4gdmFyaW91 cyBwbGFjZXMgYXJvdW5kIGN1c3RvbUZpeGVkUG9zaXRpb25MYXlvdXRSZWN0KCkgY29kZQpJbmRl eDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Byb3h5UmVzb2x2ZXJTb3Vw LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv UHJveHlSZXNvbHZlclNvdXAuY3BwCShyZXZpc2lvbiAxNjI0NzgpCisrKyBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUHJveHlSZXNvbHZlclNvdXAuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC02OCw3ICs2OCw3IEBAIHN0YXRpYyB2b2lkIHNvdXBQcm94eVJlc29sdmVyV2tGaW5h bGl6ZSgKICAgICBHX09CSkVDVF9DTEFTUyhzb3VwX3Byb3h5X3Jlc29sdmVyX3drX3BhcmVudF9j bGFzcyktPmZpbmFsaXplKG9iamVjdCk7CiB9CiAKLXN0YXRpYyB2b2lkIHNvdXBQcm94eVJlc29s dmVyV2tTZXRQcm9wZXJ0eShHT2JqZWN0KiBvYmplY3QsIHVpbnQgcHJvcElELCBjb25zdCBHVmFs dWUqIHZhbHVlLCBHUGFyYW1TcGVjKiBwc3BlYykKK3N0YXRpYyB2b2lkIHNvdXBQcm94eVJlc29s dmVyV2tTZXRQcm9wZXJ0eShHT2JqZWN0KiBvYmplY3QsIHVuc2lnbmVkIHByb3BJRCwgY29uc3Qg R1ZhbHVlKiB2YWx1ZSwgR1BhcmFtU3BlYyogcHNwZWMpCiB7CiAgICAgU291cFByb3h5UmVzb2x2 ZXJXa1ByaXZhdGUqIHByaXYgPSBTT1VQX1BST1hZX1JFU09MVkVSX1dLX0dFVF9QUklWQVRFKG9i amVjdCk7CiAKQEAgLTkyLDcgKzkyLDcgQEAgc3RhdGljIHZvaWQgc291cFByb3h5UmVzb2x2ZXJX a1NldFByb3BlcgogICAgIH0KIH0KIAotc3RhdGljIHZvaWQgc291cFByb3h5UmVzb2x2ZXJXa0dl dFByb3BlcnR5KEdPYmplY3QqIG9iamVjdCwgdWludCBwcm9wSUQsIEdWYWx1ZSogdmFsdWUsIEdQ YXJhbVNwZWMqIHBzcGVjKQorc3RhdGljIHZvaWQgc291cFByb3h5UmVzb2x2ZXJXa0dldFByb3Bl cnR5KEdPYmplY3QqIG9iamVjdCwgdW5zaWduZWQgcHJvcElELCBHVmFsdWUqIHZhbHVlLCBHUGFy YW1TcGVjKiBwc3BlYykKIHsKICAgICBTb3VwUHJveHlSZXNvbHZlcldrUHJpdmF0ZSogcHJpdiA9 IFNPVVBfUFJPWFlfUkVTT0xWRVJfV0tfR0VUX1BSSVZBVEUob2JqZWN0KTsKIApAQCAtMTU2LDcg KzE1Niw3IEBAIHN0YXRpYyB2b2lkIHNvdXBQcm94eVJlc29sdmVyV2tHZXRQcm94eVUKICAgICBz b3VwX2FkZF9jb21wbGV0aW9uKGFzeW5jQ29udGV4dCwgaWRsZV9yZXR1cm5fcHJveHlfdXJpLCBz c2FkKTsKIH0KIAotc3RhdGljIHVpbnQgc291cFByb3h5UmVzb2x2ZXJXa0dldFByb3h5VVJJU3lu YyhTb3VwUHJveHlVUklSZXNvbHZlciogcHJveHlSZXNvbHZlciwgU291cFVSSSogdXJpLCBHQ2Fu Y2VsbGFibGUqLCBTb3VwVVJJKiogcHJveHlVUkkpCitzdGF0aWMgdW5zaWduZWQgc291cFByb3h5 UmVzb2x2ZXJXa0dldFByb3h5VVJJU3luYyhTb3VwUHJveHlVUklSZXNvbHZlciogcHJveHlSZXNv bHZlciwgU291cFVSSSogdXJpLCBHQ2FuY2VsbGFibGUqLCBTb3VwVVJJKiogcHJveHlVUkkpCiB7 CiAgICAgU291cFByb3h5UmVzb2x2ZXJXa1ByaXZhdGUqIHByaXYgPSBTT1VQX1BST1hZX1JFU09M VkVSX1dLX0dFVF9QUklWQVRFKHByb3h5UmVzb2x2ZXIpOwogCg==