127353 2014-01-21 09:50:22 -0800 AX: Mac: Expose the visible text of a password field to AX 2014-01-21 16:06:28 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro commit-queue dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 970288 0 cfleizach 2014-01-21 09:50:22 -0800 The Mac platform is now exposing the rendered visible text of password fields through accessibility. VoiceOver is able to make use of that to provide a better user experience. <rdar://problem/15344998> 970293 1 221756 cfleizach 2014-01-21 09:57:21 -0800 Created attachment 221756 patch 970376 2 221756 bfulgham 2014-01-21 12:23:41 -0800 Comment on attachment 221756 patch r=me 970377 3 221756 cfleizach 2014-01-21 12:24:17 -0800 Comment on attachment 221756 patch Thanks! 970389 4 221756 commit-queue 2014-01-21 12:52:22 -0800 Comment on attachment 221756 patch Clearing flags on attachment: 221756 Committed r162466: <http://trac.webkit.org/changeset/162466> 970390 5 commit-queue 2014-01-21 12:52:23 -0800 All reviewed patches have been landed. Closing bug. 970458 6 ap 2014-01-21 15:58:03 -0800 accessibility/password-field-value.html is failing on all bots: <http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fpassword-field-value.html> +CONSOLE MESSAGE: line 15: TypeError: HTMLParagraphElement is not a function (evaluating 'description("This tests that the AX exposed value of a password field is the rendered text.")') 970464 7 ap 2014-01-21 16:02:32 -0800 Hopefully fixed in <http://trac.webkit.org/r162482>. 970465 8 cfleizach 2014-01-21 16:06:28 -0800 Thanks for looking into that! 221756 2014-01-21 09:57:21 -0800 2014-01-21 12:52:21 -0800 patch patch text/plain 4299 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjQ0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAxLTIxICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IE1hYzogRXhwb3Nl IHRoZSB2aXNpYmxlIHRleHQgb2YgYSBwYXNzd29yZCBmaWVsZCB0byBBWAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3MzUzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIE1hYyBwbGF0Zm9ybSBzaG91 bGQgbm93IGV4cG9zZSB0aGUgcmVuZGVyZWQgdmFsdWUgb2YgcGFzc3dvcmQgZmllbGRzIHRocm91 Z2ggQVguCisKKyAgICAgICAgVGVzdDogYWNjZXNzaWJpbGl0eS9wYXNzd29yZC1maWVsZC12YWx1 ZS5odG1sCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmpl Y3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6dGV4 dExlbmd0aCk6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojpw YXNzd29yZEZpZWxkVmFsdWUpOgorCiAyMDE0LTAxLTIxICBDb21taXQgUXVldWUgIDxjb21taXQt cXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTYy NDQ1LgpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVu ZGVyT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCShyZXZpc2lvbiAxNjIyMDUpCisrKyBTb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMzkzLDExICsxMzkzLDcgQEAKICAgICBBU1NFUlQoaXNUZXh0Q29u dHJvbCgpKTsKICAgICAKICAgICBpZiAoaXNQYXNzd29yZEZpZWxkKCkpCi0jaWYgUExBVEZPUk0o R1RLKQogICAgICAgICByZXR1cm4gcGFzc3dvcmRGaWVsZFZhbHVlKCkubGVuZ3RoKCk7Ci0jZWxz ZQotICAgICAgICByZXR1cm4gLTE7IC8vIG5lZWQgdG8gcmV0dXJuIHNvbWV0aGluZyBkaXN0aW5j dCBmcm9tIDAKLSNlbmRpZgogCiAgICAgcmV0dXJuIHRleHQoKS5sZW5ndGgoKTsKIH0KQEAgLTMz NTksNyArMzM1NSw2IEBACiAKIFN0cmluZyBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpwYXNz d29yZEZpZWxkVmFsdWUoKSBjb25zdAogewotI2lmIFBMQVRGT1JNKEdUSykKICAgICBBU1NFUlQo aXNQYXNzd29yZEZpZWxkKCkpOwogCiAgICAgLy8gTG9vayBmb3IgdGhlIFJlbmRlclRleHQgb2Jq ZWN0IGluIHRoZSBSZW5kZXJPYmplY3QgdHJlZSBmb3IgdGhpcyBpbnB1dCBmaWVsZC4KQEAgLTMz NzEsMTEgKzMzNjYsNyBAQAogICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAKICAgICAvLyBSZXR1 cm4gdGhlIHRleHQgdGhhdCBpcyBhY3R1YWxseSBiZWluZyByZW5kZXJlZCBpbiB0aGUgaW5wdXQg ZmllbGQuCi0gICAgcmV0dXJuIHN0YXRpY19jYXN0PFJlbmRlclRleHQqPihyZW5kZXJlciktPnRl eHRXaXRob3V0Q29udmVydGluZ0JhY2tzbGFzaFRvWWVuU3ltYm9sKCk7Ci0jZWxzZQotICAgIC8v IEl0IHNlZW1zIG9ubHkgR1RLIGlzIGludGVyZXN0ZWQgaW4gdGhpcyBhdCB0aGUgbW9tZW50Lgot ICAgIHJldHVybiBTdHJpbmcoKTsKLSNlbmRpZgorICAgIHJldHVybiB0b1JlbmRlclRleHQocmVu ZGVyZXIpLT50ZXh0V2l0aG91dENvbnZlcnRpbmdCYWNrc2xhc2hUb1llblN5bWJvbCgpOwogfQog CiBTY3JvbGxhYmxlQXJlYSogQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6Z2V0U2Nyb2xsYWJs ZUFyZWFJZlNjcm9sbGFibGUoKSBjb25zdApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTYyNDQ2KQorKysg TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIw MTQtMDEtMjEgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAg ICBBWDogTWFjOiBFeHBvc2UgdGhlIHZpc2libGUgdGV4dCBvZiBhIHBhc3N3b3JkIGZpZWxkIHRv IEFYCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjcz NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFj Y2Vzc2liaWxpdHkvcGFzc3dvcmQtZmllbGQtdmFsdWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBhY2Nlc3NpYmlsaXR5L3Bhc3N3b3JkLWZpZWxkLXZhbHVlLmh0bWw6IEFkZGVkLgor CiAyMDE0LTAxLTIxICBNaWhhaSBUaWNhICA8bWl0aWNhQGFkb2JlLmNvbT4KIAogICAgICAgICBJ ZiB5b3Ugc2V0IGEgdGlsZWQgY3Jvc3MtZmFkZWQtaW1hZ2Ugb3IgYSB0aWxlZCBncmFkaWVudCBh cwpJbmRleDogTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9wYXNzd29yZC1maWVsZC12YWx1ZS1l eHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9wYXNz d29yZC1maWVsZC12YWx1ZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9hY2Nlc3NpYmlsaXR5L3Bhc3N3b3JkLWZpZWxkLXZhbHVlLWV4cGVjdGVkLnR4dAkod29ya2lu ZyBjb3B5KQpAQCAtMCwwICsxLDExIEBACisKK1RoaXMgdGVzdHMgdGhhdCB0aGUgQVggZXhwb3Nl ZCB2YWx1ZSBvZiBhIHBhc3N3b3JkIGZpZWxkIGlzIHRoZSByZW5kZXJlZCB0ZXh0LgorCitPbiBz dWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dl ZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUGFzc3dvcmQgZmllbGQ6IEFYVmFsdWU6IOKAouKA ouKAouKAogorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRF CisKSW5kZXg6IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvcGFzc3dvcmQtZmllbGQtdmFsdWUu aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3Bhc3N3b3JkLWZp ZWxkLXZhbHVlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5 L3Bhc3N3b3JkLWZpZWxkLXZhbHVlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyNiBA QAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+ Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMi Pjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgaWQ9ImJvZHkiPgorCis8aW5wdXQgdHlwZT0icGFz c3dvcmQiIGlkPSJwYXNzIiB2YWx1ZT0idGVzdCI+CisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9w PgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+CisKKyAgICBkZXNjcmlwdGlv bigiVGhpcyB0ZXN0cyB0aGF0IHRoZSBBWCBleHBvc2VkIHZhbHVlIG9mIGEgcGFzc3dvcmQgZmll bGQgaXMgdGhlIHJlbmRlcmVkIHRleHQuIik7CisKKyAgICBpZiAod2luZG93LmFjY2Vzc2liaWxp dHlDb250cm9sbGVyKSB7CisgICAgICAgIGRlYnVnKCJQYXNzd29yZCBmaWVsZDogIiArIGFjY2Vz c2liaWxpdHlDb250cm9sbGVyLmFjY2Vzc2libGVFbGVtZW50QnlJZCgicGFzcyIpLnN0cmluZ1Zh bHVlKTsKKyAgICB9CisgICAgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKworPC9zY3JpcHQ+ CisKKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Nj cmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K