127352 2014-01-21 09:36:57 -0800 [GTK] Accessibility daemons are killing the bots 2020-07-06 00:10:55 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED WORKSFORME https://bugs.webkit.org/show_bug.cgi?id=132134 https://bugs.webkit.org/show_bug.cgi?id=153483 P2 Major --- 1 svillar webkit-unassigned apinheiro bugs-noreply cgarcia clopez commit-queue jdiggs mario mcatanzaro ossy svillar zan zsborbely.u-szeged oldest_to_newest 970284 0 svillar 2014-01-21 09:36:57 -0800 I knew that we fixed something like this in the past, but I have just logged in our bots and there were literally hundreds of dbus-daemon and at-spi processes running in the bot machines. 976305 1 mario 2014-02-04 06:09:38 -0800 What we fixed was a typo in the run-gtk-tests that was preventing the daemon to properly shut down, so I thought that would be enough to fix the problem in the bots. Unfortunately, that seemed not to be enough, and it's quite hard for me to find the real issue and fix it because I neither can reproduce the problem locally nor I can ssh into the bots. Thus, if someone else with access to the bot could investigate this issue, that would be great. Of course, I'd be happy to help with it, but at this point I think some investigation inside the actual bot would be the way to go. 997507 2 svillar 2014-04-04 02:12:14 -0700 Raising importance. 997625 3 228604 clopez 2014-04-04 10:48:31 -0700 Created attachment 228604 Patch 997627 4 clopez 2014-04-04 10:49:48 -0700 I can confirm the issue with the dbus-daemon processes, but not with at-spi ones. I have attached a patch for this. 997652 5 228604 commit-queue 2014-04-04 11:37:28 -0700 Comment on attachment 228604 Patch Clearing flags on attachment: 228604 Committed r166798: <http://trac.webkit.org/changeset/166798> 997653 6 commit-queue 2014-04-04 11:37:32 -0700 All reviewed patches have been landed. Closing bug. 998532 7 zsborbely.u-szeged 2014-04-08 04:52:47 -0700 Killing the dbus-daemon is not a good solution, since it locks the screen of the EFL performance bot. In this case every tests will fail. 998535 8 clopez 2014-04-08 05:00:24 -0700 (In reply to comment #7) > Killing the dbus-daemon is not a good solution, since it locks the screen of the EFL performance bot. In this case every tests will fail. How that can happen? You should be running the bot as an unprivileged user, so the bot can't kill the processes (dbus-daemon) of the system or of other users. 998542 9 zsborbely.u-szeged 2014-04-08 05:37:27 -0700 Every user has his/her own dbus-daemon, and the EFL performance bot kills the current user's daemon. 998543 10 clopez 2014-04-08 05:51:15 -0700 (In reply to comment #9) > Every user has his/her own dbus-daemon, and the EFL performance bot kills the current user's daemon. Does the EFL performance bot runs as root? Otherwise I don't understand 999527 11 zsborbely.u-szeged 2014-04-10 07:37:24 -0700 We run it as not root, the buildbot killed its own dbus-daemon, not anyone else's daemon. The dbus-daemon is neccessary in case of gnome and unity as well. 999535 12 ossy 2014-04-10 07:57:37 -0700 I agree with Zsolt, killing dbus-daemon is not the proper fix instead of finding and fixing the issue you raised on GTK. If you really want to kill all dbus-daemon processes, please improve kill-old-processes to receive --efl/--gtk/... options and kill dbus-daemon only on GTK. And then you can simple make the buildmaster to pass the platform to the script with calling appendCustomBuildFlag() in master.cfg similar to CompileWebKit or RunWebKitTests. 1000472 13 clopez 2014-04-14 05:43:46 -0700 (In reply to comment #12) > I agree with Zsolt, killing dbus-daemon is not the proper fix > instead of finding and fixing the issue you raised on GTK. > I don't know if there is another possible fix for this issue other than killing all the dbus-daemon process. Ideas? > If you really want to kill all dbus-daemon processes, please improve > kill-old-processes to receive --efl/--gtk/... options and kill dbus-daemon > only on GTK. And then you can simple make the buildmaster to pass the > platform to the script with calling appendCustomBuildFlag() in master.cfg > similar to CompileWebKit or RunWebKitTests. This looks like a good idea, I think we can do it. 1010455 14 clopez 2014-05-20 04:37:57 -0700 I have been investigating this issue, and my tests reveal that the rogue dbus-daemon processes that are created when running Tools/Scripts/run-gtk-tests is because of bug https://bugs.webkit.org/show_bug.cgi?id=131675 I tried to run run-gtk-tests several times with and without the patch attached on https://bugs.webkit.org/show_bug.cgi?id=131675 and compared the dbus-daemon process before and after the execution of run-gtk-tests. I can confirm that with the patch on https://bugs.webkit.org/show_bug.cgi?id=131675 this problem not longer shows, and not extra dbus-daemon process are left after the test ends the execution. The approach of killing all the dbus-daemon process on the step kill-old-processes only hides the real problem. It also makes very difficult to run the bot inside a GNOME session (and that is convenient for a perf bot). So I suggest to rollout r166798 <http://trac.webkit.org/changeset/166798> and get the patch on https://bugs.webkit.org/show_bug.cgi?id=131675 applied. 1011240 15 clopez 2014-05-23 07:42:16 -0700 (In reply to comment #14) > The approach of killing all the dbus-daemon process on the step kill-old-processes only hides the real problem. It also makes very difficult to run the bot inside a GNOME session (and that is convenient for a perf bot). So I suggest to rollout r166798 <http://trac.webkit.org/changeset/166798> and get the patch on https://bugs.webkit.org/show_bug.cgi?id=131675 applied. Created bug 133215 for rolling out r166798. But before rolling out r166798, it would be great if we can get bug 131675 fixed 1129895 16 clopez 2015-10-01 04:26:20 -0700 We have detected this started to happen again. There are lots of rogue at-spi-bus-launcher and dbus-daemon process on the GTK+ bots There was about 600 processes like this on the test bots: slave 9795 0.0 0.0 34120 1016 ? Ss Sep30 0:00 /usr/bin/dbus-daemon --fork --print-pid 5 --print-address 7 --session slave 9797 0.0 0.0 255720 3276 ? Sl Sep30 0:00 /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/libexec/at-spi-bus-launcher slave 9800 0.0 0.0 34120 1640 ? S Sep30 0:00 \_ /usr/bin/dbus-daemon --config-file=/home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/etc/at-spi2/accessibility.conf --nofork --print-address 3 1158800 17 clopez 2016-01-26 06:32:12 -0800 I have proposed in bug 153483 a patch to allow defining an extra list of tasks to kill on each bot. That way I can configure dbus-daemon and related at-spi process to be killed on the GTK test bots as needed. 1668984 18 svillar 2020-07-06 00:10:55 -0700 Seems that this is no longer an issue. Let's reopen this in case it fails again. 228604 2014-04-04 10:48:31 -0700 2014-04-04 11:37:27 -0700 Patch bug-127352-20140404194810.patch text/plain 1102 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NzgyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGI2NGQ5N2IyZGRhNWI5ZDU4MjRlNmJkMWI5ODI0OWQ3 MWE5NzQxOS4uOTkxZTRkNjQ3MjU4NThmYmRlNmEzNWQ0MTA0NTkyYzdlOTNlMTNlYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTA0LTA0ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdIGtpbGwtb2xkLXByb2Nlc3NlcyBzaG91bGQga2lsbCBk YnVzLWRhZW1vbiBwcm9jZXNzZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyNzM1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQva2lsbC1vbGQtcHJvY2Vzc2VzOgorICAg ICAgICAobWFpbik6CisKIDIwMTQtMDQtMDQgIEFuZHJlcyBHb21leiAgPGFnb21lekBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtXaW5dIFVwZGF0ZSBvYnNvbGV0ZSBwYWNrYWdlcyBpbiBjeWd3aW4K ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2tpbGwtb2xkLXByb2Nlc3NlcyBi L1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2tpbGwtb2xkLXByb2Nlc3NlcwppbmRleCAzNzM3MjA1 ZWNiNGZiYjc1YTEwMTM5OTMyMzJmNjA5YTliNDc2MzQ2Li43ZDU3ZTVlZmU4OWJkMjY4ZGVhMGY1 NmFlMDlkMWE3M2EzYjM2YjM2IDEwMDc1NQotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9r aWxsLW9sZC1wcm9jZXNzZXMKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQva2lsbC1vbGQt cHJvY2Vzc2VzCkBAIC05MCw2ICs5MCw3IEBAIGRlZiBtYWluKCk6CiAgICAgdGFza1RvS2lsbFVu aXggPSBbCiAgICAgICAgICJhcGFjaGUyIiwKICAgICAgICAgImNjMXBsdXMiLAorICAgICAgICAi ZGJ1cy1kYWVtb24iLAogICAgICAgICAiRHVtcFJlbmRlclRyZWUiLAogICAgICAgICAiZ29sZCIs CiAgICAgICAgICJodHRwZCIsCg==