127347 2014-01-21 07:57:21 -0800 Delay initial layer flush during loading on all platforms 2014-01-21 14:04:24 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser thorton oldest_to_newest 970246 0 koivisto 2014-01-21 07:57:21 -0800 To reduce unnecessary repaints enable the same behaviour as iOS already has. 970249 1 221743 koivisto 2014-01-21 08:02:04 -0800 Created attachment 221743 patch 970260 2 221743 kling 2014-01-21 08:18:09 -0800 Comment on attachment 221743 patch View in context: https://bugs.webkit.org/attachment.cgi?id=221743&action=review Well that looked easy. r=me > Source/WebCore/rendering/RenderLayerCompositor.cpp:253 > - , m_layerFlushThrottlingEnabled(false) > + , m_layerFlushThrottlingEnabled(page() && page()->progress().isMainLoadProgressing()) I wonder why page() returns a pointer, and not a reference. 970266 3 koivisto 2014-01-21 08:40:08 -0800 https://trac.webkit.org/r162443 970320 4 simon.fraser 2014-01-21 10:53:04 -0800 Does this mean we see a longer delay on back/forward before seeing the new page? Or is page cache navigation not affected? 970413 5 koivisto 2014-01-21 14:04:24 -0800 (In reply to comment #4) > Does this mean we see a longer delay on back/forward before seeing the new page? Or is page cache navigation not affected? Page cache navigation shouldn't be affected. Completed load always turn off throttling. 221743 2014-01-21 08:02:04 -0800 2014-01-21 08:18:09 -0800 patch layer-flush-initial-mac.patch text/plain 3948 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjQ0MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTAxLTIxICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBEZWxheSBpbml0aWFsIGxheWVy IGZsdXNoIGR1cmluZyBsb2FkaW5nIG9uIGFsbCBwbGF0Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzM0NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRvIHJlZHVjZSB1bm5lY2Vzc2FyeSByZXBh aW50cyBlbmFibGUgdGhlIHNhbWUgYmVoYXZpb3VyIGFzIGlPUyBhbHJlYWR5IGhhcy4KKworICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpSZW5kZXJMYXllckNvbXBvc2l0b3IpOgorICAg ICAgICAKKyAgICAgICAgICAgIFNldCB0aGUgaW5pdGlhbCBzdGF0ZSBvZiBtX2xheWVyRmx1c2hU aHJvdHRsaW5nRW5hYmxlZCBjb3JyZWN0bHkuCisKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxh eWVyQ29tcG9zaXRvcjo6c2NoZWR1bGVMYXllckZsdXNoKToKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckxheWVyQ29tcG9zaXRvcjo6c3RhcnRJbml0aWFsTGF5ZXJGbHVzaFRpbWVySWZOZWVkZWQp OgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaDoKKyAgICAgICAg CisgICAgICAgICAgICBFbmFibGUgaW5pdGlhbCBsYXllciBmbHVzaCBkZWxheSBvbiBhbGwgcGxh dGZvcm1zLgorCiAyMDE0LTAxLTIxICBHdXJwcmVldCBLYXVyICA8ay5ndXJwcmVldEBzYW1zdW5n LmNvbT4KIAogICAgICAgICBUaGUgV2ViQ29yZS52Y3hwcm9qLmZpbHRlcnMgZG9lc25vdCBhcHBs eQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29t cG9zaXRvci5jcHAJKHJldmlzaW9uIDE2MjIwMSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NSw2ICs0NSw3 IEBACiAjaW5jbHVkZSAiTG9nZ2luZy5oIgogI2luY2x1ZGUgIk5vZGVMaXN0LmgiCiAjaW5jbHVk ZSAiUGFnZS5oIgorI2luY2x1ZGUgIlByb2dyZXNzVHJhY2tlci5oIgogI2luY2x1ZGUgIlJlbmRl ckVtYmVkZGVkT2JqZWN0LmgiCiAjaW5jbHVkZSAiUmVuZGVyRmxvd1RocmVhZC5oIgogI2luY2x1 ZGUgIlJlbmRlckZ1bGxTY3JlZW4uaCIKQEAgLTk4LDYgKzk5LDcgQEAgc3RhdGljIGNvbnN0IGlu dCBjYW52YXNBcmVhVGhyZXNob2xkUmVxdQogc3RhdGljIGNvbnN0IGRvdWJsZSB0aHJvdHRsZWRM YXllckZsdXNoSW5pdGlhbERlbGF5ID0gLjU7CiBzdGF0aWMgY29uc3QgZG91YmxlIHRocm90dGxl ZExheWVyRmx1c2hEZWxheSA9IDEuNTsKICNlbHNlCitzdGF0aWMgY29uc3QgZG91YmxlIHRocm90 dGxlZExheWVyRmx1c2hJbml0aWFsRGVsYXkgPSAuMzsKIHN0YXRpYyBjb25zdCBkb3VibGUgdGhy b3R0bGVkTGF5ZXJGbHVzaERlbGF5ID0gLjU7CiAjZW5kaWYKIApAQCAtMjQ4LDcgKzI1MCw3IEBA IFJlbmRlckxheWVyQ29tcG9zaXRvcjo6UmVuZGVyTGF5ZXJDb21wb3MKICAgICAsIG1fbGF5ZXJz V2l0aFRpbGVkQmFja2luZ0NvdW50KDApCiAgICAgLCBtX3Jvb3RMYXllckF0dGFjaG1lbnQoUm9v dExheWVyVW5hdHRhY2hlZCkKICAgICAsIG1fbGF5ZXJGbHVzaFRpbWVyKHRoaXMsICZSZW5kZXJM YXllckNvbXBvc2l0b3I6OmxheWVyRmx1c2hUaW1lckZpcmVkKQotICAgICwgbV9sYXllckZsdXNo VGhyb3R0bGluZ0VuYWJsZWQoZmFsc2UpCisgICAgLCBtX2xheWVyRmx1c2hUaHJvdHRsaW5nRW5h YmxlZChwYWdlKCkgJiYgcGFnZSgpLT5wcm9ncmVzcygpLmlzTWFpbkxvYWRQcm9ncmVzc2luZygp KQogICAgICwgbV9sYXllckZsdXNoVGhyb3R0bGluZ1RlbXBvcmFyaWx5RGlzYWJsZWRGb3JJbnRl cmFjdGlvbihmYWxzZSkKICAgICAsIG1faGFzUGVuZGluZ0xheWVyRmx1c2goZmFsc2UpCiAgICAg LCBtX3BhaW50UmVsYXRlZE1pbGVzdG9uZXNUaW1lcih0aGlzLCAmUmVuZGVyTGF5ZXJDb21wb3Np dG9yOjpwYWludFJlbGF0ZWRNaWxlc3RvbmVzVGltZXJGaXJlZCkKQEAgLTM3NCwxMCArMzc2LDgg QEAgdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnNjaGVkdWxlTGF5ZQogewogICAgIEFTU0VS VCghbV9mbHVzaGluZ0xheWVycyk7CiAKLSNpZiBQTEFURk9STShJT1MpCiAgICAgaWYgKGNhblRo cm90dGxlKQogICAgICAgICBzdGFydEluaXRpYWxMYXllckZsdXNoVGltZXJJZk5lZWRlZCgpOwot I2VuZGlmCiAKICAgICBpZiAoY2FuVGhyb3R0bGUgJiYgaXNUaHJvdHRsaW5nTGF5ZXJGbHVzaGVz KCkpIHsKICAgICAgICAgbV9oYXNQZW5kaW5nTGF5ZXJGbHVzaCA9IHRydWU7CkBAIC0zNjc3LDcg KzM2NzcsNiBAQCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6c3RhcnRMYXllckZsCiAgICAg bV9sYXllckZsdXNoVGltZXIuc3RhcnRPbmVTaG90KHRocm90dGxlZExheWVyRmx1c2hEZWxheSk7 CiB9CiAKLSNpZiBQTEFURk9STShJT1MpCiB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6c3Rh cnRJbml0aWFsTGF5ZXJGbHVzaFRpbWVySWZOZWVkZWQoKQogewogICAgIGlmICghbV9sYXllckZs dXNoVGhyb3R0bGluZ0VuYWJsZWQpCkBAIC0zNjg2LDcgKzM2ODUsNiBAQCB2b2lkIFJlbmRlckxh eWVyQ29tcG9zaXRvcjo6c3RhcnRJbml0aWFsCiAgICAgICAgIHJldHVybjsKICAgICBtX2xheWVy Rmx1c2hUaW1lci5zdGFydE9uZVNob3QodGhyb3R0bGVkTGF5ZXJGbHVzaEluaXRpYWxEZWxheSk7 CiB9Ci0jZW5kaWYKIAogdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmxheWVyRmx1c2hUaW1l ckZpcmVkKFRpbWVyPFJlbmRlckxheWVyQ29tcG9zaXRvcj4mKQogewpJbmRleDogU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaAkocmV2aXNpb24g MTYyMjAxKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRv ci5oCSh3b3JraW5nIGNvcHkpCkBAIC00MDYsNyArNDA2LDYgQEAgcHJpdmF0ZToKIAogICAgIENo cm9tZUNsaWVudCogY2hyb21lQ2xpZW50KCkgY29uc3Q7CiAKLSAgICB2b2lkIHN0YXJ0SW5pdGlh bExheWVyRmx1c2hUaW1lcklmTmVlZGVkKCk7CiAjZW5kaWYKIAogICAgIHZvaWQgYWRkVmlld3Bv cnRDb25zdHJhaW5lZExheWVyKFJlbmRlckxheWVyJik7CkBAIC00MzAsNiArNDI5LDcgQEAgcHJp dmF0ZToKIAogICAgIHZvaWQgc2NoZWR1bGVMYXllckZsdXNoTm93KCk7CiAgICAgYm9vbCBpc1Ro cm90dGxpbmdMYXllckZsdXNoZXMoKSBjb25zdDsKKyAgICB2b2lkIHN0YXJ0SW5pdGlhbExheWVy Rmx1c2hUaW1lcklmTmVlZGVkKCk7CiAgICAgdm9pZCBzdGFydExheWVyRmx1c2hUaW1lcklmTmVl ZGVkKCk7CiAgICAgdm9pZCBsYXllckZsdXNoVGltZXJGaXJlZChUaW1lcjxSZW5kZXJMYXllckNv bXBvc2l0b3I+Jik7CiAK