127323 2014-01-20 16:58:53 -0800 platform/mac/accessibility/iframe-aria-hidden.html is flaky 2014-01-21 14:10:20 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs kling koivisto mario samuel_white webkit-bug-importer oldest_to_newest 970083 0 ap 2014-01-20 16:58:53 -0800 platform/mac/accessibility/iframe-aria-hidden.html always fails on the first attempt on WebKit2 bots, and only passes on retry: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fmac%2Faccessibility%2Fiframe-aria-hidden.html PASS body.childrenCount is 3 PASS body.childAtIndex(0).childrenCount is 0 PASS body.childrenCount is 4 FAIL body.childAtIndex(0).childAtIndex(0).childAtIndex(0).role should be AXRole: AXWebArea. Threw exception TypeError: null is not an object (evaluating 'body.childAtIndex(0).childAtIndex(0).childAtIndex(0).role') When running locally, I see that it always fails on second try. The second attempt will fail: run-webkit-tests -2 platform/mac/accessibility/iframe-aria-hidden.html --repeat 2 --no-retry-failures Looking at the test, I think that it needs to be run in window.onload, because otherwise, there is a race with loading the iframe. But when I change it to run in onload, it starts to fail every time. For some reason, AXScrollArea doesn't have any child elements. So it seems like there are at least two issues - one that the test should be made more robust by switching to onload, and another that it shouldn't fail. 970085 1 ap 2014-01-20 17:01:59 -0800 Marked as flaky in <http://trac.webkit.org/r162392>. Unfortunately, this reduces test coverage, as we won't confirm that the test passes on retry - we'll just accept failure as an expected outcome. Hopefully this bug can be fixed for good, making this moot. 970088 2 ap 2014-01-20 17:13:05 -0800 Hmm, this is a very recent regression! These changes are ones in blame list: http://trac.webkit.org/changeset/162354 Update overlay scrollbars in single pass http://trac.webkit.org/changeset/162355 Remove an unused member variable http://trac.webkit.org/changeset/162356 Let RenderImage construct its RenderImageResource I suspect that this is the scroll bars change. Antti, will you have an opportunity to look into this soon? Should we roll out for now to confirm that this change is to blame? 970093 3 webkit-bug-importer 2014-01-20 17:28:06 -0800 <rdar://problem/15865578> 970311 4 ap 2014-01-21 10:38:10 -0800 Rolling out r162354 appears to have helped. I'll update the test and un-mark it. 970332 5 221765 ap 2014-01-21 11:23:38 -0800 Created attachment 221765 proposed patch 970414 6 221765 commit-queue 2014-01-21 14:10:16 -0800 Comment on attachment 221765 proposed patch Clearing flags on attachment: 221765 Committed r162474: <http://trac.webkit.org/changeset/162474> 970415 7 commit-queue 2014-01-21 14:10:20 -0800 All reviewed patches have been landed. Closing bug. 221765 2014-01-21 11:23:38 -0800 2014-01-21 14:10:14 -0800 proposed patch DeflakeAccessibility.txt text/plain 3118 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE2MjQ1MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAxLTIxICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5 L2lmcmFtZS1hcmlhLWhpZGRlbi5odG1sIGlzIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjczMjMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHRlc3QgZ290IGRlLWZsYWtlZCBvbiBib3Rz IGJ5IHJvbGxpbmcgb3V0IHIxNjIzNTQuIEJ1dCB0aGVyZSB3YXMgc3RpbGwKKyAgICAgICAgYSBw b3RlbnRpYWwgcmFjZSBpbiBpdCwgd2hpY2ggdGhpcyBjaGFuZ2UgZml4ZXMuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnM6IFJlbW92ZWQgZXhwZWN0YXRpb24u CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9pZnJhbWUtYXJpYS1oaWRk ZW4uaHRtbDogUnVuIHRoZSB0ZXN0IGluIG9ubG9hZCwgYXMKKyAgICAgICAgZnJhbWVzIGxvYWQg YXN5bmNocm9ub3VzbHkuCisKIDIwMTQtMDEtMjEgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNv bkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkICZscm07ICZybG07IGFuZCAmbmJzcDsgdG8gV2Vi VlRUIHBhcnNlcgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0 YXRpb25zCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4 cGVjdGF0aW9ucwkocmV2aXNpb24gMTYyMzkyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj LXdrMi9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC00NTEsOCArNDUxLDYgQEAg d2Via2l0Lm9yZy9iLzEyNjk2MiBwbHVnaW5zL3BsdWdpbi1kb2N1bQogCiB3ZWJraXQub3JnL2Iv MTI3MzE2IHN2Zy9kb20vU1ZHUG9seWdvbkVsZW1lbnQtYmFzZVZhbC1saXN0LXJlbW92YWwtY3Jh c2guaHRtbCBbIFBhc3MgVGltZW91dCBdCiAKLXdlYmtpdC5vcmcvYi8xMjczMjMgcGxhdGZvcm0v bWFjL2FjY2Vzc2liaWxpdHkvaWZyYW1lLWFyaWEtaGlkZGVuLmh0bWwgWyBQYXNzIEZhaWx1cmUg XQotCiAjIyMgRU5EIE9GICgzKSBVbmNsYXNzaWZpZWQgZmFpbHVyZXMKICMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMKIApJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL2FjY2Vzc2liaWxpdHkvaWZyYW1lLWFyaWEtaGlkZGVuLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvaWZyYW1lLWFyaWEtaGlkZGVu Lmh0bWwJKHJldmlzaW9uIDE2MjM2NikKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nl c3NpYmlsaXR5L2lmcmFtZS1hcmlhLWhpZGRlbi5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xNCwy NCArMTQsMjkgQEAgdmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IGZhbHNlOwogPGRpdiBpZD0iY29u c29sZSI+PC9kaXY+CiAKIDxzY3JpcHQ+CitkZXNjcmlwdGlvbigiVGhpcyB0ZXN0cyB0aGF0IGFy aWEtaGlkZGVuIHdpbGwgYWZmZWN0IHRoZSB2aXNpYmlsaXR5IG9mIHRoZSB3ZWIgYXJlYSBhbmQg c2Nyb2xsIHZpZXcuIik7CiAKLSAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0cyB0aGF0IGFyaWEt aGlkZGVuIHdpbGwgYWZmZWN0IHRoZSB2aXNpYmlsaXR5IG9mIHRoZSB3ZWIgYXJlYSBhbmQgc2Ny b2xsIHZpZXcuIik7CitpZiAod2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisgICAg anNUZXN0SXNBc3luYyA9IHRydWU7CiAKLSAgICBpZiAod2luZG93LmFjY2Vzc2liaWxpdHlDb250 cm9sbGVyKSB7CisgICAgLy8gR2V0IHRoZSBpZnJhbWUgcmVmZXJlbmNlLgorICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJib2R5IikuZm9jdXMoKTsKKyAgICB2YXIgYm9keSA9IGFjY2Vzc2li aWxpdHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50OwogCi0gICAgICAgIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJib2R5IikuZm9jdXMoKTsKLQotICAgICAgICAvLyBHZXQgdGhlIGlmcmFtZSBy ZWZlcmVuY2UuCi0gICAgICAgIHZhciBib2R5ID0gYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuZm9j dXNlZEVsZW1lbnQ7CisgICAgd2luZG93Lm9ubG9hZCA9IGZ1bmN0aW9uKCkgewogICAgICAgICBz aG91bGRCZSgiYm9keS5jaGlsZHJlbkNvdW50IiwgIjMiKTsKICAgICAgICAgc2hvdWxkQmUoImJv ZHkuY2hpbGRBdEluZGV4KDApLmNoaWxkcmVuQ291bnQiLCAiMCIpOwogCiAgICAgICAgIGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJpZnJhbWUiKS5zZXRBdHRyaWJ1dGUoImFyaWEtaGlkZGVuIiwg ImZhbHNlIik7CiAgICAgICAgIHNob3VsZEJlKCJib2R5LmNoaWxkcmVuQ291bnQiLCAiNCIpOwog ICAgICAgICBzaG91bGRCZSgiYm9keS5jaGlsZEF0SW5kZXgoMCkuY2hpbGRBdEluZGV4KDApLmNo aWxkQXRJbmRleCgwKS5yb2xlIiwgIidBWFJvbGU6IEFYV2ViQXJlYSciKTsKKworICAgICAgICBm aW5pc2hKU1Rlc3QoKTsKICAgICB9Cit9IGVsc2UKKyAgICB0ZXN0RmFpbGVkKCJUaGlzIHRlc3Qg cmVsaWVzIG9uIGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLCBwbGVhc2UgdXNlIHJ1bi13ZWJraXQt dGVzdHMgdG8gcnVuIGl0LiIpCiAKLSAgICBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworc3Vj Y2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKIDwvc2NyaXB0PgogCiA8c2NyaXB0IHNyYz0iLi4vLi4v Li4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cg==