127320 2014-01-20 16:02:06 -0800 ArithSqrt in FTL 2014-02-07 13:01:05 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mmirman webkit-unassigned fpizlo oldest_to_newest 970061 0 mmirman 2014-01-20 16:02:06 -0800 patch forthcoming. 970063 1 221702 mmirman 2014-01-20 16:04:41 -0800 Created attachment 221702 ArithSqrt in FTL patch Also simplified implementation of lowering for ArithSin and ArithCos 970078 2 221702 fpizlo 2014-01-20 16:35:26 -0800 Comment on attachment 221702 ArithSqrt in FTL patch Awesome. R=me. I will land. 977995 3 fpizlo 2014-02-07 13:01:05 -0800 Landed in http://trac.webkit.org/changeset/162388 221702 2014-01-20 16:04:41 -0800 2014-01-20 16:35:25 -0800 ArithSqrt in FTL patch patch.patch text/plain 5085 mmirman SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYyMzgzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE0LTAxLTIwICBNYXR0aGV3IE1pcm1hbiAgPG1taXJtYW5AYXBwbGUuY29tPgorCisgICAg ICAgIEFyaXRoU3FydCBpbiBGVEwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyNzMyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogZnRsL0ZUTENhcGFiaWxpdGllcy5jcHA6CisgICAgICAgIChKU0M6OkZU TDo6Y2FuQ29tcGlsZSk6CisgICAgICAgICogZnRsL0ZUTEludHJpbnNpY1JlcG9zaXRvcnkuaDoK KyAgICAgICAgKiBmdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwOgorICAgICAgICAoSlNDOjpGVEw6 Okxvd2VyREZHVG9MTFZNOjpjb21waWxlTm9kZSk6IEFkZGVkCisgICAgICAgIChKU0M6OkZUTDo6 TG93ZXJERkdUb0xMVk06OmNvbXBpbGVBcml0aFNpbik6IFNpbXBsaWZpZWQgaW1wbGVtZW50YXRp b24KKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExWTTo6Y29tcGlsZUFyaXRoQ29zKTog U2ltcGxpZmllZCBpbXBsZW1lbnRhdGlvbgorICAgICAgICAoSlNDOjpGVEw6Okxvd2VyREZHVG9M TFZNOjpjb21waWxlQXJpdGhTcXJ0KTogQWRkZWQKKyAgICAgICAgKiBmdGwvRlRMT3V0cHV0Lmg6 CisgICAgICAgIChKU0M6OkZUTDo6T3V0cHV0Ojpkb3VibGVTcXJ0KTogQWRkZWQKKyAgICAgICAg KiB0ZXN0cy9zdHJlc3MvZnRsLWFyaXRoc3FydC5qczogQWRkZWQuCisgICAgICAgIChmb28pOgor CiAyMDE0LTAxLTIwICBNYXR0aGV3IE1pcm1hbiAgPG1taXJtYW5AYXBwbGUuY29tPgogCiAgICAg ICAgIEFyaXRoQ29zIGluIEZUTApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExD YXBhYmlsaXRpZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwv RlRMQ2FwYWJpbGl0aWVzLmNwcAkocmV2aXNpb24gMTYyMzgzKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2Z0bC9GVExDYXBhYmlsaXRpZXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NCw2ICs4 NCw3IEBAIGlubGluZSBDYXBhYmlsaXR5TGV2ZWwgY2FuQ29tcGlsZShOb2RlKiAKICAgICBjYXNl IEFyaXRoQWJzOgogICAgIGNhc2UgQXJpdGhTaW46CiAgICAgY2FzZSBBcml0aENvczoKKyAgICBj YXNlIEFyaXRoU3FydDoKICAgICBjYXNlIEFyaXRoTmVnYXRlOgogICAgIGNhc2UgVUludDMyVG9O dW1iZXI6CiAgICAgY2FzZSBJbnQzMlRvRG91YmxlOgpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2Z0bC9GVExJbnRyaW5zaWNSZXBvc2l0b3J5LmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2Z0bC9GVExJbnRyaW5zaWNSZXBvc2l0b3J5LmgJKHJldmlzaW9uIDE2MjM4 MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMSW50cmluc2ljUmVwb3NpdG9yeS5o CSh3b3JraW5nIGNvcHkpCkBAIC00Miw2ICs0Miw3IEBAIG5hbWVzcGFjZSBKU0MgeyBuYW1lc3Bh Y2UgRlRMIHsKICAgICBtYWNybyhkb3VibGVBYnMsICJsbHZtLmZhYnMuZjY0IiwgZnVuY3Rpb25U eXBlKGRvdWJsZVR5cGUsIGRvdWJsZVR5cGUpKSBcCiAgICAgbWFjcm8oZG91YmxlU2luLCAibGx2 bS5zaW4uZjY0IiwgZnVuY3Rpb25UeXBlKGRvdWJsZVR5cGUsIGRvdWJsZVR5cGUpKSBcCiAgICAg bWFjcm8oZG91YmxlQ29zLCAibGx2bS5jb3MuZjY0IiwgZnVuY3Rpb25UeXBlKGRvdWJsZVR5cGUs IGRvdWJsZVR5cGUpKSBcCisgICAgbWFjcm8oZG91YmxlU3FydCwgImxsdm0uc3FydC5mNjQiLCBm dW5jdGlvblR5cGUoZG91YmxlVHlwZSwgZG91YmxlVHlwZSkpIFwKICAgICBtYWNybyhmcmFtZUFk ZHJlc3MsICJsbHZtLmZyYW1lYWRkcmVzcyIsIGZ1bmN0aW9uVHlwZShwb2ludGVyVHlwZShpbnQ4 KSwgaW50MzIpKSBcCiAgICAgbWFjcm8obXVsV2l0aE92ZXJmbG93MzIsICJsbHZtLnNtdWwud2l0 aC5vdmVyZmxvdy5pMzIiLCBmdW5jdGlvblR5cGUoc3RydWN0VHlwZShtX2NvbnRleHQsIGludDMy LCBib29sZWFuKSwgaW50MzIsIGludDMyKSkgXAogICAgIG1hY3JvKG11bFdpdGhPdmVyZmxvdzY0 LCAibGx2bS5zbXVsLndpdGgub3ZlcmZsb3cuaTY0IiwgZnVuY3Rpb25UeXBlKHN0cnVjdFR5cGUo bV9jb250ZXh0LCBpbnQ2NCwgYm9vbGVhbiksIGludDY0LCBpbnQ2NCkpIFwKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCShyZXZpc2lv biAxNjIzODMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZN LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzMwLDYgKzMzMCw5IEBAIHByaXZhdGU6CiAgICAgICAg IGNhc2UgQXJpdGhDb3M6CiAgICAgICAgICAgICBjb21waWxlQXJpdGhDb3MoKTsKICAgICAgICAg ICAgIGJyZWFrOworICAgICAgICBjYXNlIEFyaXRoU3FydDoKKyAgICAgICAgICAgIGNvbXBpbGVB cml0aFNxcnQoKTsKKyAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIEFyaXRoTmVnYXRl OgogICAgICAgICAgICAgY29tcGlsZUFyaXRoTmVnYXRlKCk7CiAgICAgICAgICAgICBicmVhazsK QEAgLTExOTYsMzQgKzExOTksMTYgQEAgcHJpdmF0ZToKICAgICAgICAgfQogICAgIH0KIAotICAg IHZvaWQgY29tcGlsZUFyaXRoU2luKCkKLSAgICB7Ci0gICAgICAgIHN3aXRjaCAobV9ub2RlLT5j aGlsZDEoKS51c2VLaW5kKCkpIHsKLSAgICAgICAgCi0gICAgICAgIGNhc2UgTnVtYmVyVXNlOiB7 Ci0gICAgICAgICAgICBzZXREb3VibGUobV9vdXQuZG91YmxlU2luKGxvd0RvdWJsZShtX25vZGUt PmNoaWxkMSgpKSkpOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIH0KLSAgICAgICAgICAg IAotICAgICAgICBkZWZhdWx0OgotICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNI RUQoKTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9CisgICAgdm9pZCBjb21waWxlQXJp dGhTaW4oKXsKKyAgICAgICAgc2V0RG91YmxlKG1fb3V0LmRvdWJsZVNpbihsb3dEb3VibGUobV9u b2RlLT5jaGlsZDEoKSkpKTsKICAgICB9CiAKLSAgICB2b2lkIGNvbXBpbGVBcml0aENvcygpCi0g ICAgewotICAgICAgICBzd2l0Y2ggKG1fbm9kZS0+Y2hpbGQxKCkudXNlS2luZCgpKSB7Ci0gICAg ICAgIAotICAgICAgICBjYXNlIE51bWJlclVzZTogewotICAgICAgICAgICAgc2V0RG91YmxlKG1f b3V0LmRvdWJsZUNvcyhsb3dEb3VibGUobV9ub2RlLT5jaGlsZDEoKSkpKTsKLSAgICAgICAgICAg IGJyZWFrOwotICAgICAgICB9Ci0gICAgICAgICAgICAKLSAgICAgICAgZGVmYXVsdDoKLSAgICAg ICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgICAgICAgICBicmVhazsK LSAgICAgICAgfQorICAgIHZvaWQgY29tcGlsZUFyaXRoQ29zKCl7CisgICAgICAgIHNldERvdWJs ZShtX291dC5kb3VibGVDb3MobG93RG91YmxlKG1fbm9kZS0+Y2hpbGQxKCkpKSk7CisgICAgfQor CisgICAgdm9pZCBjb21waWxlQXJpdGhTcXJ0KCl7CisgICAgICAgIHNldERvdWJsZShtX291dC5k b3VibGVTcXJ0KGxvd0RvdWJsZShtX25vZGUtPmNoaWxkMSgpKSkpOwogICAgIH0KICAgICAKICAg ICB2b2lkIGNvbXBpbGVBcml0aE5lZ2F0ZSgpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZnRsL0ZUTE91dHB1dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwv RlRMT3V0cHV0LmgJKHJldmlzaW9uIDE2MjM4MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9m dGwvRlRMT3V0cHV0LmgJKHdvcmtpbmcgY29weSkKQEAgLTE5NSw2ICsxOTUsMTIgQEAgcHVibGlj OgogICAgICAgICByZXR1cm4gY2FsbChkb3VibGVDb3NJbnRyaW5zaWMoKSwgdmFsdWUpOwogICAg IH0KIAorICAgIExWYWx1ZSBkb3VibGVTcXJ0KExWYWx1ZSB2YWx1ZSkKKyAgICB7CisgICAgICAg IHJldHVybiBjYWxsKGRvdWJsZVNxcnRJbnRyaW5zaWMoKSwgdmFsdWUpOworICAgIH0KKworCiAg ICAgc3RhdGljIGJvb2wgaGFzU2Vuc2libGVEb3VibGVUb0ludCgpIHsgcmV0dXJuIGlzWDg2KCk7 IH0KICAgICBMVmFsdWUgc2Vuc2libGVEb3VibGVUb0ludChMVmFsdWUgdmFsdWUpCiAgICAgewpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9mdGwtYXJpdGhzcXJ0Lmpz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvZnRsLWFy aXRoc3FydC5qcwkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9z dHJlc3MvZnRsLWFyaXRoc3FydC5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEzIEBACitm dW5jdGlvbiBmb28oeCkgeworICAgIHJldHVybiBNYXRoLnNxcnQoeCk7Cit9CisKK25vSW5saW5l KGZvbyk7CisKK3ZhciBqID0gMDsKK2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDAwOyArK2kpCisg ICAgaiA9IGZvbyhpKTsKKworaWYgKCAzMTYuMjI2MTg0ODc0MDU1ICE9IGopeworICAgIHRocm93 ICJFcnJvciIKK30K