127311 2014-01-20 14:38:48 -0800 op_captured_mov and op_new_captured_func in UnlinkedCodeBlocks should use the IdentifierMap instead of the strings directly 2014-01-20 16:42:14 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo adamk barraclough ggaren mark.lam mhahnenberg mmirman msaboff nrotem oliver sam oldest_to_newest 970021 0 fpizlo 2014-01-20 14:38:48 -0800 Patch forthcoming. 970022 1 221693 fpizlo 2014-01-20 14:40:04 -0800 Created attachment 221693 the patch 970024 2 221693 kling 2014-01-20 14:44:34 -0800 Comment on attachment 221693 the patch r=me 970025 3 fpizlo 2014-01-20 14:44:56 -0800 (In reply to comment #2) > (From update of attachment 221693 [details]) > r=me Thanks, will land after EWS is happy. 970080 4 fpizlo 2014-01-20 16:42:14 -0800 Landed in http://trac.webkit.org/changeset/162390 221693 2014-01-20 14:40:04 -0800 2014-01-20 14:44:34 -0800 the patch blah.patch text/plain 5988 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYyMzc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE0LTAxLTIwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg b3BfY2FwdHVyZWRfbW92IGFuZCBvcF9uZXdfY2FwdHVyZWRfZnVuYyBpbiBVbmxpbmtlZENvZGVC bG9ja3Mgc2hvdWxkIHVzZSB0aGUgSWRlbnRpZmllck1hcCBpbnN0ZWFkIG9mIHRoZSBzdHJpbmdz IGRpcmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjczMTEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE1ODUzOTU4PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGhpcyBtYWtlcyBV bmxpbmtlZENvZGVCbG9ja3MgdXNlIDMyLWJpdCBpbnN0cnVjdGlvbiBzdHJlYW1zIGFnYWluLgor CisgICAgICAgICogYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcDoKKyAgICAgICAgKEpTQzo6Q29kZUJs b2NrOjpDb2RlQmxvY2spOgorICAgICAgICAqIGJ5dGVjb2RlL1VubGlua2VkQ29kZUJsb2NrLmg6 CisgICAgICAgIChKU0M6OlVubGlua2VkSW5zdHJ1Y3Rpb246OlVubGlua2VkSW5zdHJ1Y3Rpb24p OgorICAgICAgICAqIGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHA6CisgICAgICAg IChKU0M6OkJ5dGVjb2RlR2VuZXJhdG9yOjphZGRWYXIpOgorICAgICAgICAoSlNDOjpCeXRlY29k ZUdlbmVyYXRvcjo6ZW1pdEluaXRMYXp5UmVnaXN0ZXIpOgorICAgICAgICAoSlNDOjpCeXRlY29k ZUdlbmVyYXRvcjo6Y3JlYXRlQXJndW1lbnRzSWZOZWNlc3NhcnkpOgorICAgICAgICAqIGJ5dGVj b21waWxlci9CeXRlY29kZUdlbmVyYXRvci5oOgorICAgICAgICAoSlNDOjpCeXRlY29kZUdlbmVy YXRvcjo6d2F0Y2hhYmxlVmFyaWFibGUpOgorICAgICAgICAoSlNDOjpCeXRlY29kZUdlbmVyYXRv cjo6aGFzV2F0Y2hhYmxlVmFyaWFibGUpOgorCiAyMDE0LTAxLTIwICBNYXJrIEhhaG5lbmJlcmcg IDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQ29kZUJsb2NrU2V0Ojp0cmFjZU1h cmtlZCBkb2Vzbid0IG5lZWQgdG8gdmlzaXQgdGhlIG93bmVyRXhlY3V0YWJsZQpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAJKHJldmlzaW9uIDE2 MjM3NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xODE1LDkgKzE4MTUsMTEgQEAgQ29kZUJsb2NrOjpDb2RlQmxvY2so U2NyaXB0RXhlY3V0YWJsZSogbwogICAgICAgICAgICAgCiAgICAgICAgIGNhc2Ugb3BfY2FwdHVy ZWRfbW92OgogICAgICAgICBjYXNlIG9wX25ld19jYXB0dXJlZF9mdW5jOiB7Ci0gICAgICAgICAg ICBTdHJpbmdJbXBsKiB1aWQgPSBwY1tpICsgM10udS51aWQ7Ci0gICAgICAgICAgICBpZiAoIXVp ZCkKKyAgICAgICAgICAgIGlmIChwY1tpICsgM10udS5pbmRleCA9PSBVSU5UX01BWCkgeworICAg ICAgICAgICAgICAgIGluc3RydWN0aW9uc1tpICsgM10udS53YXRjaHBvaW50U2V0ID0gMDsKICAg ICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIFN0cmluZ0lt cGwqIHVpZCA9IGlkZW50aWZpZXIocGNbaSArIDNdLnUuaW5kZXgpLmltcGwoKTsKICAgICAgICAg ICAgIFJFTEVBU0VfQVNTRVJUKGRpZENsb25lU3ltYm9sVGFibGUpOwogICAgICAgICAgICAgQ29u Y3VycmVudEpJVExvY2tlciBsb2NrZXIobV9zeW1ib2xUYWJsZS0+bV9sb2NrKTsKICAgICAgICAg ICAgIFN5bWJvbFRhYmxlOjpNYXA6Oml0ZXJhdG9yIGl0ZXIgPSBtX3N5bWJvbFRhYmxlLT5maW5k KGxvY2tlciwgdWlkKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Vbmxp bmtlZENvZGVCbG9jay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29kZS9VbmxpbmtlZENvZGVCbG9jay5oCShyZXZpc2lvbiAxNjIzNzUpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRDb2RlQmxvY2suaAkod29ya2luZyBjb3B5KQpA QCAtMjMwLDExICsyMzAsMTAgQEAgc3RydWN0IFVubGlua2VkSW5zdHJ1Y3Rpb24gewogICAgIFVu bGlua2VkSW5zdHJ1Y3Rpb24oKSB7IHUub3BlcmFuZCA9IDA7IH0KICAgICBVbmxpbmtlZEluc3Ry dWN0aW9uKE9wY29kZUlEIG9wY29kZSkgeyB1Lm9wY29kZSA9IG9wY29kZTsgfQogICAgIFVubGlu a2VkSW5zdHJ1Y3Rpb24oaW50IG9wZXJhbmQpIHsgdS5vcGVyYW5kID0gb3BlcmFuZDsgfQotICAg IFVubGlua2VkSW5zdHJ1Y3Rpb24oU3RyaW5nSW1wbCogdWlkKSB7IHUudWlkID0gdWlkOyB9CiAg ICAgdW5pb24gewogICAgICAgICBPcGNvZGVJRCBvcGNvZGU7CiAgICAgICAgIGludDMyX3Qgb3Bl cmFuZDsKLSAgICAgICAgU3RyaW5nSW1wbCogdWlkOworICAgICAgICB1bnNpZ25lZCBpbmRleDsK ICAgICB9IHU7CiB9OwogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVy L0J5dGVjb2RlR2VuZXJhdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAkocmV2aXNpb24gMTYyMzc1KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTEzMiw4ICsxMzIsOCBAQCBib29sIEJ5dGVjb2RlR2VuZXJh dG9yOjphZGRWYXIoCiAgICAgCiAgICAgaWYgKHdhdGNoTW9kZSA9PSBJc1dhdGNoYWJsZSkgewog ICAgICAgICB3aGlsZSAobV93YXRjaGFibGVWYXJpYWJsZXMuc2l6ZSgpIDwgc3RhdGljX2Nhc3Q8 c2l6ZV90PihtX2NvZGVCbG9jay0+bV9udW1WYXJzKSkKLSAgICAgICAgICAgIG1fd2F0Y2hhYmxl VmFyaWFibGVzLmFwcGVuZChudWxscHRyKTsKLSAgICAgICAgbV93YXRjaGFibGVWYXJpYWJsZXMu YXBwZW5kKGlkZW50LmltcGwoKSk7CisgICAgICAgICAgICBtX3dhdGNoYWJsZVZhcmlhYmxlcy5h cHBlbmQoSWRlbnRpZmllcigpKTsKKyAgICAgICAgbV93YXRjaGFibGVWYXJpYWJsZXMuYXBwZW5k KGlkZW50KTsKICAgICB9CiAgICAgCiAgICAgcjAgPSBhZGRWYXIoKTsKQEAgLTQ2OSw3ICs0Njks NyBAQCBSZWdpc3RlcklEKiBCeXRlY29kZUdlbmVyYXRvcjo6ZW1pdEluaXRMCiB7CiAgICAgZW1p dE9wY29kZShvcF9pbml0X2xhenlfcmVnKTsKICAgICBpbnN0cnVjdGlvbnMoKS5hcHBlbmQocmVn LT5pbmRleCgpKTsKLSAgICBBU1NFUlQoIXdhdGNoYWJsZVZhcmlhYmxlKHJlZy0+aW5kZXgoKSkp OworICAgIEFTU0VSVCghaGFzV2F0Y2hhYmxlVmFyaWFibGUocmVnLT5pbmRleCgpKSk7CiAgICAg cmV0dXJuIHJlZzsKIH0KIApAQCAtMTYyOCw3ICsxNjI4LDcgQEAgdm9pZCBCeXRlY29kZUdlbmVy YXRvcjo6Y3JlYXRlQXJndW1lbnRzSQogCiAgICAgZW1pdE9wY29kZShvcF9jcmVhdGVfYXJndW1l bnRzKTsKICAgICBpbnN0cnVjdGlvbnMoKS5hcHBlbmQobV9jb2RlQmxvY2stPmFyZ3VtZW50c1Jl Z2lzdGVyKCkub2Zmc2V0KCkpOwotICAgIEFTU0VSVCghd2F0Y2hhYmxlVmFyaWFibGUobV9jb2Rl QmxvY2stPmFyZ3VtZW50c1JlZ2lzdGVyKCkub2Zmc2V0KCkpKTsKKyAgICBBU1NFUlQoIWhhc1dh dGNoYWJsZVZhcmlhYmxlKG1fY29kZUJsb2NrLT5hcmd1bWVudHNSZWdpc3RlcigpLm9mZnNldCgp KSk7CiB9CiAKIHZvaWQgQnl0ZWNvZGVHZW5lcmF0b3I6OmNyZWF0ZUFjdGl2YXRpb25JZk5lY2Vz c2FyeSgpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2Rl R2VuZXJhdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21w aWxlci9CeXRlY29kZUdlbmVyYXRvci5oCShyZXZpc2lvbiAxNjIzNzUpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmgJKHdvcmtpbmcgY29w eSkKQEAgLTU5MSwxNCArNTkxLDIyIEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICB2b2lkIGNy ZWF0ZUFjdGl2YXRpb25JZk5lY2Vzc2FyeSgpOwogICAgICAgICBSZWdpc3RlcklEKiBjcmVhdGVM YXp5UmVnaXN0ZXJJZk5lY2Vzc2FyeShSZWdpc3RlcklEKik7CiAgICAgICAgIAotICAgICAgICBT dHJpbmdJbXBsKiB3YXRjaGFibGVWYXJpYWJsZShpbnQgb3BlcmFuZCkKKyAgICAgICAgdW5zaWdu ZWQgd2F0Y2hhYmxlVmFyaWFibGUoaW50IG9wZXJhbmQpCiAgICAgICAgIHsKICAgICAgICAgICAg IFZpcnR1YWxSZWdpc3RlciByZWcob3BlcmFuZCk7CiAgICAgICAgICAgICBpZiAoIXJlZy5pc0xv Y2FsKCkpCi0gICAgICAgICAgICAgICAgcmV0dXJuIDA7CisgICAgICAgICAgICAgICAgcmV0dXJu IFVJTlRfTUFYOwogICAgICAgICAgICAgaWYgKHN0YXRpY19jYXN0PHNpemVfdD4ocmVnLnRvTG9j YWwoKSkgPj0gbV93YXRjaGFibGVWYXJpYWJsZXMuc2l6ZSgpKQotICAgICAgICAgICAgICAgIHJl dHVybiAwOwotICAgICAgICAgICAgcmV0dXJuIG1fd2F0Y2hhYmxlVmFyaWFibGVzW3JlZy50b0xv Y2FsKCldOworICAgICAgICAgICAgICAgIHJldHVybiBVSU5UX01BWDsKKyAgICAgICAgICAgIElk ZW50aWZpZXImIGlkZW50ID0gbV93YXRjaGFibGVWYXJpYWJsZXNbcmVnLnRvTG9jYWwoKV07Cisg ICAgICAgICAgICBpZiAoaWRlbnQuaXNOdWxsKCkpCisgICAgICAgICAgICAgICAgcmV0dXJuIFVJ TlRfTUFYOworICAgICAgICAgICAgcmV0dXJuIGFkZENvbnN0YW50KGlkZW50KTsKKyAgICAgICAg fQorICAgICAgICAKKyAgICAgICAgYm9vbCBoYXNXYXRjaGFibGVWYXJpYWJsZShpbnQgb3BlcmFu ZCkKKyAgICAgICAgeworICAgICAgICAgICAgcmV0dXJuIHdhdGNoYWJsZVZhcmlhYmxlKG9wZXJh bmQpICE9IFVJTlRfTUFYOwogICAgICAgICB9CiAgICAgICAgIAogICAgICAgICBWZWN0b3I8VW5s aW5rZWRJbnN0cnVjdGlvbiwgMCwgVW5zYWZlVmVjdG9yT3ZlcmZsb3c+IG1faW5zdHJ1Y3Rpb25z OwpAQCAtNjIwLDcgKzYyOCw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBSZWdpc3RlcklE KiBtX2FjdGl2YXRpb25SZWdpc3RlcjsKICAgICAgICAgUmVnaXN0ZXJJRCogbV9lbXB0eVZhbHVl UmVnaXN0ZXI7CiAgICAgICAgIFJlZ2lzdGVySUQqIG1fZ2xvYmFsT2JqZWN0UmVnaXN0ZXI7Ci0g ICAgICAgIFZlY3RvcjxTdHJpbmdJbXBsKiwgMTY+IG1fd2F0Y2hhYmxlVmFyaWFibGVzOworICAg ICAgICBWZWN0b3I8SWRlbnRpZmllciwgMTY+IG1fd2F0Y2hhYmxlVmFyaWFibGVzOwogICAgICAg ICBTZWdtZW50ZWRWZWN0b3I8UmVnaXN0ZXJJRCwgMzI+IG1fY29uc3RhbnRQb29sUmVnaXN0ZXJz OwogICAgICAgICBTZWdtZW50ZWRWZWN0b3I8UmVnaXN0ZXJJRCwgMzI+IG1fY2FsbGVlUmVnaXN0 ZXJzOwogICAgICAgICBTZWdtZW50ZWRWZWN0b3I8UmVnaXN0ZXJJRCwgMzI+IG1fcGFyYW1ldGVy czsK