127306 2014-01-20 13:48:46 -0800 Replace uses of std::forward<T>(), std::unique_ptr<T>::clear() that landed in r162368 2014-01-20 14:00:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan andersca commit-queue darin eric.carlson glenn jer.noble oldest_to_newest 969994 0 zan 2014-01-20 13:48:46 -0800 Improve uses of std::forward<T>(), std::unique_ptr<T>::clear() that landed in r162368 970000 1 zan 2014-01-20 13:53:41 -0800 This bug should address the post-landing comments in bug #127274. 970001 2 221690 zan 2014-01-20 13:53:52 -0800 Created attachment 221690 Patch 970004 3 221690 zan 2014-01-20 14:00:48 -0800 Comment on attachment 221690 Patch Clearing flags on attachment: 221690 Committed r162376: <http://trac.webkit.org/changeset/162376> 970005 4 zan 2014-01-20 14:00:54 -0800 All reviewed patches have been landed. Closing bug. 221690 2014-01-20 13:53:52 -0800 2014-01-20 14:00:47 -0800 Patch bug-127306-20140120135351.patch text/plain 5507 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjM3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE0LTAxLTIwICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXBsYWNlIHVzZXMgb2Yg c3RkOjpmb3J3YXJkPFQ+KCksIHN0ZDo6dW5pcXVlX3B0cjxUPjo6Y2xlYXIoKSB0aGF0IGxhbmRl ZCBpbiByMTYyMzY4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjczMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGRyZXNzIHRoZSBwb3N0LWxhbmRpbmcgcmV2aWV3cyBvZiB0aGUgcjE2MjM2OCBjb21t aXQgdGhhdCBtb3ZlZCBXZWJBdWRpbyBzb3VyY2UgY29kZSB0byB1c2luZyBzdGQ6OnVuaXF1ZV9w dHIuCisgICAgICAgIHN0ZDo6bW92ZSgpIHNob3VsZCBiZSB1c2VkIGluc3RlYWQgb2Ygc3RkOjpm b3J3YXJkPFQ+KCkgaW4gSFJURktlcm5lbDo6Y3JlYXRlKCkuCisgICAgICAgIEluc3RlYWQgb2Yg Y2FsbGluZyBzdGQ6OnVuaXF1ZV9wdHI8VD46OnJlc2V0KCksIG51bGxwdHIgc2hvdWxkIGJlIGFz c2lnbmVkIHRvIHRoYXQgc21hcnQgcG9pbnRlciB0byByZXNldCBpdC4KKworICAgICAgICAqIE1v ZHVsZXMvd2ViYXVkaW8vQ29udm9sdmVyTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb252 b2x2ZXJOb2RlOjp1bmluaXRpYWxpemUpOgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vRHlu YW1pY3NDb21wcmVzc29yTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEeW5hbWljc0NvbXBy ZXNzb3JOb2RlOjp1bmluaXRpYWxpemUpOgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vTWVk aWFFbGVtZW50QXVkaW9Tb3VyY2VOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhRWxl bWVudEF1ZGlvU291cmNlTm9kZTo6c2V0Rm9ybWF0KToKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1 ZGlvL1Bhbm5lck5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFubmVyTm9kZTo6dW5pbml0 aWFsaXplKToKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9BdWRpb0NoYW5uZWwuaDoKKyAgICAg ICAgKFdlYkNvcmU6OkF1ZGlvQ2hhbm5lbDo6c2V0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRp by9IUlRGRGF0YWJhc2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFJURkRhdGFiYXNl TG9hZGVyOjp+SFJURkRhdGFiYXNlTG9hZGVyKToKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9I UlRGS2VybmVsLmg6CisgICAgICAgIChXZWJDb3JlOjpIUlRGS2VybmVsOjpjcmVhdGUpOgorCiAy MDE0LTAxLTIwICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAg ICAgTW9kZXJuaXplIFdlYkNvcmUvaW5zcGVjdG9yIHdpdGggbnVsbHB0cgpJbmRleDogU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9Db252b2x2ZXJOb2RlLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0NvbnZvbHZlck5vZGUuY3BwCShyZXZp c2lvbiAxNjIzNzQpCisrKyBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0NvbnZvbHZl ck5vZGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTEsNyArMTExLDcgQEAgdm9pZCBDb252b2x2 ZXJOb2RlOjp1bmluaXRpYWxpemUoKQogICAgIGlmICghaXNJbml0aWFsaXplZCgpKQogICAgICAg ICByZXR1cm47CiAKLSAgICBtX3JldmVyYi5yZXNldCgpOworICAgIG1fcmV2ZXJiID0gbnVsbHB0 cjsKICAgICBBdWRpb05vZGU6OnVuaW5pdGlhbGl6ZSgpOwogfQogCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0R5bmFtaWNzQ29tcHJlc3Nvck5vZGUuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vRHluYW1pY3NDb21wcmVzc29y Tm9kZS5jcHAJKHJldmlzaW9uIDE2MjM3NCkKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vi YXVkaW8vRHluYW1pY3NDb21wcmVzc29yTm9kZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMyw3 ICsxMDMsNyBAQCB2b2lkIER5bmFtaWNzQ29tcHJlc3Nvck5vZGU6OnVuaW5pdGlhbGl6CiAgICAg aWYgKCFpc0luaXRpYWxpemVkKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIG1fZHluYW1pY3ND b21wcmVzc29yLnJlc2V0KCk7CisgICAgbV9keW5hbWljc0NvbXByZXNzb3IgPSBudWxscHRyOwog ICAgIEF1ZGlvTm9kZTo6dW5pbml0aWFsaXplKCk7CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L01vZHVsZXMvd2ViYXVkaW8vTWVkaWFFbGVtZW50QXVkaW9Tb3VyY2VOb2RlLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL01lZGlhRWxlbWVudEF1ZGlv U291cmNlTm9kZS5jcHAJKHJldmlzaW9uIDE2MjM3NCkKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVs ZXMvd2ViYXVkaW8vTWVkaWFFbGVtZW50QXVkaW9Tb3VyY2VOb2RlLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtODcsNyArODcsNyBAQCB2b2lkIE1lZGlhRWxlbWVudEF1ZGlvU291cmNlTm9kZTo6c2V0 Rm9yCiAgICAgICAgICAgICBtX211bHRpQ2hhbm5lbFJlc2FtcGxlciA9IHN0ZDo6bWFrZV91bmlx dWU8TXVsdGlDaGFubmVsUmVzYW1wbGVyPihzY2FsZUZhY3RvciwgbnVtYmVyT2ZDaGFubmVscyk7 CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAvLyBCeXBhc3MgcmVzYW1wbGluZy4KLSAg ICAgICAgICAgIG1fbXVsdGlDaGFubmVsUmVzYW1wbGVyLnJlc2V0KCk7CisgICAgICAgICAgICBt X211bHRpQ2hhbm5lbFJlc2FtcGxlciA9IG51bGxwdHI7CiAgICAgICAgIH0KIAogICAgICAgICB7 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1Bhbm5lck5vZGUuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9kZS5j cHAJKHJldmlzaW9uIDE2MjM3NCkKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8v UGFubmVyTm9kZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1NCw3ICsxNTQsNyBAQCB2b2lkIFBh bm5lck5vZGU6OnVuaW5pdGlhbGl6ZSgpCiAgICAgaWYgKCFpc0luaXRpYWxpemVkKCkpCiAgICAg ICAgIHJldHVybjsKICAgICAgICAgCi0gICAgbV9wYW5uZXIucmVzZXQoKTsKKyAgICBtX3Bhbm5l ciA9IG51bGxwdHI7CiAgICAgQXVkaW9Ob2RlOjp1bmluaXRpYWxpemUoKTsKIH0KIApJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vQXVkaW9DaGFubmVsLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vQXVkaW9DaGFubmVsLmgJKHJldmlzaW9u IDE2MjM3NCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0F1ZGlvQ2hhbm5lbC5o CSh3b3JraW5nIGNvcHkpCkBAIC03MCw3ICs3MCw3IEBAIHB1YmxpYzoKICAgICAvLyBzdG9yYWdl IHJlcHJlc2VudHMgZXh0ZXJuYWwgbWVtb3J5IG5vdCBtYW5hZ2VkIGJ5IHRoaXMgb2JqZWN0Lgog ICAgIHZvaWQgc2V0KGZsb2F0KiBzdG9yYWdlLCBzaXplX3QgbGVuZ3RoKQogICAgIHsKLSAgICAg ICAgbV9tZW1CdWZmZXIucmVzZXQoKTsgLy8gY2xlYW51cCBtYW5hZ2VkIHN0b3JhZ2UKKyAgICAg ICAgbV9tZW1CdWZmZXIgPSBudWxscHRyOyAvLyBjbGVhbnVwIG1hbmFnZWQgc3RvcmFnZQogICAg ICAgICBtX3Jhd1BvaW50ZXIgPSBzdG9yYWdlOwogICAgICAgICBtX2xlbmd0aCA9IGxlbmd0aDsK ICAgICAgICAgbV9zaWxlbnQgPSBmYWxzZTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2F1ZGlvL0hSVEZEYXRhYmFzZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vYXVkaW8vSFJURkRhdGFiYXNlTG9hZGVyLmNwcAkocmV2aXNpb24gMTYyMzc0 KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vSFJURkRhdGFiYXNlTG9hZGVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNzcsNyArNzcsNyBAQCBIUlRGRGF0YWJhc2VMb2FkZXI6On5I UlRGRGF0YWJhc2VMb2FkZXIoCiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKIAogICAgIHdh aXRGb3JMb2FkZXJUaHJlYWRDb21wbGV0aW9uKCk7Ci0gICAgbV9ocnRmRGF0YWJhc2UucmVzZXQo KTsKKyAgICBtX2hydGZEYXRhYmFzZSA9IG51bGxwdHI7CiAKICAgICAvLyBSZW1vdmUgb3Vyc2Vs ZiBmcm9tIHRoZSBtYXAuCiAgICAgbG9hZGVyTWFwKCkucmVtb3ZlKG1fZGF0YWJhc2VTYW1wbGVS YXRlKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0hSVEZLZXJuZWwuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9IUlRGS2VybmVsLmgJ KHJldmlzaW9uIDE2MjM3NCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0hSVEZL ZXJuZWwuaAkod29ya2luZyBjb3B5KQpAQCAtNTcsNyArNTcsNyBAQCBwdWJsaWM6CiAKICAgICBz dGF0aWMgUGFzc1JlZlB0cjxIUlRGS2VybmVsPiBjcmVhdGUoc3RkOjp1bmlxdWVfcHRyPEZGVEZy YW1lPiBmZnRGcmFtZSwgZmxvYXQgZnJhbWVEZWxheSwgZmxvYXQgc2FtcGxlUmF0ZSkKICAgICB7 Ci0gICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgSFJURktlcm5lbChzdGQ6OmZvcndhcmQ8c3Rk Ojp1bmlxdWVfcHRyPEZGVEZyYW1lPj4oZmZ0RnJhbWUpLCBmcmFtZURlbGF5LCBzYW1wbGVSYXRl KSk7CisgICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgSFJURktlcm5lbChzdGQ6Om1vdmUoZmZ0 RnJhbWUpLCBmcmFtZURlbGF5LCBzYW1wbGVSYXRlKSk7CiAgICAgfQogCiAgICAgLy8gR2l2ZW4g dHdvIEhSVEZLZXJuZWxzLCBhbmQgYW4gaW50ZXJwb2xhdGlvbiBmYWN0b3IgeDogMCAtPiAxLCBy ZXR1cm5zIGFuIGludGVycG9sYXRlZCBIUlRGS2VybmVsLgo=