127301 2014-01-20 12:44:06 -0800 CodeBlockSet::traceMarked doesn't need to visit the ownerExecutable 2014-01-20 14:13:04 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue fpizlo oldest_to_newest 969963 0 mhahnenberg 2014-01-20 12:44:06 -0800 We used to just call CodeBlock::visitAggregate, but now we call visitChildren on the ownerExecutable, which is unnecessary. We should go back to the old way of doing things. 969974 1 221684 mhahnenberg 2014-01-20 13:14:08 -0800 Created attachment 221684 Patch 970007 2 221684 commit-queue 2014-01-20 14:13:02 -0800 Comment on attachment 221684 Patch Clearing flags on attachment: 221684 Committed r162377: <http://trac.webkit.org/changeset/162377> 970008 3 commit-queue 2014-01-20 14:13:04 -0800 All reviewed patches have been landed. Closing bug. 221684 2014-01-20 13:14:08 -0800 2014-01-20 14:13:02 -0800 Patch bug-127301-20140120131407.patch text/plain 1336 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYyMzcwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTAxLTIwICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQ29kZUJsb2NrU2V0Ojp0cmFjZU1hcmtlZCBkb2Vzbid0IG5lZWQgdG8gdmlzaXQg dGhlIG93bmVyRXhlY3V0YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTI3MzAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2UgdXNlZCB0byBqdXN0IGNhbGwgQ29kZUJsb2NrOjp2aXNpdEFnZ3JlZ2F0 ZSwgYnV0IG5vdyB3ZSBjYWxsIHZpc2l0Q2hpbGRyZW4gCisgICAgICAgIG9uIHRoZSBvd25lckV4 ZWN1dGFibGUsIHdoaWNoIGlzIHVubmVjZXNzYXJ5LiAKKworICAgICAgICAqIGhlYXAvQ29kZUJs b2NrU2V0LmNwcDoKKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrU2V0Ojp0cmFjZU1hcmtlZCk6CisK IDIwMTQtMDEtMjAgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAg ICAgICBGaXggYnVpbGQuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db2RlQmxv Y2tTZXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0NvZGVC bG9ja1NldC5jcHAJKHJldmlzaW9uIDE2MjM2OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9o ZWFwL0NvZGVCbG9ja1NldC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMiw3ICsxMDIsNyBAQCB2 b2lkIENvZGVCbG9ja1NldDo6dHJhY2VNYXJrZWQoU2xvdFZpc2l0CiAgICAgICAgIENvZGVCbG9j ayogY29kZUJsb2NrID0gKml0ZXI7CiAgICAgICAgIGlmICghY29kZUJsb2NrLT5tX21heUJlRXhl Y3V0aW5nKQogICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIGNvZGVCbG9jay0+b3duZXJF eGVjdXRhYmxlKCktPm1ldGhvZFRhYmxlKCktPnZpc2l0Q2hpbGRyZW4oY29kZUJsb2NrLT5vd25l ckV4ZWN1dGFibGUoKSwgdmlzaXRvcik7CisgICAgICAgIGNvZGVCbG9jay0+dmlzaXRBZ2dyZWdh dGUodmlzaXRvcik7CiAgICAgfQogfQogCg==