127293 2014-01-20 09:04:45 -0800 Bindings generation tests hit an error trying to include wtf/Platform.h after r161638 2014-01-24 09:45:56 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap dbates commit-queue dbates ddkilzer mrowe timothy oldest_to_newest 969862 0 ap 2014-01-20 09:04:45 -0800 <http://trac.webkit.org/changeset/161638> added an include of wtf/Platform.h in Source/WebCore/bindings/objc/PublicDOMInterfaces.h, which makes bindings test hit an error: WebCore/bindings/objc/PublicDOMInterfaces.h:29:10: fatal error: 'wtf/Platform.h' file not found #include <wtf/Platform.h> ^ 1 error generated. See e.g. <https://webkit-queues.appspot.com/results/5638167180869632>. 970718 1 ap 2014-01-22 09:45:43 -0800 Daniel, you added this line recently, could you please look into why this broke bindings tests? 971286 2 222016 dbates 2014-01-23 12:34:52 -0800 Created attachment 222016 Patch 971288 3 commit-queue 2014-01-23 12:36:58 -0800 Please wait for approval from timothy@apple.com (or another member of the Apple Safari Team) before submitting because this patch contains changes to the Apple Mac WebKit.framework public API. 971631 4 dbates 2014-01-24 09:45:56 -0800 Committed r162704: <http://trac.webkit.org/changeset/162704> 222016 2014-01-23 12:34:52 -0800 2014-01-23 14:28:33 -0800 Patch bug-127293-20140123123444.patch text/plain 2141 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyNTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM0YjQ4NTlmMTg1Yjk3 YjU2ZDNmMGJkYzM4ODQ1MTE5MDU1MDViZC4uYjM0Mjc0OTJjZDRiZjVmYTI2ZjI5MmI3Y2RjNDhl OWZmMWZhNWU3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAxLTIzICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBCaW5kaW5ncyBnZW5lcmF0 aW9uIHRlc3RzIGhpdCBhbiBlcnJvciB0cnlpbmcgdG8gaW5jbHVkZSB3dGYvUGxhdGZvcm0uaCBh ZnRlciByMTYxNjM4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjcyOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJbmNsdWRlIFRhcmdldENvbmRpdGlvbmFscy5oIGluc3RlYWQgb2Ygd3RmL1BsYXRmb3Jt LmggYXMgdGhlIGxhdHRlciBpc24ndCBhdmFpbGFibGUKKyAgICAgICAgaW4gdGhlIHB1YmxpYyBT REsuCisKKyAgICAgICAgQXMgYSBzaWRlIGVmZmVjdCBvZiB0aGlzIGNoYW5nZSwgcmVwbGFjZSB1 c2FnZSBvZiBQTEFURk9STShJT1MpIHdpdGggVEFSR0VUX09TX0lQSE9ORS4KKworICAgICAgICAq IGJpbmRpbmdzL29iamMvUHVibGljRE9NSW50ZXJmYWNlcy5oOgorCiAyMDE0LTAxLTIyICBBbnR0 aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBBdm9pZCB1bnRocm90dGxl ZCBsYXllciBmbHVzaGVzIHRyaWdnZXJlZCBieSBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmVuc3Vy ZVJvb3RMYXllcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvb2JqYy9QdWJs aWNET01JbnRlcmZhY2VzLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9vYmpjL1B1YmxpY0RP TUludGVyZmFjZXMuaAppbmRleCA4MWIzZDlkNWJjZDYyZjc1NGQ3MTk3ZWZlYmQ4ZTExZTIyYjE2 YmE4Li5kZGUxYTdlMWU1MWE2NGU3MTJmNWUxM2U3MDlhN2ZmNDI3ZjVmOTIyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9vYmpjL1B1YmxpY0RPTUludGVyZmFjZXMuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9vYmpjL1B1YmxpY0RPTUludGVyZmFjZXMuaApAQCAt MjYsNyArMjYsNyBAQAogLy8gQWxsIHB1YmxpYyBET00gY2xhc3MgaW50ZXJmYWNlcywgcHJvcGVy dGllcyBhbmQgbWV0aG9kcyBuZWVkIHRvIGJlIGluIHRoaXMgZmlsZS4KIC8vIEFueXRoaW5nIG5v dCBpbiB0aGUgZmlsZSB3aWxsIGJlIGdlbmVyYXRlZCBpbnRvIHRoZSBhcHByb3ByaWF0ZSBwcml2 YXRlIGhlYWRlciBmaWxlLgogCi0jaW5jbHVkZSA8d3RmL1BsYXRmb3JtLmg+CisjaW5jbHVkZSA8 VGFyZ2V0Q29uZGl0aW9uYWxzLmg+CiAKICNpZm5kZWYgT0JKQ19DT0RFX0dFTkVSQVRJT04KICNl cnJvciBEbyBub3QgaW5jbHVkZSB0aGlzIGhlYWRlciwgaW5zdGVhZCBpbmNsdWRlIHRoZSBhcHBy b3ByaWF0ZSBET00gaGVhZGVyLgpAQCAtOTUzLDcgKzk1Myw3IEBACiBAcHJvcGVydHkgKHJlYWRv bmx5LCBzdHJvbmcpIERPTUNTU1ByaW1pdGl2ZVZhbHVlICpncmVlbjsKIEBwcm9wZXJ0eSAocmVh ZG9ubHksIHN0cm9uZykgRE9NQ1NTUHJpbWl0aXZlVmFsdWUgKmJsdWU7CiBAcHJvcGVydHkgKHJl YWRvbmx5LCBzdHJvbmcpIERPTUNTU1ByaW1pdGl2ZVZhbHVlICphbHBoYTsKLSNpZiAhUExBVEZP Uk0oSU9TKQorI2lmICFUQVJHRVRfT1NfSVBIT05FCiBAcHJvcGVydHkgKHJlYWRvbmx5LCBjb3B5 KSBOU0NvbG9yICpjb2xvciBXRUJLSVRfQVZBSUxBQkxFX01BQygxMF81KTsKICNlbHNlCiAtIChD R0NvbG9yUmVmKWNvbG9yOwpAQCAtMTI1MCw2ICsxMjUwLDYgQEAKIC0gKE5TU3RyaW5nICopbG9v a3VwTmFtZXNwYWNlVVJJOihOU1N0cmluZyAqKXByZWZpeDsKIEBlbmQKIAotI2lmIFBMQVRGT1JN KElPUykKKyNpZiBUQVJHRVRfT1NfSVBIT05FCiAjaW5jbHVkZSA8V2ViS2l0QWRkaXRpb25zL1B1 YmxpY0RPTUludGVyZmFjZXNJT1MuaD4KICNlbmRpZgo=